Re: [PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers

2024-02-26 Thread Dmitry Safonov
On Mon, Feb 26, 2024 at 8:43 PM Simon Horman wrote: > > On Sat, Feb 24, 2024 at 09:04:11AM +, Dmitry Safonov wrote: [..] > > + if (req) { > > + if (tcp_rsk_used_ao(req) != !!aoh) { > > + u8 keyid, rnext, maclen; > > + > > + if (aoh) { > >

Re: [PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers

2024-02-26 Thread Simon Horman
On Sat, Feb 24, 2024 at 09:04:11AM +, Dmitry Safonov wrote: > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including >, which is necessary for TCP tracepoints. > > Signed-off-by: Dmitry Safonov ... > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > in

Re: [PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers

2024-02-24 Thread Dmitry Safonov
On 2/24/24 09:30, Eric Dumazet wrote: > On Sat, Feb 24, 2024 at 10:04 AM Dmitry Safonov wrote: >> >> Two reasons: >> 1. It's grown up enough >> 2. In order to not do header spaghetti by including >>, which is necessary for TCP tracepoints. >> >> Signed-off-by: Dmitry Safonov > > Okay, but wh

Re: [PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers

2024-02-24 Thread Eric Dumazet
On Sat, Feb 24, 2024 at 10:04 AM Dmitry Safonov wrote: > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including >, which is necessary for TCP tracepoints. > > Signed-off-by: Dmitry Safonov Okay, but what about CONFIG_IPV6=m ? I do not see any EXPORT_S

[PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers

2024-02-24 Thread Dmitry Safonov
Two reasons: 1. It's grown up enough 2. In order to not do header spaghetti by including , which is necessary for TCP tracepoints. Signed-off-by: Dmitry Safonov --- include/net/tcp.h | 65 - net/ipv4/tcp.c| 72 +++