Re: [PATCH net-next 2/2] selftests: net: ksft: support marking tests as disruptive

2024-07-30 Thread Jakub Kicinski
On Tue, 30 Jul 2024 09:20:05 -0700 Stanislav Fomichev wrote: > SG! The patch you reference is doing it in NetDrvEnv* but I'll probably > try to keep most of the code in 'core' ksft. So far I'm thinking about > adding some ksft_setup(env) to initialize that disruptive=yes/no state. > LMK if you pref

Re: [PATCH net-next 2/2] selftests: net: ksft: support marking tests as disruptive

2024-07-30 Thread Stanislav Fomichev
On 07/29, Jakub Kicinski wrote: > On Mon, 29 Jul 2024 15:10:42 -0700 Stanislav Fomichev wrote: > > +parser = argparse.ArgumentParser() > > +parser.add_argument('--skip-disruptive', default=False, > > action='store_true', help='skip tests that might be disruptive (e.g. > > restart the inte

Re: [PATCH net-next 2/2] selftests: net: ksft: support marking tests as disruptive

2024-07-29 Thread Jakub Kicinski
On Mon, 29 Jul 2024 15:10:42 -0700 Stanislav Fomichev wrote: > +parser = argparse.ArgumentParser() > +parser.add_argument('--skip-disruptive', default=False, > action='store_true', help='skip tests that might be disruptive (e.g. restart > the interface)') > +global KSFT_ARGS > +KS

[PATCH net-next 2/2] selftests: net: ksft: support marking tests as disruptive

2024-07-29 Thread Stanislav Fomichev
(not sure we want this, but just throwing it out there..) Add new @ksft_disruptive decorator to mark the tests that might be disruptive to the system. Depending on how well the previous test works in the CI we might want to disable disruptive tests by default and only let the developers run them m