Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-08-09 Thread Simon Horman
On Tue, Aug 06, 2024 at 08:39:34AM -0400, Willem de Bruijn wrote: > Markus Elfring wrote: > > >> … > > >>> +++ b/include/net/devmem.h > > >>> @@ -0,0 +1,115 @@ > > >> … > > >>> +#ifndef _NET_DEVMEM_H > > >>> +#define _NET_DEVMEM_H > > >> … > > >> > > >> I suggest to omit leading underscores from su

Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-08-06 Thread Willem de Bruijn
Markus Elfring wrote: > >> … > >>> +++ b/include/net/devmem.h > >>> @@ -0,0 +1,115 @@ > >> … > >>> +#ifndef _NET_DEVMEM_H > >>> +#define _NET_DEVMEM_H > >> … > >> > >> I suggest to omit leading underscores from such identifiers. > >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+dec

Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-08-06 Thread Markus Elfring
>> … >>> +++ b/include/net/devmem.h >>> @@ -0,0 +1,115 @@ >> … >>> +#ifndef _NET_DEVMEM_H >>> +#define _NET_DEVMEM_H >> … >> >> I suggest to omit leading underscores from such identifiers. >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier >> >

Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-08-05 Thread Mina Almasry
On Tue, Jul 30, 2024 at 4:38 AM Markus Elfring wrote: > > … > > +++ b/include/net/devmem.h > > @@ -0,0 +1,115 @@ > … > > +#ifndef _NET_DEVMEM_H > > +#define _NET_DEVMEM_H > … > > I suggest to omit leading underscores from such identifiers. > https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+D

Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-07-30 Thread Markus Elfring
… > +++ b/include/net/devmem.h > @@ -0,0 +1,115 @@ … > +#ifndef _NET_DEVMEM_H > +#define _NET_DEVMEM_H … I suggest to omit leading underscores from such identifiers. https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier Regards, Markus

[PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-07-29 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool