Re: [PATCH net-next v2 1/2] selftests: net-drv: exercise queue stats when the device is down

2024-08-01 Thread Petr Machata
Stanislav Fomichev writes: > On 08/01, Petr Machata wrote: >> >> Stanislav Fomichev writes: >> >> > On 07/31, Jakub Kicinski wrote: >> >> On Wed, 31 Jul 2024 13:34:58 +0200 Petr Machata wrote: >> >> > > +qstat = netfam.qstats_get({"ifindex": cfg.ifindex}, >> >> > > dump=True) >> >>

Re: [PATCH net-next v2 1/2] selftests: net-drv: exercise queue stats when the device is down

2024-08-01 Thread Stanislav Fomichev
On 08/01, Petr Machata wrote: > > Stanislav Fomichev writes: > > > On 07/31, Jakub Kicinski wrote: > >> On Wed, 31 Jul 2024 13:34:58 +0200 Petr Machata wrote: > >> > > +qstat = netfam.qstats_get({"ifindex": cfg.ifindex}, dump=True) > >> > > +except NlError as e: > >> > > +if

Re: [PATCH net-next v2 1/2] selftests: net-drv: exercise queue stats when the device is down

2024-08-01 Thread Petr Machata
Stanislav Fomichev writes: > On 07/31, Jakub Kicinski wrote: >> On Wed, 31 Jul 2024 13:34:58 +0200 Petr Machata wrote: >> > > +qstat = netfam.qstats_get({"ifindex": cfg.ifindex}, dump=True) >> > > +except NlError as e: >> > > +if e.error == 95: >> > >> > Could you do this

Re: [PATCH net-next v2 1/2] selftests: net-drv: exercise queue stats when the device is down

2024-07-31 Thread Stanislav Fomichev
On 07/31, Jakub Kicinski wrote: > On Wed, 31 Jul 2024 13:34:58 +0200 Petr Machata wrote: > > > +qstat = netfam.qstats_get({"ifindex": cfg.ifindex}, dump=True) > > > +except NlError as e: > > > +if e.error == 95: > > > > Could you do this as if e.error == errno.ENOTSUP? > > j

Re: [PATCH net-next v2 1/2] selftests: net-drv: exercise queue stats when the device is down

2024-07-31 Thread Jakub Kicinski
On Wed, 31 Jul 2024 13:34:58 +0200 Petr Machata wrote: > > +qstat = netfam.qstats_get({"ifindex": cfg.ifindex}, dump=True) > > +except NlError as e: > > +if e.error == 95: > > Could you do this as if e.error == errno.ENOTSUP? just to be clear EOPNOTSUPP ..

Re: [PATCH net-next v2 1/2] selftests: net-drv: exercise queue stats when the device is down

2024-07-31 Thread Petr Machata
Stanislav Fomichev writes: > Verify that total device stats don't decrease after it has been turned down. > Also make sure the device doesn't crash when we access per-queue stats > when it's down (in case it tries to access some pointers that are NULL). > > KTAP version 1 > 1..5 > ok 1 st

[PATCH net-next v2 1/2] selftests: net-drv: exercise queue stats when the device is down

2024-07-30 Thread Stanislav Fomichev
Verify that total device stats don't decrease after it has been turned down. Also make sure the device doesn't crash when we access per-queue stats when it's down (in case it tries to access some pointers that are NULL). KTAP version 1 1..5 ok 1 stats.check_pause ok 2 stats.check_fec ok