Re: [PATCH v1 5/9] selftests: kvm: s390: Add debug print functions

2024-07-11 Thread Christoph Schlameuss
On Tue, 9 Jul 2024 18:31:54 +0200 Claudio Imbrenda wrote: > On Tue, 9 Jul 2024 14:57:00 +0200 > Christoph Schlameuss wrote: > [...] > > +static inline void print_hex_bytes(const char *name, u64 page, size_t len) > > > > "page" is not an appropriate name, it's just an address, right? "add

Re: [PATCH v1 5/9] selftests: kvm: s390: Add debug print functions

2024-07-09 Thread Claudio Imbrenda
On Tue, 9 Jul 2024 14:57:00 +0200 Christoph Schlameuss wrote: > Add functions to simply print some basic state information in selftests. > > The output can be enabled by setting: > > #define TH_LOG_ENABLED 1 > #define DEBUG 1 > > * print_psw: current SIE state description and VM run s

[PATCH v1 5/9] selftests: kvm: s390: Add debug print functions

2024-07-09 Thread Christoph Schlameuss
Add functions to simply print some basic state information in selftests. The output can be enabled by setting: #define TH_LOG_ENABLED 1 #define DEBUG 1 * print_psw: current SIE state description and VM run state * print_hex_bytes: print memory with some counting markers * print_hex: PRIN