Re: [PATCH v13 04/21] KVM: pfncache: add a mark-dirty helper

2024-02-20 Thread Paul Durrant
On 19/02/2024 21:42, Sean Christopherson wrote: On Thu, Feb 15, 2024, Paul Durrant wrote: +/** + * kvm_gpc_mark_dirty_in_slot - mark a cached guest page as dirty. + * + * @gpc: struct gfn_to_pfn_cache object. Meh, just omit the kerneldoc comment. + */ +static inline void

Re: [PATCH v13 04/21] KVM: pfncache: add a mark-dirty helper

2024-02-19 Thread Sean Christopherson
On Thu, Feb 15, 2024, Paul Durrant wrote: > +/** > + * kvm_gpc_mark_dirty_in_slot - mark a cached guest page as dirty. > + * > + * @gpc:struct gfn_to_pfn_cache object. Meh, just omit the kerneldoc comment. > + */ > +static inline void kvm_gpc_mark_dirty_in_slot(struct gfn_to_pfn_cache

[PATCH v13 04/21] KVM: pfncache: add a mark-dirty helper

2024-02-15 Thread Paul Durrant
From: Paul Durrant At the moment pages are marked dirty by open-coded calls to mark_page_dirty_in_slot(), directly deferefencing the gpa and memslot from the cache. After a subsequent patch these may not always be set so add a helper now so that caller will protected from the need to know about