Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

2024-05-06 Thread John Hubbard
On 5/6/24 7:44 AM, Mark Brown wrote: On Mon, May 06, 2024 at 09:45:21AM +0200, Takashi Iwai wrote: Jaroslav Kysela wrote: This function is nice for debugging. I'd prefer to keep it with the fix. I'm find in either way; just submit a fix patch, then. The fix was already submitted as v1,

Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

2024-05-06 Thread Mark Brown
On Mon, May 06, 2024 at 09:45:21AM +0200, Takashi Iwai wrote: > Jaroslav Kysela wrote: > > This function is nice for debugging. I'd prefer to keep it with the fix. > I'm find in either way; just submit a fix patch, then. The fix was already submitted as v1, I noticed that the function was

Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

2024-05-06 Thread Takashi Iwai
On Mon, 06 May 2024 09:27:38 +0200, Jaroslav Kysela wrote: > > On 06. 05. 24 9:19, Takashi Iwai wrote: > > On Sun, 05 May 2024 23:08:24 +0200, > > John Hubbard wrote: > >> > >> dump_config_tree() is declared to return an int, but the compiler cannot > >> prove that it always returns any value at

Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

2024-05-06 Thread Jaroslav Kysela
On 06. 05. 24 9:19, Takashi Iwai wrote: On Sun, 05 May 2024 23:08:24 +0200, John Hubbard wrote: dump_config_tree() is declared to return an int, but the compiler cannot prove that it always returns any value at all. This leads to a clang warning, when building via: make LLVM=1 -C

Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

2024-05-06 Thread Takashi Iwai
On Sun, 05 May 2024 23:08:24 +0200, John Hubbard wrote: > > dump_config_tree() is declared to return an int, but the compiler cannot > prove that it always returns any value at all. This leads to a clang > warning, when building via: > > make LLVM=1 -C tools/testing/selftests > >

Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

2024-05-05 Thread Mark Brown
On Sun, May 05, 2024 at 02:08:24PM -0700, John Hubbard wrote: > dump_config_tree() is declared to return an int, but the compiler cannot > prove that it always returns any value at all. This leads to a clang > warning, when building via: Reviewed-by: Mark Brown signature.asc Description: PGP

[PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

2024-05-05 Thread John Hubbard
dump_config_tree() is declared to return an int, but the compiler cannot prove that it always returns any value at all. This leads to a clang warning, when building via: make LLVM=1 -C tools/testing/selftests Furthermore, Mark Brown noticed that dump_config_tree() isn't even used anymore, so