Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

On 5/8/24 1:00 AM, Ilpo Järvinen wrote: On Tue, 7 May 2024, Reinette Chatre wrote: Hi John, On 5/7/2024 6:25 PM, John Hubbard wrote: On 5/7/24 6:21 PM, Reinette Chatre wrote: Hi John, ... Yes, there are two *abs() calls in this function. In this case is okay to remove the first one since

Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

On Tue, 7 May 2024, Reinette Chatre wrote: > Hi John, > > On 5/7/2024 6:25 PM, John Hubbard wrote: > > On 5/7/24 6:21 PM, Reinette Chatre wrote: > >> Hi John, > > ... > >> > >> The following (what was in v1) looks good to me. What am I missing? > >> > >> diff --git a/tools/testing/selftests/resct

Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

Hi John, On 5/7/2024 6:25 PM, John Hubbard wrote: > On 5/7/24 6:21 PM, Reinette Chatre wrote: >> Hi John, > ... >> >> The following (what was in v1) looks good to me. What am I missing? >> >> diff --git a/tools/testing/selftests/resctrl/cmt_test.c >> b/tools/testing/selftests/resctrl/cmt_test.c >

Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

On 5/7/24 6:21 PM, Reinette Chatre wrote: Hi John, ... The following (what was in v1) looks good to me. What am I missing? diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c index a81f91222a89..05a241519ae8 100644 --- a/tools/testing/selftest

Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

Hi John, On 5/7/2024 6:16 PM, John Hubbard wrote: > On 5/7/24 3:30 PM, Reinette Chatre wrote: > ... >>> diff --git a/tools/testing/selftests/resctrl/cmt_test.c >>> b/tools/testing/selftests/resctrl/cmt_test.c >>> index a81f91222a89..af33abd1cca7 100644 >>> --- a/tools/testing/selftests/resctrl/cm

Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

On 5/7/24 3:30 PM, Reinette Chatre wrote: ... diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c index a81f91222a89..af33abd1cca7 100644 --- a/tools/testing/selftests/resctrl/cmt_test.c +++ b/tools/testing/selftests/resctrl/cmt_test.c @@ -29,22 +

Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

Hi John, On 5/3/2024 4:40 PM, John Hubbard wrote: > First of all, in order to build with clang at all, one must first apply > Valentin Obst's build fix for LLVM [1]. Furthermore, for this particular > resctrl directory, my pending fix [2] must also be applied. Once those > fixes are in place, then

[PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

First of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Furthermore, for this particular resctrl directory, my pending fix [2] must also be applied. Once those fixes are in place, then when building with clang, via: make LLVM=1 -C tools/t