Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-02 Thread Shuah Khan
On 8/1/24 23:38, Muhammad Usama Anjum wrote: On 8/1/24 9:27 PM, Shuah Khan wrote: On 8/1/24 02:42, Muhammad Usama Anjum wrote: On 7/31/24 9:57 PM, Shuah Khan wrote: On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. This is aga

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-01 Thread Muhammad Usama Anjum
On 8/1/24 10:27 PM, Shuah Khan wrote: > On 8/1/24 10:27, Shuah Khan wrote: >> On 8/1/24 02:42, Muhammad Usama Anjum wrote: >>> On 7/31/24 9:57 PM, Shuah Khan wrote: On 7/31/24 07:39, Muhammad Usama Anjum wrote: > Don't print that 88 sub-tests are going to be executed, but then skip. >

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-01 Thread Muhammad Usama Anjum
On 8/1/24 9:27 PM, Shuah Khan wrote: > On 8/1/24 02:42, Muhammad Usama Anjum wrote: >> On 7/31/24 9:57 PM, Shuah Khan wrote: >>> On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. This is against TAP compliance. Instead che

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-01 Thread Shuah Khan
On 8/1/24 10:27, Shuah Khan wrote: On 8/1/24 02:42, Muhammad Usama Anjum wrote: On 7/31/24 9:57 PM, Shuah Khan wrote: On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. This is against TAP compliance. Instead check pre-requisite

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-01 Thread Shuah Khan
On 8/1/24 02:42, Muhammad Usama Anjum wrote: On 7/31/24 9:57 PM, Shuah Khan wrote: On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. This is against TAP compliance. Instead check pre-requisites first before printing total number

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-01 Thread Muhammad Usama Anjum
On 7/31/24 9:57 PM, Shuah Khan wrote: > On 7/31/24 07:39, Muhammad Usama Anjum wrote: >> Don't print that 88 sub-tests are going to be executed, but then skip. >> This is against TAP compliance. Instead check pre-requisites first >> before printing total number of tests. > > Does TAP clearly menti

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-07-31 Thread Shuah Khan
On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. This is against TAP compliance. Instead check pre-requisites first before printing total number of tests. Does TAP clearly mention this? Old non-tap compliant output: TAP v

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-07-31 Thread Aleksa Sarai
On 2024-07-31, Muhammad Usama Anjum wrote: > Don't print that 88 sub-tests are going to be executed, but then skip. > This is against TAP compliance. Instead check pre-requisites first > before printing total number of tests. > > Old non-tap compliant output: > TAP version 13 > 1..88 > ok 2

[PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-07-31 Thread Muhammad Usama Anjum
Don't print that 88 sub-tests are going to be executed, but then skip. This is against TAP compliance. Instead check pre-requisites first before printing total number of tests. Old non-tap compliant output: TAP version 13 1..88 ok 2 # SKIP all tests require euid == 0 # Planned tests != run