Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Google
On Thu, 21 Dec 2023 21:07:57 -0500 Steven Rostedt wrote: > On Fri, 22 Dec 2023 10:52:00 +0900 > Masami Hiramatsu (Google) wrote: > > > On Fri, 22 Dec 2023 10:48:41 +0900 > > Masami Hiramatsu (Google) wrote: > > > And I confirmed that this test passed on v6.5.13 with that change. > > > > I j

Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Steven Rostedt
On Fri, 22 Dec 2023 10:52:00 +0900 Masami Hiramatsu (Google) wrote: > On Fri, 22 Dec 2023 10:48:41 +0900 > Masami Hiramatsu (Google) wrote: > And I confirmed that this test passed on v6.5.13 with that change. > I just ran it on 6.5.13 and it took *forever*! But I do have a bit of debug, and

Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Steven Rostedt
On Fri, 22 Dec 2023 10:52:00 +0900 Masami Hiramatsu (Google) wrote: > > +instance="foo-$(mktemp -u X)" > > > > This doesn't work. it needs XX (6 times X). And this is > > somewhat wrong usage of mktemp because it can not check there is > > foo-. > > What about change it as > > > > insta

Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Google
On Fri, 22 Dec 2023 10:48:41 +0900 Masami Hiramatsu (Google) wrote: > On Thu, 21 Dec 2023 20:28:13 -0500 > Steven Rostedt wrote: > > > On Fri, 22 Dec 2023 10:21:48 +0900 > > Masami Hiramatsu (Google) wrote: > > > > > The testcase itself is OK but is there any way to identify the system > > >

Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Google
On Thu, 21 Dec 2023 20:28:13 -0500 Steven Rostedt wrote: > On Fri, 22 Dec 2023 10:21:48 +0900 > Masami Hiramatsu (Google) wrote: > > > The testcase itself is OK but is there any way to identify the system > > supports eventfs or not? I ran this test on v6.5.13 for checking then > > it failed. W

Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Google
On Thu, 21 Dec 2023 20:28:13 -0500 Steven Rostedt wrote: > On Fri, 22 Dec 2023 10:21:48 +0900 > Masami Hiramatsu (Google) wrote: > > > The testcase itself is OK but is there any way to identify the system > > supports eventfs or not? I ran this test on v6.5.13 for checking then > > it failed. W

Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Steven Rostedt
On Fri, 22 Dec 2023 10:21:48 +0900 Masami Hiramatsu (Google) wrote: > The testcase itself is OK but is there any way to identify the system > supports eventfs or not? I ran this test on v6.5.13 for checking then > it failed. We may need to skip (unsupported) this test for such case. Hmm, honestl

Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Google
Hi Steve, On Thu, 21 Dec 2023 19:45:16 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > As there were bugs found with the ownership of eventfs dynamic file > creation. Add a test to test it. > > It will remount tracefs with a different gid and check the ownership of > the eve

[PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

2023-12-21 Thread Steven Rostedt
From: "Steven Rostedt (Google)" As there were bugs found with the ownership of eventfs dynamic file creation. Add a test to test it. It will remount tracefs with a different gid and check the ownership of the eventfs directory, as well as the system and event directories. It will also check the