Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom

2024-08-26 Thread Thomas Gleixner
On Mon, Aug 26 2024 at 12:45, Christophe Leroy wrote: > Le 26/08/2024 à 10:58, Jason A. Donenfeld a écrit : >> On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: >>> >>> >>> Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe

Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom

2024-08-26 Thread Jason A. Donenfeld
On Mon, Aug 26, 2024 at 12:45:40PM +0200, Christophe Leroy wrote: > > > Le 26/08/2024 à 10:58, Jason A. Donenfeld a écrit : > > On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: > >> > >> > >> Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : > >>> On Thu, Aug 22, 2024 at 09:13:

Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom

2024-08-26 Thread Christophe Leroy
Le 26/08/2024 à 10:58, Jason A. Donenfeld a écrit : On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) +#

Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom

2024-08-26 Thread Jason A. Donenfeld
On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: > > > Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : > > On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: > >> > >> +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) > >> +#define _PAGE_MASK (~(_PAGE_SIZE - 1)

Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom

2024-08-26 Thread Christophe Leroy
Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) +#define _PAGE_MASK (~(_PAGE_SIZE - 1)) If PAGE_SIZE isn't defined at this point, why not just call it PAGE_SIZE instead of

Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom

2024-08-26 Thread Jason A. Donenfeld
On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: > diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h > index 0c92db84469d..6e4f8fae3ce9 100644 > --- a/arch/x86/include/asm/pvclock.h > +++ b/arch/x86/include/asm/pvclock.h > @@ -5,6 +5,7 @@ > #include >

[PATCH v2 02/17] vdso: Clean header inclusion in getrandom

2024-08-22 Thread Christophe Leroy
Building a VDSO32 on a 64 bits kernel is problematic when some system headers are included. See commit 8c59ab839f52 ("lib/vdso: Enable common headers") for more details. Minimise the amount of headers by moving needed items into dedicated common headers. For PAGE_SIZE and PAGE_MASK, redefine them