Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

2024-05-08 Thread Mark Brown
On Tue, May 07, 2024 at 09:38:28PM +, Edward Liaw wrote: > tools/testing/selftests/arm64/signal/Makefile | 2 +- This is not really using any of the kselftest framework at all to build so I'm not sure the change makes sense for it. OTOH it does no harm... signature.asc Description

Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

2024-05-08 Thread John Hubbard
On 5/8/24 5:29 PM, Edward Liaw wrote: On Wed, May 8, 2024 at 2:41 PM John Hubbard wrote: On 5/7/24 2:38 PM, Edward Liaw wrote: ... Seeing as how these all include lib.mk, and all use CFLAGS, is there any reason not to simply fix this in lib.mk instead? Like this: diff --git a/tools/testing/s

Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

2024-05-08 Thread Edward Liaw
On Wed, May 8, 2024 at 2:41 PM John Hubbard wrote: > > On 5/7/24 2:38 PM, Edward Liaw wrote: > > Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness > > dependencies (-D_GNU_SOURCE). > > > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > > Signed-off-by: Edward Liaw

Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

2024-05-08 Thread John Hubbard
On 5/7/24 2:38 PM, Edward Liaw wrote: Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE). Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Edward Liaw --- tools/testing/selftests/alsa/Makefile | 2 +- too

Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

2024-05-08 Thread Muhammad Usama Anjum
On 5/8/24 2:38 AM, Edward Liaw wrote: > Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness > dependencies (-D_GNU_SOURCE). > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > Signed-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selfte

Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

2024-05-07 Thread Jarkko Sakkinen
On Wed May 8, 2024 at 12:38 AM EEST, Edward Liaw wrote: > Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness > dependencies (-D_GNU_SOURCE). > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > Signed-off-by: Edward Liaw Oops, this is not for this patch but for SGX. P

[PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

2024-05-07 Thread Edward Liaw
Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE). Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Edward Liaw --- tools/testing/selftests/alsa/Makefile | 2 +- tools/testing/selftests/arm64/signal/Makefile