Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE

2024-05-08 Thread John Hubbard
On 5/7/24 2:38 PM, Edward Liaw wrote: _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to prevent _GNU_SOURCE redefined warnings. Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Edward Liaw --- Very nice. Reviewed-by: John Hubbard thanks, -

Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE

2024-05-08 Thread Edward Liaw
On Wed, May 8, 2024 at 6:54 AM Sean Christopherson wrote: > > On Tue, May 07, 2024, Edward Liaw wrote: > > _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to > > prevent _GNU_SOURCE redefined warnings. > > ... > > > diff --git a/tools/testing/selftests/x86/test_syscall_vdso.c >

Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE

2024-05-08 Thread Sean Christopherson
On Tue, May 07, 2024, Edward Liaw wrote: > _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to > prevent _GNU_SOURCE redefined warnings. ... > diff --git a/tools/testing/selftests/x86/test_syscall_vdso.c > b/tools/testing/selftests/x86/test_syscall_vdso.c > index 8965c311bd65..5

Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE

2024-05-08 Thread Muhammad Usama Anjum
On 5/8/24 2:38 AM, Edward Liaw wrote: > _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to > prevent _GNU_SOURCE redefined warnings. > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > Signed-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum > --- > to

[PATCH v2 4/5] selftests: Drop define _GNU_SOURCE

2024-05-07 Thread Edward Liaw
_GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to prevent _GNU_SOURCE redefined warnings. Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Edward Liaw --- tools/testing/selftests/cachestat/test_cachestat.c| 2 -- tools/testing/selfte