Re: [PATCH v2 5/5] selftests: Drop duplicate -D_GNU_SOURCE

2024-05-08 Thread John Hubbard
On 5/7/24 2:38 PM, Edward Liaw wrote: -D_GNU_SOURCE can be de-duplicated here, as it is added by KHDR_INCLUDES. Signed-off-by: Edward Liaw --- Most of the churn in these Makefiles can be avoided if it is possible to take my recommendation on patch 3/5 [1]. However, as it is, it is correct, s

Re: [PATCH v2 5/5] selftests: Drop duplicate -D_GNU_SOURCE

2024-05-08 Thread Muhammad Usama Anjum
On 5/8/24 2:38 AM, Edward Liaw wrote: > -D_GNU_SOURCE can be de-duplicated here, as it is added by > KHDR_INCLUDES. > > Signed-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/futex/functional/Makefile | 2 +- > tools/testing/selftests/iommu/Makefile

[PATCH v2 5/5] selftests: Drop duplicate -D_GNU_SOURCE

2024-05-07 Thread Edward Liaw
-D_GNU_SOURCE can be de-duplicated here, as it is added by KHDR_INCLUDES. Signed-off-by: Edward Liaw --- tools/testing/selftests/futex/functional/Makefile | 2 +- tools/testing/selftests/iommu/Makefile| 2 -- tools/testing/selftests/net/tcp_ao/Makefile | 2 +- tools/testing/sel