Re: [PATCH v3 0/9] Fix Kselftest's vfork() side effects

2024-04-30 Thread Kees Cook
On Tue, Apr 30, 2024 at 06:38:40PM +0200, Mickaël Salaün wrote: > On Tue, Apr 30, 2024 at 08:13:04AM -0700, Jakub Kicinski wrote: > > On Tue, 30 Apr 2024 15:54:38 +0200 Mickaël Salaün wrote: > > > Jakub, can you please review it? > > > > I looked thru it. I don't have the cycles to investigate and

Re: [PATCH v3 0/9] Fix Kselftest's vfork() side effects

2024-04-30 Thread Mickaël Salaün
On Tue, Apr 30, 2024 at 08:13:04AM -0700, Jakub Kicinski wrote: > On Tue, 30 Apr 2024 15:54:38 +0200 Mickaël Salaün wrote: > > Jakub, can you please review it? > > I looked thru it. I don't have the cycles to investigate and suggest > a better approach but the sprinkling of mmaps(), if nothing el

Re: [PATCH v3 0/9] Fix Kselftest's vfork() side effects

2024-04-30 Thread Jakub Kicinski
On Tue, 30 Apr 2024 15:54:38 +0200 Mickaël Salaün wrote: > Jakub, can you please review it? I looked thru it. I don't have the cycles to investigate and suggest a better approach but the sprinkling of mmaps(), if nothing else, feels a bit band-aid-y 🤷️

Re: [PATCH v3 0/9] Fix Kselftest's vfork() side effects

2024-04-30 Thread Mickaël Salaün
Shuah, could you please take this series in your tree and push it to next? This mainly fixes an issue in the pidfd tests and we should get this merged before the final 6.9 release. Thanks. Jakub, can you please review it? Mark, it would be good to have your Tested-by tags. :) On Mon, Apr 29, 2

[PATCH v3 0/9] Fix Kselftest's vfork() side effects

2024-04-29 Thread Mickaël Salaün
Hi, As reported by Kernel Test Robot [1], some pidfd tests fail. This is due to the use of vfork() which introduced some side effects. Similarly, while making it more generic, a previous commit made some Landlock file system tests flaky, and subject to the host's file system mount configuration.