Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-12-08 Thread John Hubbard
On 12/8/23 14:10, Peter Zijlstra wrote: So as David already argued, the current thing does not in fact help with b. You just have to install once and the error goes away, then carry that tree for a year and you're running old crap again. My biggest beef with the whole thing is that I simply do n

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-12-08 Thread Peter Zijlstra
On Fri, Dec 08, 2023 at 12:29:37PM -0800, John Hubbard wrote: > I don't have a strong opinion about how this should be done, and in > fact I believed at the time that I was bringing the system into > compliance with what everyone wanted here. :) > > There seem to be two conflicting visions: > >

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-12-08 Thread John Hubbard
On 12/8/23 07:21, David Hildenbrand wrote: On 08.12.23 16:14, Peter Zijlstra wrote: On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: On 03.11.23 13:16, Peter Zijlstra wrote: On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: As per a discussion with Muhammad Usama

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-12-08 Thread David Hildenbrand
On 08.12.23 16:14, Peter Zijlstra wrote: On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: On 03.11.23 13:16, Peter Zijlstra wrote: On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: As per a discussion with Muhammad Usama Anjum [1], the following is how one is supp

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-12-08 Thread Peter Zijlstra
On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: > On 03.11.23 13:16, Peter Zijlstra wrote: > > On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: > > > As per a discussion with Muhammad Usama Anjum [1], the following is how > > > one is supposed to build selftests: > >

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-12-08 Thread Miroslav Benes
Hi John, Muhammad, On Tue, 6 Jun 2023, John Hubbard wrote: > As per a discussion with Muhammad Usama Anjum [1], the following is how > one is supposed to build selftests: > > make headers && make -C tools/testing/selftests/mm > > Change the selftest build system's lib.mk to fail out with a

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-11-03 Thread Peter Zijlstra
On Fri, Nov 03, 2023 at 01:59:28PM +0100, David Hildenbrand wrote: > Okay. the question is if your workflow can be easily adjusted, or if we can > improve that header handling as a whole. So on IRC the following was suggested: make O=defconfig-build headers ; make O=defconfig-build -C tools/t

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-11-03 Thread David Hildenbrand
On 03.11.23 13:46, Peter Zijlstra wrote: On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: On 03.11.23 13:16, Peter Zijlstra wrote: On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: As per a discussion with Muhammad Usama Anjum [1], the following is how one is supp

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-11-03 Thread David Hildenbrand
On 03.11.23 13:59, David Hildenbrand wrote: On 03.11.23 13:46, Peter Zijlstra wrote: On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: On 03.11.23 13:16, Peter Zijlstra wrote: On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: As per a discussion with Muhammad Usam

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-11-03 Thread Peter Zijlstra
On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: > On 03.11.23 13:16, Peter Zijlstra wrote: > > On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: > > > As per a discussion with Muhammad Usama Anjum [1], the following is how > > > one is supposed to build selftests: > >

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-11-03 Thread David Hildenbrand
On 03.11.23 13:16, Peter Zijlstra wrote: On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: As per a discussion with Muhammad Usama Anjum [1], the following is how one is supposed to build selftests: make headers && make -C tools/testing/selftests/mm Change the selftest build s

Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built

2023-11-03 Thread Peter Zijlstra
On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: > As per a discussion with Muhammad Usama Anjum [1], the following is how > one is supposed to build selftests: > > make headers && make -C tools/testing/selftests/mm > > Change the selftest build system's lib.mk to fail out with a