Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-20 Thread Marcos Paulo de Souza
On Mon, 2023-12-18 at 13:47 -0700, Shuah Khan wrote: > On 12/15/23 13:36, Joe Lawrence wrote: > > On 12/11/23 16:53, Shuah Khan wrote: > > > On 12/6/23 07:39, Miroslav Benes wrote: > > > > Hi, > > > > > > > > On Tue, 5 Dec 2023, Shuah Khan wrote: > > > > > > > > > On 12/5/23 05:52, mpdeso...@suse

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-18 Thread Shuah Khan
On 12/15/23 13:36, Joe Lawrence wrote: On 12/11/23 16:53, Shuah Khan wrote: On 12/6/23 07:39, Miroslav Benes wrote: Hi, On Tue, 5 Dec 2023, Shuah Khan wrote: On 12/5/23 05:52, mpdeso...@suse.com wrote: On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: 0003-selftests-livepatch-Test-liv

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-15 Thread Joe Lawrence
On 12/11/23 16:53, Shuah Khan wrote: > On 12/6/23 07:39, Miroslav Benes wrote: >> Hi, >> >> On Tue, 5 Dec 2023, Shuah Khan wrote: >> >>> On 12/5/23 05:52, mpdeso...@suse.com wrote: On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: >>> 0003-selftests-livepatch-Test-livepatching-a-heavil

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-11 Thread Shuah Khan
On 12/6/23 07:39, Miroslav Benes wrote: Hi, On Tue, 5 Dec 2023, Shuah Khan wrote: On 12/5/23 05:52, mpdeso...@suse.com wrote: On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has style problems, please review. NOTE: If an

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-06 Thread Miroslav Benes
Hi, On Tue, 5 Dec 2023, Shuah Khan wrote: > On 12/5/23 05:52, mpdeso...@suse.com wrote: > > On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: > > > 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has > > style problems, please review. > > > > NOTE: If any of the errors are fa

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-05 Thread Shuah Khan
On 12/5/23 05:52, mpdeso...@suse.com wrote: On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-05 Thread mpdesouza
On Fri, 2023-12-01 at 16:38 +, Shuah Khan wrote: > On 12/1/23 06:13, Marcos Paulo de Souza wrote: > > On Thu, Nov 30, 2023 at 04:24:26PM -0700, Shuah Khan wrote: > > > > > > > Missing module name? Is there a reason to not name this module? > > > > Can you please elaborate? This new module us

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-01 Thread Shuah Khan
On 12/1/23 06:13, Marcos Paulo de Souza wrote: On Thu, Nov 30, 2023 at 04:24:26PM -0700, Shuah Khan wrote: Missing module name? Is there a reason to not name this module? Can you please elaborate? This new module use the same MODULE_ macros used by the current livepatch selftests. What do y

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-12-01 Thread Marcos Paulo de Souza
On Thu, Nov 30, 2023 at 04:24:26PM -0700, Shuah Khan wrote: > On 10/31/23 15:10, Marcos Paulo de Souza wrote: > > The test proves that a syscall can be livepatched. It is interesting > > because syscalls are called a tricky way. Also the process gets > > livepatched either when sleeping in the user

Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-11-30 Thread Shuah Khan
On 10/31/23 15:10, Marcos Paulo de Souza wrote: The test proves that a syscall can be livepatched. It is interesting because syscalls are called a tricky way. Also the process gets livepatched either when sleeping in the userspace or when entering or leaving the kernel space. The livepatch is a

[PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall

2023-10-31 Thread Marcos Paulo de Souza
The test proves that a syscall can be livepatched. It is interesting because syscalls are called a tricky way. Also the process gets livepatched either when sleeping in the userspace or when entering or leaving the kernel space. The livepatch is a bit tricky: 1. The syscall function name is arch