Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-14 Thread Ryan Roberts
On 14/02/2024 16:28, Zi Yan wrote: > On 14 Feb 2024, at 11:22, Ryan Roberts wrote: > >> On 14/02/2024 16:11, Zi Yan wrote: >>> On 14 Feb 2024, at 5:38, Ryan Roberts wrote: >>> On 13/02/2024 21:55, Zi Yan wrote: > From: Zi Yan > > To split a THP to any lower order (except

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-14 Thread Zi Yan
On 14 Feb 2024, at 11:22, Ryan Roberts wrote: > On 14/02/2024 16:11, Zi Yan wrote: >> On 14 Feb 2024, at 5:38, Ryan Roberts wrote: >> >>> On 13/02/2024 21:55, Zi Yan wrote: From: Zi Yan To split a THP to any lower order (except order-1) pages, we need to reform THPs on

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-14 Thread Ryan Roberts
On 14/02/2024 16:11, Zi Yan wrote: > On 14 Feb 2024, at 5:38, Ryan Roberts wrote: > >> On 13/02/2024 21:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> To split a THP to any lower order (except order-1) pages, we need to >>> reform THPs on subpages at given order and add page refcount based on the

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-14 Thread Zi Yan
On 14 Feb 2024, at 5:38, Ryan Roberts wrote: > On 13/02/2024 21:55, Zi Yan wrote: >> From: Zi Yan >> >> To split a THP to any lower order (except order-1) pages, we need to >> reform THPs on subpages at given order and add page refcount based on the >> new page order. Also we need to

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-14 Thread Ryan Roberts
On 13/02/2024 21:55, Zi Yan wrote: > From: Zi Yan > > To split a THP to any lower order (except order-1) pages, we need to > reform THPs on subpages at given order and add page refcount based on the > new page order. Also we need to reinitialize page_deferred_list after > removing the page from

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-13 Thread Zi Yan
On 13 Feb 2024, at 17:19, Zi Yan wrote: > On 13 Feb 2024, at 17:15, Zi Yan wrote: > >> On 13 Feb 2024, at 17:05, Luis Chamberlain wrote: >> >>> On Tue, Feb 13, 2024 at 04:55:18PM -0500, Zi Yan wrote: From: Zi Yan Order-1 folio is not supported because _deferred_list, which is used by

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-13 Thread Zi Yan
On 13 Feb 2024, at 17:15, Zi Yan wrote: > On 13 Feb 2024, at 17:05, Luis Chamberlain wrote: > >> On Tue, Feb 13, 2024 at 04:55:18PM -0500, Zi Yan wrote: >>> From: Zi Yan >>> Order-1 folio is not supported because _deferred_list, which is used by >>> partially mapped folios, is stored in subpage

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-13 Thread Zi Yan
On 13 Feb 2024, at 17:05, Luis Chamberlain wrote: > On Tue, Feb 13, 2024 at 04:55:18PM -0500, Zi Yan wrote: >> From: Zi Yan >> Order-1 folio is not supported because _deferred_list, which is used by >> partially mapped folios, is stored in subpage 2 and an order-1 folio only >> has subpage 0 and

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-13 Thread David Hildenbrand
On 13.02.24 23:05, Luis Chamberlain wrote: On Tue, Feb 13, 2024 at 04:55:18PM -0500, Zi Yan wrote: From: Zi Yan Order-1 folio is not supported because _deferred_list, which is used by partially mapped folios, is stored in subpage 2 and an order-1 folio only has subpage 0 and 1. The LBS

Re: [PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-13 Thread Luis Chamberlain
On Tue, Feb 13, 2024 at 04:55:18PM -0500, Zi Yan wrote: > From: Zi Yan > Order-1 folio is not supported because _deferred_list, which is used by > partially mapped folios, is stored in subpage 2 and an order-1 folio only > has subpage 0 and 1. The LBS patches has the patch from Matthew which

[PATCH v4 5/7] mm: thp: split huge page to any lower order pages (except order-1).

2024-02-13 Thread Zi Yan
From: Zi Yan To split a THP to any lower order (except order-1) pages, we need to reform THPs on subpages at given order and add page refcount based on the new page order. Also we need to reinitialize page_deferred_list after removing the page from the split_queue, otherwise a subsequent split