Re: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-23 Thread Shuah Khan
On 5/23/24 12:12, Edward Liaw wrote: On Thu, May 23, 2024 at 11:02 AM Shuah Khan wrote: On 5/22/24 20:28, John Hubbard wrote: On 5/22/24 10:46 AM, Edward Liaw wrote: On Wed, May 22, 2024 at 4:21 AM Mark Brown wrote: On Wed, May 22, 2024 at 12:56:48AM +, Edward Liaw wrote: ... You've

Re: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-23 Thread Edward Liaw
On Thu, May 23, 2024 at 11:02 AM Shuah Khan wrote: > > On 5/22/24 20:28, John Hubbard wrote: > > On 5/22/24 10:46 AM, Edward Liaw wrote: > >> On Wed, May 22, 2024 at 4:21 AM Mark Brown wrote: > >>> On Wed, May 22, 2024 at 12:56:48AM +, Edward Liaw wrote: > > ... > >>> You've not provided a Si

Re: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-23 Thread Shuah Khan
On 5/22/24 20:28, John Hubbard wrote: On 5/22/24 10:46 AM, Edward Liaw wrote: On Wed, May 22, 2024 at 4:21 AM Mark Brown wrote: On Wed, May 22, 2024 at 12:56:48AM +, Edward Liaw wrote: ... You've not provided a Signed-off-by for this so people can't do anything with it, please see Docume

Re: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-22 Thread John Hubbard
On 5/22/24 10:46 AM, Edward Liaw wrote: On Wed, May 22, 2024 at 4:21 AM Mark Brown wrote: On Wed, May 22, 2024 at 12:56:48AM +, Edward Liaw wrote: ... You've not provided a Signed-off-by for this so people can't do anything with it, please see Documentation/process/submitting-patches.rst

Re: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-22 Thread Edward Liaw
On Wed, May 22, 2024 at 4:21 AM Mark Brown wrote: > > On Wed, May 22, 2024 at 12:56:48AM +, Edward Liaw wrote: > > > to make stopping builds early replace the static_assert() with a > > missing without making the error more severe than it already was. This > > will be moot once the issue is f

Re: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-22 Thread Mark Brown
On Wed, May 22, 2024 at 12:56:48AM +, Edward Liaw wrote: > to make stopping builds early replace the static_assert() with a > missing without making the error more severe than it already was. This > will be moot once the issue is fixed properly but reduces the disruption > while that happens.

Re: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-21 Thread Vitaly Chikunov
On Wed, May 22, 2024 at 12:56:48AM +, Edward Liaw wrote: > From: Mark Brown > > Commit daef47b89efd0b7 ("selftests: Compile kselftest headers with > -D_GNU_SOURCE") adds a static_assert() which means that things which > would be warnings about undeclared functions get escalated into build > f

[PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-21 Thread Edward Liaw
From: Mark Brown Commit daef47b89efd0b7 ("selftests: Compile kselftest headers with -D_GNU_SOURCE") adds a static_assert() which means that things which would be warnings about undeclared functions get escalated into build failures. While we do actually want _GNU_SOURCE to be defined for users o