On Tue, Dec 5, 2023 at 4:16 PM Chris Li wrote:
>
> On Mon, Dec 4, 2023 at 5:39 PM Nhat Pham wrote:
> >
> > > > memcg as a candidate for the global limit reclaim.
> > >
> > > Very minor nitpick. This patch can fold with the later patch that uses
> > > it. That makes the review easier, no need to
On Mon, Dec 4, 2023 at 5:39 PM Nhat Pham wrote:
>
> > > memcg as a candidate for the global limit reclaim.
> >
> > Very minor nitpick. This patch can fold with the later patch that uses
> > it. That makes the review easier, no need to cross reference different
> > patches. It will also make it
On Tue, Dec 5, 2023 at 10:03 AM Yosry Ahmed wrote:
>
> On Thu, Nov 30, 2023 at 11:40 AM Nhat Pham wrote:
> >
> > This patch implements a helper function that try to get a reference to
> > an memcg's css, as well as checking if it is online. This new function
> > is almost exactly the same as the
On Thu, Nov 30, 2023 at 11:40 AM Nhat Pham wrote:
>
> This patch implements a helper function that try to get a reference to
> an memcg's css, as well as checking if it is online. This new function
> is almost exactly the same as the existing mem_cgroup_tryget(), except
> for the onlineness
On Mon, Dec 4, 2023 at 4:36 PM Chris Li wrote:
>
> Hi Nhat,
>
> Very minor nitpick. This patch can fold with the later patch that uses
> it. That makes the review easier, no need to cross reference different
> patches. It will also make it harder to introduce API that nobody
> uses.
>
> Chris
>
>
Hi Nhat,
Very minor nitpick. This patch can fold with the later patch that uses
it. That makes the review easier, no need to cross reference different
patches. It will also make it harder to introduce API that nobody
uses.
Chris
On Thu, Nov 30, 2023 at 11:40 AM Nhat Pham wrote:
>
> This patch
This patch implements a helper function that try to get a reference to
an memcg's css, as well as checking if it is online. This new function
is almost exactly the same as the existing mem_cgroup_tryget(), except
for the onlineness check. In the !CONFIG_MEMCG case, it always returns
true,
