Re: [RFC] drm/tests: annotate intentional stack trace in drm_test_rect_calc_hscale()

2023-11-28 Thread Maxime Ripard
Hi Dan, On Wed, Nov 15, 2023 at 05:42:17PM -0500, Dan Carpenter wrote: > On Mon, Nov 06, 2023 at 02:58:12PM +0100, mrip...@kernel.org wrote: > > > But a similar thing is happening here where we have so many bogus > > > warnings that we missed a real bug. > > > > IIRC, there was a similar

Re: [RFC] drm/tests: annotate intentional stack trace in drm_test_rect_calc_hscale()

2023-11-15 Thread Dan Carpenter
On Mon, Nov 06, 2023 at 02:58:12PM +0100, mrip...@kernel.org wrote: > > But a similar thing is happening here where we have so many bogus > > warnings that we missed a real bug. > > IIRC, there was a similar discussion for lockdep issues. IMO, any > (unintended) warning should trigger a test

Re: [RFC] drm/tests: annotate intentional stack trace in drm_test_rect_calc_hscale()

2023-11-06 Thread mripard
Hi, On Wed, Nov 01, 2023 at 12:08:00PM +0300, Dan Carpenter wrote: > Let me add Richard to the CC list. See lore for more details. > https://lore.kernel.org/all/CA+G9fYuA643RHHpPnz9Ww7rr3zV5a0y=7_uFcybBSL=qp_s...@mail.gmail.com/ > > On Tue, Oct 31, 2023 at 09:57:48PM +0530, Naresh Kamboju

Re: [RFC] drm/tests: annotate intentional stack trace in drm_test_rect_calc_hscale()

2023-11-01 Thread Dan Carpenter
Let me add Richard to the CC list. See lore for more details. https://lore.kernel.org/all/CA+G9fYuA643RHHpPnz9Ww7rr3zV5a0y=7_uFcybBSL=qp_s...@mail.gmail.com/ On Tue, Oct 31, 2023 at 09:57:48PM +0530, Naresh Kamboju wrote: > On Mon, 30 Oct 2023 at 14:33, Dan Carpenter wrote: > > > > We have

Re: [RFC] drm/tests: annotate intentional stack trace in drm_test_rect_calc_hscale()

2023-10-31 Thread Naresh Kamboju
On Mon, 30 Oct 2023 at 14:33, Dan Carpenter wrote: > > We have started printing more and more intentional stack traces. Whether > it's testing KASAN is able to detect use after frees or it's part of a > kunit test. > > These stack traces can be problematic. They suddenly show up as a new >

[RFC] drm/tests: annotate intentional stack trace in drm_test_rect_calc_hscale()

2023-10-30 Thread Dan Carpenter
We have started printing more and more intentional stack traces. Whether it's testing KASAN is able to detect use after frees or it's part of a kunit test. These stack traces can be problematic. They suddenly show up as a new failure. Now the test team has to contact the developers. A bunch