Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-09 Thread Muhammad Usama Anjum
On 4/9/24 5:12 AM, Waiman Long wrote: > > On 4/8/24 08:04, Muhammad Usama Anjum wrote: >> On 4/8/24 5:01 PM, Michal Koutný wrote: >>> On Mon, Apr 08, 2024 at 04:53:11PM +0500, Muhammad Usama Anjum >>> wrote: ksft_test_result_report(tests[i].fn(root), tests[i].name) >>> $ git grep ksft_test_r

Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-08 Thread Waiman Long
On 4/8/24 08:04, Muhammad Usama Anjum wrote: On 4/8/24 5:01 PM, Michal Koutný wrote: On Mon, Apr 08, 2024 at 04:53:11PM +0500, Muhammad Usama Anjum wrote: ksft_test_result_report(tests[i].fn(root), tests[i].name) $ git grep ksft_test_result_report v6.9-rc3 -- (empty result) I can't find t

Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-08 Thread Muhammad Usama Anjum
On 4/8/24 5:01 PM, Michal Koutný wrote: > On Mon, Apr 08, 2024 at 04:53:11PM +0500, Muhammad Usama Anjum > wrote: >> ksft_test_result_report(tests[i].fn(root), tests[i].name) > > $ git grep ksft_test_result_report v6.9-rc3 -- > (empty result) > > I can't find that helper. Is that in some devel

Re: Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-08 Thread Michal Koutný
On Mon, Apr 08, 2024 at 04:53:11PM +0500, Muhammad Usama Anjum wrote: > ksft_test_result_report(tests[i].fn(root), tests[i].name) $ git grep ksft_test_result_report v6.9-rc3 -- (empty result) I can't find that helper. Is that in some devel repositories? Michal signature.asc Description: PGP

Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-08 Thread Muhammad Usama Anjum
On 4/8/24 4:29 PM, Michal Koutný wrote: > On Sun, Apr 07, 2024 at 02:37:44AM +0500, Muhammad Usama Anjum > wrote: >> The >> ksft_print_header(); >> ksft_set_plan(total_number_of_tests); >> are missing. Please use all of the ksft APIs to make the test TAP compliant. > > Will do. > >>>

Re: Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-08 Thread Michal Koutný
On Sun, Apr 07, 2024 at 02:37:44AM +0500, Muhammad Usama Anjum wrote: > The > ksft_print_header(); > ksft_set_plan(total_number_of_tests); > are missing. Please use all of the ksft APIs to make the test TAP compliant. Will do. > > + for (i = 0; i < ARRAY_SIZE(tests); i++) { > > +

Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-06 Thread Muhammad Usama Anjum
On 4/5/24 10:05 PM, Michal Koutný wrote: > This commit adds (and wires in) new test program for checking basic pids > controller functionality -- restricting tasks in a cgroup and correct > event counting. > > Signed-off-by: Michal Koutný > --- > tools/testing/selftests/cgroup/Makefile| 2

[RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller

2024-04-05 Thread Michal Koutný
This commit adds (and wires in) new test program for checking basic pids controller functionality -- restricting tasks in a cgroup and correct event counting. Signed-off-by: Michal Koutný --- tools/testing/selftests/cgroup/Makefile| 2 + tools/testing/selftests/cgroup/test_pids.c | 187 +++