Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-19 Thread Peter Newman
Hi Tony, On Mon, Mar 18, 2024 at 3:05 PM Luck, Tony wrote: > > > Could you please help me understand the details by answering my first > > question: What is the use case for needing to expose the individual cluster > > counts? > > > > This is a model specific feature so if this is something neede

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Reinette Chatre
Hi Tony, On 3/18/2024 3:00 PM, Luck, Tony wrote: >> Perhaps ... in this case it may make things easier to understand if >> those "mon_NODE_*" directories are sub-directories of the appropriate >> "mon_L3_*" directories. > > Reinette, > > Like this? > > $ tree mon_data/ > mon_data/ > ├── mon_L3

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Luck, Tony
> Could you please help me understand the details by answering my first > question: What is the use case for needing to expose the individual cluster > counts? > > This is a model specific feature so if this is something needed for just a > couple of systems I think we should be less inclined to m

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Luck, Tony
> Perhaps ... in this case it may make things easier to understand if > those "mon_NODE_*" directories are sub-directories of the appropriate > "mon_L3_*" directories. Reinette, Like this? $ tree mon_data/ mon_data/ ├── mon_L3_00 │   ├── llc_occupancy │   ├── mbm_local_bytes │   ├── mbm_total_b

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Reinette Chatre
On 3/18/2024 2:04 PM, Luck, Tony wrote: >>> What is the use case for needing to expose the individual cluster counts? >>> What if >>> resctrl just summed the cluster counts and presented the data as before - >>> per L3 >>> cache instance? I doubt that resctrl would be what applications would u

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Reinette Chatre
Hi Tony, On 3/18/2024 1:47 PM, Luck, Tony wrote: >> What is the use case for needing to expose the individual cluster counts? >> What if >> resctrl just summed the cluster counts and presented the data as before - >> per L3 >> cache instance? I doubt that resctrl would be what applications would

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Luck, Tony
> > What is the use case for needing to expose the individual cluster counts? > > What if > > resctrl just summed the cluster counts and presented the data as before - > > per L3 > > cache instance? I doubt that resctrl would be what applications would use > > to verify > > whether they are "wel

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Luck, Tony
> What is the use case for needing to expose the individual cluster counts? > What if > resctrl just summed the cluster counts and presented the data as before - per > L3 > cache instance? I doubt that resctrl would be what applications would use to > verify > whether they are "well behaved" wrt

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Reinette Chatre
Hi Tony, On 3/18/2024 12:34 PM, Luck, Tony wrote: While that is in some ways a more accurate view, it breaks a lot of legacy monitoring applications that expect the "L3" names. >>> >>> True - but the behaviour is different from a non SNC system, if this >>> software can read the >>> fil

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Luck, Tony
> >> While that is in some ways a more accurate view, it breaks a lot of > >> legacy monitoring applications that expect the "L3" names. > > > > True - but the behaviour is different from a non SNC system, if this > > software can read the > > file - but goes wrong because the contents of the file

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-18 Thread Reinette Chatre
On 3/15/2024 11:02 AM, James Morse wrote: > On 08/03/2024 18:42, Tony Luck wrote: >> On Fri, Mar 08, 2024 at 06:06:45PM +, James Morse wrote: >>> Hi guys, >>> >>> On 07/03/2024 23:16, Tony Luck wrote: On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: > Thank you for t

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-15 Thread James Morse
Hi Tony, On 08/03/2024 18:42, Tony Luck wrote: > On Fri, Mar 08, 2024 at 06:06:45PM +, James Morse wrote: >> Hi guys, >> >> On 07/03/2024 23:16, Tony Luck wrote: >>> On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: Thank you for the example. I find that significantly easie

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-08 Thread Tony Luck
On Fri, Mar 08, 2024 at 06:06:45PM +, James Morse wrote: > Hi guys, > > On 07/03/2024 23:16, Tony Luck wrote: > > On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: > >> Thank you for the example. I find that significantly easier to > >> understand than a single number in a gener

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-08 Thread James Morse
Hi guys, On 07/03/2024 23:16, Tony Luck wrote: > On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: >> Thank you for the example. I find that significantly easier to >> understand than a single number in a generic "nodes_per_l3_cache". >> Especially with potential confusion surroundi

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 3:16 PM, Tony Luck wrote: > On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: >> Thank you for the example. I find that significantly easier to >> understand than a single number in a generic "nodes_per_l3_cache". >> Especially with potential confusion surroundi

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Tony Luck
On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: > Thank you for the example. I find that significantly easier to > understand than a single number in a generic "nodes_per_l3_cache". > Especially with potential confusion surrounding inconsistent "nodes" > between allocation and moni

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 1:14 PM, Luck, Tony wrote: >> Thinking about it even differently. The goal is to give information >> to userspace so we need to think about what would help user space? >> For example, what if there is a file in info that shows >> which CPUs are associated with each domain? >

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Luck, Tony
> Thinking about it even differently. The goal is to give information > to userspace so we need to think about what would help user space? > For example, what if there is a file in info that shows > which CPUs are associated with each domain? Reinette, Interesting idea. That would save users fro

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 9:57 AM, Luck, Tony wrote: >>> SNC2 enabled: >>> >>> $ cat /sys/fs/resctrl/info/L3_mon/ snc_nodes_per_l3_cache >>> 2 >>> >> >> This would be useful. I believe "SNC" is architecture specific? >> What if the file always exists and is named "nodes_per_l3_cache"? >> >> I assume th

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Luck, Tony
> > SNC2 enabled: > > > > $ cat /sys/fs/resctrl/info/L3_mon/ snc_nodes_per_l3_cache > > 2 > > > > This would be useful. I believe "SNC" is architecture specific? > What if the file always exists and is named "nodes_per_l3_cache"? > > I assume that the internals of handling more nodes per L3 cache s

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 9:18 AM, Luck, Tony wrote: >>> If so, what should it be named? "snc_ways" as a kernel variable was >>> later replaced by "snc_nodes_per_l3_cache". Is that a good filename? >> >> "snc_nodes_per_l3_cache" seems okay to me. >> >> And I understand that the file content would show

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Luck, Tony
>>If so, what should it be named? "snc_ways" as a kernel variable was >>later replaced by "snc_nodes_per_l3_cache". Is that a good filename? > > "snc_nodes_per_l3_cache" seems okay to me. > > And I understand that the file content would show SNC mode and the presence or > absence of this file would

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Maciej Wieczor-Retman
On 2024-03-06 at 21:54:02 +, Luck, Tony wrote: >> Figuring out if SNC is enabled is only one part of the problem, the >> other being whether the kernel supports it. As there is no easy >> interface that simply states SNC support in the kernel one can find that >> information by comparing L3 cac

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-06 Thread Luck, Tony
> Figuring out if SNC is enabled is only one part of the problem, the > other being whether the kernel supports it. As there is no easy > interface that simply states SNC support in the kernel one can find that > information by comparing L3 cache sizes from different sources. Cache > size reported