Re: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the QI faults

2024-01-10 Thread Ethan Zhao
On 1/1/2024 11:34 AM, Baolu Lu wrote: On 12/28/23 2:17 PM, Tian, Kevin wrote: raw_spin_lock_irqsave(&qi->q_lock, flags);   /* @@ -1430,7 +1439,7 @@ int qi_submit_sync(struct intel_iommu *iommu, struct qi_desc *desc,    * a deadlock where the interrupt context can wait indefinitely

Re: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the QI faults

2023-12-31 Thread Baolu Lu
On 12/28/23 2:17 PM, Tian, Kevin wrote: raw_spin_lock_irqsave(&qi->q_lock, flags); /* @@ -1430,7 +1439,7 @@ int qi_submit_sync(struct intel_iommu *iommu, struct qi_desc *desc, * a deadlock where the interrupt context can wait indefinitely * for fr

Re: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the QI faults

2023-12-28 Thread Yi Liu
On 2023/12/28 14:17, Tian, Kevin wrote: From: Liu, Yi L Sent: Thursday, December 28, 2023 12:14 AM @@ -1376,6 +1383,8 @@ int qi_submit_sync(struct intel_iommu *iommu, struct qi_desc *desc, restart: rc = 0; + if (fault) + *fault = 0; move it to right before the l

RE: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the QI faults

2023-12-27 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, December 28, 2023 12:14 AM > > @@ -1376,6 +1383,8 @@ int qi_submit_sync(struct intel_iommu *iommu, > struct qi_desc *desc, > > restart: > rc = 0; > + if (fault) > + *fault = 0; move it to right before the loop of qi_check_fault() > >