Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

2018-06-11 Thread Finn Thain
On Sun, 10 Jun 2018, Benjamin Herrenschmidt wrote: > Pre-PCI is basically "NUBUS" based even in absence of an actual NuBus > slot :-) It has to do with the internal HW architecture. The only ones > that aren't are the even older designs (the 68000 based ones). > There is already some

Re: [PATCH 3/3 RFC] Revert "net: stmmac: fix build failure due to missing COMMON_CLK dependency"

2018-06-11 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Jun 11, 2018 at 10:59 AM Arnd Bergmann wrote: > On Mon, Jun 11, 2018 at 10:44 AM, Geert Uytterhoeven > wrote: > > This reverts commit bde4975310eb1982bd0bbff673989052d92fd481. > > > > All legacy clock implementations now implement clk_set_rate() (Some > > implementations may be

Re: [PATCH 0/3] Legacy clock drivers: Normalize clk API

2018-06-11 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Jun 11, 2018 at 11:02 AM Arnd Bergmann wrote: > On Mon, Jun 11, 2018 at 10:44 AM, Geert Uytterhoeven > wrote: > > When seeing commit bde4975310eb1982 ("net: stmmac: fix build failure due > > to missing COMMON_CLK dependency"), I wondered why this dependency is > > needed, as

Re: [PATCH 0/3] Legacy clock drivers: Normalize clk API

2018-06-11 Thread Arnd Bergmann
On Mon, Jun 11, 2018 at 10:44 AM, Geert Uytterhoeven wrote: > Hi all, > > When seeing commit bde4975310eb1982 ("net: stmmac: fix build failure due > to missing COMMON_CLK dependency"), I wondered why this dependency is > needed, as all implementations of the clock API should implement all

Re: [PATCH 3/3 RFC] Revert "net: stmmac: fix build failure due to missing COMMON_CLK dependency"

2018-06-11 Thread Arnd Bergmann
On Mon, Jun 11, 2018 at 10:44 AM, Geert Uytterhoeven wrote: > This reverts commit bde4975310eb1982bd0bbff673989052d92fd481. > > All legacy clock implementations now implement clk_set_rate() (Some > implementations may be dummies, though). > > Signed-off-by: Geert Uytterhoeven > --- > Marked

Re: [PATCH] microblaze: Remove architecture heart beat code

2018-06-11 Thread Geert Uytterhoeven
Hi Linus, On Mon, Jun 11, 2018 at 10:47 AM Linus Walleij wrote: > On Mon, Jun 11, 2018 at 8:09 AM, Michal Simek wrote: > > There is no reason to keep this gpio based code in architecture. Use > > ledtrig-heartbeat.c instead which is much more flexible then this > > ancient code. > > > >

Re: [PATCH] microblaze: Remove architecture heart beat code

2018-06-11 Thread Linus Walleij
On Mon, Jun 11, 2018 at 8:09 AM, Michal Simek wrote: > There is no reason to keep this gpio based code in architecture. Use > ledtrig-heartbeat.c instead which is much more flexible then this > ancient code. > > Signed-off-by: Michal Simek Reviewed-by: Linus Walleij Maybe the arch

[PATCH 1/3] m68k: coldfire: Normalize clk API

2018-06-11 Thread Geert Uytterhoeven
Coldfire still provides its own variant of the clk API rather than using the generic COMMON_CLK API. This generally works, but it causes some link errors with drivers using the clk_round_rate(), clk_set_rate(), clk_set_parent(), or clk_get_parent() functions when a platform lacks those

[PATCH 3/3 RFC] Revert "net: stmmac: fix build failure due to missing COMMON_CLK dependency"

2018-06-11 Thread Geert Uytterhoeven
This reverts commit bde4975310eb1982bd0bbff673989052d92fd481. All legacy clock implementations now implement clk_set_rate() (Some implementations may be dummies, though). Signed-off-by: Geert Uytterhoeven --- Marked "RFC", as this depends on "m68k: coldfire: Normalize clk API" and "MIPS: AR7:

[PATCH 2/3] MIPS: AR7: Normalize clk API

2018-06-11 Thread Geert Uytterhoeven
Coldfire still provides its own variant of the clk API rather than using the generic COMMON_CLK API. This generally works, but it causes some link errors with drivers using the clk_round_rate(), clk_set_rate(), clk_set_parent(), or clk_get_parent() functions when a platform lacks those

[PATCH 0/3] Legacy clock drivers: Normalize clk API

2018-06-11 Thread Geert Uytterhoeven
Hi all, When seeing commit bde4975310eb1982 ("net: stmmac: fix build failure due to missing COMMON_CLK dependency"), I wondered why this dependency is needed, as all implementations of the clock API should implement all required functionality, or provide dummies. It turns out there were