On Thu, 8 Jan 2009, Jean Delvare wrote:
> > +#if (defined(CONFIG_USB_ZR364XX_MODULE) && defined(MODULE))
>
> Huh? I guess you really mean: CONFIG_VIDEO_ZORAN_MODULE?
>
> I don't get the point of checking for both CONFIG_VIDEO_ZORAN_MODULE
> and MODULE, checking for just one of them should be enough
Well that simplifies the ifdef and allows text editors to still see the
braces as being balanced, at the expense of uglier code for all current
kernel versions. On the other hand this clearly documents the backwards
compatible change for all those kernels and won't affect anything going
forwa
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> On Thu, 8 Jan 2009 13:20:19 -0800 (PST)
> Trent Piepho wrote:
> > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> > It doesn't seem like any other driver needs to protect the module device
> > table with an ifdef.
>
> However, Zoran driver does
On Thu, 8 Jan 2009, Mike Isely wrote:
> > Yes... Anyway, this is the real patch. I've added a small comment about this
> > change... I'll commit this tomorrow, if you don't have a better suggestion.
>
> Looks good.
Or maybe like this?
diff -r f01b3897d141 linux/drivers/media/video/pvrusb2/pvrusb2
On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote:
> On Thu, 8 Jan 2009 22:42:41 -0600 (CST)
> Mike Isely wrote:
>
> > On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote:
> >
> > > On Thu, 8 Jan 2009 22:28:18 -0600 (CST)
> > > Mike Isely wrote:
> > >
> > > > On Thu, 8 Jan 2009, Mike Isely wrote:
>
On Thu, 8 Jan 2009 22:42:41 -0600 (CST)
Mike Isely wrote:
> On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote:
>
> > On Thu, 8 Jan 2009 22:28:18 -0600 (CST)
> > Mike Isely wrote:
> >
> > > On Thu, 8 Jan 2009, Mike Isely wrote:
> > >
> > > >
> > > >
> > > > On Thu, 8 Jan 2009, Mauro Carvalho C
On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote:
> On Thu, 8 Jan 2009 22:28:18 -0600 (CST)
> Mike Isely wrote:
>
> > On Thu, 8 Jan 2009, Mike Isely wrote:
> >
> > >
> > >
> > > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> > >
> > > > Hi Mike,
> > > >
> > > > There were an upstream cha
On Thu, 8 Jan 2009 22:28:18 -0600 (CST)
Mike Isely wrote:
> On Thu, 8 Jan 2009, Mike Isely wrote:
>
> >
> >
> > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> >
> > > Hi Mike,
> > >
> > > There were an upstream change usb_lock_device_for_reset() that touched on
> > > pvrusb2 driver. I di
Thank you Mauro.
I finally got it what to do.
I'll figure it out how to make it easier to control strobe lights through CIDs.
"Try to avoid creating newer ioctls" is the same I think.
Cheers,
Nate
On Fri, Jan 9, 2009 at 1:18 PM, Mauro Carvalho Chehab
wrote:
> On Fri, 9 Jan 2009 12:20:16 +090
On Thu, 8 Jan 2009, Mike Isely wrote:
>
>
> On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
>
> > Hi Mike,
> >
> > There were an upstream change usb_lock_device_for_reset() that touched on
> > pvrusb2 driver. I didn't backport it yet, since I'm not sure if the change
> > is
> > ok. Could you
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> Hi Mike,
>
> There were an upstream change usb_lock_device_for_reset() that touched on
> pvrusb2 driver. I didn't backport it yet, since I'm not sure if the change is
> ok. Could you please check?
>
> Thanks,
> Mauro.
Yes, the pvrusb2 part of
On Fri, 9 Jan 2009 12:20:16 +0900
"DongSoo Kim" wrote:
> Hello everyone.
>
> I'm facing with some questions about "Can I make it ioctl or CID?"
For most cases, creating a control (CID) is better than using another ioctl.
> Because if I make it in ioctl It should occupy one of the extra ioctl
>
Hello everyone.
I'm facing with some questions about "Can I make it ioctl or CID?"
Because if I make it in ioctl It should occupy one of the extra ioctl
number for v4l2, and I'm afraid it deserves that.
Actually I'm working on strobe flash device (like xenon flash, LED
flash and so on...) for di
Hi Mike,
There were an upstream change usb_lock_device_for_reset() that touched on
pvrusb2 driver. I didn't backport it yet, since I'm not sure if the change is
ok. Could you please check?
Thanks,
Mauro.
commit 011b15df465745474e3ec85482633685933ed5a7
Author: Alan Stern
Date: Tue Nov 4 11:29:
On Thu, 8 Jan 2009 22:45:20 +0100
Jean Delvare wrote:
> Hi Mauro,
>
> On Thu, 8 Jan 2009 17:56:27 -0200, Mauro Carvalho Chehab wrote:
> > > Hi Mauro,
> > >
> > > This commit of yours:
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=60b4bde48b36c0315ef41fd3
Hi Mauro,
On Thu, 8 Jan 2009 17:56:27 -0200, Mauro Carvalho Chehab wrote:
> > Hi Mauro,
> >
> > This commit of yours:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=60b4bde48b36c0315ef41fd38c339b9c7e68c46f
> > causes the zr36067 driver to no longer load automa
On Thu, 8 Jan 2009 13:20:19 -0800 (PST)
Trent Piepho wrote:
> On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=60b4bde48b36c0315ef41fd38c339b9c7e68c46f
> > > causes the zr36067 driver to no longer load automati
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=60b4bde48b36c0315ef41fd38c339b9c7e68c46f
> > causes the zr36067 driver to no longer load automatically on systems
> > with a Zoran-based adapter. The comment says tha
Mauro Carvalho Chehab wrote:
> Alexey,
>
> You should get the driver maintainer's ack or at least let them know that
> you're touching on their drivers.
>
> Mike, Thierry an Dean,
>
> Could you please review this patch?
>
It is OK for usbvision.
Just a note with usbvision-video, Mauro you will
Sebastian,
Please, always c/c linux-media@vger.kernel.org, when submitting patches. This
allows patchwork.kernel.org to track it.
Forwarded message:
Date: Thu, 8 Jan 2009 16:49:17 +0100
From: Sebastian Andrzej Siewior
To: Mauro Carvalho Chehab
Cc: v4l-dvb-maintai...@linuxtv.org, video4linux-l
On Thu, 08 Jan 2009 09:44:20 -0800
Randy Dunlap wrote:
>
> linux-next-20090108/drivers/media/video/cx88/cx88-i2c.c: In function
> 'cx88_call_i2c_clients':
> linux-next-20090108/drivers/media/video/cx88/cx88-i2c.c:122: error: 'struct
> cx88_core' has no me
Mike Isely wrote:
> Why is this change needed? (Please point me at a discussion thread, if
> you'd like...)
>
> -Mike
>
I remember this list of patches:
https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3708324
and
https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3709124
I think
> Hi Mauro,
>
> This commit of yours:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=60b4bde48b36c0315ef41fd38c339b9c7e68c46f
> causes the zr36067 driver to no longer load automatically on systems
> with a Zoran-based adapter. The comment says that zr36067_pci_tb
(This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.)
Results of the daily build of v4l-dvb:
date:Thu Jan 8 19:00:13 CET 2009
path:http://www.linuxtv.org/hg/v4l-dvb
changeset: 10200:2879e2993349
gcc version: gcc
linux-next-20090108/drivers/media/video/cx88/cx88-i2c.c: In function
'cx88_call_i2c_clients':
linux-next-20090108/drivers/media/video/cx88/cx88-i2c.c:122: error: 'struct
cx88_core' has no member named 'gate_ctrl'
linux-next-20090108/drivers/media/video/cx88/
> > Hi Mauro,
> > please look at the patch below.
> >
> > Signed-off-by: Hans Werner
> >
> > Thanks,
> > Hans
> >
> > Original-Nachricht
> > Datum: Mon, 05 Jan 2009 16:10:50 +0100
> > Von: "Hans Werner"
> > An: linux-...@linuxtv.org
> > Betreff: [linux-dvb] [PATCH] stb6100: s
> > Hi Mauro,
> > please look at the patch below.
> >
> > Signed-off-by: Hans Werner
> >
> > Thanks,
> > Hans
> >
> > Original-Nachricht
> > Datum: Mon, 05 Jan 2009 16:10:50 +0100
> > Von: "Hans Werner"
> > An: linux-...@linuxtv.org
> > Betreff: [linux-dvb] [PATCH] stb6100:
Hi Alexey,
It looks fine. There's no functional changes in the s2255 driver. It
is good to get rid of the magic string "s2255". The "err to pr_err"
change is the only change I'm not sure about. I have no strong opinion
about it however.
Thanks,
Mauro Carvalho Chehab wrote:
Alexey,
Yo
Why is this change needed? (Please point me at a discussion thread, if
you'd like...)
-Mike
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> Alexey,
>
> You should get the driver maintainer's ack or at least let them know that
> you're touching on their drivers.
>
> Mike, Thierry an De
On Thu, 8 Jan 2009, Klaus Schmidinger wrote:
On 07.01.2009 03:09, Mauro Carvalho Chehab wrote:
V4L, DVB and V4L/DVB Maintainers Mailing Lists Were merged on Jan, 2 2009 at
vger.kernel.org
The idea of merging the mailing lists is running around for some time.
It took some time for me to have
Thanks,
Vaibhav Hiremath
> -Original Message-
> From: Tony Lindgren [mailto:t...@atomide.com]
> Sent: Wednesday, January 07, 2009 6:06 PM
> To: Hiremath, Vaibhav
> Cc: linux-o...@vger.kernel.org; linux-media@vger.kernel.org;
> video4linux-l...@redhat.com; Jadav, Brijesh R; Shah, Hardik;
Alexey,
You should get the driver maintainer's ack or at least let them know that
you're touching on their drivers.
Mike, Thierry an Dean,
Could you please review this patch?
Cheers,
Mauro.
Forwarded message:
Date: Thu, 01 Jan 2009 11:06:08 +0300
From: Alexey Klimov
To: Mauro Carvalho Chehab
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> On Wed, 7 Jan 2009 10:14:31 +0100 (CET)
> Guennadi Liakhovetski wrote:
>
> > Hi all
> >
> > I have been guessing around these operations for a while now, and
> > eventually have decided to ask.
> >
> > My current understanding is, that S_FMT
On Wed, 7 Jan 2009 10:14:31 +0100 (CET)
Guennadi Liakhovetski wrote:
> Hi all
>
> I have been guessing around these operations for a while now, and
> eventually have decided to ask.
>
> My current understanding is, that S_FMT in terms of window geometry should
> (ideally) set user window size
On Thu, 8 Jan 2009 12:31:48 +0700
"Nam Phạm Thành" wrote:
> OK, resent. Hope it's OK now.
Unfortunately, it is not 100% ok. See the comments bellow.
You shouldn't add any comment before the patch (like the above). Otherwise, it
will be committed by the scripts also, or I need to double check
On Thu, 8 Jan 2009 12:03:00 +0100 (CET)
Patrick Boettcher wrote:
> Hi Mauro,
>
> can you please pull from
>
> http://linuxtv.org/hg/~pb/v4l-dvb/
>
> for
>
> [PATCH] add Terratec Cinergy T Express to dibcom driver
>
> .
>
> Do PULL requests are also have to be sent over the new linux-m
36 matches
Mail list logo
