Re: [PATCH 1/8] v4l: add videobuf2 Video for Linux 2 driver framework

2010-12-13 Thread Hans Verkuil
On Tuesday, December 14, 2010 08:14:32 Marek Szyprowski wrote: > Hello, > > On Saturday, December 11, 2010 5:55 PM Hans Verkuil wrote: > > Big thanks for the review! I will fix all these minor issues and resend > the patches soon. I hope we will manage to get videobuf2 merged soon! :) > > > Hi M

RE: [PATCH 1/8] v4l: add videobuf2 Video for Linux 2 driver framework

2010-12-13 Thread Marek Szyprowski
Hello, On Saturday, December 11, 2010 5:55 PM Hans Verkuil wrote: Big thanks for the review! I will fix all these minor issues and resend the patches soon. I hope we will manage to get videobuf2 merged soon! :) > Hi Marek, > > Here is my review. I wish I could ack it, but I found a few bugs tha

Re: tm6000 and IR

2010-12-13 Thread Dmitri Belimov
Hi What about my last patch?? This is OK or bad? Our customers kick me every day with IR remotes. With my best regards, Dmitry. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2

2010-12-13 Thread Mauro Carvalho Chehab
Em 13-12-2010 16:31, Jarod Wilson escreveu: > On Mon, Dec 13, 2010 at 01:06:00AM -0800, Dmitry Torokhov wrote: >> On Thu, Dec 09, 2010 at 11:16:47AM -0800, Dmitry Torokhov wrote: >>> On Thu, Dec 09, 2010 at 08:04:36PM +0100, Henrik Rydberg wrote: On 12/09/2010 10:39 AM, Dmitry Torokhov wrote:

Re: BUG: double mutex_unlock in drivers/media/video/tlg2300/pd-video.c

2010-12-13 Thread Huang Shijie
Hi Strakh: Thanks for your patch. But I prefer to remove the mutex_unlock() in the pd_vidioc_s_fmt(), since the pd_vidioc_s_fmt() is also called in restore_v4l2_context(). would you please change the patch? I will ack it. Best Regards Huang Shijie 2010/12/13 Alexander Strakh : >        KERNEL

Re: [PATCHv7 08/10] mm: cma: Contiguous Memory Allocator added

2010-12-13 Thread KAMEZAWA Hiroyuki
On Mon, 13 Dec 2010 12:26:49 +0100 Michal Nazarewicz wrote: > The Contiguous Memory Allocator is a set of functions that lets > one initialise a region of memory which then can be used to perform > allocations of contiguous memory chunks from. The implementation > uses MIGRATE_CMA migration type

Re: [PATCHv7 06/10] mm: MIGRATE_CMA migration type added

2010-12-13 Thread KAMEZAWA Hiroyuki
On Mon, 13 Dec 2010 12:26:47 +0100 Michal Nazarewicz wrote: > The MIGRATE_CMA migration type has two main characteristics: > (i) only movable pages can be allocated from MIGRATE_CMA > pageblocks and (ii) page allocator will never change migration > type of MIGRATE_CMA pageblocks. > > This guaran

Re: [PATCH] bttv: fix mutex use before init

2010-12-13 Thread Brandon Philips
On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: > * change &fh->cap.vb_lock in bttv_open() AND radio_open() to > &btv->init.cap.vb_lock > * add a mutex_init(&btv->init.cap.vb_lock) to the setup of init in > bttv_probe() That seems like a reasonable suggestion. An openSUSE user submitted this bu

Re: [PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17

2010-12-13 Thread Jean-Francois Moine
On Mon, 13 Dec 2010 11:27:24 -0200 Mauro Carvalho Chehab wrote: > > case SENSOR_OV7660: > > init = ov7660_sensor_param1; > > - if (sd->bridge == BRIDGE_SN9C120) { > > - if (mode) { /* 320x240 - 160x120 */ > > - reg1

Re: [PATCH] bttv: fix mutex use before init

2010-12-13 Thread Torsten Kaiser
On Mon, Dec 13, 2010 at 3:04 PM, Dave Young wrote: > On Sun, Dec 12, 2010 at 05:13:47PM +0100, Torsten Kaiser wrote: >> On Sun, Dec 12, 2010 at 2:15 PM, Dave Young >> wrote: >> > oops happen in bttv_open while locking uninitialized mutex fh->cap.vb_lock >> > add mutex_init before usage >> >> I h

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-13 Thread Hans Verkuil
On Monday, December 13, 2010 14:31:18 Andy Walls wrote: > On Mon, 2010-12-13 at 08:32 +0100, Hans Verkuil wrote: > > On Sunday, December 12, 2010 19:46:33 Andy Walls wrote: > > Hi Hans, > > > > 1. Why set the vol step to 655, when the volume will actaully step at > > > increments of 512? > > >

Re: [PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17

2010-12-13 Thread Hans de Goede
Hi, On 12/13/2010 02:27 PM, Mauro Carvalho Chehab wrote: Em 13-12-2010 11:04, Jean-Francois Moine escreveu: I'm not sure about this... On my tests with the two devices I have with ov7660 (sn9c105 and sn9c120), the original driver uses 48 MHz for all resolutions. My 2 cents: In my experien

Re: [RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2

2010-12-13 Thread Jarod Wilson
On Mon, Dec 13, 2010 at 01:06:00AM -0800, Dmitry Torokhov wrote: > On Thu, Dec 09, 2010 at 11:16:47AM -0800, Dmitry Torokhov wrote: > > On Thu, Dec 09, 2010 at 08:04:36PM +0100, Henrik Rydberg wrote: > > > On 12/09/2010 10:39 AM, Dmitry Torokhov wrote: > > > > > > > The desire to keep old names fo

[cron job] v4l-dvb daily build: WARNINGS

2010-12-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Mon Dec 13 19:00:06 CET 2010 git master: 59365d136d205cc20fe666ca7f89b1c5001b0d5a git media-master: gcc version: i6

[PATCH 1/2] media: saa7115: allow input standard autodetection for SAA7113

2010-12-13 Thread Anatolij Gustschin
Autodetect input's standard using field frequency detection feature (FIDT in status byte at 0x1F) of the SAA7113. Signed-off-by: Anatolij Gustschin --- drivers/media/video/saa7115.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/saa7115.c

[PATCH 2/2] media: fsl_viu: add VIDIOC_QUERYSTD and VIDIOC_G_STD support

2010-12-13 Thread Anatolij Gustschin
VIDIOC_QUERYSTD and VIDIOC_G_STD ioctls are currently not supported in the FSL VIU driver. The decoder subdevice driver saa7115 extended by previous patch supports QUERYSTD for saa7113, so we add the appropriate ioctls to the VIU driver to be able to determine the video input's standard. Signed-of

Re: [RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2010-12-13 Thread Russell King - ARM Linux
On Mon, Dec 13, 2010 at 03:52:20PM +, Catalin Marinas wrote: > On 10 December 2010 17:03, Russell King - ARM Linux > wrote: > > On Fri, Dec 10, 2010 at 12:03:07PM +0100, Janusz Krzysztofik wrote: > >>  void __init omap1_camera_init(void *info) > >>  { > >>       struct platform_device *dev = &

BUG: return from function without mutex_unlock in drivers/media/video/cx231xx/cx231xx-core.c

2010-12-13 Thread Alexander Strakh
KERNEL_VERSION: 2.6.36 SUBJECT: return from function without mutex_unlock in drivers/media/video/cx231xx/cx231xx-core.c SUBSCRIBE: 1. In line 282 in function cx231xx_read_ctrl_reg mutex was locked. 2. If usb_control_msg returns ret<0 then we exit from function cx231x

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-13 Thread Clemens Ladisch
I wrote: > I'll see if I can draw up the ALSA-specific media stuff over the weekend. Sorry, wrong weekend. Anyway, below are some remarks and a patch. * Entity types TYPE_NODE was renamed to TYPE_DEVICE because "node" sounds like a node in a graph, which does not distinguish it from other enti

BUG: double mutex_unlock in drivers/media/video/tlg2300/pd-video.c

2010-12-13 Thread Alexander Strakh
KERNEL_VERSION: 2.6.36 SUBJECT: double mutex_lock in drivers/media/video/tlg2300/pd-video.c in function vidioc_s_fmt SUBSCRIBE: First mutex_unlock in function pd_vidioc_s_fmt in line 767: 764ret |= send_set_req(pd, VIDEO_ROSOLU_SEL, 765

Re: [RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2010-12-13 Thread Catalin Marinas
On 10 December 2010 17:03, Russell King - ARM Linux wrote: > On Fri, Dec 10, 2010 at 12:03:07PM +0100, Janusz Krzysztofik wrote: >>  void __init omap1_camera_init(void *info) >>  { >>       struct platform_device *dev = &omap1_camera_device; >> +     dma_addr_t paddr = omap1_camera_phys_mempool_ba

RE: [PATCH v5 0/6] davinci vpbe: dm6446 v4l2 driver

2010-12-13 Thread Karicheri, Muralidharan
Manju, >2. Fixed Murali's comments on moving davinci_vpbe_readme.txt to different >patch different patch or path? My comment was to move the documentation to Documentation folder. But it is still in it's original path :( > >Manjunath Hadli (6): > davinci vpbe: V4L2 display driver for DM644X So

Re: [PATCH] bttv: fix mutex use before init

2010-12-13 Thread Dave Young
On Sun, Dec 12, 2010 at 05:13:47PM +0100, Torsten Kaiser wrote: > On Sun, Dec 12, 2010 at 2:15 PM, Dave Young wrote: > > oops happen in bttv_open while locking uninitialized mutex fh->cap.vb_lock > > add mutex_init before usage > > I have seen the same problem twice since I switched of the BKL in

problems with several saa7134 cards

2010-12-13 Thread Artem Bokhan
I use several (from three to five) saa7134-based cards on single PC. Currently I'm trying to migrate from 2.6.22 to 2.6.32 (ubuntu lts). I've got problems which I did not have with 2.6.22 kernel: 1. Depending on configuration load average holds 1 or 2 when saa7134 module is loaded. The reason

Re: [PATCH 0/6] gspca sonixj better handling of reg 01 and 17

2010-12-13 Thread Mauro Carvalho Chehab
Em 13-12-2010 11:02, Jean-Francois Moine escreveu: > Here is an other way to fix the inv powerdown bug. Didn't test yet, but it seems that this series will properly address the issue. > > These patches are not tested yet. > > Jean-François Moine (6): > gspca - sonixj: Move bridge init to s

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-13 Thread Andy Walls
On Mon, 2010-12-13 at 08:32 +0100, Hans Verkuil wrote: > On Sunday, December 12, 2010 19:46:33 Andy Walls wrote: Hi Hans, > > 1. Why set the vol step to 655, when the volume will actaully step at > > increments of 512? > > The goal of the exercise is to convert to the control framework. I don'

Re: [PATCH 3/6] gspca - sonixj: Add a flag in the driver_info table

2010-12-13 Thread Mauro Carvalho Chehab
Em 13-12-2010 11:03, Jean-Francois Moine escreveu: > > Signed-off-by: Jean-François Moine > > diff --git a/drivers/media/video/gspca/sonixj.c > b/drivers/media/video/gspca/sonixj.c > index 5978676..bd5858e 100644 > --- a/drivers/media/video/gspca/sonixj.c > +++ b/drivers/media/video/gspca/sonix

Re: [PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17

2010-12-13 Thread Mauro Carvalho Chehab
Em 13-12-2010 11:04, Jean-Francois Moine escreveu: > > The initial values of the registers 0x01 and 0x17 are taken from the > senso table at capture start and updated according to the flag PDN_INV. > > Their values are updated at each step of the capture initialization and > memorized for reuse i

[PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17

2010-12-13 Thread Jean-Francois Moine
The initial values of the registers 0x01 and 0x17 are taken from the senso table at capture start and updated according to the flag PDN_INV. Their values are updated at each step of the capture initialization and memorized for reuse in capture stop. This patch also fixed automatically some bad h

[PATCH 5/6] gspca - sonixj: Add the bit definitions of the bridge reg 0x01 and 0x17

2010-12-13 Thread Jean-Francois Moine
Signed-off-by: Jean-François Moine diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c index 9b7e28a..4c10324 100644 --- a/drivers/media/video/gspca/sonixj.c +++ b/drivers/media/video/gspca/sonixj.c @@ -100,6 +100,19 @@ enum sensors { /* device flags */ #defin

[PATCH 4/6] gspca - sonixj: Set the flag for some devices

2010-12-13 Thread Jean-Francois Moine
The flag PDN_INV indicates that the sensor pin S_PWR_DN has not the same value as other webcams with the same sensor. For now, only two webcams have been detected so: the Microsoft's VX1000 and VX3000. Signed-off-by: Jean-François Moine diff --git a/drivers/media/video/gspca/sonixj.c b/drivers

[PATCH 3/6] gspca - sonixj: Add a flag in the driver_info table

2010-12-13 Thread Jean-Francois Moine
Signed-off-by: Jean-François Moine diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c index 5978676..bd5858e 100644 --- a/drivers/media/video/gspca/sonixj.c +++ b/drivers/media/video/gspca/sonixj.c @@ -64,6 +64,7 @@ struct sd { u8 jpegqual;

PATCH 2/6] gspca - sonixj: Fix a bad probe exchange

2010-12-13 Thread Jean-Francois Moine
Signed-off-by: Jean-François Moine diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c index 4660cbe..5978676 100644 --- a/drivers/media/video/gspca/sonixj.c +++ b/drivers/media/video/gspca/sonixj.c @@ -1794,7 +1794,7 @@ static int sd_init(struct gspca_dev *gspc

[PATCH 1/6] gspca - sonixj: Move bridge init to sd start

2010-12-13 Thread Jean-Francois Moine
Signed-off-by: Jean-François Moine diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c index 2229847..4660cbe 100644 --- a/drivers/media/video/gspca/sonixj.c +++ b/drivers/media/video/gspca/sonixj.c @@ -1755,141 +1755,6 @@ static void po2030n_probe(struct gspca_

[PATCH 0/6] gspca sonixj better handling of reg 01 and 17

2010-12-13 Thread Jean-Francois Moine
Here is an other way to fix the inv powerdown bug. These patches are not tested yet. Jean-François Moine (6): gspca - sonixj: Move bridge init to sd start gspca - sonixj: Fix a bad probe exchange gspca - sonixj: Add a flag in the driver_info table gspca - sonixj: Set the f

Re: [PATCH] [media] s5p-fimc: fix the value of YUV422 1plane formats

2010-12-13 Thread Sylwester Nawrocki
Hi HyunWoong, Thanks for catching those YUV order errors. On 12/13/2010 02:50 AM, Hyunwoong Kim wrote: > Some color formats are mismatched in s5p-fimc driver. > CICICTRL[1:0], order422_out, should be set 2b'00 not 2b'11 to use > V4L2_PIX_FMT_YUYV. s/CICICTRL[1:0]/CIOCTRL[1:0] > Because in V4L

[PATCH] v4l: Include linux/videodev2.h in media/v4l2-ctrls.h

2010-12-13 Thread Laurent Pinchart
The later makes extensive use of structures defined in the former. Signed-off-by: Laurent Pinchart --- include/media/v4l2-ctrls.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Hans, if you're OK with this patch, can you please apply it to your tree and push it for 2.6.38 ? diff --

[PATCHv7 06/10] mm: MIGRATE_CMA migration type added

2010-12-13 Thread Michal Nazarewicz
The MIGRATE_CMA migration type has two main characteristics: (i) only movable pages can be allocated from MIGRATE_CMA pageblocks and (ii) page allocator will never change migration type of MIGRATE_CMA pageblocks. This guarantees that page in a MIGRATE_CMA page block can always be migrated somewher

[PATCHv7 05/10] mm: alloc_contig_free_pages() added

2010-12-13 Thread Michal Nazarewicz
From: KAMEZAWA Hiroyuki This commit introduces alloc_contig_free_pages() function which allocates (ie. removes from buddy system) free pages in range. Caller has to guarantee that all pages in range are in buddy system. Along with alloc_contig_free_pages(), a free_contig_pages() function is pro

[PATCHv7 04/10] mm: move some functions from memory_hotplug.c to page_isolation.c

2010-12-13 Thread Michal Nazarewicz
From: KAMEZAWA Hiroyuki Memory hotplug is a logic for making pages unused in the specified range of pfn. So, some of core logics can be used for other purpose as allocating a very large contigous memory block. This patch moves some functions from mm/memory_hotplug.c to mm/page_isolation.c. This

[PATCHv7 02/10] lib: bitmap: Added alignment offset for bitmap_find_next_zero_area()

2010-12-13 Thread Michal Nazarewicz
This commit adds a bitmap_find_next_zero_area_off() function which works like bitmap_find_next_zero_area() function expect it allows an offset to be specified when alignment is checked. This lets caller request a bit such that its number plus the offset is aligned according to the mask. Signed-of

[PATCHv7 03/10] lib: genalloc: Generic allocator improvements

2010-12-13 Thread Michal Nazarewicz
This commit adds a gen_pool_alloc_aligned() function to the generic allocator API. It allows specifying alignment for the allocated block. This feature uses the bitmap_find_next_zero_area_off() function. It also fixes possible issue with bitmap's last element being not fully allocated (ie. space

[PATCHv7 10/10] ARM: cma: Added CMA to Aquila, Goni and c210 universal boards

2010-12-13 Thread Michal Nazarewicz
This commit adds CMA memory reservation code to Aquila, Goni and c210 universal boards. Signed-off-by: Michal Nazarewicz Signed-off-by: Kyungmin Park --- arch/arm/mach-s5pv210/mach-aquila.c |2 + arch/arm/mach-s5pv210/mach-goni.c |2 + arch/arm/mach-s5pv310/mach-univer

[PATCHv7 07/10] mm: MIGRATE_CMA isolation functions added

2010-12-13 Thread Michal Nazarewicz
This commit changes various functions that change pages and pageblocks migrate type between MIGRATE_ISOLATE and MIGRATE_MOVABLE in such a way as to allow to work with MIGRATE_CMA migrate type. Signed-off-by: Michal Nazarewicz Signed-off-by: Kyungmin Park --- include/linux/page-isolation.h | 3

[PATCHv7 09/10] mm: cma: Test device and application added

2010-12-13 Thread Michal Nazarewicz
This patch adds a "cma" misc device which lets user space use the CMA API. This device is meant for testing. A testing application is also provided. Signed-off-by: Michal Nazarewicz Signed-off-by: Kyungmin Park --- drivers/misc/Kconfig | 10 + drivers/misc/Makefile |1 + drivers/misc

[PATCHv7 00/10] Contiguous Memory Allocator

2010-12-13 Thread Michal Nazarewicz
Hello everyone, This is yet another version of CMA this time stripped from a lot of code and with working migration implementation. The Contiguous Memory Allocator (CMA) makes it possible for device drivers to allocate big contiguous chunks of memory after the system has booted. For mor

[PATCHv7 08/10] mm: cma: Contiguous Memory Allocator added

2010-12-13 Thread Michal Nazarewicz
The Contiguous Memory Allocator is a set of functions that lets one initialise a region of memory which then can be used to perform allocations of contiguous memory chunks from. The implementation uses MIGRATE_CMA migration type which means that the memory is shared with standard page allocator, i

[PATCHv7 01/10] mm: migrate.c: fix compilation error

2010-12-13 Thread Michal Nazarewicz
GCC complained about update_mmu_cache() not being defined in migrate.c. Including seems to solve the problem. Signed-off-by: Michal Nazarewicz Signed-off-by: Kyungmin Park --- mm/migrate.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c in

Re: [RFC][media] s5p-fimc : Need to modify for s5pv310

2010-12-13 Thread Sylwester Nawrocki
Hi Sungchun, On 12/10/2010 03:21 AM, Sungchun Kang wrote: > > >> -Original Message- >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Sylwester Nawrocki >> Sent: Monday, December 06, 2010 6:46 PM >> To: sungchun.k...@samsung.com >> Cc

Re: [RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2

2010-12-13 Thread Dmitry Torokhov
On Thu, Dec 09, 2010 at 11:16:47AM -0800, Dmitry Torokhov wrote: > On Thu, Dec 09, 2010 at 08:04:36PM +0100, Henrik Rydberg wrote: > > On 12/09/2010 10:39 AM, Dmitry Torokhov wrote: > > > > > The desire to keep old names for the EVIOCGKEYCODE/EVIOCSKEYCODE while > > > extending them to support lar