[PATCH 1/1] Media: radio: si470x: remove double mutex lock

2011-01-23 Thread Alexander Strakh
From: Alexander Strakh croml...@gmail.com 1. First mutex_lock on radio-lock in line 441 2. Second in line 462 I think that mutex in line 462 is not needed. In kernel v2.6.36.3 function si470 x_rds_on contains mutex_lock/mutex_unlock. Have no mutex_lock in line 441. In kernel v2.6.37

Re: [RFC PATCH 3/3] v4l2-ctrls: update control framework documentation

2011-01-23 Thread Sylwester Nawrocki
Hi Hans, On 01/22/2011 08:06 PM, Hans Verkuil wrote: Document how to enable/disable controls. Document the new v4l2_ctrl_auto_cluster function. Document the practical method of using anonymous structs to 'cluster' controls instead of using cumbersome control pointer arrays. Signed-off-by:

Re: [PATCH 2/3] sr030pc30: Use the control framework

2011-01-23 Thread Sylwester Nawrocki
On 01/21/2011 04:09 AM, Hans Verkuil wrote: Hi Sylwester! I have some review comments below... On Thursday, January 20, 2011 02:44:01 Sylwester Nawrocki wrote: Implement controls using the control framework. Add horizontal/vertical flip controls, minor cleanup. Signed-off-by: Sylwester

Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Alex Butcher
Hi - I've recently built an upgraded MythTV system. My old system was running Fedora 8 (with kernel 2.6.26.6-49), MythTV 0.21-fixes, and used a single-tuner PCI Nova-T and a dual tuner PCI Nova-T-500 for a total of three physical tuners. I've re-used the tuner cards in my upgraded system, which

Re: Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Devin Heitmueller
Hi Alex, As a refresher, the drivers in the 2.6.26.6-49 kernel didn't yet include support for the new I2C functions only supported by dib0700 firmware revisions = 1.20.  I don't think this is relevant to the Nova-T-500, though, as only s5h1411_frontend_attach() and lgdt3305_frontend_attach()

Re: [RFC PATCH] Getting Hauppauge WinTV HVR-1400 (XC3028L) to work

2011-01-23 Thread Mauro Carvalho Chehab
Hi Alina, Em 22-01-2011 22:16, Alina Friedrichsen escreveu: With this patch my DVB-T receiver works now like before 2.6.34, only the first four tunings fails, after that all works fine. The code was still in there, only commented out. As the original author says, please test it with different

Re: [RFC PATCH 3/3] v4l2-ctrls: update control framework documentation

2011-01-23 Thread Kim HeungJun
Hi Sylwester, It's my humble opinions. Just read plz :) 2011. 1. 23., 오후 8:08, Sylwester Nawrocki 작성: [snip] +Handling autogain/gain-type Controls with Auto Clusters +=== + +A common type of control cluster is one that handles

Re: [RFC PATCH 2/3] v4l2-ctrls: add v4l2_ctrl_auto_cluster to simplify autogain/gain scenarios

2011-01-23 Thread Hans de Goede
Hi, On 01/22/2011 12:06 PM, Hans Verkuil wrote: It is a bit tricky to handle autogain/gain type scenerios correctly. Such controls need to be clustered and the V4L2_CTRL_FLAG_UPDATE should be set on the non-auto controls. If you set a non-auto control without setting the auto control at the

Re: [PATCH v2] Add support for M5MO-LS 8 Mega Pixel camera

2011-01-23 Thread Kim HeungJun
Hi Sylwester, Oh. Very thanks to reviewing. It's almost not a big deal to change and I'll fix this and resend. 2011. 1. 23., 오후 1:16, Sylwester Nawrocki 작성: HeungJun, as I didn't really get a chance to review this patch in its current form before, please let me now add some further

tuner-xc2028: More firmware loading retries

2011-01-23 Thread Alina Friedrichsen
My Hauppauge WinTV HVR-1400 needs sometimes more then only one retry to load the firmware successfully. Signed-off-by: Alina Friedrichsen x-al...@gmx.net --- diff -urNp linux-2.6.37.orig/drivers/media/common/tuners/tuner-xc2028.c linux-2.6.37/drivers/media/common/tuners/tuner-xc2028.c ---

Re: Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Malcolm Priestley
On Sun, 2011-01-23 at 11:58 +, Alex Butcher wrote: 11) I briefly experimented with setting buggy_sfn_workaround=1 when loading the dib3000mc and dib7000p modules with no apparent improvement. As far as I can see, though, UK DVB-T broadcasting isn't a single frequency network, so a)

Re: [RFC PATCH 2/3] v4l2-ctrls: add v4l2_ctrl_auto_cluster to simplify autogain/gain scenarios

2011-01-23 Thread Hans Verkuil
On Sunday, January 23, 2011 16:15:03 Hans de Goede wrote: Hi, On 01/22/2011 12:06 PM, Hans Verkuil wrote: It is a bit tricky to handle autogain/gain type scenerios correctly. Such controls need to be clustered and the V4L2_CTRL_FLAG_UPDATE should be set on the non-auto controls. If you

[PATCH] tuner-xc2028: More firmware loading retries

2011-01-23 Thread Alina Friedrichsen
My Hauppauge WinTV HVR-1400 needs sometimes more then only one retry to load the firmware successfully. Signed-off-by: Alina Friedrichsen x-al...@gmx.net --- diff -urNp linux-2.6.37.orig/drivers/media/common/tuners/tuner-xc2028.c linux-2.6.37/drivers/media/common/tuners/tuner-xc2028.c ---

Re: [RFC PATCH] Getting Hauppauge WinTV HVR-1400 (XC3028L) to work

2011-01-23 Thread Alina Friedrichsen
Hi Mauro! This is problematic, as it seems to be country-specific and/or demod-specific. We'll need to work on a different solution for it. On what Country do you live? By looking at HVR1400 entry, it uses a dibcom 7000p demod. We need to know what are country/demod for the users for whose

Re: [RFC/PATCH v6 1/4] Changes in include/linux/videodev2.h for MFC 5.1

2011-01-23 Thread Hans Verkuil
Hi Kamil, Here is a review of this patch. I didn't really look that closely at the others, other than noticing that they didn't use the control framework yet. The main issue really is lack of documentation. It's hard to review something if you don't know what a new define stands for. On Friday,

[cron job] v4l-dvb daily build: OK

2011-01-23 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Sun Jan 23 19:00:26 CET 2011 git master: 1b59be2a6cdcb5a12e18d8315c07c94a624de48f git media-master: gcc version:

Re: [RFC PATCH 01/12] soc_camera: add control handler support

2011-01-23 Thread Guennadi Liakhovetski
On Wed, 19 Jan 2011, Guennadi Liakhovetski wrote: @@ -963,15 +897,15 @@ static int soc_camera_probe(struct device *dev) if (icl-reset) icl-reset(icd-pdev); - ret = ici-ops-add(icd); - if (ret 0) - goto eadd; - /* Must have icd-vdev before

Re: Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Alex Butcher
Hi Devin - [A confession; after my last post, I double-checked my MythTV config, and I found that I had EIT scanning enabled on one of the tuners on the Nova-T-500. This was the same configuration that used to work, so it shouldn't have made any difference, but I've disabled EIT on both of the

Re: Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Alex Butcher
On Sun, 23 Jan 2011, Malcolm Priestley wrote: On Sun, 2011-01-23 at 11:58 +, Alex Butcher wrote: 11) I briefly experimented with setting buggy_sfn_workaround=1 when loading the dib3000mc and dib7000p modules with no apparent improvement. As far as I can see, though, UK DVB-T broadcasting

[PATCH 1/2] DM04/QQBOX Update V1.76 - use 32 bit remote decoding

2011-01-23 Thread Malcolm Priestley
Use 32 bit decoding to add support for more than one variant of remote control. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/media/dvb/dvb-usb/lmedm04.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c

[PATCH 2/2] Change to 32 bit and add other remote controls for lme2510

2011-01-23 Thread Malcolm Priestley
These bubble button remote controls appear to be generic from China. These are the three variants known to be supplied with DM04/QQBOX DVB-S They could well be supplied with other devices from the region. Signed-off-by: Malcolm Priestley tvbox...@gmail.com ---

Re: Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Alex Butcher
On Sun, 23 Jan 2011, Alex Butcher wrote: Can anyone offer any tips for regaining reliability? Failing that, is there any further logging I can enable, and entries to look out for? Exactly what errors are you seeing? I2c write errors in dmesg? No, nothing in the kernel logs, which is what I

Re: Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Malcolm Priestley
On Sun, 2011-01-23 at 21:01 +, Alex Butcher wrote: On Sun, 23 Jan 2011, Malcolm Priestley wrote: On Sun, 2011-01-23 at 11:58 +, Alex Butcher wrote: 11) I briefly experimented with setting buggy_sfn_workaround=1 when loading the dib3000mc and dib7000p modules with no apparent

[PATCH] Fix bug in au0828 VBI streaming

2011-01-23 Thread Devin Heitmueller
Attached is a patch for a V4L2 spec violation with regards to the au0828 not working in streaming mode. This was just an oversight on my part when I did the original VBI support for this bridge, as libzvbi was silently falling back to using the read() interface. Devin -- Devin J. Heitmueller -

[RFC PATCH] tuner-core: fix broken G_TUNER call when tuner is in standby

2011-01-23 Thread Devin Heitmueller
Hello all, The following patch addresses a V4L2 specification violation where the G_TUNER call would return complete garbage in the event that the tuner is asleep. Per Hans' suggestion, I have split out the tuner operational mode from whether it is in standby, and fixed the G_TUNER call to

Re: [RFC] ISP lane shifter support

2011-01-23 Thread Laurent Pinchart
Hi Michael, On Friday 21 January 2011 09:40:21 Michael Jones wrote: Hi all, In the OMAP ISP driver, I'm interested in being able to choose between 8-bit and 12-bit formats when I have a 12-bit sensor attached. At the moment it looks like it's only possible to define this statically with

Re: [PATCH 1/1] Media: radio: si470x: remove double mutex lock

2011-01-23 Thread Tobias Lorenz
Hi, good catch! Thanks. Acked-by: Tobias Lorenz tobias.lor...@gmx.net Bye, Toby On Sun, 23 Jan 2011 12:16:54 +0300, Alexander Strakh croml...@gmail.com wrote: From: Alexander Strakh croml...@gmail.com 1. First mutex_lock on radio-lock in line 441 2. Second in line 462 I think that