Re: [beagleboard] [PATCH v6 2/2] Add support for mt9p031 sensor in Beagleboard XM.

2011-06-02 Thread javier Martin
Hi Koen, On 1 June 2011 20:08, Koen Kooi k...@beagleboard.org wrote: Op 1 jun 2011, om 17:36 heeft Javier Martin het volgende geschreven: New version and vdd_io flags have been added. A subtle change now prevents camera from being registered in the wrong platform. I get a decent picture

RE: [RFC/PATCH v2] v4l: add control definitions for codec devices.

2011-06-02 Thread Jeongtae Park
Hi, Thank you for your nice work. Here are my some comments. -Original Message- From: Kamil Debski [mailto:k.deb...@samsung.com] Sent: Tuesday, May 31, 2011 6:08 PM Cc: m.szyprow...@samsung.com; kyungmin.p...@samsung.com; k.deb...@samsung.com; jaeryul...@samsung.com;

[PATCH] MAINTAINERS: Add videobuf2 maintainers

2011-06-02 Thread Marek Szyprowski
Add maintainers for the videobuf2 V4L2 driver framework. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCH v6 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-02 Thread Guennadi Liakhovetski
No technical review this time. Relying fully on Laurent and others to take care of that, just a couple of cosmetic points, which even checkpatch.pl failed to warn about:( On Wed, 1 Jun 2011, Javier Martin wrote: Clock frequency of 57MHz used in previous version was wrong since when VDD_IO is

Re: [PATCH V2] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-02 Thread Jonathan Corbet
On Wed, 1 Jun 2011 21:16:45 +0800 Kassey Lee y...@marvell.com wrote: This driver exports a video device node per each CCIC (CMOS Camera Interface Controller) device contained in Marvell Mobile PXA910 SoC The driver is based on soc-camera + videobuf2 frame work, and only USERPTR is

RE: [PATCH v3 - resend] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend.

2011-06-02 Thread Lutz Sammer
Hello Hans Petter, I haven't tested your patch yet, but looking at the source I see some problems. What does your patch fix and how? If you have problem locking channels, try my locking patch: https://patchwork.kernel.org/patch/753382/ On each step (timing, carrier, data) you reset the derot:

Re: [PATCH V2] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-02 Thread Kassey Lee
hi, Jonathan: yes, you are right, this driver uses most of the low level code from cafe-ccic.c. I am so sorry to miss the your email and refer info from cafe-ccic.c in my driver, really appreciate your work. the point that I write mv_camera.c is to base the

Re: [PATCH V2] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-02 Thread Guennadi Liakhovetski
On Thu, 2 Jun 2011, Jonathan Corbet wrote: On Wed, 1 Jun 2011 21:16:45 +0800 Kassey Lee y...@marvell.com wrote: This driver exports a video device node per each CCIC (CMOS Camera Interface Controller) device contained in Marvell Mobile PXA910 SoC The driver is based on soc-camera +

Re: [PATCH v3 - resend] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend.

2011-06-02 Thread Hans Petter Selasky
On Thursday 02 June 2011 11:46:15 Lutz Sammer wrote: Hello Hans Petter, Hi, I haven't tested your patch yet, but looking at the source I see some problems. What does your patch fix and how? It switches from software derot to hardware derot, by writing zero to the derot register. If

Re: [PATCH v6 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-02 Thread javier Martin
OK Guennadi, I'll fix those cosmetics issues in my next version where I will add VFLIP and HFLIP control support (which I removed previously to make the code less complex). Now we talk about controls I have a question regarding controls defined in video subdevices like mt9p031 or mt9v032: What

[PATCH 0/7] s5p-fimc driver fixes for 3.0

2011-06-02 Thread Sylwester Nawrocki
Hello, the following are a few bugfix patches for s5p-fimc driver. Except the kernel-doc comments corrections, debug trace cleanup and the copyright update they fix the buffer allocation issue and possible memory leak on error path. drivers/media/video/s5p-fimc/fimc-capture.c | 21

[PATCH 3/7] s5p-fimc: Fix data structures documentation and cleanup debug trace

2011-06-02 Thread Sylwester Nawrocki
Correct inconsistencies in data structures' documentation. Remove meaningless debug traces. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-capture.c |9 -

[PATCH 2/7] s5p-fimc: Fix V4L2_PIX_FMT_RGB565X description

2011-06-02 Thread Sylwester Nawrocki
Remove V4L2_MBUS_FMT_RGB565_2X8_BE media code entry as camera interface supports only packed YUYV formats. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-core.c |1 - 1 files changed, 0

[PATCH 5/7] s5p-fimc: Remove empty buf_init operation

2011-06-02 Thread Sylwester Nawrocki
The buf_init buffer queue operation is optional and buffer_init() does nothing, remove it. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-capture.c |7 --- 1 files changed, 0

Re: [PATCH v6 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-02 Thread Guennadi Liakhovetski
On Thu, 2 Jun 2011, javier Martin wrote: OK Guennadi, I'll fix those cosmetics issues in my next version where I will add VFLIP and HFLIP control support (which I removed previously to make the code less complex). Please, don't. Let's first get the simple version of your driver in the

Re: [PATCH v6 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-02 Thread javier Martin
On 2 June 2011 12:36, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 2 Jun 2011, javier Martin wrote: OK Guennadi, I'll fix those cosmetics issues in my next version where I will add VFLIP and HFLIP control support (which I removed previously to make the code less complex).

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-02 Thread Devin Heitmueller
2011/5/31 Dmitri Belimov d.beli...@gmail.com: Is it possible make some patches and add support xc4000 into kernel? With my best regards, Dmitry. What needs to happen here is somebody needs to prepare a patch series which contains all the relevant patches, including the SOBs. This is entirely

SOB for original xc4000 patch

2011-06-02 Thread Devin Heitmueller
Here is the email thread where Davide Ferri consented to having the SOB added to his original patch. Whoever prepares the patch series should ensure that it has the following chain of SOBs: Signed-off-by: Davide Ferri davidef1...@gmail.com Signed-off-by: Devin Heitmueller

Re: [PATCH] [media] V4L/videobuf2-memops: use pr_debug for debug messages

2011-06-02 Thread Mauro Carvalho Chehab
Em 02-06-2011 02:56, Marek Szyprowski escreveu: Hello, On Thursday, June 02, 2011 3:35 AM Mauro Carvalho Chehab wrote: Hi Kyungmin, Em 01-06-2011 21:50, Kyungmin Park escreveu: Acked-by: Kyungmin Park kyunginn.,p...@samsung.com As this patch is really trivial and makes sense, I've just

[PATCH v7 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-02 Thread Javier Martin
This version fixes some cosmetic issues pointed out by Guennadi. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 763 +

[PATCH 1/7] s5p-fimc: Fix possible memory leak during capture devnode registration

2011-06-02 Thread Sylwester Nawrocki
Add missing kfree on the error path. Reported-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-capture.c |1 + 1 files changed, 1

Does omap3isp driver inherit controls of attached sensors?

2011-06-02 Thread javier Martin
Hi, I'm trying to add VFLIP control to the mt9p031 driver (don't worry Guennadi, I won't send the patch yet). For that purpose I've followed the code in mt9v032 sensor. When I try to query available controls using yavta I get the following: root@beagleboard:~# ./media-ctl -e OMAP3 ISP CCDC output

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-02 Thread Mauro Carvalho Chehab
Em 02-06-2011 07:52, Devin Heitmueller escreveu: 2011/5/31 Dmitri Belimov d.beli...@gmail.com: Is it possible make some patches and add support xc4000 into kernel? With my best regards, Dmitry. What needs to happen here is somebody needs to prepare a patch series which contains all the

RE: [RFC/PATCH v2] v4l: add control definitions for codec devices.

2011-06-02 Thread Kamil Debski
From: Jeongtae Park [mailto:jtp.p...@samsung.com] Sent: 02 June 2011 09:44 To: 'Kamil Debski'; linux-media@vger.kernel.org Cc: jaeryul...@samsung.com; june@samsung.com; janghyuck@samsung.com; kyungmin.p...@samsung.com; younglak1004@samsung.com; 'Marek Szyprowski' Subject: RE:

[RFC/PATCH v3] v4l: add control definitions for codec devices.

2011-06-02 Thread Kamil Debski
Hi, This is a third version of the patch that adds controls for the codec family of devices. I have implemented the suggestions to v1 I got from Hans Verkuil on the #v4l channel. Also I have addressed comments to v2 by Jeongtae Park. Changes from v2 to v3: - added MVC anc SVC profiles to H264 -

[PATCH 1/1] V4L/DVB: mt9v011: Fixed incorrect value for the first valid column

2011-06-02 Thread Johannes Obermaier
According to the datasheet (page 8), the first optical clear pixel-column is not at position 14. The correct/recommended value is 20. Without this patch there is a dark line on the left side of the image. Signed-off-by: Johannes Obermaier johannes.oberma...@gmail.com ---

[PATCH 1/1] V4L/DVB: mt9v011: Fixed incorrect value for the first valid column

2011-06-02 Thread Johannes Obermaier
According to the datasheet (page 8), the first optical clear pixel-column is not at position 14. The correct/recommended value is 20. Without this patch there is a dark line on the left side of the image. Signed-off-by: Johannes Obermaier johannes.oberma...@gmail.com ---

[PATCH 2/2] V4L/DVB: mt9v011: Added exposure for mt9v011

2011-06-02 Thread Johannes Obermaier
There are problems when you use this camera/sensor in a very bright room or outside. The image is completely white, because it is overexposed. The driver uses a default value which is not suitable for all environments. This patch makes it possible to adjust the exposure time by youself. I found

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-02 Thread Mohammad Bahathir Hashim
Now I understood how thing works here, and it clear to me, why the xc4000 driver is not being included in mainline V4L2. It will be lots of commitments and hard work to be the maintainer, and I respect Mr. Devin's choice and decisions. There are several peoples that are interested in this

[PATCH 3/3] V4L/DVB: mt9v011: Fixed gain calculation

2011-06-02 Thread Johannes Obermaier
(This patch must be used AFTER the patch V4L/DVB: mt9v011: Added exposure for mt9v011) The implementation of the gain calculation for this sensor is incorrect. It is only working for the first 127 values. The reason is, that the gain cannot be set directly by writing a value into the gain

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-02 Thread Mauro Carvalho Chehab
Em 02-06-2011 12:17, Devin Heitmueller escreveu: On Thu, Jun 2, 2011 at 10:41 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: 1. Assemble tree with current patches It is probably easier for me to do this step, as I have my hg import scripts. However, as I don't have the PCTV devices

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-02 Thread Mauro Carvalho Chehab
Em 02-06-2011 12:53, Mohammad Bahathir Hashim escreveu: Now I understood how thing works here, and it clear to me, why the xc4000 driver is not being included in mainline V4L2. It will be lots of commitments and hard work to be the maintainer, and I respect Mr. Devin's choice and decisions.

RE: [PATCH 1/1] davinci: dm646x: move vpif related code to driver core header from platform

2011-06-02 Thread Nori, Sekhar
Hi Mauro, On Fri, May 20, 2011 at 19:28:49, Hadli, Manjunath wrote: move vpif related code for capture and display drivers from dm646x platform header file to vpif.h as these definitions are related to driver code more than the platform or board. Signed-off-by: Manjunath Hadli

[cron job] v4l-dvb daily build: ERRORS

2011-06-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Jun 2 19:00:42 CEST 2011 git hash:f9b51477fe540fb4c65a05027fdd6f2ecce4db3b gcc version: i686-linux-gcc (GCC)

Re: Media patches with review pending (14 patches)

2011-06-02 Thread Andy Walls
Mauro Carvalho Chehab mche...@redhat.com wrote: This is the list of the patches currently on my queue (13 patches from patchwork and one patch that patchwork lost due to a database corruption). There's not much patches there, as I've applied most of the pending stuff. Unfortunately, however,

[RFC 0/6] iommu: generic api migration and grouping

2011-06-02 Thread Ohad Ben-Cohen
First stab at iommu consolidation: - Migrate OMAP's iommu driver to the generic iommu API. With this in hand, users can now start using the generic iommu layer instead of calling omap-specific iommu API. New code that requires functionality missing from the generic iommu api, will add

[RFC 1/6] omap: iommu: generic iommu api migration

2011-06-02 Thread Ohad Ben-Cohen
Migrate OMAP's iommu to the generic iommu api, so users can stay generic, and non-omap-specific code can be removed and eventually consolidated into a generic framework. Tested on both OMAP3 and OMAP4. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- arch/arm/plat-omap/Kconfig |

[RFC 4/6] drivers: iommu: move to a dedicated folder

2011-06-02 Thread Ohad Ben-Cohen
Create a dedicated folder for iommu drivers, and move the base iommu implementation over there. Grouping the varius iommu drivers in a single location will help finding similar problems shared by different platforms, so they could be solved once, in the iommu framework, instead of solved

[RFC 6/6] msm: iommu: move to dedicated iommu drivers folder

2011-06-02 Thread Ohad Ben-Cohen
This should ease finding similarities with other platforms, with the intention of solving problems once in a generic framework which everyone can use. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- arch/arm/mach-msm/Kconfig | 12

[RFC 5/6] omap: iommu/iovmm: move to dedicated iommu folder

2011-06-02 Thread Ohad Ben-Cohen
Move OMAP's iommu drivers to the dedicated iommu drivers folder. While OMAP's iovmm (virtual memory manager) driver does not strictly belong to the iommu drivers folder, move it there as well, because it's by no means OMAP-specific (in concept. technically it is still coupled with the omap

[RFC 3/6] media: omap3isp: generic iommu api migration

2011-06-02 Thread Ohad Ben-Cohen
First step towards migrating omap3isp to the generic iommu api. At this point we still need a handle of the omap-specific iommu, mainly because we highly depend on omap's iovmm. Migration will be fully completed only once omap's iovmm will be generalized (or replaced by a generic virtual memory

[RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-02 Thread Ohad Ben-Cohen
Migrate omap's iovmm (virtual memory manager) to the generic iommu api. This brings iovmm a step forward towards being completely non omap-specific (it's still assuming omap's iommu page sizes, and also maintaining state inside omap's internal iommu structure, but it no longer calls omap-specific

Re: [PATCH] media: omap3isp: fix a pontential NULL deref

2011-06-02 Thread Laurent Pinchart
Hi Ohad, On Wednesday 01 June 2011 18:39:46 Ohad Ben-Cohen wrote: Fix a potential NULL pointer dereference by skipping registration of external entities in case none are provided. This is useful at least when testing mere memory-to-memory scenarios. Signed-off-by: Ohad Ben-Cohen

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-02 Thread Kyungmin Park
Hi, Good approach. CC'ed the Samsung IOMMU developer. Marek. BTW, Russell wants to use the DMA based IOMMU? Please see the RFC patch, ARM: DMA-mapping IOMMU integration http://www.spinics.net/lists/linux-mm/msg19856.html Thank you, Kyungmin Park On Fri, Jun 3, 2011 at 7:27 AM, Ohad Ben-Cohen

Re: Does omap3isp driver inherit controls of attached sensors?

2011-06-02 Thread Laurent Pinchart
Hi Javier, On Thursday 02 June 2011 15:52:57 javier Martin wrote: Hi, I'm trying to add VFLIP control to the mt9p031 driver (don't worry Guennadi, I won't send the patch yet). For that purpose I've followed the code in mt9v032 sensor. When I try to query available controls using yavta I get

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-02 Thread Dmitri Belimov
On Thu, 02 Jun 2011 11:41:53 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: Em 02-06-2011 07:52, Devin Heitmueller escreveu: 2011/5/31 Dmitri Belimov d.beli...@gmail.com: Is it possible make some patches and add support xc4000 into kernel? With my best regards, Dmitry. What

Re: [PATCH] MAINTAINERS: Add videobuf2 maintainers

2011-06-02 Thread Pawel Osciak
On Thu, Jun 2, 2011 at 00:52, Marek Szyprowski m.szyprow...@samsung.com wrote: Add maintainers for the videobuf2 V4L2 driver framework. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---  MAINTAINERS |    9 +  1 files

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-02 Thread Mohammad Bahathir Hashim
Thank you for the comments and pointers. I am happy, at least there are peoples who want to see the xc4000 driver alive. On 2011-06-02, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 02-06-2011 12:53, Mohammad Bahathir Hashim escreveu: Now I understood how thing works here, and it clear to

Anchor Chips V4L2 driver

2011-06-02 Thread John McMaster
I'd like to write a driver for an Anchor Chips (seems to be bought by Cypress) USB camera Linux driver sold as an AmScope MD1800. It seems like this implies I need to write a V4L2 driver. The camera does not seem its currently supported (checked on Fedora 13 / 2.6.34.8) and I did not find any