[PATCH v2] [media] omap3isp: queue: fail QBUF if user buffer is too small

2011-08-08 Thread Michael Jones
Add buffer length check to sanity checks for USERPTR QBUF Signed-off-by: Michael Jones --- Changes for v2: - only check when V4L2_MEMORY_USERPTR drivers/media/video/omap3isp/ispqueue.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3isp/ispq

Re: [PATCH] CXD2820R: Replace i2c message translation with repeater gate control

2011-08-08 Thread Antti Palosaari
Hello That patch is technically fine and I liked it much since get rid of complex repeater logic and going for normal I2C-gate. But fix these and send new patch: 1) there is a lot of style errors. you should use always checkpatch.pl before send patches. ./scripts/checkpatch.pl --file drivers/medi

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Sakari Ailus
Laurent Pinchart wrote: Hi Hans, On Monday 08 August 2011 14:40:27 Hans Verkuil wrote: On Monday, August 08, 2011 13:40:23 Laurent Pinchart wrote: On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: A possibility to prealloca

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Laurent Pinchart
Hi Hans, On Monday 08 August 2011 14:40:27 Hans Verkuil wrote: > On Monday, August 08, 2011 13:40:23 Laurent Pinchart wrote: > > On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: > > > On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: > > > > A possibility to preallocate and ini

Re: [RFC] The clock dependencies between sensor subdevs and the host interface drivers

2011-08-08 Thread Laurent Pinchart
Hi Guennadi, On Monday 08 August 2011 19:29:13 Guennadi Liakhovetski wrote: > On Mon, 8 Aug 2011, Laurent Pinchart wrote: > > On Monday 08 August 2011 17:36:32 Sylwester Nawrocki wrote: > > > Hi everyone, > > > > > > Nowadays many of the V4L2 camera device drivers heavily depend on the > > > boar

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-08-08 Thread Antti Palosaari
Reviewed-by: Antti Palosaari It looks just fine. regards Antti On 08/08/2011 01:35 PM, Jose Alberto Reguero wrote: > On Martes, 2 de Agosto de 2011 21:21:13 Jose Alberto Reguero escribió: >> On Jueves, 28 de Julio de 2011 21:25:01 Jose Alberto Reguero escribió: >>> On Miércoles, 27 de Julio de

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Theodore Kilgore
On Mon, 8 Aug 2011, Adam Baker wrote: > On Monday 08 August 2011, Mauro Carvalho Chehab wrote: > > > I will send a second reply to this message, which deals in particular > > > with the list of abilities you outlined above. The point is, the > > > situation as to that list of abilities is more

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Theodore Kilgore
On Mon, 8 Aug 2011, Adam Baker wrote: > On Monday 08 August 2011, Mauro Carvalho Chehab wrote: > > > > > > > > > Well, in practice the "fork" would presumably be carried out by yours > > > truly. Presumably with the advice and help of concerned parties. too. > > > Since I am involved on both

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Alan Stern
On Mon, 8 Aug 2011, Theodore Kilgore wrote: > > > > Maybe a good compromise would be to create a kind of stub driver that > > > > could negotiate the device access while still delegating most of the > > > > real work to userspace. > > > > > > Hooray. This appears to me to be a very good solution.

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Adam Baker
On Monday 08 August 2011, Mauro Carvalho Chehab wrote: > > I will send a second reply to this message, which deals in particular > > with the list of abilities you outlined above. The point is, the > > situation as to that list of abilities is more chaotic than is generally > > realized. And when

Re: [PATCH] [media] nuvoton-cir: simplify raw IR sample handling

2011-08-08 Thread Jarod Wilson
Jarod Wilson wrote: The nuvoton-cir driver was storing up consecutive pulse-pulse and space-space samples internally, for no good reason, since ir_raw_event_store_with_filter() already merges back to back like samples types for us. This should also fix a regression introduced late in 3.0 that rel

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Adam Baker
On Monday 08 August 2011, Mauro Carvalho Chehab wrote: > > > > > > Well, in practice the "fork" would presumably be carried out by yours > > truly. Presumably with the advice and help of concerned parties. too. > > Since I am involved on both the kernel side and the libgphoto2 side of > > the s

[PATCH] [media] nuvoton-cir: simplify raw IR sample handling

2011-08-08 Thread Jarod Wilson
The nuvoton-cir driver was storing up consecutive pulse-pulse and space-space samples internally, for no good reason, since ir_raw_event_store_with_filter() already merges back to back like samples types for us. This should also fix a regression introduced late in 3.0 that related to a timeout chan

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Mauro Carvalho Chehab
Em 08-08-2011 16:32, Theodore Kilgore escreveu: >> Doing an specific libusb-like approach just for those cams seems to be the >> wrong direction, as such driver would be just a fork of an already existing >> code. I'm all against duplicating it. > > Well, in practice the "fork" would presumably b

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Theodore Kilgore
On Mon, 8 Aug 2011, Alan Stern wrote: > On Mon, 8 Aug 2011, Theodore Kilgore wrote: > > > On Mon, 8 Aug 2011, Alan Stern wrote: > > > > > On Sun, 7 Aug 2011, Theodore Kilgore wrote: > > > > > > > This indirectly answers my question, above, about whatever device there > > > > may or may not b

Re: RTL2831U driver updates

2011-08-08 Thread Antti Palosaari
On 08/06/2011 08:13 AM, Alistair Buxton wrote: > On 6 August 2011 04:56, Alistair Buxton wrote: >> With the latest driver my card never gets a signal lock, not even >> once. As before there are no error messages. It does always probe >> correctly now though. > > I tracked this down to: > > http:

Re: USB mini-summit at LinuxCon Vancouver

2011-08-08 Thread Mauro Carvalho Chehab
Hi Sarah, Em 08-08-2011 14:58, Sarah Sharp escreveu: > On Fri, Aug 05, 2011 at 09:45:56AM +0200, Hans de Goede wrote: >> Hi, >> >> On 08/05/2011 12:56 AM, Greg KH wrote: >>> On Thu, Aug 04, 2011 at 07:21:47PM -0300, Mauro Carvalho Chehab wrote: >> I think it is important to separate oranges from a

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Theodore Kilgore
On Mon, 8 Aug 2011, Mauro Carvalho Chehab wrote: > Em 08-08-2011 14:39, Theodore Kilgore escreveu: > > > > > > On Mon, 8 Aug 2011, Mauro Carvalho Chehab wrote: > > > >> Em 07-08-2011 23:26, Theodore Kilgore escreveu: > >>> > >>> (first of two replies to Adam's message; second reply deals with

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Alan Stern
On Mon, 8 Aug 2011, Theodore Kilgore wrote: > On Mon, 8 Aug 2011, Alan Stern wrote: > > > On Sun, 7 Aug 2011, Theodore Kilgore wrote: > > > > > This indirectly answers my question, above, about whatever device there > > > may or may not be. What I get from this, and also from a bit of snooping

[cron job] v4l-dvb daily build: ERRORS

2011-08-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Mon Aug 8 19:00:18 CEST 2011 git hash:9bed77ee2fb46b74782d0d9d14b92e9d07f3df6e gcc version: i686-linux-gcc (GCC) 4.5

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Mauro Carvalho Chehab
Em 08-08-2011 14:39, Theodore Kilgore escreveu: > > > On Mon, 8 Aug 2011, Mauro Carvalho Chehab wrote: > >> Em 07-08-2011 23:26, Theodore Kilgore escreveu: >>> >>> (first of two replies to Adam's message; second reply deals with other >>> topics) >>> >>> On Sun, 7 Aug 2011, Adam Baker wrote: >>

Re: USB mini-summit at LinuxCon Vancouver

2011-08-08 Thread Sarah Sharp
On Mon, Aug 08, 2011 at 01:23:56PM -0500, Theodore Kilgore wrote: > > > On Mon, 8 Aug 2011, Sarah Sharp wrote: > > > On Fri, Aug 05, 2011 at 09:45:56AM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 08/05/2011 12:56 AM, Greg KH wrote: > > > >On Thu, Aug 04, 2011 at 07:21:47PM -0300, Mauro

Re: USB mini-summit at LinuxCon Vancouver

2011-08-08 Thread Theodore Kilgore
On Mon, 8 Aug 2011, Sarah Sharp wrote: > On Fri, Aug 05, 2011 at 09:45:56AM +0200, Hans de Goede wrote: > > Hi, > > > > On 08/05/2011 12:56 AM, Greg KH wrote: > > >On Thu, Aug 04, 2011 at 07:21:47PM -0300, Mauro Carvalho Chehab wrote: > > I think it is important to separate oranges from apples

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Theodore Kilgore
On Mon, 8 Aug 2011, Alan Stern wrote: > On Sun, 7 Aug 2011, Theodore Kilgore wrote: > > > This indirectly answers my question, above, about whatever device there > > may or may not be. What I get from this, and also from a bit of snooping > > around, is that there is not any dev that gets cre

Re: USB mini-summit at LinuxCon Vancouver

2011-08-08 Thread Sarah Sharp
On Fri, Aug 05, 2011 at 09:45:56AM +0200, Hans de Goede wrote: > Hi, > > On 08/05/2011 12:56 AM, Greg KH wrote: > >On Thu, Aug 04, 2011 at 07:21:47PM -0300, Mauro Carvalho Chehab wrote: > I think it is important to separate oranges from apples here, there are > at least 3 different problem classes

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Theodore Kilgore
On Mon, 8 Aug 2011, Mauro Carvalho Chehab wrote: > Em 07-08-2011 23:26, Theodore Kilgore escreveu: > > > > (first of two replies to Adam's message; second reply deals with other > > topics) > > > > On Sun, 7 Aug 2011, Adam Baker wrote: > > > >> On Friday 05 August 2011, Hans de Goede wrote:

Re: [RFC] The clock dependencies between sensor subdevs and the host interface drivers

2011-08-08 Thread Guennadi Liakhovetski
Hi Laurent On Mon, 8 Aug 2011, Laurent Pinchart wrote: > Hi Sylwester, > > On Monday 08 August 2011 17:36:32 Sylwester Nawrocki wrote: > > Hi everyone, > > > > Nowadays many of the V4L2 camera device drivers heavily depend on the board > > code to set up voltage supplies, clocks, and some contr

[PATCH] s5p-g2d: add G2D driver for the s5p device family

2011-08-08 Thread Kamil Debski
G2D is a 2D graphics accelerator engine present in the s5p family of Samsung SoCs. It is capable of bitblt and raster operations on images having dimensions of up to 8000x8000. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- Hi, This patch adds the G2D 2D graphics accelerator driv

[PATCH] media: s5p-mfc: fix section mismatch

2011-08-08 Thread Kamil Debski
Fix section mismatch in the MFC driver. Reported-by: Marek Szyprowski Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-mfc/s5p_mfc.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/d

Structure of DiSEqC Command

2011-08-08 Thread Nima Mohammadi
Hi folks, I was reading the source code of various dvb related utilities and I was wondering about forming up the message which instructs the DiSEqC switch. But I found out that different programs produce the command differently. The confusing thing is that according to the DiSEqC specification doc

Re: [PATCH 5/7] [media] ati_remote: add keymap for Medion X10 RF remote

2011-08-08 Thread Jarod Wilson
Anssi Hannula wrote: On 08.08.2011 08:57, Dmitry Torokhov wrote: On Sun, Aug 07, 2011 at 01:18:11AM +0300, Anssi Hannula wrote: Add keymap for the Medion X10 RF remote which uses the ati_remote driver, and default to it based on the usb id. Since rc-core supports loading custom keytmaps should

[ANN] Meeting minutes of the Cambourne meeting

2011-08-08 Thread Laurent Pinchart
Hi everybody, The V4L2 brainstorming meeting held in Cambourne from August the 1st to August the 5th was a success. I would like to thank Linaro again, and particularly Stephen Doel and Arwen Donaghey, for accommodating us during the whole week. Here is a summary of the discussions, with prelim

Re: [RFC] The clock dependencies between sensor subdevs and the host interface drivers

2011-08-08 Thread Laurent Pinchart
Hi Sylwester, On Monday 08 August 2011 17:36:32 Sylwester Nawrocki wrote: > Hi everyone, > > Nowadays many of the V4L2 camera device drivers heavily depend on the board > code to set up voltage supplies, clocks, and some control signals, like > 'reset' and 'standby' signals for the sensors. Those

[RFC] The clock dependencies between sensor subdevs and the host interface drivers

2011-08-08 Thread Sylwester Nawrocki
Hi everyone, Nowadays many of the V4L2 camera device drivers heavily depend on the board code to set up voltage supplies, clocks, and some control signals, like 'reset' and 'standby' signals for the sensors. Those things are often being done by means of the driver specific platform data callbacks.

Re: Media Subsystem Workshop 2011

2011-08-08 Thread Hans Verkuil
On Monday, August 08, 2011 15:25:26 Mauro Carvalho Chehab wrote: > Em 08-08-2011 03:22, Hans Verkuil escreveu: > > On Wednesday, August 03, 2011 19:45:36 Mauro Carvalho Chehab wrote: > >> Em 03-08-2011 14:21, Mauro Carvalho Chehab escreveu: > >>> As already announced, we're continuing the planning

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Alan Stern
On Sun, 7 Aug 2011, Theodore Kilgore wrote: > This indirectly answers my question, above, about whatever device there > may or may not be. What I get from this, and also from a bit of snooping > around, is that there is not any dev that gets created in order to be > accessed by libusb. Just an

[PATCH 3/3] DVB: gp8psk-fe: use SYS_TURBO

2011-08-08 Thread Andreas Oberritter
- Allows to select Turbo QPSK (SYS_TURBO + QPSK) Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-usb/gp8psk-fe.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/gp8psk-fe.c b/drivers/media/dvb/dvb-usb/gp8psk-fe.c in

[PATCH 1/3] DVB: Add SYS_TURBO for north american turbo code FEC

2011-08-08 Thread Andreas Oberritter
- Allow to distinguish turbo code from DVB-S Signed-off-by: Andreas Oberritter --- Documentation/DocBook/media/dvb/dvbproperty.xml |1 + include/linux/dvb/frontend.h|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Documentation/DocBook/media/dvb/dv

[PATCH 2/3] DVB: dvb_frontend: Fix compatibility criteria for satellite receivers

2011-08-08 Thread Andreas Oberritter
- When converting satellite receiver parameters from S2API to legacy, identify a satellite receiver by its 'delivery_system' instead of 'modulation', which may overlap between different delivery systems. Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c | 13 +

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Alan Stern
On Mon, 8 Aug 2011, Adam Baker wrote: > Further testing reveals the situation is more complex than I first thought - > the behaviour I get depends upon whether what gets plugged in is a full speed > or a high speed device. After I've run the test of running gphoto whilst > streaming from a supp

Re: [PATCH 5/7] [media] ati_remote: add keymap for Medion X10 RF remote

2011-08-08 Thread Anssi Hannula
On 08.08.2011 08:57, Dmitry Torokhov wrote: > On Sun, Aug 07, 2011 at 01:18:11AM +0300, Anssi Hannula wrote: >> Add keymap for the Medion X10 RF remote which uses the ati_remote >> driver, and default to it based on the usb id. > > Since rc-core supports loading custom keytmaps should we ass medio

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Mauro Carvalho Chehab
Em 07-08-2011 23:26, Theodore Kilgore escreveu: > > (first of two replies to Adam's message; second reply deals with other > topics) > > On Sun, 7 Aug 2011, Adam Baker wrote: > >> On Friday 05 August 2011, Hans de Goede wrote: This sounds to be a good theme for the Workshop, or even to KS/

Re: Media Subsystem Workshop 2011

2011-08-08 Thread Mauro Carvalho Chehab
Em 08-08-2011 03:22, Hans Verkuil escreveu: > On Wednesday, August 03, 2011 19:45:36 Mauro Carvalho Chehab wrote: >> Em 03-08-2011 14:21, Mauro Carvalho Chehab escreveu: >>> As already announced, we're continuing the planning for this year's >>> media subsystem workshop. >>> >>> To avoid overridin

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Hans Verkuil
On Monday, August 08, 2011 13:40:23 Laurent Pinchart wrote: > On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: > > On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: > > > A possibility to preallocate and initialise buffers of different sizes > > > in V4L2 is required for an effi

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Laurent Pinchart
On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: > On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: > > A possibility to preallocate and initialise buffers of different sizes > > in V4L2 is required for an efficient implementation of asnapshot mode. > > This patch adds two new

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-08-08 Thread Jose Alberto Reguero
On Martes, 2 de Agosto de 2011 21:21:13 Jose Alberto Reguero escribió: > On Jueves, 28 de Julio de 2011 21:25:01 Jose Alberto Reguero escribió: > > On Miércoles, 27 de Julio de 2011 21:22:26 Antti Palosaari escribió: > > > On 07/24/2011 12:45 AM, Jose Alberto Reguero wrote: > > > > Read without wri

Re: [PATCH] [media] omap3isp: queue: fail QBUF if buffer is too small

2011-08-08 Thread Michael Jones
Hi Laurent, On 08/08/2011 12:08 PM, Laurent Pinchart wrote: > > Hi Michael, > > On Friday 05 August 2011 13:41:54 Michael Jones wrote: >> On 08/05/2011 10:59 AM, Laurent Pinchart wrote: >>> Hi Michael, >>> >>> Thanks for the patch. >>> >>> On Thursday 04 August 2011 17:40:37 Michael Jones wrote:

Re: Possible issue in videobuf2 with buffer length check at QBUF time

2011-08-08 Thread Laurent Pinchart
Hi Pawel, On Friday 05 August 2011 17:01:09 Pawel Osciak wrote: > On Fri, Aug 5, 2011 at 01:55, Laurent Pinchart wrote: > > Hi Marek and Pawel, > > > > While reviewing an OMAP3 ISP patch, I noticed that videobuf2 doesn't > > verify the buffer length field value when a new USERPTR buffer is > > qu

Re: [PATCH] [media] omap3isp: queue: fail QBUF if buffer is too small

2011-08-08 Thread Laurent Pinchart
Hi Michael, On Friday 05 August 2011 13:41:54 Michael Jones wrote: > On 08/05/2011 10:59 AM, Laurent Pinchart wrote: > > Hi Michael, > > > > Thanks for the patch. > > > > On Thursday 04 August 2011 17:40:37 Michael Jones wrote: > >> Add buffer length to sanity checks for QBUF. > >> > >> Signed-

Re: ISP CCDC freeze-up on STREAMON

2011-08-08 Thread Laurent Pinchart
Hi Michael, On Friday 05 August 2011 11:33:20 Michael Jones wrote: > On 07/20/2011 10:47 AM, Laurent Pinchart wrote: > > On Thursday 30 June 2011 10:31:52 Michael Jones wrote: > >> Hi Laurent, > >> > >> I'm observing a system freeze-up with the ISP when writing data to > >> memory directly from t

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Hans Verkuil
Hi Guennadi! On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: > A possibility to preallocate and initialise buffers of different sizes > in V4L2 is required for an efficient implementation of asnapshot mode. > This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and > VIDIOC_PREPAR

Re: [PATCH 4/6 v4] V4L: vb2: add support for buffers of different sizes on a single queue

2011-08-08 Thread Sakari Ailus
Hi Guennadi, Thanks for the patch. I have a few comments below. Guennadi Liakhovetski wrote: > The two recently added ioctl()s VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF > allow user-space applications to allocate video buffers of different > sizes and hand them over to the driver for fast switchi

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Sakari Ailus
Guennadi Liakhovetski wrote: > A possibility to preallocate and initialise buffers of different sizes > in V4L2 is required for an efficient implementation of asnapshot mode. > This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and > VIDIOC_PREPARE_BUF and defines respective data structures. > >

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Hans de Goede
Hi, On 08/08/2011 12:53 AM, Adam Baker wrote: On Friday 05 August 2011, Hans de Goede wrote: This sounds to be a good theme for the Workshop, or even to KS/2011. Agreed, although we don't need to talk about this for very long, the solution is basically: 1) Define a still image retrieval API f