Re: omap4 v4l media-ctl usage

2012-02-19 Thread Aguirre, Sergio
H Ryan, On Sun, Feb 19, 2012 at 10:04 AM, Ryan wrote: > Hi Laurent, > > It actually blocks at VIDIOC_DQBUF ioctl and not in STREAMON ioctl. > Looks like the data is not available. > > Any way of verifying if OMAP is receiving data. Wonder why i keep > interrupts though? Can you try again after c

Re: omap4 v4l media-ctl usage

2012-02-19 Thread Sakari Ailus
Hi Ryan, On Sun, Feb 19, 2012 at 09:34:24PM +0530, Ryan wrote: > It actually blocks at VIDIOC_DQBUF ioctl and not in STREAMON ioctl. > Looks like the data is not available. > > Any way of verifying if OMAP is receiving data. Wonder why i keep > interrupts though? You do get or do not get interru

Re: [PATCH v3 0/33] V4L2 subdev and sensor control changes, SMIA++ driver and N9 camera board code

2012-02-19 Thread Sakari Ailus
Hi, On Mon, Feb 20, 2012 at 03:56:05AM +0200, Sakari Ailus wrote: > Hi everyone, > > This the third version of my patchset that contains: > > - Integer menu controls [2], > - Selection IOCTL for subdevs [3], > - Sensor control changes [5,7], > - link_validate() media entity and V4L2 subdev pad o

[PATCH v3 33/33] rm680: Add camera init

2012-02-19 Thread Sakari Ailus
From: Sakari Ailus This currently introduces an extra file to the arch/arm/mach-omap2 directory: board-rm680-camera.c. Keeping the device tree in mind, the context of the file could be represented as static data with one exception: the external clock to the sensor. This external clock is provide

[PATCH v3 31/33] omap3isp: Remove isp_validate_pipeline and other old stuff

2012-02-19 Thread Sakari Ailus
Remove isp_set_pixel_clock(). Remove set_pixel_clock() callback from platform callbacks since the same information is now passed to the ISP driver by other means. Remove struct ispccdc_vp since the only field in this structure, pixelclk, is no longer used. Remove isp_video_is_shiftable() --- thi

[PATCH v3 30/33] omap3isp: Add resizer data rate configuration to resizer_set_stream

2012-02-19 Thread Sakari Ailus
Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/ispresizer.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3isp/ispresizer.c b/drivers/media/video/omap3isp/ispresizer.c index 6ce2349..81e1bc4 100644 --- a/drivers/media/video/omap

[PATCH v3 29/33] omap3isp: Configure CSI-2 phy based on platform data

2012-02-19 Thread Sakari Ailus
Configure CSI-2 phy based on platform data in the ISP driver. For that, the new V4L2_CID_IMAGE_SOURCE_PIXEL_RATE control is used. Previously the same was configured from the board code. Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/isp.h |3 - drivers/media/video/omap3is

[PATCH v3 28/33] omap3isp: Move setting constaints above media_entity_pipeline_start

2012-02-19 Thread Sakari Ailus
Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/ispvideo.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/omap3isp/ispvideo.c b/drivers/media/video/omap3isp/ispvideo.c index f1c68ca..2e4786d 100644 --- a/drivers/media/video/oma

[PATCH v3 27/33] omap3isp: Implement proper CCDC link validation, check pixel rate

2012-02-19 Thread Sakari Ailus
Implement correct link validation for the CCDC. Use external_rate from isp_pipeline to configurat vp divisor and check that external_rate does not exceed our data rate limitations. Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/ispccdc.c | 69 +-- 1 fi

[PATCH v3 26/33] omap3isp: Default link validation for ccp2, csi2, preview and resizer

2012-02-19 Thread Sakari Ailus
Use default link validation for ccp2, csi2, preview and resizer. On ccp2, csi2 and ccdc we also collect information on external subdevs as one may be connected to those entities. The CCDC link validation still must be done separately. Also set pipe->external correctly as we go Signed-off-by: Sak

[PATCH v3 25/33] omap3isp: Introduce omap3isp_get_external_info()

2012-02-19 Thread Sakari Ailus
omap3isp_get_external_info() will retrieve external subdev's bits-per-pixel and pixel rate for the use of other ISP subdevs at streamon time. omap3isp_get_external_info() is used during pipeline validation. Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/isp.c | 48 +++

[PATCH v3 24/33] omap3isp: Add information on external subdev to struct isp_pipeline

2012-02-19 Thread Sakari Ailus
Add pointer to external subdev, pixel rate of the external subdev and bpp of the format to struct isp_pipeline. Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/ispvideo.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3isp/ispvideo

[PATCH v3 23/33] omap3isp: Add lane configuration to platform data

2012-02-19 Thread Sakari Ailus
Add lane configuration (order of clock and data lane) to platform data on both CCP2 and CSI-2. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/video/omap3isp/ispcsiphy.h | 15 ++- include/media/omap3isp.h | 25 + 2

[PATCH v3 22/33] omap3isp: Assume media_entity_pipeline_start may fail

2012-02-19 Thread Sakari Ailus
Since media_entity_pipeline_start() now does link validation, it may actually fail. Perform the error handling. Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/ispvideo.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/media/video

[PATCH v3 21/33] omap3: add definition for CONTROL_CAMERA_PHY_CTRL

2012-02-19 Thread Sakari Ailus
This register is available only in OMAP3630. The original patch was submitted by Vimarsh Zutshi. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- arch/arm/mach-omap2/control.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/control.h b/arc

[PATCH v3 20/33] omap3isp: Move definitions required by board code under include/media.

2012-02-19 Thread Sakari Ailus
XCLK definitions are often required by the board code. Move them to public include file. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/video/omap3isp/isp.h |4 include/media/omap3isp.h |4 2 files changed, 4 insertions(+), 4 deletions(-) d

[PATCH v3 19/33] omap3isp: Support additional in-memory compressed bayer formats

2012-02-19 Thread Sakari Ailus
This also prevents accessing NULL pointer in csi2_try_format(). Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/video/omap3isp/ispvideo.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3isp/ispvideo.c b/dri

[PATCH v3 18/33] v4l: Allow changing control handler lock

2012-02-19 Thread Sakari Ailus
Allow choosing the lock used by the control handler. This may be handy sometimes when a driver providing multiple subdevs does not want to use several locks to serialise its functions. Signed-off-by: Sakari Ailus --- drivers/media/video/adp1653.c|8 +++--- drivers/media/video/v4l2-ctrls.

[PATCH v3 17/33] v4l: Implement v4l2_subdev_link_validate()

2012-02-19 Thread Sakari Ailus
v4l2_subdev_link_validate() is the default op for validating a link. In V4L2 subdev context, it is used to call a pad op which performs the proper link check without much extra work. Signed-off-by: Sakari Ailus --- Documentation/video4linux/v4l2-framework.txt | 12 + drivers/media/video/v4

[PATCH v3 16/33] v4l: Improve sub-device documentation for pad ops

2012-02-19 Thread Sakari Ailus
Document that format related configuration is done through pad ops in case the driver does use the media framework. Signed-off-by: Sakari Ailus --- Documentation/video4linux/v4l2-framework.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/Documentation/video4li

[PATCH v3 15/33] media: Add link_validate() op to check links to the sink pad

2012-02-19 Thread Sakari Ailus
The purpose of the link_validate() op is to allow an entity driver to ensure that the properties of the pads at the both ends of the link are suitable for starting the pipeline. link_validate is called on sink pads on active links which belong to the active part of the graph. Signed-off-by: Sakari

[PATCH v3 14/33] v4l: Add DPCM compressed formats

2012-02-19 Thread Sakari Ailus
Add three other colour orders for 10-bit to 8-bit DPCM compressed formats. Signed-off-by: Sakari Ailus --- Documentation/DocBook/media/v4l/pixfmt-srggb10.xml |2 +- .../DocBook/media/v4l/pixfmt-srggb10dpcm8.xml | 29 Documentation/DocBook/media/v4l/pixfmt.xml

[PATCH v3 13/33] v4l: Document raw bayer 4CC codes

2012-02-19 Thread Sakari Ailus
Document guidelines how 4CC codes should be named. Only raw bayer is included currently. Other formats should be documented later on. Signed-off-by: Sakari Ailus --- Documentation/video4linux/4CCs.txt | 32 1 files changed, 32 insertions(+), 0 deletions(-) cre

[PATCH v3 12/33] v4l: Image processing control class

2012-02-19 Thread Sakari Ailus
Add control class for image processing controls. The control class deals with controls processing image, for example digital gain or noise filtering, which can be present in any part of the pipeline. Signed-off-by: Sakari Ailus --- Documentation/DocBook/media/v4l/controls.xml | 82 ++

[PATCH v3 11/33] v4l: Image source control class

2012-02-19 Thread Sakari Ailus
Add image source control class. This control class is intended to contain low level controls which deal with control of the image capture process --- the A/D converter in image sensors, for example. Signed-off-by: Sakari Ailus --- Documentation/DocBook/media/v4l/controls.xml | 86 +++

[PATCH v3 10/33] v4l: Mark VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP obsolete

2012-02-19 Thread Sakari Ailus
These two IOCTLS are obsoleted by VIDIOC_SUBDEV_G_SELECTION and VIDIOC_SUBDEV_S_SELECTION. Mark them obsolete. Signed-off-by: Sakari Ailus --- Documentation/DocBook/media/v4l/compat.xml |7 +++ .../DocBook/media/v4l/vidioc-subdev-g-crop.xml |9 ++--- 2 files changed,

[PATCH v3 09/33] v4l: Add subdev selections documentation

2012-02-19 Thread Sakari Ailus
Add documentation for V4L2 subdev selection API. This changes also experimental V4L2 subdev API so that scaling now works through selection API only. Signed-off-by: Sakari Ailus --- Documentation/DocBook/media/Makefile |2 +- Documentation/DocBook/media/v4l/compat.xml |

[PATCH v3 07/33] v4l: Support s_crop and g_crop through s/g_selection

2012-02-19 Thread Sakari Ailus
Fall back to s_selection if s_crop isn't implemented by a driver. Same for g_selection / g_crop. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/video/v4l2-subdev.c | 37 +++-- 1 files changed, 35 insertions(+), 2 deletions(-) diff --g

[PATCH v3 06/33] v4l: Check pad number in get try pointer functions

2012-02-19 Thread Sakari Ailus
Unify functions to get try pointers and validate the pad number accessed by the user. Signed-off-by: Sakari Ailus --- include/media/v4l2-subdev.h | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/include/media/v4l2-subdev.h b/include/media/v

[PATCH v3 05/33] v4l: vdev_to_v4l2_subdev() should have return type "struct v4l2_subdev *"

2012-02-19 Thread Sakari Ailus
vdev_to_v4l2_subdev() should return struct v4l2_subdev *, not void *. Fix this. Signed-off-by: Sakari Ailus --- include/media/v4l2-subdev.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index feab950..bcaf6b8 1

[PATCH v3 04/33] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-19 Thread Sakari Ailus
Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and VIDIOC_SUBDEV_G_CROP IOCTLs and also add new functionality (composing). VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP continue to be supported. Signed-of

[PATCH v3 03/33] vivi: Add an integer menu test control

2012-02-19 Thread Sakari Ailus
Add an integer menu test control for the vivi driver. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/video/vivi.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c inde

[PATCH v3 02/33] v4l: Document integer menu controls

2012-02-19 Thread Sakari Ailus
Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- Documentation/DocBook/media/v4l/compat.xml | 10 + Documentation/DocBook/media/v4l/v4l2.xml |6 +++ .../DocBook/media/v4l/vidioc-queryctrl.xml | 39 +++- 3 files changed, 53 insertion

[PATCH v3 01/33] v4l: Introduce integer menu controls

2012-02-19 Thread Sakari Ailus
Create a new control type called V4L2_CTRL_TYPE_INTEGER_MENU. Integer menu controls are just like menu controls but the menu items are 64-bit integers rather than strings. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/video/v4l2-ctrls.c | 74

[PATCH v3 0/33] V4L2 subdev and sensor control changes, SMIA++ driver and N9 camera board code

2012-02-19 Thread Sakari Ailus
Hi everyone, This the third version of my patchset that contains: - Integer menu controls [2], - Selection IOCTL for subdevs [3], - Sensor control changes [5,7], - link_validate() media entity and V4L2 subdev pad ops, - OMAP 3 ISP driver improvements [4], - SMIA++ sensor driver, - rm680/rm696 boa

Re: [PATCH] em28xx: pre-allocate DVB isoc transfer buffers

2012-02-19 Thread Gianluca Gennari
Il 20/02/2012 00:46, Chris Rankin ha scritto: > Gianluca, > > One quick comment about your patch; I've noticed that you've declared > two new "GPL only" symbols: > > EXPORT_SYMBOL_GPL(em28xx_capture_start); > EXPORT_SYMBOL_GPL(em28xx_alloc_isoc); > > I'm not sure what the exact policy is with GP

[PATCH] em28xx: pre-allocate DVB isoc transfer buffers

2012-02-19 Thread Chris Rankin
Gianluca, One quick comment about your patch; I've noticed that you've declared two new "GPL only" symbols: EXPORT_SYMBOL_GPL(em28xx_capture_start); EXPORT_SYMBOL_GPL(em28xx_alloc_isoc); I'm not sure what the exact policy is with GPL symbols, but I do know what Al Viro posted recently on the

[BUG] divide by zero in uvc_video_clock_update, v3.3-rc4

2012-02-19 Thread James Hogan
Hi, I just tried v3.3-rc4 on an Acer Aspire One Happy 2 netbook. I happened to open the settings dialog box of kopete, which shows a view of the webcam. The kernel switched to a text console with a register dump (see below), indicating a divide error in uvc_video_clock_update. The IP is on 7482,

Re: DVB-S2 multistream support

2012-02-19 Thread Konstantin Dimitrov
hello Christian, that's really great news! i'm looking forward to look at the code when the public repository is ready. i'm sure i'm not the only one and the news would be especially exciting for TBS 6925 owners, which use Linux, but it's away beyond that, because the real news here is working bas

cron job: media_tree daily build: ERRORS

2012-02-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Feb 19 19:00:17 CET 2012 git hash:a3db60bcf7671cc011ab4f848cbc40ff7ab52c1e gcc version: i686-linux-gcc (GCC

Re: omap4 v4l media-ctl usage

2012-02-19 Thread Ryan
Hi Laurent, It actually blocks at VIDIOC_DQBUF ioctl and not in STREAMON ioctl. Looks like the data is not available. Any way of verifying if OMAP is receiving data. Wonder why i keep interrupts though? Is my media-ctl setting up things correctly? Thank you. Regards, Ryan On Sun, Feb 19, 2012

Re: omap4 v4l media-ctl usage

2012-02-19 Thread Ryan
Hi Laurent, On Sun, Feb 19, 2012 at 2:27 PM, Laurent Pinchart wrote: > Hi Ryan, > > On Saturday 18 February 2012 20:59:57 Ryan wrote: >> hello, >> I am using media-ctl on the panda board. The sensor gets detected. But >> media-ctl doesnt print anything. >> The kernel is cloned from omap4 v4l git

Re: omap4 v4l media-ctl usage

2012-02-19 Thread Laurent Pinchart
Hi Ryan, On Saturday 18 February 2012 20:59:57 Ryan wrote: > hello, > I am using media-ctl on the panda board. The sensor gets detected. But > media-ctl doesnt print anything. > The kernel is cloned from omap4 v4l git tree: commit id: > 3bc023462a68f78bb0273848f5ab08a01b434ffa > > what could be w

Re: Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

2012-02-19 Thread Keith Packard
<#part sign=pgpmime> On Fri, 17 Feb 2012 00:25:51 +0100, Laurent Pinchart wrote: > *** Synchronous pipeline changes *** > > Goal: Create an API to apply complex changes to a video pipeline atomically. > > Needed for complex camera use cases. On the DRM/KMS side, the approach is to > use