Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
Hi Guennadi, thank you for your review. On 20 February 2012 15:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: @@ -707,6 +732,74 @@ static void mx27_camera_emma_buf_init(struct soc_camera_device *icd,       writel(prp-cfg.irq_flags, pcdev-base_emma + PRP_INTR_CNTL);  } +static void

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread Guennadi Liakhovetski
Hi Javier One more thing occurred to me: I don't see anywhere in your patch checking for supported pixel (fourcc) formats. I don't think the PRP can resize arbitrary formats? Most likely these would be limited to some YUV, and, possibly, some RGB formats? Thanks Guennadi On Tue, 21 Feb 2012,

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
On 21 February 2012 09:39, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier One more thing occurred to me: I don't see anywhere in your patch checking for supported pixel (fourcc) formats. I don't think the PRP can resize arbitrary formats? Most likely these would be limited to

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread Guennadi Liakhovetski
On Tue, 21 Feb 2012, javier Martin wrote: On 21 February 2012 09:39, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier One more thing occurred to me: I don't see anywhere in your patch checking for supported pixel (fourcc) formats. I don't think the PRP can resize

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
On 21 February 2012 10:24, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Tue, 21 Feb 2012, javier Martin wrote: On 21 February 2012 09:39, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier One more thing occurred to me: I don't see anywhere in your patch checking

Re: [PATCH] tea575x: fix HW seek

2012-02-21 Thread Hans Verkuil
On Saturday, February 18, 2012 17:45:45 Ondrej Zary wrote: Fix HW seek in TEA575x to work properly: - a delay must be present after search start and before first register read or the seek does weird things - when the search stops, the new frequency is not available immediately, we

[PATCH 2/2] Driver: video: Use the macro DMA_BIT_MASK().

2012-02-21 Thread santosh nayak
From: Santosh Nayak santoshprasadna...@gmail.com Use the macro DMA_BIT_MASK instead of the constant 0x. Signed-off-by: Santosh Nayak santoshprasadna...@gmail.com --- drivers/media/video/cx18/cx18-driver.c |4 ++-- drivers/media/video/ivtv/ivtv-driver.c |4 ++-- 2 files changed,

Re: [PATCH v3 04/33] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-21 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Monday 20 February 2012 03:56:43 Sakari Ailus wrote: Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and VIDIOC_SUBDEV_G_CROP IOCTLs and also add new functionality

Re: [PATCH v3 05/33] v4l: vdev_to_v4l2_subdev() should have return type struct v4l2_subdev *

2012-02-21 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Monday 20 February 2012 03:56:44 Sakari Ailus wrote: vdev_to_v4l2_subdev() should return struct v4l2_subdev *, not void *. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Sounds like you've been bitten by this :-) Acked-by: Laurent Pinchart

Re: [PATCH v3 06/33] v4l: Check pad number in get try pointer functions

2012-02-21 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Monday 20 February 2012 03:56:45 Sakari Ailus wrote: Unify functions to get try pointers and validate the pad number accessed by the user. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- include/media/v4l2-subdev.h | 31

Re: [PATCH v3 08/33] v4l: Add subdev selections documentation: svg and dia files

2012-02-21 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Monday 20 February 2012 03:56:47 Sakari Ailus wrote: Add svga and dia files for V4L2 subdev selections documentation. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi The diagram look fine, although a bit complex. They could be simplified by merging the

Re: [PATCH v3 04/33] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-21 Thread Laurent Pinchart
Hi Sakari, One more comment. On Monday 20 February 2012 03:56:43 Sakari Ailus wrote: [snip] +/* active cropping area */ +#define V4L2_SUBDEV_SEL_TGT_CROP_ACTIVE 0x +/* cropping bounds */ +#define V4L2_SUBDEV_SEL_TGT_CROP_BOUNDS 0x0002 +/*

[PATCH] rtl28xxu: add another Freecom usb id

2012-02-21 Thread Paolo Pantò
Besides sticks with the usb id 14AA:0160, there exists also some with 14AA:0161 - this is the output in /var/log/messages: usb 1-1: new high-speed USB device number 2 using ehci_hcd usb 1-1: New USB device found, idVendor=14aa, idProduct=0161 usb 1-1: New USB device strings: Mfr=1, Product=2,

Re: [PATCH] rtl28xxu: add another Freecom usb id

2012-02-21 Thread Antti Palosaari
On 21.02.2012 18:26, Paolo Pantò wrote: Besides sticks with the usb id 14AA:0160, there exists also some with 14AA:0161 - this is the output in /var/log/messages: The patch is based on the code at http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/realtek Signed-off-by: Paolo

Re: [PATCH v3 09/33] v4l: Add subdev selections documentation

2012-02-21 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Monday 20 February 2012 03:56:48 Sakari Ailus wrote: Add documentation for V4L2 subdev selection API. This changes also experimental V4L2 subdev API so that scaling now works through selection API only. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH v3 10/33] v4l: Mark VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP obsolete

2012-02-21 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Monday 20 February 2012 03:56:49 Sakari Ailus wrote: These two IOCTLS are obsoleted by VIDIOC_SUBDEV_G_SELECTION and VIDIOC_SUBDEV_S_SELECTION. Mark them obsolete. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart

cron job: media_tree daily build: WARNINGS

2012-02-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Feb 21 19:00:13 CET 2012 git hash:a3db60bcf7671cc011ab4f848cbc40ff7ab52c1e gcc version: i686-linux-gcc

Re: [PATCHv22 13/16] drivers: add Contiguous Memory Allocator

2012-02-21 Thread Aaro Koskinen
Hi, On Fri, 17 Feb 2012, Marek Szyprowski wrote: +/** + * dma_release_from_contiguous() - release allocated pages + * @dev: Pointer to device for which the pages were allocated. + * @pages: Allocated pages. + * @count: Number of allocated pages. + * + * This function releases memory allocated

Re: [PATCHv22 14/16] X86: integrate CMA with DMA-mapping subsystem

2012-02-21 Thread Andrew Morton
On Fri, 17 Feb 2012 20:30:34 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: This patch adds support for CMA to dma-mapping subsystem for x86 architecture that uses common pci-dma/pci-nommu implementation. This allows to test CMA on KVM/QEMU and a lot of common x86 boxes. ... ---

Re: [PATCH v2 1/1] rc: Add support for GPIO based IR Receiver driver.

2012-02-21 Thread Ravi Kumar V
On 2/21/2012 1:59 AM, James Hogan wrote: On Mon, Feb 20, 2012 at 03:17:52PM +0530, Ravi Kumar V wrote: Adds GPIO based IR Receiver driver. It decodes signals using decoders available in rc framework. Signed-off-by: Ravi Kumar Vkumar...@codeaurora.org --- drivers/media/rc/Kconfig|