[patch] [media] uvcvideo: remove unneeded access_ok() check

2012-03-21 Thread Dan Carpenter
copy_in_user() already checks for write permission, so we don't need to do it here. This was added in 1a5e4c867c [media] uvcvideo: Implement compat_ioctl32 for custom ioctls. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/video/uvc/uvc_v4l2.c

[PATCH 05/16] mm/drivers: use vm_flags_t for vma flags

2012-03-21 Thread Konstantin Khlebnikov
Signed-off-by: Konstantin Khlebnikov khlebni...@openvz.org Cc: linux-media@vger.kernel.org Cc: de...@driverdev.osuosl.org Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: John Stultz

Re: [PATCH 2/3] Basic AF9035/AF9033 driver

2012-03-21 Thread Oliver Schinagl
On 20-03-12 17:27, Gianluca Gennari wrote: Hi Michael, Il 20/03/2012 14:04, Michael Büsch ha scritto: Thank you for working on a af903x driver. I tried to test the driver on a debian 3.2 kernel, after applying a small fix: It should be CONFIG_DVB_USB_AF903X here. this issue is fixed in

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Jean-Francois Moine
On Tue, 20 Mar 2012 21:05:13 -0300 Ezequiel García elezegar...@gmail.com wrote: I'm a little lost while writing a driver for an easycap device (saa7113 capture device). I have my isoc handler, and the isoc urb flying OK. I also have the videobuf2 queue setup (or at least I think so), and I

Re: [PATCH v5 14/35] v4l: Add DPCM compressed raw bayer pixel formats

2012-03-21 Thread Prabhakar Lad
Sakari, On Tue, Mar 6, 2012 at 10:02 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Add three other colour orders for 10-bit to 8-bit DPCM compressed raw bayer pixel formats. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi ---  Documentation/DocBook/media/v4l/pixfmt-srggb10.xml |    2 +-  

Re: [PATCH v5 14/35] v4l: Add DPCM compressed raw bayer pixel formats

2012-03-21 Thread Sakari Ailus
Hi Prabhakar, Prabhakar Lad wrote: On Tue, Mar 6, 2012 at 10:02 PM, Sakari Ailussakari.ai...@iki.fi wrote: ... diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10dpcm8.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb10dpcm8.xml new file mode 100644 index 000..80937f1 ---

Re: [PATCH 05/16] mm/drivers: use vm_flags_t for vma flags

2012-03-21 Thread Laurent Pinchart
Hi Konstantin, Thanks for the patch. On Wednesday 21 March 2012 10:56:33 Konstantin Khlebnikov wrote: Signed-off-by: Konstantin Khlebnikov khlebni...@openvz.org Cc: linux-media@vger.kernel.org Cc: de...@driverdev.osuosl.org Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Mauro

Re: [patch] [media] uvcvideo: remove unneeded access_ok() check

2012-03-21 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Wednesday 21 March 2012 09:35:23 Dan Carpenter wrote: copy_in_user() already checks for write permission, so we don't need to do it here. This was added in 1a5e4c867c [media] uvcvideo: Implement compat_ioctl32 for custom ioctls. Signed-off-by: Dan

Re: [PATCH 1/2] V4L: sh_mobile_ceu_camera: maximum image size depends on the hardware version

2012-03-21 Thread Laurent Pinchart
Hi Guennadi, On Wednesday 14 March 2012 16:02:20 Guennadi Liakhovetski wrote: Newer CEU versions, e.g., the one, used on sh7372, support image sizes larger than 2560x1920. Retrieve maximum sizes from platform properties. Isn't there a way you could query the CEU version at runtime instead ?

Re: [PATCH 1/2] V4L: sh_mobile_ceu_camera: maximum image size depends on the hardware version

2012-03-21 Thread Guennadi Liakhovetski
Hi Laurent On Wed, 21 Mar 2012, Laurent Pinchart wrote: Hi Guennadi, On Wednesday 14 March 2012 16:02:20 Guennadi Liakhovetski wrote: Newer CEU versions, e.g., the one, used on sh7372, support image sizes larger than 2560x1920. Retrieve maximum sizes from platform properties. Isn't

[PATCH v2 0/9] soc-camera: Add support for configurable line stride

2012-03-21 Thread Laurent Pinchart
Hi Guennadi, Here's the second version of the soc-camera configurable line stride support patches. The patches have been successfully tested on a Mackerel board with the on-board VGA sensor. Laurent Pinchart (9): mx2_camera: Fix sizeimage computation in try_fmt() soc_camera: Use

[PATCH v2 4/9] soc-camera: Add plane layout information to struct soc_mbus_pixelfmt

2012-03-21 Thread Laurent Pinchart
To compute the value of the v4l2_pix_format::bytesperline field, we need information about planes layout for planar formats. The new enum soc_mbus_layout conveys that information. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/atmel-isi.c|

[PATCH v2 5/9] soc-camera: Fix bytes per line computation for planar formats

2012-03-21 Thread Laurent Pinchart
The V4L2 specification defines bytesperline for planar formats as the number of bytes per line for the largest plane. Modify soc_mbus_bytes_per_line() accordingly. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/soc_mediabus.c |3 +++ 1 files

[PATCH v2 6/9] soc-camera: Add soc_mbus_image_size

2012-03-21 Thread Laurent Pinchart
The function returns the minimum size of an image for a given number of bytes per line (as per the V4L2 specification), width and format. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/soc_mediabus.c | 18 ++

[PATCH v2 1/9] mx2_camera: Fix sizeimage computation in try_fmt()

2012-03-21 Thread Laurent Pinchart
The try_fmt() handler restricts the image width based on the hardware limits and updates the bytesperline value, but doesn't update sizeimage. Fix it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mx2_camera.c |1 + 1 files changed, 1

[PATCH v2 7/9] soc-camera: Honor user-requested bytesperline and sizeimage

2012-03-21 Thread Laurent Pinchart
Compute the bytesperline and sizeimage values when trying/setting formats or when allocating buffers by taking the user-requested values into account. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mx3_camera.c | 20 +-

[PATCH v2 8/9] mx2_camera: Use soc_mbus_image_size() instead of manual computation

2012-03-21 Thread Laurent Pinchart
Use the new soc_mbus_image_size() function to compute the image size. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mx2_camera.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mx2_camera.c

[PATCH v2 9/9] soc-camera: Support user-configurable line stride

2012-03-21 Thread Laurent Pinchart
Add a capabilities field to the soc_camera_host structure to flag hosts that support user-configurable line strides. soc_camera_try_fmt() then passes the user-provided bytesperline and sizeimage format fields to such hosts, and expects the host to check (and fix if needed) the values.

[PATCH v2 3/9] soc_camera: Use soc_camera_device::bytesperline to compute line sizes

2012-03-21 Thread Laurent Pinchart
Instead of computing the line sizes, use the previously negotiated soc_camera_device::bytesperline value. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mx3_camera.c |7 ++- drivers/media/video/sh_mobile_ceu_camera.c |4 +--- 2

[PATCH v2 2/9] soc_camera: Use soc_camera_device::sizeimage to compute buffer sizes

2012-03-21 Thread Laurent Pinchart
Instead of computing the buffer size manually in the videobuf queue setup and buffer prepare callbacks, use the previously negotiated soc_camera_device::sizeimage value. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/atmel-isi.c| 17

Re: [PATCH 1/2] V4L: sh_mobile_ceu_camera: maximum image size depends on the hardware version

2012-03-21 Thread Laurent Pinchart
Hi Guennadi, On Wednesday 21 March 2012 11:59:59 Guennadi Liakhovetski wrote: On Wed, 21 Mar 2012, Laurent Pinchart wrote: On Wednesday 14 March 2012 16:02:20 Guennadi Liakhovetski wrote: Newer CEU versions, e.g., the one, used on sh7372, support image sizes larger than 2560x1920.

Re: [PATCH] media: vb2-memops: Export vb2_get_vma symbol

2012-03-21 Thread Laurent Pinchart
Hi Tomasz, On Monday 23 January 2012 15:44:25 Tomasz Stanislawski wrote: Hi Laurent, Thank you for finding a bug in vb2-core. You're welcome. Could you please take the patch in your tree ? On 01/23/2012 03:35 PM, Laurent Pinchart wrote: The vb2_get_vma() function is called by

[PATCH v2 10/9] sh_mobile_ceu_camera: Support user-configurable line stride

2012-03-21 Thread Laurent Pinchart
In image mode, the CEU allows configurable line strides up to 8188 pixels. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/sh_mobile_ceu_camera.c | 25 + 1 files changed, 17 insertions(+), 8 deletions(-) Hi Guennadi, This

[PATCH v5.5 14/40] v4l: Add DPCM compressed raw bayer pixel formats

2012-03-21 Thread Sakari Ailus
Add three other colour orders for 10-bit to 8-bit DPCM compressed raw bayer pixel formats. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/pixfmt-srggb10.xml |2 +- .../DocBook/media/v4l/pixfmt-srggb10dpcm8.xml | 29

[GIT PULL FOR v3.4 v3] V4L2 subdev and sensor control changes and SMIA++ driver

2012-03-21 Thread Sakari Ailus
Hi Mauro, This patchset adds - Integer menu controls, - Selection IOCTL for subdevs, - Sensor control improvements, - link_validate() media entity and V4L2 subdev pad ops, - OMAP 3 ISP driver improvements, - SMIA++ sensor driver and - Other V4L2 and media improvements (see individual patches)

Re: [PATCH v5.5 14/40] v4l: Add DPCM compressed raw bayer pixel formats

2012-03-21 Thread Prabhakar Lad
On Wed, Mar 21, 2012 at 5:14 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Add three other colour orders for 10-bit to 8-bit DPCM compressed raw bayer pixel formats. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Prabhakar Lad prabhakar.cse...@gmail.com ---  

Re: [GIT PULL FOR v3.4] V4L2 subdev and sensor control changes and SMIA++ driver

2012-03-21 Thread Prabhakar Lad
Sakari, On Tue, Mar 20, 2012 at 4:24 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Mauro, On Mon, Mar 19, 2012 at 06:47:28PM -0300, Mauro Carvalho Chehab wrote: Em 11-03-2012 13:56, Sakari Ailus escreveu: Hi Mauro, This patchset adds - Integer menu controls, - Selection IOCTL for

Re: [GIT PULL FOR v3.4] V4L2 subdev and sensor control changes and SMIA++ driver

2012-03-21 Thread Sakari Ailus
Hi Prabhakar, Prabhakar Lad wrote: On Tue, Mar 20, 2012 at 4:24 AM, Sakari Ailussakari.ai...@iki.fi wrote: Hi Mauro, On Mon, Mar 19, 2012 at 06:47:28PM -0300, Mauro Carvalho Chehab wrote: Em 11-03-2012 13:56, Sakari Ailus escreveu: Hi Mauro, This patchset adds - Integer menu controls, -

Re: [PATCH 05/16] mm/drivers: use vm_flags_t for vma flags

2012-03-21 Thread Greg Kroah-Hartman
On Wed, Mar 21, 2012 at 10:56:33AM +0400, Konstantin Khlebnikov wrote: Signed-off-by: Konstantin Khlebnikov khlebni...@openvz.org Cc: linux-media@vger.kernel.org Cc: de...@driverdev.osuosl.org Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Mauro Carvalho Chehab

Re: [PATCH] [RFC] dma-buf: mmap support

2012-03-21 Thread Rob Clark
On Tue, Mar 20, 2012 at 3:53 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Let's have some competition here for dma_buf mmap support ;-) Compared to Rob Clarke's RFC I've ditched the prepare/finish hooks and corresponding ioctls on the dma_buf file. The major reason for that is that many

[GIT PATCHES FOR 3.4] s5p/exynos fimc driver updates

2012-03-21 Thread Sylwester Nawrocki
Hello Mauro, please pull the following, if it isn't too late yet, for v3.4. The last patch doesn't apply cleanly to linuxtv/staging/for_v3.4, due to some changes that are already in Linus' tree. Also this conflicting patch depends on commit d1c3414c2a9d10ef7f drivercore: Add driver probe

[PATCH 0/2] Fitipower fc0011 support

2012-03-21 Thread Michael Büsch
This patchset adds support for the Fitipower fc0011 DVB tuner. Version 2 of this patchset fixes several small bugs and adds some descriptive register names. -- Greetings, Michael. PGP encryption is encouraged / 908D8B0E signature.asc Description: PGP signature

[PATCH 2/2] Integrate Fitipower fc0011 into af903x

2012-03-21 Thread Michael Büsch
This adds fc0011 support to the af903x driver. Signed-off-by: Michael Buesch m...@bues.ch --- Index: linux-source-3.2/drivers/media/dvb/dvb-usb/Kconfig === --- linux-source-3.2.orig/drivers/media/dvb/dvb-usb/Kconfig 2012-03-20

Re: [Linaro-mm-sig] [PATCH] [RFC] dma-buf: mmap support

2012-03-21 Thread Rebecca Schultz Zavin
On Wed, Mar 21, 2012 at 8:45 AM, Rob Clark rob.cl...@linaro.org wrote: On Tue, Mar 20, 2012 at 3:53 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Let's have some competition here for dma_buf mmap support ;-) Compared to Rob Clarke's RFC I've ditched the prepare/finish hooks and

Re: [PATCH] [RFT/RFC] Add gspca subdriver for Speedlink VAD Laplace (EM2765+OV2640)

2012-03-21 Thread Frank Schäfer
Am 17.03.2012 14:11, schrieb Jean-Francois Moine: On Fri, 16 Mar 2012 23:15:45 +0100 Frank Schäfer fschaefer@googlemail.com wrote: Anyway, I would be glad to get some feedback concerning form and content of the code, becausse I'm still a newbie to kernel programming. Hi Frank, I agree

Re: Move em27xx/em28xx webcams to a gspca subdriver ?

2012-03-21 Thread Frank Schäfer
Am 16.03.2012 23:18, schrieb Frank Schäfer: [Was: eMPIA EM2710 Webcam (em28xx) and LIRC] Continue this part of the discussion in a new thread... Am 15.03.2012 14:05, schrieb Mauro Carvalho Chehab: Em 15-03-2012 09:34, Frank Schäfer escreveu: ... I would like to bring up the question, if

cron job: media_tree daily build: ERRORS

2012-03-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Mar 21 19:00:39 CET 2012 git hash:f92c97c8bd77992ff8bd6ef29a23dc82dca799cb gcc version: i686-linux-gcc

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
2012/3/20 Andy Walls awa...@md.metrocast.net: Section 8.10 of the SAA7113 data sheet shows 16 data formats.  The interesting one for video is #15 Y:U:V 4:2:2. Thanks. Perhaps, I should have done my homework. The EM28xx chip programming might rearrange some data, but I have no knowledge or

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Devin Heitmueller
2012/3/21 Ezequiel García elezegar...@gmail.com: 2012/3/20 Andy Walls awa...@md.metrocast.net: Section 8.10 of the SAA7113 data sheet shows 16 data formats.  The interesting one for video is #15 Y:U:V 4:2:2. Every USB bridge provides their raw video over isoc in a slightly different format

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
Hi, 2012/3/21 Jean-Francois Moine moin...@free.fr: In the gspca test tarball (see my site), I merged the spca506 code into the spca505 for a webcam which may also do analog video capture. The webcam works, but the analog video capture has never been tested. Also, the gspca_main - subdriver

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
Hi, 2012/3/21 Devin Heitmueller dheitmuel...@kernellabs.com: Every USB bridge provides their raw video over isoc in a slightly different format (not just in terms of the colorspace but also how to read the isoc header to detect the start of video frame, which field is being sent, etc).  

Re: [PATCH 1/2] Fitipower fc0011 driver

2012-03-21 Thread Gianluca Gennari
Il 21/03/2012 16:56, Michael Büsch ha scritto: This adds the Fitipower fc0011 tuner driver. Note: The '#if 0' statements will be removed on the final submission. Signed-off-by: Michael Buesch m...@bues.ch --- .. + +#if 0 //TODO 3.3 +static int fc0011_set_params(struct

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Devin Heitmueller
2012/3/21 Ezequiel García elezegar...@gmail.com: Ok. So, it's not saa7113 related, but rather stk1160 related? Yes. When there is no video, isoc urbs are received with actual length=4. This is header right? I'm not sure what you mean by no video. Do you have capture disabled? Are you

Re: [Q] v4l buffer format inside isoc

2012-03-21 Thread Ezequiel García
2012/3/21 Devin Heitmueller dheitmuel...@kernellabs.com: I'm not sure what you mean by no video.  Do you have capture disabled?  Are you saying that you didn't connect the video cable to your input?  Most devices will continue to generate video frames over isoc even if there is no actual video

Problem with building linuxtv.org's V4L-DVB drivers

2012-03-21 Thread Joe Henley
I'm running kernel-ml-2.6.35-14.1.el5.elrepo I'm following the info on: http://linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers First I run: git clone git://linuxtv.org/media_build.git cd media_build Then when I run ./build, it stops with the following error:

Re: [PATCH 1/2] Fitipower fc0011 driver

2012-03-21 Thread Michael Büsch
On Wed, 21 Mar 2012 20:12:03 +0100 Gianluca Gennari gennar...@gmail.com wrote: +#if 0 //TODO 3.3 + struct dtv_frontend_properties *p = fe-dtv_property_cache; + u32 freq = p-frequency / 1000; + u32 delsys = p-delivery_system; The delsys variable is unused, you can delete it.

Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

2012-03-21 Thread Jean Delvare
Hi Mauro, On Tue, 20 Mar 2012 09:17:54 -0300, Mauro Carvalho Chehab wrote: Em 20-03-2012 04:20, Jean Delvare escreveu: On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote: Yet, I'd be more happy if Jean's patch could check first if the status is below 0, in order to prevent a

Re: Move em27xx/em28xx webcams to a gspca subdriver ?

2012-03-21 Thread Mauro Carvalho Chehab
Em 21-03-2012 15:01, Frank Schäfer escreveu: Am 16.03.2012 23:18, schrieb Frank Schäfer: [Was: eMPIA EM2710 Webcam (em28xx) and LIRC] Continue this part of the discussion in a new thread... Am 15.03.2012 14:05, schrieb Mauro Carvalho Chehab: Em 15-03-2012 09:34, Frank Schäfer escreveu: ...

Re: [Linaro-mm-sig] [PATCH] [RFC] dma-buf: mmap support

2012-03-21 Thread Daniel Vetter
On Wed, Mar 21, 2012 at 10:46:14AM -0700, Rebecca Schultz Zavin wrote: I want to make sure I understand how this would work. I've been planning on making cache maintenance implicit, and most of the corresponding userspace components I've seen for android expect to do implicit cache

Re: [Linaro-mm-sig] [PATCH] [RFC] dma-buf: mmap support

2012-03-21 Thread Rebecca Schultz Zavin
On Wed, Mar 21, 2012 at 3:25 PM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Mar 21, 2012 at 10:46:14AM -0700, Rebecca Schultz Zavin wrote: I want to make sure I understand how this would work.  I've been planning on making cache maintenance implicit, and most of the corresponding userspace

Re: [Linaro-mm-sig] [PATCH] [RFC] dma-buf: mmap support

2012-03-21 Thread Daniel Vetter
On Wed, Mar 21, 2012 at 03:44:38PM -0700, Rebecca Schultz Zavin wrote: Couldn't this just as easily be handled by not having those mappings be mapped cached or write combine to userspace? They'd be coherent, just slow. I'm not sure we can actually say that all these cpu access are necessary

Re: [PATCH v2 1/1] media: video: s5p-g2d: Add support for FIMG2D v41 H/W logic

2012-03-21 Thread Ajay kumar
Hi Mr.Sakari On Sun, Mar 18, 2012 at 12:27 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Ajay, Thanks for the patch. I have a few comments below. On Sat, Mar 17, 2012 at 04:52:14PM +0530, Ajay Kumar wrote: Modify the G2D driver(which initially supported only FIMG2D v3 style H/W) to

[PATCH] usb: gadget/uvc: Remove non-required locking from 'uvc_queue_next_buffer' routine

2012-03-21 Thread Bhupesh Sharma
This patch removes the non-required spinlock acquire/release calls on 'queue_irqlock' from 'uvc_queue_next_buffer' routine. This routine is called from 'video-encode' function (which translates to either 'uvc_video_encode_bulk' or 'uvc_video_encode_isoc') in 'uvc_video.c'. As, the 'video-encode'