Re: [patch] [media] gspca: passing wrong length parameter to reg_w()

2012-05-02 Thread Jean-Francois Moine
On Wed, 2 May 2012 09:15:25 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: This looks like a cut an paste error. This is a two byte array but we use 8 as a length parameter. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- This is a static checker fix. I don't own the

Re: [patch] [media] gspca: passing wrong length parameter to reg_w()

2012-05-02 Thread Dan Carpenter
On Wed, May 02, 2012 at 08:47:58AM +0200, Jean-Francois Moine wrote: Thanks for the patch. The bug is very very old (6 years, at least - neither have I such a webcam). My guess is that it's harmless to write a few extra garbage bits, but it's still worth fixing as a cleanup. Maybe the fix

[GIT PATCHES FOR 3.4] gspca for_v3.4

2012-05-02 Thread Jean-Francois Moine
The following changes since commit 976a87b9ce3172065e21f0d136353a01df06d0d6: [media] gspca - sn9c20x: Change the exposure setting of Omnivision sensors (2012-04-09 14:22:52 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v3.4 for you to fetch

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-02 Thread Karl Kiniger
Please can someone shed a little light on this? Greatly appreciated, Karl On Tue 120424, Karl Kiniger wrote: Dear all, guvcview does not display the extra controls (focus, led etc) any more since kernel 3.2 an higher (Fedora 16, x86_64). after the various video modes it says: vid:046d

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-02 Thread Paulo Assis
Karl Hi, I'm using a 3.2 kernel and I haven't notice this problem, can you check the exact version that causes it. Regards, Paulo 2012/5/2 Karl Kiniger karl.kini...@med.ge.com: Please can someone shed a little light on this? Greatly appreciated, Karl On Tue 120424, Karl Kiniger wrote:

[GIT PULL for v3.5] (v2) uvcvideo fixes

2012-05-02 Thread Laurent Pinchart
Hi Mauro, Here's one more uvcvideo patch for v3.5. The first two patches have already been submitted in a previous pull request. The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907: [media] ngene: remove an unneeded condition (2012-04-26 15:29:23 -0300) are available

Re: omap3isp: isp_video_mbus_to_pix causes WARN_ON

2012-05-02 Thread Laurent Pinchart
Hi Chris, On Thursday 26 April 2012 10:54:58 Chris Whittenburg wrote: I'm using a 3.0.17 kernel on a dm3730 with a custom 8-bit grayscale sensor. When using a simple gstreamer pipeline to test: gst-launch -v v4l2src device=/dev/video2 !

Re: RFC: Improve VIDIOC_S_HW_FREQ_SEEK

2012-05-02 Thread Hans Verkuil
On Tuesday 01 May 2012 18:19:39 halli manjunatha wrote: On Tue, May 1, 2012 at 4:46 AM, Hans Verkuil hverk...@xs4all.nl wrote: Hi all! While working on a test function for the hardware seek functionality in v4l2-compliance I realized that the specification is rather vague and

Re: [PATCH 07/10] dvb-demux: add functionality to send raw payload to the dvr device

2012-05-02 Thread Patrick Boettcher
Hi Mike, On Tuesday 01 May 2012 06:12:22 Michael Krufky wrote: From: Michael Krufky mkru...@kernellabs.com If your driver needs to deliver the raw payload to userspace without passing through the kernel demux, use function: dvb_dmx_swfilter_raw I like this one very much. I had a background

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-02 Thread Karl Kiniger
Hi Paulo, I am running plain Fedora 16 on x86_64. The last kernel where UVC dyncontrols worked was 3.1.10-2. (If I remember correctly...) The first kernel with failing dyncontrols was 3.2.1-1 and all later kernels up to 3.3.2-6 fail as well. libwebcam version is libwebcam-0.2.0-4.20100322svn

[GIT PULL for v3.5] OMAP3 ISP patches

2012-05-02 Thread Laurent Pinchart
Hi Mauro, The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907: [media] ngene: remove an unneeded condition (2012-04-26 15:29:23 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git omap3isp-omap3isp-next Laurent Pinchart (17):

Re: Using UVC webcam gadget with a real v4l2 device

2012-05-02 Thread Laurent Pinchart
Hi Bhupesh, On Monday 30 April 2012 18:47:24 Bhupesh SHARMA wrote: On Monday, April 30, 2012 3:51 PM Laurent Pinchart wrote: On Thursday 26 April 2012 13:23:59 Bhupesh SHARMA wrote: Hi Laurent, Sorry to jump-in before your reply on my previous mail, but as I was studying the

Re: UVCvideo: Failed to resubmit video URB (-27) with Linux 3.3.3

2012-05-02 Thread Laurent Pinchart
Hi Anisse, On Thursday 26 April 2012 20:07:21 Anisse Astier wrote: Hi, I'm experiencing a problem with uvcvideo with kernel 3.3.3 and today's Linus' tree. Problem not reproduced in 3.2.15, so this could be labelled as a regression. See webcam lsusb and (verbose!) dmesg log in

[PATCH v3 1/1] v4l: drop v4l2_buffer.input and V4L2_BUF_FLAG_INPUT

2012-05-02 Thread Sakari Ailus
Remove input field in struct v4l2_buffer and flag V4L2_BUF_FLAG_INPUT which tells the former is valid. The flag is used by no driver currently. Also change the documentation accordingly. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-02 Thread Paulo Assis
karl, I've run some tests under ubuntu 12.04 with kernel 3.2.0 and everything seems to be working fine. I know some changes were made to the uvcvideo module regarding XU controls, but I was under the impression that they wouldn't break userspace. Logitech shutdown the quickcamteam site, so you

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-02 Thread Karl Kiniger
On Wed 120502, Paulo Assis wrote: karl, I've run some tests under ubuntu 12.04 with kernel 3.2.0 and everything seems to be working fine. I know some changes were made to the uvcvideo module regarding XU controls, but I was under the impression that they wouldn't break userspace. Logitech

HVR-1800 Analog Driver: MPEG video broken

2012-05-02 Thread sitten74490
I have been testing the latest cx23885 driver built from http://git.kernellabs.com/?p=stoth/cx23885-hvr1850-fixups.git;a=summary running on kernel 3.3.4 with my HVR-1800 (model 78521). I am able to watch analog TV with tvtime using the raw device, /dev/video0. But if I try to use it with the

RE: SoC i.mx35 userptr method failure while running capture-example utility

2012-05-02 Thread Alex Gershgorin
Hi Guennadi, Thanks for your quick response. ./capture-example -u -f -d /dev/video0 mx3-camera mx3-camera.0: MX3 Camera driver attached to camera 0 Failed acquiring VMA for vaddr 0x76cd9008 VIDIOC_QBUF error 22, Invalid arg It doesn't surprise me, that this doesn't work. capture-example

Re: HVR-1800 Analog Driver: MPEG video broken

2012-05-02 Thread Devin Heitmueller
On Wed, May 2, 2012 at 9:32 AM, sitten74...@mypacks.net wrote: I have been testing the latest cx23885 driver built from http://git.kernellabs.com/?p=stoth/cx23885-hvr1850-fixups.git;a=summary running on kernel 3.3.4 with my HVR-1800 (model 78521).  I am able to watch analog TV with tvtime

Error compiling tw68-v2 module (module_param / linux3.2)

2012-05-02 Thread Teun
I'm having problems compiling the tw68-v2. I looked up the code from the error messages, but I don't know anything about making linux driver modules. I can't find a lot about the module_param function, at least, not why this would be wrong. Can anyone give any comment on this? Thanks in

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-02 Thread Paulo Assis
Hi, yes, libwebcam depends on uvcvideo.h, I've only added this as a patch since it was missing from debian kernel headers at the time. I think you should be able to get it from there now, not sure if the new header breaks anything, I'll have to run some tests. The other patches are not needed, but

Re: [PATCH 07/10] dvb-demux: add functionality to send raw payload to the dvr device

2012-05-02 Thread Michael Krufky
On Wed, May 2, 2012 at 7:38 AM, Patrick Boettcher pboettc...@kernellabs.com wrote: Hi Mike, On Tuesday 01 May 2012 06:12:22 Michael Krufky wrote: From: Michael Krufky mkru...@kernellabs.com If your driver needs to deliver the raw payload to userspace without passing through the kernel

[PATCH v3 00/10] v4l2: OMAP4 ISS driver + Sensor + Board support

2012-05-02 Thread Sergio Aguirre
Hi everyone, It's been a long time since last version (5 months)! :) This is the third version of the OMAP4 ISS driver, which uses Media Controller and videobuf2 frameworks. This patchset should apply cleanly on top of v3.4-rc5 kernel tag. This driver attempts to provide an fully open source

[PATCH v3 01/10] mfd: twl6040: Fix wrong TWL6040_GPO3 bitfield value

2012-05-02 Thread Sergio Aguirre
The define should be the result of 1 Bit number. Bit number for GPOCTL.GPO3 field is 2, which results in 0x4 value. Signed-off-by: Sergio Aguirre saagui...@ti.com --- include/linux/mfd/twl6040.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH v3 03/10] OMAP4: Add base addresses for ISS

2012-05-02 Thread Sergio Aguirre
NOTE: This isn't the whole list of features that the ISS supports, but the only ones supported at the moment. Signed-off-by: Sergio Aguirre saagui...@ti.com --- arch/arm/mach-omap2/devices.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git

[PATCH v3 02/10] OMAP4: hwmod: Include CSI2A/B and CSIPHY1/2 memory sections

2012-05-02 Thread Sergio Aguirre
In memory, They are in this particular order: - CSI2A - CSIPHY1 - CSI2B - CSIPHY2 Signed-off-by: Sergio Aguirre saagui...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git

[PATCH v3 07/10] arm: omap4430sdp: Add support for omap4iss camera

2012-05-02 Thread Sergio Aguirre
This adds support for camera interface with the support for following sensors: - OV5640 - OV5650 Signed-off-by: Sergio Aguirre saagui...@ti.com --- arch/arm/mach-omap2/Kconfig| 16 + arch/arm/mach-omap2/Makefile |2 +

[PATCH v3 05/10] v4l: Add support for ov5640 sensor

2012-05-02 Thread Sergio Aguirre
This adds a very limited driver for ov5640, which only supports: - 2592x1944 @ ~7.5 fps - 1920x1080 @ ~15 fps, - 1280x720 @ ~24 fps, - 640x480 @ ~24 fps, - 320x240 @ ~24 fps, All in YUV422i format, using 1 CSI2 datalane @ 333 MHz. Signed-off-by: Sergio Aguirre saagui...@ti.com ---

[PATCH v3 08/10] arm: omap4panda: Add support for omap4iss camera

2012-05-02 Thread Sergio Aguirre
This adds support for camera interface with the support for following sensors: - OV5640 - OV5650 Signed-off-by: Sergio Aguirre saagui...@ti.com --- arch/arm/mach-omap2/Kconfig | 16 ++ arch/arm/mach-omap2/Makefile |1 +

[PATCH v3 09/10] omap2plus: Add support for omap4iss camera

2012-05-02 Thread Sergio Aguirre
Also add support for following sensors: - OV5640 - OV5650 Signed-off-by: Sergio Aguirre saagui...@ti.com --- arch/arm/configs/omap2plus_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig

[PATCH v3 10/10] arm: Add support for CMA for omap4iss driver

2012-05-02 Thread Sergio Aguirre
Signed-off-by: Sergio Aguirre saagui...@ti.com --- arch/arm/mach-omap2/devices.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 2b8cf73..5259691 100644 --- a/arch/arm/mach-omap2/devices.c +++

[PATCH v3 06/10] v4l: Add support for ov5650 sensor

2012-05-02 Thread Sergio Aguirre
Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/Kconfig |6 + drivers/media/video/Makefile |1 + drivers/media/video/ov5650.c | 733 ++ include/media/ov5650.h | 10 + 4 files changed, 750 insertions(+), 0

Re: [PATCH v3 00/10] v4l2: OMAP4 ISS driver + Sensor + Board support

2012-05-02 Thread Aguirre, Sergio
On Wed, May 2, 2012 at 10:15 AM, Sergio Aguirre saagui...@ti.com wrote: Hi everyone, It's been a long time since last version (5 months)! :) This is the third version of the OMAP4 ISS driver, which uses Media Controller and videobuf2 frameworks. This patchset should apply cleanly on top of

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-02 Thread Paulo Assis
OK, so UVCIOC_CTRL_ADD is no longer available, now we have: UVCIOC_CTRL_MAP and UVCIOC_CTRL_QUERY, so I guess some changes are needed, I'll try to fix this ASAP. Regards, Paulo 2012/5/2 Paulo Assis pj.as...@gmail.com: Hi, yes, libwebcam depends on uvcvideo.h, I've only added this as a patch

Re: HVR-1800 Analog Driver: MPEG video broken

2012-05-02 Thread sitten74490
In case it might be helpful, here's the output of v4l2-ctl -d /dev/video1 --log-status: http://pastebin.com/4iTcXDNP Thanks, Jonathan -Original Message- From: Devin Heitmueller dheitmuel...@kernellabs.com Sent: May 2, 2012 9:58 AM To: sitten74...@mypacks.net Cc:

cron job: media_tree daily build: WARNINGS

2012-05-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed May 2 19:00:16 CEST 2012 git hash:bcb2cf6e0bf033d79821c89e5ccb328bfbd44907 gcc version: i686-linux-gcc

[RFC v2 0/2] V4L2 IOCTL enum compat wrapper

2012-05-02 Thread Sakari Ailus
Hi all, This is my first intended-to-be-complete RFC patch to get rid of the enums in V4L2 IOCTL structs. The approach is the one outlined first by Mauro (AFAIR): URL:http://www.spinics.net/lists/linux-media/msg46504.html A set of compat structs (and compat IOCTLs) are created and there are a

[RFC v3 1/2] v4l: Do not use enums in IOCTL structs

2012-05-02 Thread Sakari Ailus
Replace enums in IOCTL structs by __u32. The size of enums is variable and thus problematic. Compatibility structs having exactly the same as original definition are provided for compatibility with old binaries with the required conversion code. Signed-off-by: Mauro Carvalho Chehab

[RFC v3 2/2] v4l: Implement compat functions for enum to __u32 change

2012-05-02 Thread Sakari Ailus
Implement compat functions to provide conversion between structs containing enums and those not. The functions are intended to be removed when the support for such old binaries is no longer necessary. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/Kconfig | 12 +

Re: HVR-1800 Analog Driver: MPEG video broken

2012-05-02 Thread sitten74490
I just tried again with a live CD running kernel 3.2 and got clean video with cat /dev/video1 /tmp/foo.mpg. So there is a definitely a regression here. Please let me know what I can do to help track it down. Regards, Jonathan -Original Message- From: sitten74...@mypacks.net Sent:

Re: [PATCH v3 07/10] arm: omap4430sdp: Add support for omap4iss camera

2012-05-02 Thread Sakari Ailus
Hi Sergio, Thanks for the patches!! On Wed, May 02, 2012 at 10:15:46AM -0500, Sergio Aguirre wrote: ... +static int sdp4430_ov_cam1_power(struct v4l2_subdev *subdev, int on) +{ + struct device *dev = subdev-v4l2_dev-dev; + int ret; + + if (on) { + if

Re: HVR-1800 Analog Driver: MPEG video broken

2012-05-02 Thread Devin Heitmueller
On Wed, May 2, 2012 at 3:23 PM, sitten74...@mypacks.net wrote: I just tried again with a live CD running kernel 3.2 and got clean video with cat /dev/video1 /tmp/foo.mpg.  So there is a definitely a regression here.   Please let me know what I can do to help track it down. I'm already about

Re: [RFC v3 1/2] v4l: Do not use enums in IOCTL structs

2012-05-02 Thread Sakari Ailus
Hi Hans, On Wed, May 02, 2012 at 10:45:22PM +0200, Hans Verkuil wrote: On Wed May 2 2012 21:13:47 Sakari Ailus wrote: Replace enums in IOCTL structs by __u32. The size of enums is variable and thus problematic. Compatibility structs having exactly the same as original definition are

[PATCH V3 4/5] [Documentation] Media: Update docs for V4L2 FM new features

2012-05-02 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com The list of new features - 1) New control class for FM RX 2) New FM RX CID's - De-Emphasis filter mode and RDS AF switch 3) New FM TX CID - RDS Alternate frequency set. Signed-off-by: Manjunatha Halli x0130...@ti.com ---

[PATCH V3 5/5] [Media] WL12xx: Add support for FM new features.

2012-05-02 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com This patch adds below features to TI's V4l2 FM driver for Wilink chipsets, 1) FM RX Set frequency allows to set frequency anywhere between 65.5 MHz till 108 MHz (if chip is Wilink8 then till 164.55 MHz) 2) FM RX seek caters for band

[PATCH V3 3/5] [Media] Add new CID for FM TX RDS Alternate Frequency

2012-05-02 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com Signed-off-by: Manjunatha Halli x0130...@ti.com --- drivers/media/video/v4l2-ctrls.c |1 + include/linux/videodev2.h|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-ctrls.c

[PATCH V3 0/5] [Media] Radio: Fixes and New features for FM

2012-05-02 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com Mauro and the list, This version 3 of patchset resolves the comments received from Han's on patchset v2. This patchset creates new control class 'V4L2_CTRL_CLASS_FM_RX' for FM RX, introduces 2 new CID's for FM RX and and 1 new CID for FM TX. Also adds 1

[PATCH V3 2/5] [Media] New control class and features for FM RX

2012-05-02 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com This patch creates new ctrl class for FM RX and adds new CID's for below FM features, 1) De-Emphasis filter mode 2) RDS AF switch Also this patch adds a field for band selection in struct v4l2_hw_freq_seek Signed-off-by: Manjunatha Halli

[PATCH V3 1/5] [Media] WL128x: Add support for FM TX RDS

2012-05-02 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com This patch adds support for following FM TX RDS features, 1. Radio Text 2. PS Name 3. PI Code 4. PTY Code. Along with above this patch fixes few other minor issues(like fm tx get frequency, unnecessary error messages etc).

Re: [RFC v3 1/2] v4l: Do not use enums in IOCTL structs

2012-05-02 Thread Mauro Carvalho Chehab
Hi Hans, Em 02-05-2012 17:45, Hans Verkuil escreveu: On Wed May 2 2012 21:13:47 Sakari Ailus wrote: Replace enums in IOCTL structs by __u32. The size of enums is variable and thus problematic. Compatibility structs having exactly the same as original definition are provided for compatibility

[PATCH] mt9v032: Correct the logic for the auto-exposure setting

2012-05-02 Thread Kartik Mohta
The driver uses the ctrl value passed in as a bool to determine whether to enable auto-exposure, but the auto-exposure setting is defined as an enum where AUTO has a value of 0 and MANUAL has a value of 1. This leads to a reversed logic where if you send in AUTO, it actually sets manual exposure

Re: [RFC v3 2/2] v4l: Implement compat functions for enum to __u32 change

2012-05-02 Thread Mauro Carvalho Chehab
Em 02-05-2012 16:13, Sakari Ailus escreveu: Implement compat functions to provide conversion between structs containing enums and those not. The functions are intended to be removed when the support for such old binaries is no longer necessary. This is not a full review of this patch, as

Re: [RFC v3 2/2] v4l: Implement compat functions for enum to __u32 change

2012-05-02 Thread Laurent Pinchart
Hi Mauro, On Wednesday 02 May 2012 19:32:23 Mauro Carvalho Chehab wrote: Em 02-05-2012 16:13, Sakari Ailus escreveu: Implement compat functions to provide conversion between structs containing enums and those not. The functions are intended to be removed when the support for such old

[PATCH] Add quirk for camera of Lenovo Thinkpad X220 Tablet

2012-05-02 Thread Jakob Haufe
--- lib/libv4lconvert/control/libv4lcontrol.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c index e802a90..f9fda71 100644 --- a/lib/libv4lconvert/control/libv4lcontrol.c +++

Re: [RFC v3 1/2] v4l: Do not use enums in IOCTL structs

2012-05-02 Thread Andy Walls
On Wed, 2012-05-02 at 19:17 -0300, Mauro Carvalho Chehab wrote: We can speed-up the conversions, with something like: enum foo { BAR }; if (sizeof(foo) != sizeof(u32)) call_compat_logic(). I suspect that sizeof() won't work inside a macro. sizeof() is evaluated at

Re: HVR-1600 QAM recordings with slight glitches in them

2012-05-02 Thread Brian J. Murrell
On 12-04-29 08:09 PM, Devin Heitmueller wrote: I don't know why you're not seeing valid data on femon with the 950q. It should be printing out fine, and it's on the same 0.1 dB scale. Try running just azap and see if the SNR is reported there. $ azap -c ~/last-channel-scan.prev 100-3 using