The intent here was to test that the flag was clear but the '!' has
higher precedence than the ''. I2C_M_RD is 0x1 so the current code is
equivalent to (!sgs[i].flags) ...
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I sent this originally on Wed, 25 Jan 2012 and Emil Goode sent
On Mon 28 May 2012 13:47:43 Federico Vaga wrote:
I didn't get any reply from Federico when I posted my concerns last
week, so that makes me unhappy as well.
I hope the author will fix these issues, but in the meantime this will
move it to staging waiting for further developments.
The
Hi Chris,
On Thursday 21 June 2012 09:38:11 Chris MacGregor wrote:
Hi. I was redirected to this list by a response to my post (below) on
the BeagleBoard group. I'm happy to help/cooperate/etc. in whatever way
I reasonably can.
Original Message
Hello, all.
I managed
Hi Hans,
I noticed there are two s_std ops in core and video for output. And
some drivers call video-s_std_out and then core-s_std in their S_STD
iotcl. Could anyone share me the story why we have
s_std_output/g_std_output/g_tvnorms_output ops in video instead of
making use of s_std/g_std in
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:21 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Add helper functions to make it easier to adapt drivers to vb2.
These helpers take care of core locking and check if the filehandle is the
owner of the queue.
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:17 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Split off the memory and type validation. This is done both from reqbufs and
create_bufs, and will also be done by vb2 helpers in a later patch.
Signed-off-by:
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:13 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Since this could theoretically change the debug value while in the middle
of v4l2-ioctl.c, we make a copy of vfd-debug to ensure consistent debug
behavior.
In my
On Wed 27 June 2012 11:37:24 Scott Jiang wrote:
Hi Hans,
I noticed there are two s_std ops in core and video for output. And
some drivers call video-s_std_out and then core-s_std in their S_STD
iotcl. Could anyone share me the story why we have
s_std_output/g_std_output/g_tvnorms_output ops
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:26 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/v4l2-dev.c | 25 -
1 file changed, 24 insertions(+), 1
2012/6/27 Hans Verkuil hverk...@xs4all.nl:
On Wed 27 June 2012 11:37:24 Scott Jiang wrote:
Hi Hans,
I noticed there are two s_std ops in core and video for output. And
some drivers call video-s_std_out and then core-s_std in their S_STD
iotcl. Could anyone share me the story why we have
On Wed 27 June 2012 11:42:31 Laurent Pinchart wrote:
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:21 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Add helper functions to make it easier to adapt drivers to vb2.
These helpers take care of core
On Wed 27 June 2012 11:52:10 Laurent Pinchart wrote:
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:17 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Split off the memory and type validation. This is done both from reqbufs and
create_bufs, and will also
On Wed 27 June 2012 11:54:40 Laurent Pinchart wrote:
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:13 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Since this could theoretically change the debug value while in the middle
of v4l2-ioctl.c, we make a
Laurent Pinchart wrote:
Hi everybody,
Not much to be said here. The first patch is needed by the second, which is
described in its commit message. I'd like to get this into v3.6.
Laurent Pinchart (2):
omap3isp: Don't access ISP_CTRL directly in the statistics modules
omap3isp:
On Wed 27 June 2012 11:59:06 Laurent Pinchart wrote:
Hi Hans,
Thanks for the patch.
On Friday 22 June 2012 14:21:26 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/v4l2-dev.c | 25
On Wednesday 27 June 2012 12:37:21 Hans Verkuil wrote:
On Wed 27 June 2012 11:52:10 Laurent Pinchart wrote:
On Friday 22 June 2012 14:21:17 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Split off the memory and type validation. This is done both from reqbufs
and
Hi Hans,
On Wednesday 27 June 2012 12:38:54 Hans Verkuil wrote:
On Wed 27 June 2012 11:54:40 Laurent Pinchart wrote:
On Friday 22 June 2012 14:21:13 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Since this could theoretically change the debug value while in the
On Wed 27 June 2012 12:14:34 Scott Jiang wrote:
2012/6/27 Hans Verkuil hverk...@xs4all.nl:
On Wed 27 June 2012 11:37:24 Scott Jiang wrote:
Hi Hans,
I noticed there are two s_std ops in core and video for output. And
some drivers call video-s_std_out and then core-s_std in their S_STD
Hi Laurent,
Thanks for the patch.
Laurent Pinchart wrote:
The bpp field currently stores the sample width and is aligned to the
next multiple of 8 bits when computing data size in memory. This won't
work anymore for YUYV8_2X8 formats. Split the bpp field into a sample
width and a bits per
Laurent Pinchart wrote:
Those features are half-implemented and not used. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Thanks!
Acked-by: Sakari Ailus sakari.ai...@iki.fi
--
Sakari Ailus
sakari.ai...@iki.fi
--
To unsubscribe from this list: send the
Laurent Pinchart wrote:
The structure is only used to store configuration data and pass it to
CCDC configuration functions. Access the data directly from the
locations that need it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Thanks!!
Acked-by: Sakari Ailus
Hi Sakari,
Thanks for the review.
On Wednesday 27 June 2012 14:07:51 Sakari Ailus wrote:
Laurent Pinchart wrote:
The bpp field currently stores the sample width and is aligned to the
next multiple of 8 bits when computing data size in memory. This won't
work anymore for YUYV8_2X8 formats.
Laurent Pinchart wrote:
Enable the bridge automatically when the input format is YUYV8 or UYVY8.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Thanks for the patch, Laurent!
Acked-by: Sakari Ailus sakari.ai...@iki.fi
--
Sakari Ailus
sakari.ai...@iki.fi
--
To
On Wednesday 27 June 2012 13:54:30 Laurent Pinchart wrote:
Hi Sakari,
Thanks for the review.
On Wednesday 27 June 2012 14:07:51 Sakari Ailus wrote:
Laurent Pinchart wrote:
The bpp field currently stores the sample width and is aligned to the
next multiple of 8 bits when computing
Laurent Pinchart wrote:
Hi Sakari,
Thanks for the review.
On Wednesday 27 June 2012 14:07:51 Sakari Ailus wrote:
Laurent Pinchart wrote:
The bpp field currently stores the sample width and is aligned to the
next multiple of 8 bits when computing data size in memory. This won't
work
On 06/27/2012 07:21 AM, Thomas Mair wrote:
On 26.06.2012 19:17, poma wrote:
On 05/28/2012 04:48 PM, Thomas Mair wrote:
On 28.05.2012 08:58, Thomas Mair wrote:
On 26.05.2012 04:47, poma wrote:
On 05/20/2012 11:12 PM, Thomas Mair wrote:
On 20.05.2012 22:08, Antti Palosaari wrote:
On
Hi Federico,
Any news on this?
Not at the moment. I'll ask for detail :)
--
Federico Vaga
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Em 27-06-2012 06:06, Dan Carpenter escreveu:
The intent here was to test that the flag was clear but the '!' has
higher precedence than the ''. I2C_M_RD is 0x1 so the current code is
equivalent to (!sgs[i].flags) ...
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I sent this
Hi Ivan,
On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote:
On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote:
On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote:
On Mon, Jun 18, 2012 at 04:30:53PM +0200, Laurent Pinchart wrote:
Rearrange the CFA interpolation
Hi,
On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote:
Hi Sakari,
On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote:
On Mon, Jun 18, 2012 at 04:30:53PM +0200, Laurent Pinchart wrote:
Rearrange the CFA interpolation coefficients table based on the Bayer
pattern. Modifying
Hi Sakari,
On Tuesday 26 June 2012 22:01:14 Sakari Ailus wrote:
On Tue, Jun 26, 2012 at 03:30:09AM +0200, Laurent Pinchart wrote:
On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote:
On Mon, Jun 18, 2012 at 04:30:53PM +0200, Laurent Pinchart wrote:
Rearrange the CFA interpolation
This reverts commit feed0258e11e04b7e0, as the same issues
are already covered in another version of that patch that
was also applied (579e92ffac65c717c9c8a50feb755a).
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
This patch adds locking for open(), close(), poll() and mmap()
file operations in the driver as a follow up to the changes
done in commit 5126f2590bee412e3053de851cb07f531
v4l2-dev: add flag to have the core lock all file operations.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
commit 5126f2590bee412e3053de851cb07f531e4be36a
v4l2-dev: add flag to have the core lock all file operations
introduced an additional bit flag (V4L2_FL_LOCK_ALL_FOPS) that
should be set by drivers that use the v4l2 core lock for all file
operations. Since this driver has been merged at the same
Hi,
On Wed, 2012-06-27 at 15:54 +0200, Laurent Pinchart wrote:
Hi Ivan,
On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote:
On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote:
On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote:
On Mon, Jun 18, 2012 at 04:30:53PM
On Mon, Jun 25, 2012 at 6:09 PM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
Hi Ezequiel,
a few minor comments below...
Hi Sylwester,
I'm OK with every comment you made.
Except for the -ETIMEDOUT.
I'm still not 100% convinced, but I'll take your word for it.
Also, is there any
Hi Ivan,
On Wednesday 27 June 2012 17:30:32 Ivan T. Ivanov wrote:
On Wed, 2012-06-27 at 15:54 +0200, Laurent Pinchart wrote:
On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote:
On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote:
On Saturday 23 June 2012 11:22:37 Sakari Ailus
Hi Laurent,
On Wed, 2012-06-27 at 16:42 +0200, Laurent Pinchart wrote:
Hi Ivan,
On Wednesday 27 June 2012 17:30:32 Ivan T. Ivanov wrote:
On Wed, 2012-06-27 at 15:54 +0200, Laurent Pinchart wrote:
On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote:
On Tue, 2012-06-26 at 03:30
On 06/27/2012 04:40 PM, Ezequiel Garcia wrote:
Hi Sylwester,
I'm OK with every comment you made.
Except for the -ETIMEDOUT.
I'm still not 100% convinced, but I'll take your word for it.
It looked most appropriate to me, however I didn't really analyse
very deeply the whole driver to see
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de
---
drivers/media/video/omap3isp/ispqueue.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
This comment looks like it was a copy-paste from the description of qbuf.
diff --git
Manu,
On Wed, Jun 27, 2012 at 9:59 AM, Manu Abraham abraham.m...@gmail.com wrote:
Wonderful, instead of ignoring the return value, you ignored the whole
function
itself. Most of the demodulator registers are R-M-x registers. The patch
brings
in unwanted side-effects of R-M-x.
Sorry for
Hi Mauro,
This patchset cleans the i2c part of some drivers.
This issue was recently reported by Dan Carpenter [1],
and revealed wrong (and harmless) usage of struct i2c_algo_bit_data.
This series consist in two kinds of patches:
- remove one unused function
- remove unused field i2c_algo
-
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
This function has no users, so it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/saa7164/saa7164-i2c.c |9 -
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git
Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx23885/cx23885-i2c.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git
Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx231xx/cx231xx-i2c.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git
Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/saa7164/saa7164-i2c.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git
Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx25821/cx25821-i2c.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Wed Jun 27 19:00:22 CEST 2012
git hash:5472d3f17845c4398c6a510b46855820920c2181
gcc version: i686-linux-gcc
Hi Dima,
On Tuesday 26 June 2012 13:53:34 Dima Zavin wrote:
On Tue, Jun 26, 2012 at 2:40 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On Tue 26 June 2012 11:11:06 Laurent Pinchart wrote:
On Tuesday 26 June 2012 10:40:44 Tomasz Stanislawski wrote:
Hi Dima Zavin,
Thank you for the patch
Hi
El 27/06/12 01:52, Devin Heitmueller escribió:
On Tue, Jun 26, 2012 at 11:40 PM, Alfredo Jesús Delaiti
alfredodela...@netscape.net wrote:
The problem was that tvtime was set to 768, by passing a resolution to 720
was solved. Sorry for not having tried before.
With a resolution of 720 pixels
Hi Guennadi,
Thanks for the review.
On Thursday 21 June 2012 14:28:04 Guennadi Liakhovetski wrote:
On Wed, 23 May 2012, Laurent Pinchart wrote:
The g_mbus_fmt operation only needs to return the current mbus frame
format and doesn't need to configure the hardware to do so. Fix it to
avoid
Remove variable and ignore return value of stv090x_chk_signal().
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/dvb/frontends/stv090x.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi Guennadi,
Thanks for the review.
On Thursday 21 June 2012 23:15:14 Guennadi Liakhovetski wrote:
On Wed, 23 May 2012, Laurent Pinchart wrote:
Instead of forcing all soc-camera drivers to go through the mid-layer to
handle power management, create soc_camera_power_[on|off]() functions
Here is my list of needed DVB core related changes. Feel free to comment
- what are not needed or what you would like to see instead. I will try
to implement what I can (and what I like most interesting :).
general validly checking for demodulator callback input values
Hey Peter,
On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
- no_signal = stv090x_chk_signal(state);
+ (void) stv090x_chk_signal(state);
Why are you casting return to void? I can't see there is a reason to it.
Hi all,
I would like to see some debug messages from the dib0700 driver.
I have tried to enable debug messages like this, following the instructions
found here:
http://www.linuxtv.org/wiki/index.php/Template:Making-it-work:dvb-usb-dib0700
# rmmod dvb_usb_dib0700
# insmod
60 matches
Mail list logo
