Re: [PATCH 2/2] staging: media: cxd2099: use kzalloc to allocate ci pointer of type struct cxd in cxd2099_attach

Hello Ezequiel, On Sun, Aug 5, 2012 at 12:24 AM, Ezequiel Garcia wrote: > Hi Devendra, > > On Sat, Aug 4, 2012 at 3:12 PM, Devendra Naga > wrote: >> >> mutex_init(&ci->lock); >> memcpy(&ci->cfg, cfg, sizeof(struct cxd2099_cfg)); > > While you're still looking at this driver, perh

[PATCH 1/5] [media] dvb-usb-v2: Fix cypress firmware compilation

ERROR: "usbv2_cypress_load_firmware" [drivers/media/dvb/dvb-usb-v2/dvb-usb-az6007.ko] undefined! Cypress fimware will never be compiled properly, as the Makefile rule is wrong. Cc: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb/dvb-usb-v2/Makefile | 3 ++- 1 file c

[PATCH 2/5] [media] dvb-usb-v2: Don't ask user to select Cypress firmware module

The dvb-usb-v2 cypress firmware module is not optional, as drivers won't work without it. So, instead of opening a menu for the user to manually select, let the drivers that need it to select, hiding this option from the Kconfig menu. Cc: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 0/5] Convert az6007 to dvb-usb-v2

Now that dvb-usb-v2 patches got merged, convert az6007 to use it, as, in thesis, several core bugs at dvb-usb were fixed. Also, driver became a little more simple than before, as the number of lines reduced a little bit. No noticeable changes should be noticed... I hope ;) Mauro Carvalho Chehab

[PATCH 3/5] [media] az6007: convert it to use dvb-usb-v2

Change it to use dvb-usb-v2. The driver should be working as before. The only functional changes should be at the driver debug logs. This driver needs the cypress firmware load, so, auto-selects it. Cc: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb/dvb-usb-v2/Kconf

[PATCH 4/5] [media] az6007: fix the I2C W+R logic

The test for I2C W+R will never be true. Fix it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb/dvb-usb-v2/az6007.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb/dvb-usb-v2/az6007.c b/drivers/media/dvb/dvb-usb-v2/az6007.c index 9d2ad49..35ed91

[PATCH 5/5] [media] az6007: Fix the number of parameters for QAM setup

Remove those warning messages: [ 121.696758] drxk: SCU_RESULT_INVPAR while sending cmd 0x0203 with params: [ 121.703401] drxk: 02 00 00 00 10 00 07 00 03 02.. [ 121.703587] drxk: Warning -22 on QAMDemodulatorCommand Signed-off-by: Mauro Carvalho Chehab --- drivers/

Re: boot slow down

On 08/04/12 13:42, Andy Walls wrote: > James wrote: > >> There's a big pause before the 'unable' >> >> [2.243856] usb 4-1: Manufacturer: Logitech >> [ 62.739097] cx25840 6-0044: unable to open firmware >> v4l-cx23885-avcore-01.fw >> >> >> I have a cx23885 >> cx23885[0]: registered device vi

Re: boot slow down

On 08/04/12 13:42, Andy Walls wrote: > James wrote: > >> There's a big pause before the 'unable' >> >> [2.243856] usb 4-1: Manufacturer: Logitech >> [ 62.739097] cx25840 6-0044: unable to open firmware >> v4l-cx23885-avcore-01.fw >> >> >> I have a cx23885 >> cx23885[0]: registered device vi

Re: [PATCH 2/2] staging: media: cxd2099: use kzalloc to allocate ci pointer of type struct cxd in cxd2099_attach

Hi Devendra, On Sat, Aug 4, 2012 at 3:12 PM, Devendra Naga wrote: > > mutex_init(&ci->lock); > memcpy(&ci->cfg, cfg, sizeof(struct cxd2099_cfg)); While you're still looking at this driver, perhaps you can change the memcpy with a plain struct assignment (if you feel like). It's r

[PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

From: Julia Lawall Using devm_kzalloc and devm_clk_get simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered after the handler's data argument had been freed. The problem of a free after a devm_request_irq wa

[PATCH 2/2] staging: media: cxd2099: use kzalloc to allocate ci pointer of type struct cxd in cxd2099_attach

this does kmalloc and followed by memset, calling kzalloc will actually sets the allocated memory to zero, use kzalloc instead Signed-off-by: Devendra Naga --- drivers/staging/media/cxd2099/cxd2099.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/c

[PATCH 1/2] staging: media: cxd2099: fix sparse warnings in cxd2099_attach

The following sparse warnings were fixed drivers/staging/media/cxd2099/cxd2099.c:686:26: warning: Using plain integer as NULL pointer drivers/staging/media/cxd2099/cxd2099.c:691:24: warning: Using plain integer as NULL pointer drivers/staging/media/cxd2099/cxd2099.c:696:24: warning: Using plain

Re: boot slow down

James wrote: >There's a big pause before the 'unable' > >[2.243856] usb 4-1: Manufacturer: Logitech >[ 62.739097] cx25840 6-0044: unable to open firmware >v4l-cx23885-avcore-01.fw > > >I have a cx23885 >cx23885[0]: registered device video0 [v4l2] > >Is there any way to stop it from trying t

Re: boot slow down

Hello James, On Sat, Aug 4, 2012 at 12:52 PM, James wrote: > There's a big pause before the 'unable' > > [2.243856] usb 4-1: Manufacturer: Logitech > [ 62.739097] cx25840 6-0044: unable to open firmware > v4l-cx23885-avcore-01.fw > > > I have a cx23885 > cx23885[0]: registered device video

boot slow down

There's a big pause before the 'unable' [2.243856] usb 4-1: Manufacturer: Logitech [ 62.739097] cx25840 6-0044: unable to open firmware v4l-cx23885-avcore-01.fw I have a cx23885 cx23885[0]: registered device video0 [v4l2] Is there any way to stop it from trying to load the firmware? What

Re: [RFC] media DT bindings

On Wed, 1 Aug 2012, Laurent Pinchart wrote: > Hi Guennadi, > > On Wednesday 01 August 2012 08:47:20 Guennadi Liakhovetski wrote: > > On Tue, 31 Jul 2012, Laurent Pinchart wrote: > > > On Tuesday 31 July 2012 14:39:07 Guennadi Liakhovetski wrote: > > > > On Tue, 31 Jul 2012, Laurent Pinchart wrote

Re: [PATCH] em28xx: Fix height setting on non-progressive captures

> >> Wait a minute, unless I completely misunderstood the bug (which is > >> possible), > >> I think this patch is straightforward. > >> > >> By the look of this hunk on commit c2a6b54a: > >> > >> -8<-- > >> diff --git a/drivers/media/video/e