question about drivers/media/dvb-frontends/rtl2830.c

2012-08-26 Thread Julia Lawall
The function rtl2830_init contains the code: buf[0] = tmp 6; buf[0] = (if_ctl 16) 0x3f; buf[1] = (if_ctl 8) 0xff; buf[2] = (if_ctl 0) 0xff; Is there any purpose to initializing buf[0] twice? julia -- To unsubscribe from this list: send the line

Re: question about drivers/media/dvb-frontends/rtl2830.c

2012-08-26 Thread Andy Walls
Julia Lawall julia.law...@lip6.fr wrote: The function rtl2830_init contains the code: buf[0] = tmp 6; buf[0] = (if_ctl 16) 0x3f; buf[1] = (if_ctl 8) 0xff; buf[2] = (if_ctl 0) 0xff; Is there any purpose to initializing buf[0] twice? julia -- To

[Bug] gspca_zc3xx v.2.14.0 Auto Gain is OFF

2012-08-26 Thread Sam Bulka
This is a bug report for gspca_zc3xx v.2.14.0 webcam driver installed as a module on ArchLinux plug computer, kernel 3.5.2-1-ARCH [root@alarm ~]# dmesg [ 15.271381] gspca_main: v2.14.0 registered [ 15.303224] gspca_main: gspca_zc3xx-2.14.0 probing 046d:08d7 [ 16.211715] fuse init (API

Re: [Bug] gspca_zc3xx v.2.14.0 Auto Gain is OFF (Chipset Config)

2012-08-26 Thread Sam Bulka
Webcam Chipset Config for reference: Key Name: HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Class \{6BDD1FC6-810F-11D0-BEC7-08002BE2092F}\0001 Class Name:NO CLASS Last Write Time: 6/25/2012 - 7:08 PM Value 0 Name:CoInstallers32 Type:REG_MULTI_SZ

Re: [Bug] gspca_zc3xx v.2.14.0 Auto Gain is OFF

2012-08-26 Thread Sam Bulka
Registry Data for reference: Image Sensor Config Key Name: HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Class \{6BDD1FC6-810F-11D0-BEC7-08002BE2092F}\0001 Class Name: NO CLASS Last Write Time: 6/25/2012 - 7:08 PM Value 0 Name: CoInstallers32 Type: REG_MULTI_SZ Data:

Re: question about drivers/media/dvb-frontends/rtl2830.c

2012-08-26 Thread Antti Palosaari
On 08/26/2012 02:20 PM, Andy Walls wrote: Julia Lawall julia.law...@lip6.fr wrote: The function rtl2830_init contains the code: buf[0] = tmp 6; buf[0] = (if_ctl 16) 0x3f; buf[1] = (if_ctl 8) 0xff; buf[2] = (if_ctl 0) 0xff; Is there any purpose to

[PATCH] drivers/media/dvb-frontends/rtl2830.c: correct double assignment

2012-08-26 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr The double assignment is meant to be a bit-or to combine two values. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression i; @@ *i = ...; i = ...; // /smpl Signed-off-by:

Re: question about drivers/media/dvb-frontends/rtl2830.c

2012-08-26 Thread Julia Lawall
On Sun, 26 Aug 2012, Antti Palosaari wrote: On 08/26/2012 02:20 PM, Andy Walls wrote: Julia Lawall julia.law...@lip6.fr wrote: The function rtl2830_init contains the code: buf[0] = tmp 6; buf[0] = (if_ctl 16) 0x3f; buf[1] = (if_ctl 8) 0xff; buf[2] =

Re: [PATCH] drivers/media/dvb-frontends/rtl2830.c: correct double assignment

2012-08-26 Thread Antti Palosaari
On 08/26/2012 07:15 PM, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr The double assignment is meant to be a bit-or to combine two values. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression i; @@

Re: [PATCH] Add support to Avermedia Twinstar double tuner in af9035

2012-08-26 Thread Antti Palosaari
On 08/25/2012 10:05 PM, Jose Alberto Reguero wrote: This patch add support to the Avermedia Twinstar double tuner in the af9035 driver. This time the patch inline because it was rejected. Also patch was malformed. Signed-off-by: Jose Alberto Reguero jaregu...@telefonica.net

Re: [PATCH 0/1] S3C244X/S3C64XX SoC camera host interface driver

2012-08-26 Thread Sylwester Nawrocki
Hi Tomasz, On 08/12/2012 12:22 AM, Tomasz Figa wrote: On Saturday 11 of August 2012 21:32:15 Sylwester Nawrocki wrote: On 08/11/2012 08:39 PM, Tomasz Figa wrote: Hi, On Saturday 11 of August 2012 20:06:13 Sylwester Nawrocki wrote: Hi all, This patch adds a driver for Samsung

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-26 Thread Frank Schäfer
Sorry for the delayed reply, I got distracted by something with higher prority. Am 22.08.2012 20:15, schrieb Mauro Carvalho Chehab: Em 22-08-2012 04:53, Frank Schäfer escreveu: Am 21.08.2012 19:29, schrieb Mauro Carvalho Chehab: Hmm... before reading the rest of this email... I found some

Re: [PATCH RFC 1/4] V4L: Add V4L2_CID_FRAMESIZE image source class control

2012-08-26 Thread Sylwester Nawrocki
Hi Sakari, On 08/25/2012 12:51 AM, Sakari Ailus wrote: --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -727,6 +727,7 @@ const char *v4l2_ctrl_get_name(u32 id) case V4L2_CID_VBLANK: return Vertical Blanking; case

Terratec H7 aka az6007 with CI

2012-08-26 Thread Roger Mårtensson
Hello! Just a reminder that az6007 with CI still isn't working 100% with Kaffeine. But since I use my device with MythTV that uses the same usage pattern as my workaround for Kaffeine it works like a charm. The pattern are: * Open up device / Start Kaffeine * Tune to encrypted channel /

cron job: media_tree daily build: WARNINGS

2012-08-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Aug 26 19:00:20 CEST 2012 git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324 gcc version: i686-linux-gcc

Re: RFC: Core + Radio profile

2012-08-26 Thread Andy Walls
Hi Hans, On Sat, 2012-08-25 at 09:21 +0200, Hans Verkuil wrote: On Sat August 25 2012 02:37:15 Andy Walls wrote: On Wed, 2012-08-22 at 11:40 +0200, Hans Verkuil wrote: This RFC is my attempt to start this process by describing three profiles: the core profile that all drivers must

[PATCH] v2 Add support to Avermedia Twinstar double tuner in af9035

2012-08-26 Thread Jose Alberto Reguero
This patch add support to the Avermedia Twinstar double tuner in the af9035 driver. Version 2 of the patch with suggestions of Antti. Signed-off-by: Jose Alberto Reguero jaregu...@telefonica.net Jose Alberto diff -upr linux/drivers/media/dvb-frontends/af9033.c

patch idea

2012-08-26 Thread James
If the driver is built into kernel it causes a timeout because it relies on udev which is not initialized yet (that is the theory). Regardless, the timeout is not needed except to load the firmware to provide analog reception. I doubt anyone who compiles it in the kernel needs the firmware. I

Re: RFC: Core + Radio profile

2012-08-26 Thread Andy Walls
On Fri, 2012-08-24 at 14:31 +0200, Hans Verkuil wrote: Hi Mauro, Thanks for your review! On Wed August 22 2012 15:42:26 Mauro Carvalho Chehab wrote: Em 22-08-2012 07:11, Hans Verkuil escreveu: Also note that the core profile description is more strict than the spec. IMO, that's