Re: [RFC 0/5] Generic panel framework

2012-09-04 Thread Zhou Zhu
Hi Laurent, Basically I agree that we need a common panel framework. I just have some questions: 1. I think we should add color format in videomode - if we use such common video mode structure shared across subsystems. In HDMI, colors are bind with timings tightly. We need a combined videomode wi

Re: [RFC 1/5] video: Add generic display panel core

2012-09-04 Thread Sascha Hauer
Hi Laurent, On Fri, Aug 17, 2012 at 02:49:39AM +0200, Laurent Pinchart wrote: > +/** > + * panel_get_modes - Get video modes supported by the panel > + * @panel: The panel > + * @modes: Pointer to an array of modes > + * > + * Fill the modes argument with a pointer to an array of video modes. The

RFC: use of timestamp/sequence in v4l2_buffer

2012-09-04 Thread Hans Verkuil
Hi all, During the Media Workshop last week we discussed how the timestamp and sequence fields in struct v4l2_buffer should be used. While trying to document the exact behavior I realized that there are a few missing pieces. Open questions with regards to the sequence field: 1) Should the first

[PATCH 2/3] drivers/media/rc/ati_remote.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 1/3] drivers/media/rc/redrat3.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 3/3] drivers/media/platform/davinci/vpfe_capture.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

Re: [RFC PATCH] [media] rc: filter out not allowed protocols when decoding

2012-09-04 Thread Sean Young
On Tue, Sep 04, 2012 at 11:06:07AM +0800, Changbin Du wrote: > > > mutex_lock(&ir_raw_handler_lock); > > > - list_for_each_entry(handler, &ir_raw_handler_list, list) > > > - handler->decode(raw->dev, ev); > > > + list_for_each_entry(handler,

Re: RFC: use of timestamp/sequence in v4l2_buffer

2012-09-04 Thread Rémi Denis-Courmont
Le mardi 4 septembre 2012 13:38:06, Hans Verkuil a écrit : > 7) Should the timestamp field always be monotonically increasing? Or it is > possible to get timestamps that jump around? This makes sense for encoders > that create B-frames referring to frames captured earlier than an I-frame. I would

Re: [PATCHv3 2/9] ir-rx51: Handle signals properly

2012-09-04 Thread Sean Young
On Mon, Sep 03, 2012 at 11:41:55PM +0200, David Härdeman wrote: > Hej, > > On Mon, Sep 03, 2012 at 01:36:53PM +0100, Sean Young wrote: > >On Sun, Sep 02, 2012 at 11:08:20PM +0300, Timo Kokkonen wrote: > >> I guess the assumption is to avoid > >> breaking the transmission in the middle in case the

[GIT PULL FOR v3.6] VIDIOC_OVERLAY regression fix

2012-09-04 Thread Hans Verkuil
Hi Mauro, While working on something else I suddenly saw that the VIDIOC_OVERLAY support was broken in 3.6. The vidioc_overlay op in v4l2-ioctls.h receives an unsigned int, whereas the ioctl table in v4l2-ioctls.c assumed that it would be an unsigned int pointer. To fix this a small conversion

[PATCH] cx88: Fix reset delays

2012-09-04 Thread Alan Cox
From: Alan Cox This was reported in March 2011 by Mirek Slugen, and a simple fix posted at the time then never got fixed and applied. The bug is still present. Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=37703 Signed-off-by: Alan Cox --- drivers/media/pci/cx88/cx88-cards.c |

[PATCH] tlg2300: fix missing check for audio creation

2012-09-04 Thread Alan Cox
From: Alan Cox If we fail to set up the capture device we go through negative indexes and badness happens. Add the missing test. Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44551 Signed-off-by: Alan Cox --- drivers/media/usb/tlg2300/pd-alsa.c |4 1 file changed, 4 inser

[PATCH 2/5] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 1/5] drivers/media/platform/davinci/vpbe.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 4/5] drivers/media/platform/vino.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 3/5] drivers/media/platform/s5p-tv/mixer_video.c: fix error return code

2012-09-04 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

Re: [PATCH v4] media: v4l2-ctrls: add control for dpcm predictor

2012-09-04 Thread Sakari Ailus
Hi Prabhakar, Thanks for the patch. I've got a few comments below. On Tue, Sep 04, 2012 at 11:07:52AM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add V4L2_CID_DPCM_PREDICTOR control of type menu, which > determines the dpcm predictor. The predictor can be either > simple or advanced.

cron job: media_tree daily build: WARNINGS

2012-09-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Sep 4 19:00:18 CEST 2012 git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324 gcc version: i686-linux-gcc (GC

SAA7231 chipset support

2012-09-04 Thread Wombachi
Hi, Google tries to convince me that the Philips / NXP / Trident / SigmaDesigns SAA7231 chip is not (and will probably not be) supported on Linux (mostly because of bad will from the hardware companies). Could you please confirm that this chip is not (and will probably not be) supported [1] ?

Re: [PATCH v4] media: v4l2-ctrls: add control for dpcm predictor

2012-09-04 Thread Prabhakar Lad
Hi Sakari, Thanks for the review. On Wednesday 05 September 2012 12:42 AM, Sakari Ailus wrote: > Hi Prabhakar, > > Thanks for the patch. I've got a few comments below. > > On Tue, Sep 04, 2012 at 11:07:52AM +0530, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add V4L2_CID_DPCM_PREDICTOR c