The addr parameter may not page aligned eg. when it's come from
vfb_mmap():vma->vm_start in video driver.
This patch fix the check in remap_pfn_range() else some driver like v4l2 will
fail in this function while calling mmap() on nommu arch like blackfin and st.
Reported-by: Bhupesh SHARMA
Repor
Hi Mauro,
Two drivers, au0828 and cx2341xx depend on the DVB_CAPTURE_DRIVERS config
option, which no longer exists. So au0828 and the DVB part of cx231xx are
no longer built. Should this dependency be removed or was it renamed?
Can you take a look at it?
Thanks!
Hans
--
To unsubscribe f
Hello
I'm trying to use dual DVB-T tuner based on ITE9135 tuner. I use Debian
kernel 3.5-trunk-686-pae. My motherboard is AsRock E350M1 (no USB3 ports).
Tuner is detected ok, see log at the end of post.
When I try to scan channels, bug happens:
Sep 11 17:16:31 wuwek kernel: [ 209.291329] ehci_
On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote:
> diff --git a/drivers/media/dvb-frontends/lg2160.c
> b/drivers/media/dvb-frontends/lg2160.c
> index cc11260..748da5d 100644
> --- a/drivers/media/dvb-frontends/lg2160.c
> +++ b/drivers/media/dvb-frontends/lg2160.c
> @@ -1451,7
>
> Now, I see that the requested videobuffers are correctly allocated via
> 'vb2_dma_contig_alloc'
> call (see [3] for reference). But the MMAP call fails in
> 'vb2_dma_contig_alloc' function
> in mm/nommu.c (see [4] for reference) when it tries to make the following
> check:
>
> if (ad
Hi Scott,
> -Original Message-
> From: Scott Jiang [mailto:scott.jiang.li...@gmail.com]
> Sent: Wednesday, September 12, 2012 3:09 PM
> To: Bhupesh SHARMA
> Cc: linux-media@vger.kernel.org; Laurent Pinchart; Armando VISCONTI;
> Shiraz HASHIM; m.szyprow...@samsung.com; uclinux-dist-
> de...
Em 12-09-2012 04:01, Hans Verkuil escreveu:
> Hi Mauro,
>
> Two drivers, au0828 and cx2341xx depend on the DVB_CAPTURE_DRIVERS config
> option, which no longer exists. So au0828 and the DVB part of cx231xx are
> no longer built. Should this dependency be removed or was it renamed?
Thanks for repo
This symbol got removed by menu reorganization; just depending on
DVB_CORE is enough.
Reported-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/au0828/Kconfig | 1 -
drivers/media/usb/cx231xx/Kconfig | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git
On 11/09/12 19:38, Mauro Carvalho Chehab wrote:
> Em 16-08-2012 22:35, Antti Palosaari escreveu:
>> [snip]
>> +Possible values: 0, 1, INT_MIN
>
> Hmm... INT_MIN... are you sure it is portable on all Linux compilers?
>
> I don't like the idea on trusting on whatever C/C++/Java/... compiler (or
This patch adds driver for S5K4ECGX sensor with embedded ISP SoC,
S5K4ECGX, which is a 5M CMOS Image sensor from Samsung
The driver implements preview mode of the S5K4ECGX sensor.
capture (snapshot) operation, face detection are missing now.
Following controls are supported:
contrast/saturation/bri
The device is based on STV0903 demodulator, STB6100 tuner
and CX23885 chipset; subsystem id: 8000:3034
This is a modified version of the official Prof Tuners Group patch:
http://www.proftuners.com/sites/default/files/prof8000_0.patch
Signed-off-by: Mariusz Bialonczyk
---
Documentation/video4lin
Em 12-09-2012 08:01, David Waring escreveu:
> On 11/09/12 19:38, Mauro Carvalho Chehab wrote:
>> Em 16-08-2012 22:35, Antti Palosaari escreveu:
>>> [snip]
>>> + Possible values: 0, 1, INT_MIN
>>
>> Hmm... INT_MIN... are you sure it is portable on all Linux compilers?
>>
>> I don't like the idea o
I'll split this patch in one patch for file and resend.
On Wed, Sep 12, 2012 at 10:06 AM, Dan Carpenter
wrote:
> On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote:
>> diff --git a/drivers/media/dvb-frontends/lg2160.c
>> b/drivers/media/dvb-frontends/lg2160.c
>> index cc11260..
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
2012/9/12 Peter Senna Tschudin :
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r exists@
> position p1,p2;
> expression x;
> @@
>
> if (x@p1 =
Am 11.09.2012 09:29, schrieb Hans de Goede:
> Hi,
>
> On 09/10/2012 10:24 PM, Frank Schäfer wrote:
>
>
Ok, I understand what that means...
>
>>
>> libv4lconvert should be modifed to do the rotation regardless of what
>> comes out of the kernel whenever V4LCONTROL_ROTATED flag is set.
>> This wa
These patches contain initial firmware loading and encoding support for the
CODA7 series VPU contained in i.MX51 and i.MX53 SoCs, and fix some
multi-instance
issues.
Changes since v4:
- Added Javier's Tested/Reviewed/Acked-by.
- Fixed menu_skip_mask for V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE v4l2
Signed-off-by: Philipp Zabel
Tested-by: Javier Martin
---
drivers/media/platform/coda.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
index d4a5dd0..8ec2ff4 100644
--- a/drivers/media/platform/
The hardware can also rotate in 90° steps, but there is no
corresponding V4L2_CID defined yet.
Signed-off-by: Philipp Zabel
Tested-by: Javier Martin
---
drivers/media/platform/coda.c | 19 ++-
drivers/media/platform/coda.h |9 +
2 files changed, 27 insertions(+), 1
This fixes a failure in vb2_qbuf in user pointer mode where
__qbuf_userptr checks if the buffer queued by userspace is large
enough. The failure would happen if coda_queue_setup was called
with empty fmt (and thus set the expected buffer size to the maximum
resolution), and userspace queues buffers
VIDIOC_TRY_FMT would incorrectly return bytesperline * height,
instead of width * height * 3 / 2.
Signed-off-by: Philipp Zabel
Tested-by: Javier Martin
---
drivers/media/platform/coda.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/coda.
While the CODA is running a PIC_RUN command, its registers are
not to be touched.
Signed-off-by: Philipp Zabel
Tested-by: Javier Martin
---
drivers/media/platform/coda.c | 42 -
1 file changed, 33 insertions(+), 9 deletions(-)
diff --git a/drivers/medi
Add a 1 second timeout for each PIC_RUN command to the CODA. In
case it locks up, stop all queues and dequeue remaining buffers.
Signed-off-by: Philipp Zabel
Tested-by: Javier Martin
---
drivers/media/platform/coda.c | 26 ++
1 file changed, 26 insertions(+)
diff --gi
job_ready is supposed to signal whether a context is ready to be
added to the job queue, not whether the CODA is ready to run it
immediately.
Calling v4l2_m2m_job_finish at the end of coda_irq_handler already
guarantees that the coda is ready when v4l2-mem2mem eventually tries
to run the next queue
Determining the next free instance just by incrementing and decrementing
an instance counter does not work: if there are two instances opened,
0 and 1, and instance 0 is released, the next call to coda_open will
create a new instance with index 1, but instance 1 is already in use.
Instead, scan a
Some codecs running on CODA need internal framebuffers for reference and
reconstructed frames. Allocate them separately, and do not use the input
vb2_buffers: those will be handed off to userspace regularly, and there
is no way to signal to the CODA which of the registered framebuffers are
off limi
This uses the ARCH_MXC specific iram_alloc API to allocate a work
buffer in the SoC's on-chip SRAM and sets up the AXI_SRAM_USE
register. In the future, the allocation will be converted to use
the genalloc API.
Signed-off-by: Philipp Zabel
Tested-by: Javier Martin
---
drivers/media/platform/Kco
Signed-off-by: Philipp Zabel
---
Changes since v4:
- Fix menu_skip_mask for V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE v4l2_ctrl.
---
drivers/media/platform/coda.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/coda.c b/drive
USERPTR buffer support is provided by the videobuf2 framework.
Signed-off-by: Philipp Zabel
Acked-by: Javier Martin
---
drivers/media/platform/coda.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
index 7f
Add support for loading a raw firmware with 16-bit chars ordered in
little-endian 64-bit words, corresponding to the memory access pattern
of CODA7 and above: When writing the boot code into the code download
register, the chars have to be reordered back.
Signed-off-by: Philipp Zabel
Tested-by: J
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/af9035.c | 6 --
drivers/media/usb/dvb-usb-v2/af9035.h | 3 +++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c
b/drivers/media/usb/dvb-usb-v2/af9035.c
index fdec3b1..3c6d82e
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/af9013.c | 3 ++-
drivers/media/dvb-frontends/af9013_priv.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-frontends/af9013.c
b/drivers/media/dvb-frontends/af9013.c
index 2dac314..b30ca2
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/af9015.c | 3 ++-
drivers/media/usb/dvb-usb-v2/af9015.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c
b/drivers/media/usb/dvb-usb-v2/af9015.c
index 9afceed..d9d3030 10064
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/tda10071.c | 3 ++-
drivers/media/dvb-frontends/tda10071_priv.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-frontends/tda10071.c
b/drivers/media/dvb-frontends/tda10071.c
index 703c3d0
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/ec168.c | 3 ++-
drivers/media/usb/dvb-usb-v2/ec168.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/ec168.c
b/drivers/media/usb/dvb-usb-v2/ec168.c
index b74c810..b6a9c5b 100644
---
Hi All,
I just bought the HD PVR 2 Gaming Edition from Hauppauge.
It there any change this device will be supported by the hdpvr kernel
driver. (Or any other driver for that matter!)
When I insert the device only the usb module reacts. The hdpvr module is
not loaded.
Then I updated the pro
Marcos,
> Now that you removed this kfree, you could remove this label too. Very
> nice your cleanup :)
Thanks!
>
>> vpbe_fail_sd_register:
>> kfree(vpbe_dev->encoders);
>> vpbe_fail_v4l2_device:
The problem removing the label is that it will require some more work
naming the labels. S
On Wed, Sep 12, 2012 at 11:37 AM, Thomas Seilund wrote:
> Hi All,
>
> I just bought the HD PVR 2 Gaming Edition from Hauppauge.
>
> It there any change this device will be supported by the hdpvr kernel
> driver. (Or any other driver for that matter!)
No. It is a totally different hardware design
Hi Peter,
2012/9/12 Peter Senna Tschudin :
> Marcos,
>
>> Now that you removed this kfree, you could remove this label too. Very
>> nice your cleanup :)
> Thanks!
>
>>
>>> vpbe_fail_sd_register:
>>> kfree(vpbe_dev->encoders);
>>> vpbe_fail_v4l2_device:
>
> The problem removing the label
On Wed, Sep 12, 2012 at 05:50:54PM +0200, Peter Senna Tschudin wrote:
> Marcos,
>
> > Now that you removed this kfree, you could remove this label too. Very
> > nice your cleanup :)
> Thanks!
>
> >
> >> vpbe_fail_sd_register:
> >> kfree(vpbe_dev->encoders);
> >> vpbe_fail_v4l2_device:
>
Hi Sangwook,
two remarks from my review on September 9th haven't been addressed.
I believe those remarks are correct, but please let me know if I'm
missing something.
See below.
On 09/12/2012 01:26 PM, Sangwook Lee wrote:
> +static int s5k4ecgx_s_power(struct v4l2_subdev *sd, int on)
> +{
> +
On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote:
> This patch adds a document, describing common V4L2 device tree bindings.
>
> Co-authored-by: Sylwester Nawrocki
> Signed-off-by: Guennadi Liakhovetski
Overall, I think this looks pretty reasonable, so:
Acked-by: Stephen Warren
Just a cou
Hi Stephen
On Wed, 12 Sep 2012, Stephen Warren wrote:
> On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote:
> > This patch adds a document, describing common V4L2 device tree bindings.
> >
> > Co-authored-by: Sylwester Nawrocki
> > Signed-off-by: Guennadi Liakhovetski
>
> Overall, I think th
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Wed Sep 12 19:00:21 CEST 2012
git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324
gcc version: i686-linux-gcc (GC
On 09/12/2012 01:28 PM, Guennadi Liakhovetski wrote:
> Hi Stephen
>
> On Wed, 12 Sep 2012, Stephen Warren wrote:
>
>> On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote:
>>> This patch adds a document, describing common V4L2 device tree bindings.
>>>
>>> Co-authored-by: Sylwester Nawrocki
>>> S
On Wed, 12 Sep 2012, Stephen Warren wrote:
> On 09/12/2012 01:28 PM, Guennadi Liakhovetski wrote:
> > Hi Stephen
> >
> > On Wed, 12 Sep 2012, Stephen Warren wrote:
> >
> >> On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote:
> >>> This patch adds a document, describing common V4L2 device tree b
On 09/12/2012 03:17 PM, Guennadi Liakhovetski wrote:
> On Wed, 12 Sep 2012, Stephen Warren wrote:
>
>> On 09/12/2012 01:28 PM, Guennadi Liakhovetski wrote:
>>> Hi Stephen
>>>
>>> On Wed, 12 Sep 2012, Stephen Warren wrote:
>>>
On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote:
> This pat
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/ec100.c | 45 -
1 file changed, 29 insertions(+), 16 deletions(-)
diff --git a/drivers/media/dvb-frontends/ec100.c
b/drivers/media/dvb-frontends/ec100.c
index b4ea34c..9d42480 100644
--- a/drivers
Use .get_if_frequency() as all used tuner drivers
(mt2060/qt1010/mxl5005s) supports it.
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/rtl2830.c | 57 +++--
drivers/media/dvb-frontends/rtl2830.h | 7
drivers/media/usb/dvb-usb-v2/rtl28xxu.c |
Plain '-1' is not very good error code. Use more suitable error
code definitions.
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/af9015.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c
b/drivers/media/usb/dvb-us
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/ce6230.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/ce6230.c
b/drivers/media/usb/dvb-usb-v2/ce6230.c
index 1c4357d..f67b14b 100644
--- a/drivers/me
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/af9033.c | 83 +++-
drivers/media/dvb-frontends/af9033.h | 2 +-
2 files changed, 44 insertions(+), 41 deletions(-)
diff --git a/drivers/media/dvb-frontends/af9033.c
b/drivers/media/dvb-frontends/af9
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/ec168.c | 40 +---
1 file changed, 24 insertions(+), 16 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/ec168.c
b/drivers/media/usb/dvb-usb-v2/ec168.c
index b6a9c5b..5c68f39 100644
--- a/drive
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/gl861.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/gl861.c
b/drivers/media/usb/dvb-usb-v2/gl861.c
index df78811..b1b09c5 100644
--- a/drivers/media/usb/dvb-usb-v2/gl861.c
+++ b
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/au6610.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/au6610.c
b/drivers/media/usb/dvb-usb-v2/au6610.c
index f309fd8..ae6a671 100644
--- a/drivers/media/usb/dvb-usb-v2/au6610.c
+
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/af9035.c | 90 +++
1 file changed, 49 insertions(+), 41 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c
b/drivers/media/usb/dvb-usb-v2/af9035.c
index 3c6d82e..89cc901 100644
--- a/dri
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/af9015.c | 49 ++-
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c
b/drivers/media/usb/dvb-usb-v2/af9015.c
index c429da7..a4be303 100644
--- a/dri
... and some minor logging changes.
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/af9015.c | 155 --
drivers/media/usb/dvb-usb-v2/af9015.h | 21 -
2 files changed, 91 insertions(+), 85 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/
This optimizes few hundred bytes from data to text segment.
Also remove one unused function that was commented out already.
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/rtl2830.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/driver
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/ec100.c | 23 ---
drivers/media/dvb-frontends/ec100.h | 2 +-
drivers/media/dvb-frontends/ec100_priv.h | 39
3 files changed, 11 insertions(+), 53 deletions(-)
delete mode 1
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/rtl2830.c | 46 --
drivers/media/dvb-frontends/rtl2830.h | 2 +-
drivers/media/dvb-frontends/rtl2830_priv.h | 13 -
3 files changed, 25 insertions(+), 36 deletions(-)
diff --git a/driver
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/af9013.c | 155 +-
drivers/media/dvb-frontends/af9013.h | 2 +-
drivers/media/dvb-frontends/af9013_priv.h | 13 ---
3 files changed, 89 insertions(+), 81 deletions(-)
diff --git a/drivers/medi
Signed-off-by: Antti Palosaari
---
drivers/media/dvb-frontends/hd29l2.c | 75 ---
drivers/media/dvb-frontends/hd29l2.h | 2 +-
drivers/media/dvb-frontends/hd29l2_priv.h | 13 --
3 files changed, 41 insertions(+), 49 deletions(-)
diff --git a/drivers/med
70 matches
Mail list logo