Re: [PATCH 01/14] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2012-09-21 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, Sep 20, 2012 at 3:31 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Friday 14 September 2012 18:16:31 Prabhakar Lad wrote: >> From: Manjunath Hadli >> >> add support for dm3xx IPIPEIF hardware setup. This is the >> lowest

[PATCH 2/2] cypress_firmware: refactor firmware downloading

2012-09-21 Thread Antti Palosaari
Refactor firmware download function. It also should fix one bug coming from usb_control_msg() message buffers. Taking buffers from the stack for usb_control_msg() is not allowed as it does not work on all architectures. Allocate buffers using kmalloc(). Signed-off-by: Antti Palosaari --- drivers

[PATCH 1/2] cypress_firmware: use Kernel dev_foo() logging

2012-09-21 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/cypress_firmware.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/cypress_firmware.c b/drivers/media/usb/dvb-usb-v2/cypress_firmware.c index 9f7c970..bb21eee 1

Re: media_build error on header file not present in old linux in ivtv-alsa-pcm.c

2012-09-21 Thread Andy Walls
Jan Hoogenraad wrote: >I try to compile the media_build on an old Ubuntu Lucid system. >2.6.32-42-generic-pae #96-Ubuntu SMP Wed Aug 15 19:12:17 UTC 2012 i686 >GNU/Linux > >The make job stops with > >/home/jhh/dvb/media_build/v4l/ivtv-alsa-pcm.c:29:26: error: >linux/printk.h: No such file or dire

media_build error on header file not present in old linux in ivtv-alsa-pcm.c

2012-09-21 Thread Jan Hoogenraad
I try to compile the media_build on an old Ubuntu Lucid system. 2.6.32-42-generic-pae #96-Ubuntu SMP Wed Aug 15 19:12:17 UTC 2012 i686 GNU/Linux The make job stops with /home/jhh/dvb/media_build/v4l/ivtv-alsa-pcm.c:29:26: error: linux/printk.h: No such file or directory make[3]: *** [/home/jhh/dv

cron job: media_tree daily build: ERRORS

2012-09-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Sep 21 19:00:18 CEST 2012 git hash:4313902ebe33155209472215c62d2f29d117be29 gcc version: i686-linux-gcc (GC

Re: media_build directory error after patch dvb_frontend: implement suspend / resume

2012-09-21 Thread Jan Hoogenraad
Thanks Antti: Maybe the media_build could clean out the linux subdirectories (e.g. drivers include sound) before the tar x command. Your rtl28xxu driver immediately works, even on this old system ! Thanks for that as well. I will remove the very outdated info I put onto the Wiki pages: http:/

Re: media_build directory error after patch dvb_frontend: implement suspend / resume

2012-09-21 Thread Antti Palosaari
On 09/21/2012 07:19 PM, Jan Hoogenraad wrote: I try to compile the media_build on an old Ubuntu Lucid system. 2.6.32-42-generic-pae #96-Ubuntu SMP Wed Aug 15 19:12:17 UTC 2012 i686 GNU/Linux The make job stops with /home/jhh/dvb/media_build/v4l/dvb_usb_core.c: In function 'dvb_usb_data_complete

Re: [RFCv1 PATCH 4/6] videobuf2-core: fill in length field for multiplanar buffers.

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 18:47:54 Sylwester Nawrocki wrote: > On 09/21/2012 06:23 PM, Hans Verkuil wrote: > > On Fri September 21 2012 18:13:20 Sylwester Nawrocki wrote: > >> Hi Hans, > >> > >> On 09/19/2012 04:37 PM, Hans Verkuil wrote: > >>> From: Hans Verkuil > >>> > >>> length should be set to

Re: [alsa-devel] [PATCH v2 00/34] i.MX multi-platform support

2012-09-21 Thread Shawn Guo
On Sat, Sep 22, 2012 at 12:46:26AM +0800, Shawn Guo wrote: > I just published the branch below with this series rebased on top of > the necessary dependant branches. > > git://git.linaro.org/people/shawnguo/linux-2.6.git staging/imx-multiplatform > > The dependant branches include: > Forgot t

Re: [RFCv1 PATCH 4/6] videobuf2-core: fill in length field for multiplanar buffers.

2012-09-21 Thread Sylwester Nawrocki
On 09/21/2012 06:23 PM, Hans Verkuil wrote: > On Fri September 21 2012 18:13:20 Sylwester Nawrocki wrote: >> Hi Hans, >> >> On 09/19/2012 04:37 PM, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> length should be set to num_planes in __fill_v4l2_buffer(). That way the >>> caller knows how many

Re: [alsa-devel] [PATCH v2 00/34] i.MX multi-platform support

2012-09-21 Thread Shawn Guo
Hi Olof, On Fri, Sep 21, 2012 at 01:26:43AM -0700, Olof Johansson wrote: > I'll take a look at merging it tomorrow after I've dealt with smp_ops; > if it looks reasonably conflict-free I'll pull it in. We need the > sound dependency sorted out (or agreed upon) first though. > I just published the

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 18:33:45 andrey.smir...@convergeddevices.net wrote: > On 09/21/2012 12:31 AM, Hans Verkuil wrote: > > On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote: > >> On 09/13/2012 11:44 PM, Hans Verkuil wrote: > >>> Hi Andrey! > >>> > >>> Thanks for postin

Re: [RFCv1 PATCH 6/6] DocBook: various updates w.r.t. v4l2_buffer and multiplanar.

2012-09-21 Thread Sylwester Nawrocki
On 09/19/2012 04:37 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Clarify the behavior of v4l2_buffer in the multiplanar case, > including fixing a false statement: you can't set m.planes to NULL > when calling DQBUF. > > Signed-off-by: Hans Verkuil I'm not sure what was main argument for n

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-21 Thread andrey.smir...@convergeddevices.net
On 09/21/2012 12:31 AM, Hans Verkuil wrote: > On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote: >> On 09/13/2012 11:44 PM, Hans Verkuil wrote: >>> Hi Andrey! >>> >>> Thanks for posting this driver. One request for the future: please split >>> this >>> patch up in smaller

media_build directory error after patch dvb_frontend: implement suspend / resume

2012-09-21 Thread Jan Hoogenraad
I try to compile the media_build on an old Ubuntu Lucid system. 2.6.32-42-generic-pae #96-Ubuntu SMP Wed Aug 15 19:12:17 UTC 2012 i686 GNU/Linux The make job stops with /home/jhh/dvb/media_build/v4l/dvb_usb_core.c: In function 'dvb_usb_data_complete_raw': /home/jhh/dvb/media_build/v4l/dvb_usb_cor

Re: [RFCv1 PATCH 4/6] videobuf2-core: fill in length field for multiplanar buffers.

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 18:13:20 Sylwester Nawrocki wrote: > Hi Hans, > > On 09/19/2012 04:37 PM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > length should be set to num_planes in __fill_v4l2_buffer(). That way the > > caller knows how many planes there are in the buffer. > > > > Signed

Re: [RFCv1 PATCH 4/6] videobuf2-core: fill in length field for multiplanar buffers.

2012-09-21 Thread Sylwester Nawrocki
Hi Hans, On 09/19/2012 04:37 PM, Hans Verkuil wrote: > From: Hans Verkuil > > length should be set to num_planes in __fill_v4l2_buffer(). That way the > caller knows how many planes there are in the buffer. > > Signed-off-by: Hans Verkuil I think this would break VIDIOC_CREATE_BUFS. We need p

RE: led flash driver for lm3554/lm3556

2012-09-21 Thread Jeong, Daniel
Hi Andy and Sakari. >On Fri, Sep 21, 2012 at 01:55:15PM +0300, Andy Shevchenko wrote: >> On Fri, 2012-09-21 at 19:16 +0900, gshark wrote: >> >> [cut previous stories] >> >> > My development enviroments are Unbuntu and Android on Exynos and >> > OMAP4 Processor. >> > There is a function "Assis

Re: tda8290 regression fix

2012-09-21 Thread Mauro Carvalho Chehab
Em 21-09-2012 10:59, Anders Eriksson escreveu: > > > On Wed, Sep 19, 2012 at 9:25 PM, Anders Thomson > wrote: > > diff --git a/drivers/media/common/tuners/tda8290.c > b/drivers/media/common/tuners/tda8290.c > index 064d14c..498cc7b 100644 > --- a/driver

Re: [PATCH] Mygica X8507 audio for YPbPr, AV and S-Video

2012-09-21 Thread Alfredo Jesús Delaiti
Hi El 19/09/12 13:28, Mauro Carvalho Chehab escribió: > Em 19-09-2012 10:31, Alfredo Jesús Delaiti escreveu: >> El 18/09/12 13:16, Mauro Carvalho Chehab escribió: >>> Em 03-09-2012 17:14, Alfredo Jesús Delaiti escreveu: Hi This patch add audio support for input YPbPr, AV and S-Vide

Re: [PATCH v4] of: Add videomode helper

2012-09-21 Thread Steffen Trumtrar
On Thu, Sep 20, 2012 at 11:29:42PM +0200, Laurent Pinchart wrote: > Hi, > > (CC'ing the linux-media mailing list, as video modes are of interest there as > well) > > On Wednesday 19 September 2012 12:19:22 Tomi Valkeinen wrote: > > On Wed, 2012-09-19 at 10:20 +0200, Steffen Trumtrar wrote: > >

Re: [RFC PATCH 0/3] In non-blocking mode return EAGAIN in hwseek

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 14:29:03 Hans de Goede wrote: > Hi, > > Looks good, but for patch 3/3 you're missing the same changes to > sound/i2c/other/tea575x-tuner.c Thanks! I'll add that as another patch. I keep forgetting about that one :-) Regards, Hans > On 09/21/2012 01:44 PM, Hans

Re: [RFC PATCH 0/3] In non-blocking mode return EAGAIN in hwseek

2012-09-21 Thread Hans de Goede
Hi, Looks good, but for patch 3/3 you're missing the same changes to sound/i2c/other/tea575x-tuner.c Regards, Hans On 09/21/2012 01:44 PM, Hans Verkuil wrote: This patch series resolves a problem with S_HW_FREQ_SEEK when called in non-blocking mode. Currently this would actually block during

Re: [RFC] Processing context in the V4L2 subdev and V4L2 controls API ?

2012-09-21 Thread Hans Verkuil
On Tue September 18 2012 17:06:54 Sylwester Nawrocki wrote: > Hi All, > > I'm trying to fulfil following requirements with V4L2 API that are specific > to most of Samsung camera sensors with embedded SoC ISP and also for local > SoC camera ISPs: > > - separate pixel format and pixel resolution

[RFC PATCH 3/3] radio drivers: in non-blocking mode return EAGAIN in hwseek

2012-09-21 Thread Hans Verkuil
From: Hans Verkuil VIDIOC_S_HW_FREQ_SEEK should return EAGAIN when called in non-blocking mode. This might change in the future if we add support for this in the future, but right now this is not supported. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-mr800.c|3

[RFC PATCH 1/3] DocBook: EAGAIN == EWOULDBLOCK

2012-09-21 Thread Hans Verkuil
From: Hans Verkuil Merge the two entries since they are one and the same error. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/gen-errors.xml |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Documentation/DocBook/media/v4l/gen-errors.xml b/Docum

[RFC PATCH 2/3] DocBook: in non-blocking mode return EAGAIN in hwseek

2012-09-21 Thread Hans Verkuil
From: Hans Verkuil VIDIOC_S_HW_FREQ_SEEK should return EAGAIN when called in non-blocking mode. This might change in the future if we add support for this in the future, but right now this is not supported. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.x

[RFC PATCH 0/3] In non-blocking mode return EAGAIN in hwseek

2012-09-21 Thread Hans Verkuil
This patch series resolves a problem with S_HW_FREQ_SEEK when called in non-blocking mode. Currently this would actually block during the seek. This is not a good idea. This patch changes the spec and the drivers to return -EAGAIN when called in non-blocking mode. In the future actual support for

RFC: single+multiplanar API in one driver: possible or not?

2012-09-21 Thread Hans Verkuil
Hi all, I've been looking into multiplanar support recently, and I ran into some API ambiguities. In the examples below I stick to the capture case, but the same applies to output and m2m. There are two capabilities: V4L2_CAP_VIDEO_CAPTURE and V4L2_CAP_VIDEO_CAPTURE_MPLANE. These caps tell the

s5p-tv/mixer_video.c weirdness

2012-09-21 Thread Hans Verkuil
Hi Marek, Sylwester, I've been investigating how multiplanar is used in various drivers, and I came across this driver that is a bit weird. querycap sets both single and multiple planar output caps: cap->capabilities = V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP

Re: [RFCv1 PATCH 4/6] videobuf2-core: fill in length field for multiplanar buffers.

2012-09-21 Thread Hans Verkuil
On Wed September 19 2012 16:37:38 Hans Verkuil wrote: > From: Hans Verkuil > > length should be set to num_planes in __fill_v4l2_buffer(). That way the > caller knows how many planes there are in the buffer. Can someone review this? I'd like to know whether it will cause problems for existing ap

Re: [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
> > > > + * @prepare: called everytime the buffer is passed from userspace > > to the > nitpick: everytime -> every time > > > + * driver, usefull for cache synchronisation, optional > > + * @finish:called everytime the buffer is passed back from the > > driver > ditto. >

Re: [PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 11:21:37 Federico Vaga wrote: > This patch re-write the driver and use the videobuf2 > interface instead of the old videobuf. Moreover, it uses also > the control framework which allows the driver to inherit > controls from its subdevice (ADV7180) Some more comments below,

Re: [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 11:21:35 Federico Vaga wrote: > This patch adds support for prepare/finish callbacks in VB2 allocators. > These callback are used for buffer flushing. > > Signed-off-by: Marek Szyprowski > Acked-by: Laurent Pinchart > Acked-by: Federico Vaga > --- > drivers/media/v4l2-

Re: [RFC] Timestamps and V4L2

2012-09-21 Thread Hans Verkuil
On Thu September 20 2012 22:21:22 Sakari Ailus wrote: > Hi all, > > > This RFC intends to summarise and further the recent discussion on > linux-media regarding the proposed changes of timestamping V4L2 buffers. > > > The problem > === > > The V4L2 has long used realtime timestamps (su

Re: [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control

2012-09-21 Thread Anatolij Gustschin
On Fri, 24 Aug 2012 16:32:57 +0200 (CEST) Guennadi Liakhovetski wrote: ... > > > But why do we have to write it here at all then? Autoexposure can be off > > > only if the user has set exposure manually, using V4L2_CID_EXPOSURE_AUTO. > > > In this case MT9V022_TOTAL_SHUTTER_WIDTH already contain

Re: [PATCH 3/3] mt9v022: set y_skip_top field to zero

2012-09-21 Thread Anatolij Gustschin
Hi Guennadi, On Tue, 11 Sep 2012 10:55:31 +0200 (CEST) Guennadi Liakhovetski wrote: ... > > > On what systems have you checked this? > > > > On camera systems from ifm, both using mt9v022. > > Ok, I agree, this was a hack in the beginning, and, probably, there was a > reason for the problem, t

[PATCH v2 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-21 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit the controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x1

[PATCH v2 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-21 Thread Federico Vaga
The DMA streaming allocator is similar to the DMA contig but it use the DMA streaming interface (dma_map_single, dma_unmap_single). The allocator allocates buffers and immediately map the memory for DMA transfer. For each buffer prepare/finish it does a DMA synchronization. Signed-off-by: Federico

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread federico . vaga
From: Federico Vaga This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- dr

[PATCH 2/2] m5mols: Protect driver data with a mutex

2012-09-21 Thread Sylwester Nawrocki
Without the locking the driver's data could get corrupted when the subdev is accessed from user space and from host driver by multiple processes. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h | 18 +--- drivers/media/video/m5mols

[PATCH 1/2] m5mols: Remove unneeded control ops assignments

2012-09-21 Thread Sylwester Nawrocki
Since all host drivers using this subdev are already using the control framework these compatibility ops can be removed. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols_core.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/

Re: [RFC] Timestamps and V4L2

2012-09-21 Thread Christian Gmeiner
2012/9/20 Sakari Ailus : > Hi all, > > > This RFC intends to summarise and further the recent discussion on > linux-media regarding the proposed changes of timestamping V4L2 buffers. > > > The problem > === > > The V4L2 has long used realtime timestamps (such as > clock_gettime(CLOCK_REALTI

Re: [alsa-devel] [PATCH v2 00/34] i.MX multi-platform support

2012-09-21 Thread Olof Johansson
On Fri, Sep 21, 2012 at 1:01 AM, Shawn Guo wrote: > On Thu, Sep 20, 2012 at 03:56:56PM +, Arnd Bergmann wrote: >> Ok, fair enough. I think we can put it in arm-soc/for-next as a staging >> branch anyway to give it some exposure to linux-next, and then we can >> decide whether a rebase is neces

Re: [alsa-devel] [PATCH v2 00/34] i.MX multi-platform support

2012-09-21 Thread Shawn Guo
On Thu, Sep 20, 2012 at 03:56:56PM +, Arnd Bergmann wrote: > Ok, fair enough. I think we can put it in arm-soc/for-next as a staging > branch anyway to give it some exposure to linux-next, and then we can > decide whether a rebase is necessary before sending it to Linus. > I just saw the annou

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote: > On 09/13/2012 11:44 PM, Hans Verkuil wrote: > > Hi Andrey! > > > > Thanks for posting this driver. One request for the future: please split > > this > > patch up in smaller pieces: one for each c source for example. Tha