Re: Fw: [PATCH] v4 Add support to Avermedia Twinstar double tuner in af9035

2012-10-07 Thread Antti Palosaari
Hello, Let this patch be pending. I have got dual AF9035 + FC0012 device, but for some reason I haven't got it working at all. Due to that I cannot test this just now. Biggest problem here is that it needs MxL5007T tuner changes first. This patch is currently useless as MxL5007T changes are n

Re: [v4l-utils] Use RCC variable to call rcc compiler

2012-10-07 Thread Gregor Jasny
Hello Khem, On 10/7/12 8:41 PM, Khem Raj wrote: > In cross compile environment rcc native version > may be staged in a different directory or even > called rcc4 or somesuch. Lets provide a facility > to specify it in environment I'll take care of this patch. > diff --git a/utils/qv4l2/Makefile.a

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
Sorry, I mean either: I2C_MSG_WRITE(priv->cfg->i2c_address, ®, sizeof(reg)), I2C_MSG_READ(priv->cfg->i2c_address, val, sizeof(*val)), Of course. Sorry for not having seen that. I can do that. julia -- To unsubscribe from this list: send the line "unsubscribe linux-media" in t

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 16:05, Julia Lawall wrote: > On Mon, 8 Oct 2012, Ryan Mallon wrote: > >> On 08/10/12 02:38, Julia Lawall wrote: >>> From: Julia Lawall >>> >>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability. >>> >>> A length expressed as an explicit constant is also re-expressed as >>> the si

Re: [PATCH 12/13] drivers/media/tuners/max2165.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
On Mon, 8 Oct 2012, Ryan Mallon wrote: On 08/10/12 02:38, Julia Lawall wrote: From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. The second case is simp

Re: [PATCH 5/13] drivers/media/tuners: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
As far as I can see, the comments on this are: &b[0] should be just b There should be a newline before the elements of a multi-element array Some one-element array buffers should just be variables sizeof(val) should be used I will redo the patches to include the first two, but not the others. I

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
On Mon, 8 Oct 2012, Ryan Mallon wrote: On 08/10/12 02:38, Julia Lawall wrote: From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. A simplified version of

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
On Sun, 7 Oct 2012, Joe Perches wrote: On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote: On Sun, 7 Oct 2012, Joe Perches wrote: Are READ and WRITE the action names? They are really the important information in this case. Yes, most (all?) uses of _READ and _WRITE macros actually perform

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 12:56, Mauro Carvalho Chehab wrote: > Em Sun, 07 Oct 2012 14:51:58 -0700 > Joe Perches escreveu: > >> On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote: >>> On Sun, 7 Oct 2012, Joe Perches wrote: > Are READ and WRITE the action names? They are really the important > infor

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Mauro Carvalho Chehab
Em Sun, 07 Oct 2012 14:51:58 -0700 Joe Perches escreveu: > On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote: > > On Sun, 7 Oct 2012, Joe Perches wrote: > > >> Are READ and WRITE the action names? They are really the important > > >> information in this case. > > > > > > Yes, most (all?) use

Re: ir-keytable: Bug in gen_keytables.pl script

2012-10-07 Thread Mauro Carvalho Chehab
Em Sun, 07 Oct 2012 19:24:26 +0200 Gregor Jasny escreveu: > Hello, > > I recently received this launchpad bug: > https://bugs.launchpad.net/ubuntu/+source/v4l-utils/+bug/1054122 > It seems that the mentioned key mappings are missing. > > If you check the generated mapping file > > http://git.l

Re: [PATCH 12/13] drivers/media/tuners/max2165.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > A length expressed as an explicit constant is also re-expressed as the size > of the buffer, when this is possible. > > The second case is simplified to use simple variab

Re: [PATCH 5/13] drivers/media/tuners: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > A length expressed as an explicit constant is also re-expressed as the size > of the buffer, when this is possible. > > A simplified version of the semantic patch that ma

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > A length expressed as an explicit constant is also re-expressed as the size > of the buffer, when this is possible. > > A simplified version of the semantic patch that ma

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 03:44, Julia Lawall wrote: > On Sun, 7 Oct 2012, walter harms wrote: > >> >> >> Am 07.10.2012 17:38, schrieb Julia Lawall: >>> From: Julia Lawall >>> >>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability. >>> >>> In the second i2c_msg structure, a length expressed as an explicit

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Joe Perches
On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote: > On Sun, 7 Oct 2012, Joe Perches wrote: > >> Are READ and WRITE the action names? They are really the important > >> information in this case. > > > > Yes, most (all?) uses of _READ and _WRITE macros actually > > perform some I/O. > > I2C_MS

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 08:39, Joe Perches wrote: > On Sun, 2012-10-07 at 20:56 +0200, Julia Lawall wrote: Some people thought that it would be nice to have the macros rather than the inlined field initializations, especially since there is no flag for write. A separate question is whether an a

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
On Sun, 7 Oct 2012, Joe Perches wrote: On Sun, 2012-10-07 at 20:56 +0200, Julia Lawall wrote: Some people thought that it would be nice to have the macros rather than the inlined field initializations, especially since there is no flag for write. A separate question is whether an array of one

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Joe Perches
On Sun, 2012-10-07 at 20:56 +0200, Julia Lawall wrote: > >> Some people thought that it would be nice to have the macros rather than > >> the inlined field initializations, especially since there is no flag for > >> write. A separate question is whether an array of one element is useful, > >> or w

[PATCH v3 2/3] omap3isp: Add PHY routing configuration

2012-10-07 Thread Sakari Ailus
Add PHY routing configuration for both 3430 and 3630. Also add register bit definitions of CSIRXFE and CAMERA_PHY_CTRL registers on OMAP 3430 and 3630, respectively. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/ispcsiphy.c | 86 +++ drivers/media/plat

[PATCH v3 3/3] omap3isp: Configure CSI-2 phy based on platform data

2012-10-07 Thread Sakari Ailus
Configure CSI-2 phy based on platform data in the ISP driver. For that, the new V4L2_CID_IMAGE_SOURCE_PIXEL_RATE control is used. Previously the same was configured from the board code. This patch is dependent on "omap3: Provide means for changing CSI2 PHY configuration". Signed-off-by: Sakari Ai

[PATCH v3 1/3] omap3isp: Add CSI configuration registers from control block to ISP resources

2012-10-07 Thread Sakari Ailus
Add the registers used to configure the CSI-2 receiver PHY on OMAP3430 and 3630 and map them in the ISP driver. The register is part of the control block but it only is needed by the ISP driver. Signed-off-by: Sakari Ailus --- arch/arm/mach-omap2/devices.c | 10 ++ drivers/medi

[PATCH v3 0/3] OMAP 3 CSI-2 configuration

2012-10-07 Thread Sakari Ailus
Hi all, This is an update to an old patchset for CSI-2 configuration for OMAP 3430 and 3630r. The patches have been tested on the 3630 only so far, and I don't plan to test them on 3430 in the near future. I changed quite a few things after a discussion with Tony a few days ago. The ISP driver no

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
Some people thought that it would be nice to have the macros rather than the inlined field initializations, especially since there is no flag for write. A separate question is whether an array of one element is useful, or whether one should systematically use & on a simple variable of the structu

[v4l-utils] Use RCC variable to call rcc compiler

2012-10-07 Thread Khem Raj
In cross compile environment rcc native version may be staged in a different directory or even called rcc4 or somesuch. Lets provide a facility to specify it in environment Signed-off-by: Khem Raj --- utils/qv4l2/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH 9/13] drivers/media/tuners/fc0011.c: use macros for i2c_msg initialization

2012-10-07 Thread Michael Büsch
On Sun, 7 Oct 2012 18:50:31 +0200 (CEST) Julia Lawall wrote: > >> @@ -97,10 +96,8 @@ static int fc0011_readreg(struct fc0011_priv *priv, u8 > >> reg, u8 *val) > >> { > >>u8 dummy; > >>struct i2c_msg msg[2] = { > >> - { .addr = priv->addr, > >> -.flags = 0, .buf = ®,

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Joe Perches
On Sun, 2012-10-07 at 19:18 +0200, Julia Lawall wrote: > On Sun, 7 Oct 2012, walter harms wrote: > > Am 07.10.2012 18:44, schrieb Julia Lawall: > >> On Sun, 7 Oct 2012, walter harms wrote: > >>> Am 07.10.2012 17:38, schrieb Julia Lawall: > Introduce use of I2c_MSG_READ/WRITE/OP, for readabilit

cron job: media_tree daily build: ERRORS

2012-10-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Oct 7 19:00:25 CEST 2012 git hash:d92462401dde1effa04a51d0a15000e6246d2a43 gcc version: i686-linux-gcc (GC

ir-keytable: Bug in gen_keytables.pl script

2012-10-07 Thread Gregor Jasny
Hello, I recently received this launchpad bug: https://bugs.launchpad.net/ubuntu/+source/v4l-utils/+bug/1054122 It seems that the mentioned key mappings are missing. If you check the generated mapping file http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/utils/keytable/rc_keymaps/imon_pad and co

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
On Sun, 7 Oct 2012, walter harms wrote: Am 07.10.2012 18:44, schrieb Julia Lawall: On Sun, 7 Oct 2012, walter harms wrote: Am 07.10.2012 17:38, schrieb Julia Lawall: From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. In the second i2c_msg structure, a length e

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread walter harms
Am 07.10.2012 18:44, schrieb Julia Lawall: > On Sun, 7 Oct 2012, walter harms wrote: > >> >> >> Am 07.10.2012 17:38, schrieb Julia Lawall: >>> From: Julia Lawall >>> >>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability. >>> >>> In the second i2c_msg structure, a length expressed as an ex

Re: [PATCH 9/13] drivers/media/tuners/fc0011.c: use macros for i2c_msg initialization

2012-10-07 Thread walter harms
Am 07.10.2012 18:50, schrieb Julia Lawall: > On Sun, 7 Oct 2012, walter harms wrote: > >> >> >> Am 07.10.2012 17:38, schrieb Julia Lawall: >>> From: Julia Lawall >>> >>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability. >>> >>> A length expressed as an explicit constant is also re-expres

Re: [PATCH 9/13] drivers/media/tuners/fc0011.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
On Sun, 7 Oct 2012, walter harms wrote: Am 07.10.2012 17:38, schrieb Julia Lawall: From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer in each case. A simplified version of th

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
On Sun, 7 Oct 2012, walter harms wrote: Am 07.10.2012 17:38, schrieb Julia Lawall: From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. In the second i2c_msg structure, a length expressed as an explicit constant is also re-expressed as the size of the buffer, reg. A

Re: [PATCH 9/13] drivers/media/tuners/fc0011.c: use macros for i2c_msg initialization

2012-10-07 Thread walter harms
Am 07.10.2012 17:38, schrieb Julia Lawall: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > A length expressed as an explicit constant is also re-expressed as the size > of the buffer in each case. > > A simplified version of the semantic patch that makes

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread walter harms
Am 07.10.2012 17:38, schrieb Julia Lawall: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > In the second i2c_msg structure, a length expressed as an explicit constant > is also re-expressed as the size of the buffer, reg. > > A simplified version of the s

Re: [PATCH 2/5] fence: dma-buf cross-device synchronization (v9)

2012-10-07 Thread Maarten Lankhorst
Op 28-09-12 14:42, Maarten Lankhorst schreef: > A fence can be attached to a buffer which is being filled or consumed > by hw, to allow userspace to pass the buffer without waiting to another > device. For example, userspace can call page_flip ioctl to display the > next frame of graphics after ki

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-10-07 Thread Mauro Carvalho Chehab
Em Sun, 07 Oct 2012 15:41:50 +0200 Frank Schäfer escreveu: > Am 06.10.2012 13:56, schrieb Mauro Carvalho Chehab: > > Em Sun, 23 Sep 2012 16:03:25 +0200 > > Frank Schäfer escreveu: > > > >> Ping ! > > Sorry, too busy those days. > > No problem. > > >> Am 26.08.2012 20:53, schrieb Frank Schäfer:

Zolid USB DVB-T Tuner Pictures

2012-10-07 Thread Jens Bauer
Hi... I saw on this page... ...That I can contribute to the project by writing to this list. Now, I don't have much knowledge about USB; I don't even have Linux (but I probably will within a few months). I saw that some of the mentioned devic

[PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. In the second i2c_msg structure, a length expressed as an explicit constant is also re-expressed as the size of the buffer, reg. A simplified version of the semantic patch that makes this change is as follows: (http://c

[PATCH 2/13] drivers/media/tuners/mxl5007t.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. In each case, a length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. A simplified version of the semantic patch that makes this change is as follows: (http://co

[PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.

[PATCH 4/13] drivers/media/tuners/tda18212.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. In the second initialization, a length expressed as an explicit constant is also re-expressed as the size of the buffer (reg). A simplified version of the semantic patch that makes this change is as follows: (http://coc

[PATCH 5/13] drivers/media/tuners: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.

[PATCH 12/13] drivers/media/tuners/max2165.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. The second case is simplified to use simple variables rather than arrays. The variable b0 is dropped comp

[PATCH 8/13] drivers/media/tuners/fc2580.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer in each case. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) //

[PATCH 11/13] drivers/media/tuners/tda18218.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression a,b,c; identifier x; @@ struct i2c_msg x = - {.addr = a, .buf = b, .len = c, .flags = I2C_

[PATCH 9/13] drivers/media/tuners/fc0011.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer in each case. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) //

[PATCH 7/13] drivers/media/tuners/tua9001.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression a,b,c; identifier x; @@ struct i2c_msg x = - {.addr = a, .buf = b, .len = c, .flags = I2C_

[PATCH 10/13] drivers/media/tuners/tda8290.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the bufferin each case. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @

[PATCH 6/13] drivers/media/tuners/tda18271-common.c: use macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
From: Julia Lawall Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression a,b,c; identifier x; @@ struct i2c_msg x = - {.addr = a, .buf = b, .len = c, .flags = I2C_

[PATCH 0/11] introduce macros for i2c_msg initialization

2012-10-07 Thread Julia Lawall
This patch set introduces some macros for describing how an i2c_msg is being initialized. There are three macros: I2C_MSG_READ, for a read message, I2C_MSG_WRITE, for a write message, and I2C_MSG_OP, for some other kind of message, which is expected to be very rarely used. Some i2c_msg initializa

Re: [PATCHv9 18/25] v4l: add buffer exporting via dmabuf

2012-10-07 Thread Hans Verkuil
On Sun October 7 2012 15:38:30 Laurent Pinchart wrote: > Hi Hans, > > On Friday 05 October 2012 10:55:40 Hans Verkuil wrote: > > On Tue October 2 2012 16:27:29 Tomasz Stanislawski wrote: > > > This patch adds extension to V4L2 api. It allow to export a mmap buffer as > > > file descriptor. New ioc

Re: [PATCH] libv4lconvert: clarify the behavior and resulting restrictions of v4lconvert_convert()

2012-10-07 Thread Frank Schäfer
Hi Hans, Am 07.10.2012 15:05, schrieb Hans de Goede: > Hi Frank, > > Thanks for all your work on this. I'm afraid that atm I'm very busy > with work, so I don't have time to review your patches. I hope to > find some time for this next weekend... No problem, I will send you a reminder in 2 weeks.

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-10-07 Thread Frank Schäfer
Am 07.10.2012 04:56, schrieb Devin Heitmueller: > On Sat, Oct 6, 2012 at 7:56 AM, Mauro Carvalho Chehab > wrote: >> AFAIKT, newer em28xx chips are using this concept. The em28xx-i2c code >> require >> changes to support two I2C buses, and to handle 16 bit eeproms. We never >> cared >> of doing t

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-10-07 Thread Frank Schäfer
Am 06.10.2012 13:56, schrieb Mauro Carvalho Chehab: > Em Sun, 23 Sep 2012 16:03:25 +0200 > Frank Schäfer escreveu: > >> Ping ! > Sorry, too busy those days. No problem. >> Am 26.08.2012 20:53, schrieb Frank Schäfer: >>> Sorry for the delayed reply, I got distracted by something with higher >>> p

Re: [PATCHv9 22/25] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned

2012-10-07 Thread Laurent Pinchart
Hi Tomasz, Thanks for the patch. On Tuesday 02 October 2012 16:27:33 Tomasz Stanislawski wrote: > From: Marek Szyprowski > > The DMA transfer must be aligned to a specific value. If userptr is not > aligned to DMA requirements then unexpected corruptions of the memory may > occur before or afte

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-07 Thread Laurent Pinchart
Hi Steffen, On Friday 05 October 2012 17:51:21 Steffen Trumtrar wrote: > On Thu, Oct 04, 2012 at 12:51:00PM -0600, Stephen Warren wrote: > > On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: > > > Get videomode from devicetree in a format appropriate for the > > > backend. drm_display_mode and fb_vi

Re: [PATCHv9 18/25] v4l: add buffer exporting via dmabuf

2012-10-07 Thread Laurent Pinchart
Hi Hans, On Friday 05 October 2012 10:55:40 Hans Verkuil wrote: > On Tue October 2 2012 16:27:29 Tomasz Stanislawski wrote: > > This patch adds extension to V4L2 api. It allow to export a mmap buffer as > > file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer > > offset used by mma

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-07 Thread Laurent Pinchart
Hi Steffen, On Friday 05 October 2012 18:38:58 Steffen Trumtrar wrote: > On Fri, Oct 05, 2012 at 10:21:37AM -0600, Stephen Warren wrote: > > On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: > > > On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: > > >> On 10/04/2012 11:59 AM, Steffen

Re: [PATCHv9 21/25] v4l: vb2-dma-contig: add reference counting for a device from allocator context

2012-10-07 Thread Laurent Pinchart
Hi Tomasz, Thanks for the patch. On Tuesday 02 October 2012 16:27:32 Tomasz Stanislawski wrote: > This patch adds taking reference to the device for MMAP buffers. > > Such buffers, may be exported using DMABUF mechanism. If the driver that > created a queue is unloaded then the queue is released

Re: [PATCHv9 20/25] v4l: vb2-dma-contig: add support for DMABUF exporting

2012-10-07 Thread Laurent Pinchart
Hi Tomasz, Thanks for the patch. On Tuesday 02 October 2012 16:27:31 Tomasz Stanislawski wrote: > This patch adds support for exporting a dma-contig buffer using > DMABUF interface. > > Signed-off-by: Tomasz Stanislawski > Signed-off-by: Kyungmin Park Acked-by: Laurent Pinchart > --- > dri

Re: [PATCH RFC v3] dvb: LNA implementation changes

2012-10-07 Thread Mauro Carvalho Chehab
Em Wed, 3 Oct 2012 11:28:56 +0300 Antti Palosaari escreveu: > * use dvb property cache > * implement get (thus API minor++) > * PCTV 290e: 1=LNA ON, all the other values LNA OFF > Also fix PCTV 290e LNA comment, it is disabled by default > > Hans and Mauro proposed use of cache implementation

Re: [PATCH RFC v3] dvb: LNA implementation changes

2012-10-07 Thread Mauro Carvalho Chehab
Em Wed, 3 Oct 2012 11:28:56 +0300 Antti Palosaari escreveu: > * use dvb property cache > * implement get (thus API minor++) > * PCTV 290e: 1=LNA ON, all the other values LNA OFF > Also fix PCTV 290e LNA comment, it is disabled by default > > Hans and Mauro proposed use of cache implementation

Re: [git:v4l-dvb/for_v3.7] [media] tda18271-common: hold the I2C adapter during write transfers

2012-10-07 Thread Michael Krufky
umm, again, i didn't actually ACK the patch, I verbally said "ok, i guess" You shouldn't forge someone's signature, Mauro. :-( On Sun, Oct 7, 2012 at 8:43 AM, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued at the > htt

Re: [PATCH] tda18271-common: hold the I2C adapter during write transfers

2012-10-07 Thread Michael Krufky
On Sun, Oct 7, 2012 at 8:42 AM, Mauro Carvalho Chehab wrote: > Em Sat, 29 Sep 2012 15:20:23 -0400 > Michael Krufky escreveu: > >> On Fri, Sep 28, 2012 at 2:56 PM, Michael Krufky wrote: >> > On Fri, Sep 28, 2012 at 2:31 PM, Antti Palosaari wrote: >> >> Hello, >> >> Did not fix the issue. Problem

Re: [PATCH v2 1/5] [media] omap3isp: Fix compilation error in ispreg.h

2012-10-07 Thread Mauro Carvalho Chehab
Em Tue, 2 Oct 2012 09:31:58 -0700 Tony Lindgren escreveu: > * Ido Yariv [121001 15:48]: > > Commit c49f34bc ("ARM: OMAP2+ Move SoC specific headers to be local to > > mach-omap2") moved omap34xx.h to mach-omap2. This broke omap3isp, as it > > includes omap34xx.h. > > > > Instead of moving omap3

Re: [PATCH] libv4lconvert: clarify the behavior and resulting restrictions of v4lconvert_convert()

2012-10-07 Thread Hans de Goede
Hi Frank, Thanks for all your work on this. I'm afraid that atm I'm very busy with work, so I don't have time to review your patches. I hope to find some time for this next weekend... Regards, Hans On 10/03/2012 06:48 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer --- lib/include/l

[PATCH] rc-msi-digivox-ii: Add full scan keycodes - Was: Re: v4l

2012-10-07 Thread Mauro Carvalho Chehab
Em Sun, 30 Sep 2012 05:49:26 +0200 Wolfgang Bail escreveu: > Hello, > > the ir-rc from my msi DigiVox mini II Version 3 (af9015) will not work since > kernel 3.2.x (kubuntu 12.04), same with s2-liplianin or v4l. > > sudo ir-keytable -t shows: > > Testing events. Please, press CTRL-C to abort.

Re: [patch] [media] cx25821: testing the wrong variable

2012-10-07 Thread Mauro Carvalho Chehab
Em Sat, 29 Sep 2012 10:12:53 +0300 Dan Carpenter escreveu: > ->input_filename could be NULL here. The intent was to test > ->_filename. > > Signed-off-by: Dan Carpenter > --- > I'm not totally convinced that using /root/vid411.yuv is the right idea. Agreed. Palash, Sri, Why do we need those

Re: [PATCH] tda18271-common: hold the I2C adapter during write transfers

2012-10-07 Thread Mauro Carvalho Chehab
Em Sat, 29 Sep 2012 15:20:23 -0400 Michael Krufky escreveu: > On Fri, Sep 28, 2012 at 2:56 PM, Michael Krufky wrote: > > On Fri, Sep 28, 2012 at 2:31 PM, Antti Palosaari wrote: > >> Hello, > >> Did not fix the issue. Problem remains same. With the sleep + that patch it > >> works still. > >> >

Re: [PATCH 6/7] [media] ds3000: add module parameter to force firmware upload

2012-10-07 Thread Mauro Carvalho Chehab
Em Wed, 03 Oct 2012 03:38:19 +0300 Antti Palosaari escreveu: > On 09/28/2012 03:59 PM, Rémi Cardona wrote: > > Signed-off-by: Rémi Cardona Next time, please provide a better comment: why such change is needed? > > Reviewed-by: Antti Palosaari > > > > --- > > drivers/media/dvb-frontends/d

Re: [PATCH v2] drivers/media: Remove unnecessary semicolon

2012-10-07 Thread Mauro Carvalho Chehab
Hi Peter, Em Thu, 27 Sep 2012 13:55:06 +0200 Peter Senna Tschudin escreveu: > Remove unnecessary semicolon > > And: > drivers/media/dvb-frontends/stv0900_core.c: remove unnecessary whitespace > before a > quoted newline (answering about your v3 here, instead of at your v3 email as it got los

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-07 Thread Sylwester Nawrocki
On 10/07/2012 03:19 AM, Michael West wrote: > This patch changes versions.txt and disables VIDEO_M5MOLS which > fixed the build for my 3.2 kernel but looking at the logs it looks > like this is not the way to fix it as it's not just a 3.6+ problem > as it does not build on 3.6 as well... So prob

Re: [PATCHv9 00/25] Integration of videobuf2 with DMABUF

2012-10-07 Thread Hans Verkuil
Hi all! On Tue October 2 2012 16:27:11 Tomasz Stanislawski wrote: > Hello everyone, > This patchset adds support for DMABUF [2] importing and exporting to V4L2 > stack. I see that there is a lot of interest to getting this into 3.7. I understand that, but IMHO this is a bit too soon. I would like

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-07 Thread Hans Verkuil
On Sun October 7 2012 03:19:48 Michael West wrote: > This patch changes versions.txt and disables VIDEO_M5MOLS which fixed the > build for my 3.2 kernel but looking at the logs it looks like this is not the > way to fix it as it's not just a 3.6+ problem as it does not build on 3.6 as > well...

drivers/media/dvb/frontends/dib8000.c:1837 dib8000_tune() warn: variable dereferenced before check 'state' (see line 1834)

2012-10-07 Thread Fengguang Wu
Hi Patrick, FYI, the below commit triggered a smatch warning: 77e2c0f V4L/DVB (12900): DiB8000: added support for DiBcom ISDB-T/ISDB-Tsb demodulator DiB8000 + drivers/media/dvb/frontends/dib8000.c:1837 dib8000_tune() warn: variable dereferenced before check 'state' (see line 1834) vim +1837 d