Re: [PATCH] [media] stk1160: Remove dead code from stk1160_i2c_read_reg()

2012-10-12 Thread Ezequiel Garcia
On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl wrote: > There are two checks for 'rc' being less than zero with no change to > 'rc' between the two, so the second is just dead code - remove it. > > Signed-off-by: Jesper Juhl > --- > drivers/media/usb/stk1160/stk1160-i2c.c |3 --- > 1 files chan

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-12 Thread Guennadi Liakhovetski
Hi Bearing in mind the local time, I hope my brevity will be excused:-) Just wanted to give a sign, that I just finished a first successful run of a fully asynchronous and uniform multi-component non-DT video (soc-camera) pipeline probing, verified by a sample capture. What this means: The pip

[PATCH] [media] stk1160: Remove dead code from stk1160_i2c_read_reg()

2012-10-12 Thread Jesper Juhl
There are two checks for 'rc' being less than zero with no change to 'rc' between the two, so the second is just dead code - remove it. Signed-off-by: Jesper Juhl --- drivers/media/usb/stk1160/stk1160-i2c.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/media/

[PATCH] videobuf2-core: Verify planes lengths for output buffers

2012-10-12 Thread Laurent Pinchart
For output buffers application provide to the kernel the number of bytes they stored in each plane of the buffer. Verify that the value is smaller than or equal to the plane length. Signed-off-by: Laurent Pinchart --- drivers/media/v4l2-core/videobuf2-core.c | 36 ++

cron job: media_tree daily build: WARNINGS

2012-10-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Oct 12 19:00:25 CEST 2012 git hash:d92462401dde1effa04a51d0a15000e6246d2a43 gcc version: i686-linux-gcc (GC

[PATCH 2/3] omap3isp: video: Fix warning caused by bad vidioc_s_crop prototype

2012-10-12 Thread Laurent Pinchart
Commit 4f996594 ("v4l2: make vidioc_s_crop const") modified the vidioc_s_crop operation prototype but forgot to update the OMAP3 ISP driver. Add a const keyword to fix the function prototype. Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap3isp/ispvideo.c |2 +- 1 files change

[PATCH 1/3] omap3isp: Remove unneeded module memory address definitions

2012-10-12 Thread Laurent Pinchart
The OMAP3ISP_*_REG_OFFSET, OMAP3ISP_*_REG_BASE and OMAP3ISP_*_REG macros are not needed. Remove them. The only expection is the OMAP3ISP_HIST_REG_BASE address. Replace it with the memory address received through platform resources. Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap

[PATCH 3/3] omap3isp: Fix warning caused by bad subdev events operations prototypes

2012-10-12 Thread Laurent Pinchart
Remove the const keyword from the V4L2 subdev events operations to match the V4L2 API. Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap3isp/ispccdc.c |4 ++-- drivers/media/platform/omap3isp/ispstat.c |4 ++-- drivers/media/platform/omap3isp/ispstat.h |4 ++-- 3 files

[PATCH 0/3] Miscellaneous OMAP3 ISP fixes

2012-10-12 Thread Laurent Pinchart
Hi everybody, The subject line says it all, there's not much to add. I'll push those patches for v3.8. Laurent Pinchart (3): omap3isp: Remove unneeded module memory address definitions omap3isp: video: Fix warning caused by bad vidioc_s_crop prototype omap3isp: Fix warning caused by bad sub

[PATCH v3] omap3isp: Use monotonic timestamps for statistics buffers

2012-10-12 Thread Laurent Pinchart
V4L2 buffers use the monotonic clock, while statistics buffers use wall time. This makes it difficult to correlate video frames and statistics. Switch statistics buffers to the monotonic clock to fix this. Reported-by: Antoine Reversat Signed-off-by: Laurent Pinchart --- drivers/media/platform

Re: [Linaro-mm-sig] [PATCH] dma-buf: Use EXPORT_SYMBOL

2012-10-12 Thread Alan Cox
> > Then they can accept the risk of ignoring EXPORT_SYMBOL_GPL and > > calling into it anyway can't they. Your argument makes no rational sense > > of any kind. > > But then why object to the change, your objection makes sense, naking > the patch makes none, if you believe in your objection. [l/

RE: Proposal for the addition of a binary V4L2 control type

2012-10-12 Thread Alain VOLMAT
Hi Hans > -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Friday, October 12, 2012 8:21 AM > To: Alain VOLMAT > Cc: Laurent Pinchart; Linux Media Mailing List (linux-media@vger.kernel.org) > Subject: Re: Proposal for the addition of a binary V4L2 control type >

Re: hacking MT9P031 for i.mx

2012-10-12 Thread Laurent Pinchart
Hi Christoph, On Friday 12 October 2012 14:10:43 Christoph Fritz wrote: > On Mon, 2012-07-02 at 14:48 +0200, Laurent Pinchart wrote: > > On Thursday 28 June 2012 21:41:16 Chris MacGregor wrote: > > > > Where did you get the Aptina board code patch from ? > > > > > > From here: https://github.co

Re: mmotm 2012-10-11-16-14 uploaded (media/i2c/m5mols/m5mols_core)

2012-10-12 Thread Sylwester Nawrocki
On 10/12/2012 08:30 AM, Randy Dunlap wrote: > On 10/11/2012 04:15 PM, a...@linux-foundation.org wrote: > >> The mm-of-the-moment snapshot 2012-10-11-16-14 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> http://ww

Re: hacking MT9P031 for i.mx

2012-10-12 Thread Christoph Fritz
Hi On Mon, 2012-07-02 at 14:48 +0200, Laurent Pinchart wrote: > On Thursday 28 June 2012 21:41:16 Chris MacGregor wrote: > > > Where did you get the Aptina board code patch from ? > > > > From here: https://github.com/Aptina/BeagleBoard-xM > > That's definitely outdated, the code is based on a

IVTV Hauppauge PVR 150 bug

2012-10-12 Thread Phas Mid
I'm having problems with the IVTV driver in kernel 3.4.0. I'm running Ubuntu 12.04 with this Ubuntu compiled kernel specifically to eliminate another USB bug that was causing dmesg to fill up. The card reports an error in ivtv_serialized_open and then reloads the firmware sporadically. Once t

IVTV Hauppauge PVR 350 bug

2012-10-12 Thread Phas Mid
I'm having problems with the IVTV driver in kernel 3.4.0. I'm running Ubuntu 12.04 with this Ubuntu compiled kernel specifically to eliminate another USB bug that was causing dmesg to fill up. The card reports an error in ivtv_serialized_open and then reloads the firmware sporadically. Once

Re: Multiple Rectangle cropping

2012-10-12 Thread Laurent Pinchart
On Friday 12 October 2012 09:18:42 Ricardo Ribalda Delgado wrote: > Hello > > In fact, is the sensor, the one that supports multiple Areas of > Interest. Unfortunatelly the userland v4l2 api only supports one area > of interest for doing croping (or that is what I believe). > > Is there any plan

Re: [PATCH 2/2] [media] winbond: remove space from driver name

2012-10-12 Thread Sean Young
On Fri, Oct 12, 2012 at 01:16:36AM +0200, David Härdeman wrote: > On Fri, Sep 28, 2012 at 09:44:33AM +0100, Sean Young wrote: > >[root@pequod ~]# udevadm test /sys/class/rc/rc0 > >-snip- > >ACTION=add > >DEVPATH=/devices/pnp0/00:04/rc/rc0 > >DRV_NAME=Winbond CIR > >NAME=rc-rc6-mce > >SUBSYSTEM=rc >

Re: [PATCHv10 22/26] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned

2012-10-12 Thread Laurent Pinchart
Hi Tomasz, On Friday 12 October 2012 09:44:05 Tomasz Stanislawski wrote: > On 10/11/2012 11:36 PM, Laurent Pinchart wrote: > > On Wednesday 10 October 2012 16:46:41 Tomasz Stanislawski wrote: > >> From: Marek Szyprowski > >> > >> The DMA transfer must be aligned to a specific value. If userptr i

Re: [PATCHv10 21/26] v4l: vb2-dma-contig: add reference counting for a device from allocator context

2012-10-12 Thread Laurent Pinchart
Hi Tomasz, On Friday 12 October 2012 08:28:23 Tomasz Stanislawski wrote: > On 10/11/2012 11:49 PM, Laurent Pinchart wrote: > > On Wednesday 10 October 2012 16:46:40 Tomasz Stanislawski wrote: > >> This patch adds taking reference to the device for MMAP buffers. > >> > >> Such buffers, may be expo

Re: [PATCHv10 23/26] v4l: vb2-dma-contig: align buffer size to PAGE_SIZE

2012-10-12 Thread Tomasz Stanislawski
Hi Laurent, On 10/11/2012 11:31 PM, Laurent Pinchart wrote: > Hi Tomasz, > > On Wednesday 10 October 2012 16:46:42 Tomasz Stanislawski wrote: >> Most operations on DMA and DMABUF framework need page >> aligned buffers. > > The comment is a bit misleading, the buffer is already page-aligned (unle

Re: [PATCHv10 22/26] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned

2012-10-12 Thread Hans Verkuil
On Fri 12 October 2012 09:44:05 Tomasz Stanislawski wrote: > Hi Laurent, > Thank you for the review. > Please refer to the comments below. > > On 10/11/2012 11:36 PM, Laurent Pinchart wrote: > > Hi Tomasz, > > > > Thanks for the patch. > > > > On Wednesday 10 October 2012 16:46:41 Tomasz Stanisl

Re: [PATCHv10 22/26] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned

2012-10-12 Thread Tomasz Stanislawski
Hi Laurent, Thank you for the review. Please refer to the comments below. On 10/11/2012 11:36 PM, Laurent Pinchart wrote: > Hi Tomasz, > > Thanks for the patch. > > On Wednesday 10 October 2012 16:46:41 Tomasz Stanislawski wrote: >> From: Marek Szyprowski >> >> The DMA transfer must be aligned

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-12 Thread Steffen Trumtrar
On Thu, Oct 11, 2012 at 09:31:18PM +0200, Thierry Reding wrote: > On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote: > > On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote: > > > On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: > [...] > > > > + > > > > +

Re: Multiple Rectangle cropping

2012-10-12 Thread Ricardo Ribalda Delgado
Hello In fact, is the sensor, the one that supports multiple Areas of Interest. Unfortunatelly the userland v4l2 api only supports one area of interest for doing croping (or that is what I believe). Is there any plan to support multiple AOI? or I have to make my own ioctl? Regards On Fri, Oct