Re: [PATCH] [media] vpif_display: fix return value check in vpif_reqbufs()

2012-11-14 Thread Prabhakar Lad
Hi Wei, On Mon, Nov 12, 2012 at 2:14 PM, Wei Yongjun wrote: > Hi Prabhakar, > > On 11/09/2012 08:33 PM, Prabhakar Lad wrote: >> Hi Wei, >> >> Thanks for the patch. >> >> On Wed, Oct 24, 2012 at 4:59 PM, Wei Yongjun wrote: >>> From: Wei Yongjun >>> >>> In case of error, the function vb2_dma_cont

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

2012-11-14 Thread Laurent Pinchart
Hi Sakari, On Wednesday 14 November 2012 23:13:45 Sakari Ailus wrote: > On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > > Hi all, > > > > > > Comments would be appreciated, either positive or negative. The omap3isp > > > driv

Re: AW: [omap3-isp-live] Autofocus buffer interpretation of H3A engine

2012-11-14 Thread Laurent Pinchart
Hi Florian, On Friday 09 November 2012 15:57:58 Florian Neuhaus wrote: > Laurent Pinchart wrote on 2012-11-04: > > The AD5821 is similar to the AD5820, for which I have a driver that I need > > to clean up and post. Would you be interested in that ? > > Yes, you can send me the driver. I've just

[PATCH] ad5820: Voice coil motor controller driver

2012-11-14 Thread Laurent Pinchart
The AD5820 is a voice coil motor controller typically used to control lens position in digital cameras. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/Kconfig |9 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ad5820.c | 496 in

Re: Regarding bulk transfers on stk1160

2012-11-14 Thread Michael Hartup
On 14 Nov 2012, at 22:53, Ezequiel Garcia wrote: > Hi Greg, > > On Tue, Nov 13, 2012 at 11:58 AM, Greg KH wrote: >> >> Or better yet, buy a board with a working USB port, like a BeagleBone or >> the like :) >> > > Michael Hartup (the interested user) *has* a beaglebone. > > I'm trying to he

Re: Regarding bulk transfers on stk1160

2012-11-14 Thread Ezequiel Garcia
Hi Greg, On Tue, Nov 13, 2012 at 11:58 AM, Greg KH wrote: > > Or better yet, buy a board with a working USB port, like a BeagleBone or > the like :) > Michael Hartup (the interested user) *has* a beaglebone. I'm trying to help him getting it ready for stk1160. However, Michael is getting choppy

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

2012-11-14 Thread Sakari Ailus
On Wed, Nov 14, 2012 at 11:58:42AM +0100, Laurent Pinchart wrote: > I think my preference would go for a helper function that drivers can use, > possibly first waiting until a second driver requires this kind of checks > before implementing it. I'd like to see a driver that doesn't. Quite likely

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

2012-11-14 Thread Sakari Ailus
Hi Sylwester, Thanks for the comments. On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > Hi all, > > > > Comments would be appreciated, either positive or negative. The omap3isp > > driver does the same check itself currently, b

cron job: media_tree daily build: WARNINGS

2012-11-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Nov 14 19:00:19 CET 2012 git hash:2c4e11b7c15af70580625657a154ea7ea70b8c76 gcc version: i686-linux-gcc (GCC

Re: Support for Terratec Cinergy 2400i DT in kernel 3.x

2012-11-14 Thread Patrice Chotard
Yes, there are differences, simply because algorithms which use these tables are different ;-). On 14/11/2012 10:36, Frédéric wrote: > Le mercredi 14 novembre 2012, Frédéric a écrit : > >> I had a look at your patches. I don't see the '.fw_version' param anymore >> in the 'ngene_info' structure.

Re: Support for Terratec Cinergy 2400i DT in kernel 3.x

2012-11-14 Thread Patrice Chotard
Hi Frédéric, You are right, in the ngene initial commit (dae52d009fc950b5c209260d50fcc000f5becd3c), no fw_version was set, so by default the ngene_15.fw is selected. But in the patch available here http://wiki.ubuntuusers.de/_attachment?target=/Terratec_Cinergy_2400i_DT/ngene_p11.tar.gz, fw_versi

Hauppauge WinTV HVR 900 (M/R 65018/B3C0) doesn't work anymore since linux 3.6.6

2012-11-14 Thread Philippe Valembois - Phil
Hello, I have posted a bug report here : https://bugzilla.kernel.org/show_bug.cgi?id=50361 and I have been told to send it to the ML too. The commit causing the bug has been pushed to kernel between linux-3.5 and linux-3.6. Here is my bug summary : The WinTV HVR900 DVB-T usb stick has stopped wo

Re: [PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion

2012-11-14 Thread Sascha Hauer
On Wed, Nov 14, 2012 at 04:22:40PM -0200, Fabio Estevam wrote: > Hi Sascha, > > On Wed, Oct 31, 2012 at 9:57 AM, Mauro Carvalho Chehab > wrote: > > > As it seems that those patches depend on some patches at the arm tree, > > the better is to merge them via -arm tree. > > > > So, > > > > Acked-by

Re: [PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion

2012-11-14 Thread Fabio Estevam
Hi Sascha, On Wed, Oct 31, 2012 at 9:57 AM, Mauro Carvalho Chehab wrote: > As it seems that those patches depend on some patches at the arm tree, > the better is to merge them via -arm tree. > > So, > > Acked-by: Mauro Carvalho Chehab Could you please apply this series via your tree? Thanks,

Re: [PATCH 2/3] tcm825x: Remove driver

2012-11-14 Thread David Cohen
On Mon, Nov 12, 2012 at 2:47 PM, Sakari Ailus wrote: > > Remove tcm825x driver. It uses the obsolete V4L2 int device framework, and > can only work with omap24xxcam driver. > > Signed-off-by: Sakari Ailus I wonder if you will ever fix and send it again :) Acked-by: David Cohen > --- > driver

Re: The em28xx driver error

2012-11-14 Thread Devin Heitmueller
On Wed, Nov 14, 2012 at 11:58 AM, Frank Schäfer wrote: > This looks indeed like a bug. > a >>= b means a = a >> b, which in this case means shifting height 480 > or 576 bits to the right... > height >> 1 means height /= 2 which seems to be sane for interlaced devices. > OTOH, I wonder why it seems

Re: The em28xx driver error

2012-11-14 Thread Frank Schäfer
Am 11.11.2012 05:46, schrieb Michael Yang: > Hi I am using a v4l2 usb video capturer (em28xx based) on the TI-DM3730 board > I used the default driver ,the video can't be captured. I solve this issue > by > change the em28xx driver : > > linux-stable/drivers/media/video/em28xx/em28xx-core.c > >

Re: [PATCH v9 5/6] drm_modes: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 01:49:44PM +0100, Thierry Reding wrote: > On Wed, Nov 14, 2012 at 12:43:22PM +0100, Steffen Trumtrar wrote: > [...] > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > [...] > > @@ -504,6 +505,41 @@ drm_gtf_mode(struct drm_device *dev, int hdisplay,

Re: [PATCH v9 3/6] fbmon: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 01:12:07PM +0100, Thierry Reding wrote: > On Wed, Nov 14, 2012 at 12:43:20PM +0100, Steffen Trumtrar wrote: > > Add a function to convert from the generic videomode to a fb_videomode. > > > > Signed-off-by: Steffen Trumtrar > > --- > > drivers/video/fbmon.c | 38 +++

Re: [PATCH v9 2/6] video: add of helper for videomode

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 01:00:45PM +0100, Thierry Reding wrote: > On Wed, Nov 14, 2012 at 12:43:19PM +0100, Steffen Trumtrar wrote: > [...] > > +display-timings bindings > > + > > + > > +display timings node > > I didn't express myself very clearly here =). The way I think

Re: [RFC/PATCH] v4l: Add V4L2_CID_FLASH_HW_STROBE_MODE control

2012-11-14 Thread Laurent Pinchart
Hi Sakari, On Tuesday 13 November 2012 23:53:46 Sakari Ailus wrote: > On Wed, Oct 24, 2012 at 11:04:11AM +0200, Sylwester Nawrocki wrote: > > On 10/23/2012 10:07 PM, Sakari Ailus wrote: > > > On Tue, Oct 16, 2012 at 11:45:59PM +0200, Sylwester Nawrocki wrote: > > >> On 10/14/2012 08:30 PM, Sakari

[PATCH] [media] s5p-mfc: Handle multi-frame input buffer

2012-11-14 Thread Arun Kumar K
When one input buffer has multiple frames, it should be fed again to the hardware with the remaining bytes. Removed the check for P frame in this scenario as this condition can come with all frame types. Signed-off-by: Arun Kumar K Signed-off-by: ARUN MANKUZHI --- drivers/media/platform/s5p-mfc

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-14 Thread Laurent Pinchart
Hi Sakari, On Tuesday 13 November 2012 01:37:51 Sakari Ailus wrote: > On Mon, Nov 12, 2012 at 12:06:50PM +0100, Laurent Pinchart wrote: > > On Monday 12 November 2012 00:33:17 Sakari Ailus wrote: > > > On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote: > > > > On Wed, 31 Oct 20

[PATCH] [media] coda: Fix build due to iram.h rename

2012-11-14 Thread Fabio Estevam
commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed the location of iram.h, which causes the following build error when building the coda driver: drivers/media/platform/coda.c:27:23: error: mach/iram.h: No such file or directory drivers/media/platform/coda.c: In function

Re: [PATCH v9 6/6] drm_modes: add of_videomode helpers

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:43:23PM +0100, Steffen Trumtrar wrote: [...] > +EXPORT_SYMBOL_GPL(of_get_drm_display_mode); > +#endif > /** Nit: there should be a blank line between the last two. Thierry pgpTTm3RVeMhV.pgp Description: PGP signature

Re: [PATCH v9 5/6] drm_modes: add videomode helpers

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:43:22PM +0100, Steffen Trumtrar wrote: [...] > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c [...] > @@ -504,6 +505,41 @@ drm_gtf_mode(struct drm_device *dev, int hdisplay, int > vdisplay, int vrefresh, > } > EXPORT_SYMBOL(drm_gtf_mode); > >

Re: [PATCH v9 4/6] fbmon: add of_videomode helpers

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:43:21PM +0100, Steffen Trumtrar wrote: [...] > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c [...] > +#if IS_ENABLED(CONFIG_OF_VIDEOMODE) > +static void dump_fb_videomode(struct fb_videomode *m) static inline? Thierry pgpjEMXjaOx0a.pgp Description: PGP si

Re: [PATCH v9 3/6] fbmon: add videomode helpers

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:43:20PM +0100, Steffen Trumtrar wrote: > Add a function to convert from the generic videomode to a fb_videomode. > > Signed-off-by: Steffen Trumtrar > --- > drivers/video/fbmon.c | 38 ++ > include/linux/fb.h|5 + > 2 f

Re: [PATCH v9 2/6] video: add of helper for videomode

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:43:19PM +0100, Steffen Trumtrar wrote: [...] > +optional properties: > + - native-mode: the native mode for the display, in case multiple modes are > + provided. When omitted, assume the first node is the native. I forgot: The first sentence in this descripti

Re: [PATCH v9 1/6] video: add display_timing and videomode

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:43:18PM +0100, Steffen Trumtrar wrote: [...] > diff --git a/include/linux/videomode.h b/include/linux/videomode.h [...] > +int videomode_from_timing(struct display_timings *disp, struct videomode *vm, > + unsigned int index); > +#endif Nit: should h

Re: [PATCH v9 2/6] video: add of helper for videomode

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:43:19PM +0100, Steffen Trumtrar wrote: [...] > +display-timings bindings > + > + > +display timings node I didn't express myself very clearly here =). The way I think this should be written is "display-timings node". > +required properties: > + -

[PATCH v9 2/6] video: add of helper for videomode

2012-11-14 Thread Steffen Trumtrar
This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where each property can have up to 3 values. All children are read into an array, that can be queried. of_get_videomode converts

[PATCH v9 4/6] fbmon: add of_videomode helpers

2012-11-14 Thread Steffen Trumtrar
Add helper to get fb_videomode from devicetree. Signed-off-by: Steffen Trumtrar --- drivers/video/fbmon.c | 42 +- include/linux/fb.h|6 ++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbmon.c b/drivers/video/f

[PATCH v9 3/6] fbmon: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar --- drivers/video/fbmon.c | 38 ++ include/linux/fb.h|5 + 2 files changed, 43 insertions(+) diff --git a/drivers/video/fbmon.c b/drivers/vid

[PATCH v9 0/6] of: add display helper

2012-11-14 Thread Steffen Trumtrar
Hi! Changes since v8: - fix memory leaks - change API to be more consistent (foo_from_bar(struct bar, struct foo)) - include headers were necessary - misc minor bufixes Regards, Steffen Steffen Trumtrar (6): video: add display_timing and videomode video: add

[PATCH v9 5/6] drm_modes: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
Add conversion from videomode to drm_display_mode Signed-off-by: Steffen Trumtrar --- drivers/gpu/drm/drm_modes.c | 36 include/drm/drmP.h |6 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/

[PATCH v9 1/6] video: add display_timing and videomode

2012-11-14 Thread Steffen Trumtrar
Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single value or a range . Also, add helper functions to convert from display timings to a generic videomode

[PATCH v9 6/6] drm_modes: add of_videomode helpers

2012-11-14 Thread Steffen Trumtrar
Add helper to get drm_display_mode from devicetree. Signed-off-by: Steffen Trumtrar --- drivers/gpu/drm/drm_modes.c | 35 ++- include/drm/drmP.h |6 ++ 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/

Re: [PATCH v8 1/6] video: add display_timing and videomode

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:10:15PM +0100, Steffen Trumtrar wrote: > On Wed, Nov 14, 2012 at 12:02:15PM +0100, Thierry Reding wrote: > > On Wed, Nov 14, 2012 at 11:59:25AM +0100, Steffen Trumtrar wrote: > > > On Wed, Nov 14, 2012 at 11:56:34AM +0100, Thierry Reding wrote: > > > > On Mon, Nov 12, 201

Re: [PATCH v8 1/6] video: add display_timing and videomode

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 12:02:15PM +0100, Thierry Reding wrote: > On Wed, Nov 14, 2012 at 11:59:25AM +0100, Steffen Trumtrar wrote: > > On Wed, Nov 14, 2012 at 11:56:34AM +0100, Thierry Reding wrote: > > > On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote: > > > [...] > > > > diff --

Re: [PATCH v8 1/6] video: add display_timing and videomode

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 11:59:25AM +0100, Steffen Trumtrar wrote: > On Wed, Nov 14, 2012 at 11:56:34AM +0100, Thierry Reding wrote: > > On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote: > > [...] > > > diff --git a/drivers/video/display_timing.c > > > b/drivers/video/display_timing

Re: [PATCH v8 1/6] video: add display_timing and videomode

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 11:56:34AM +0100, Thierry Reding wrote: > On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote: > [...] > > diff --git a/drivers/video/display_timing.c b/drivers/video/display_timing.c > [...] > > +void display_timings_release(struct display_timings *disp) > > +{

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-14 Thread Thierry Reding
On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: [...] > diff --git a/include/linux/of_display_timings.h > b/include/linux/of_display_timings.h [...] > +#ifndef __LINUX_OF_DISPLAY_TIMINGS_H > +#define __LINUX_OF_DISPLAY_TIMINGS_H > + > +#include > + > +#define OF_USE_NATIVE_MODE

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

2012-11-14 Thread Laurent Pinchart
Hi Sylwester, On Wednesday 14 November 2012 10:23:19 Sylwester Nawrocki wrote: > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > Hi all, > > > > Comments would be appreciated, either positive or negative. The omap3isp > > driver does the same check itself currently, but I think this is more > > g

Re: [PATCH v8 1/6] video: add display_timing and videomode

2012-11-14 Thread Thierry Reding
On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote: [...] > diff --git a/drivers/video/display_timing.c b/drivers/video/display_timing.c [...] > +void display_timings_release(struct display_timings *disp) > +{ > + if (disp->timings) { > + unsigned int i; > + > +

Concerning OMAP v4l2 driver (omap_vout)

2012-11-14 Thread Tomi Valkeinen
Hi Vaibhav, I'd like to get clarity on the omap_vout maintenance. You've been the maintainer of omap_vout, but you have lately been quite inactive in this role, and getting omap_vout patches merged has not been as fluent as it could be. Do you still want to continue in this role? Will you have ti

Re: DVB V5 API: Event Model

2012-11-14 Thread Martin Rudge
Thanks Mauro. I'm not familiar with the code, however I'll review the design/code and see what could be done. A quick look suggests the events are originating from the tuning loop, so it's down to the timing of copying the parms for voltage/tone (not currently instigated by a DTV_TUNE). Thank

Re: Support for Terratec Cinergy 2400i DT in kernel 3.x

2012-11-14 Thread Frédéric
Le mercredi 14 novembre 2012, Frédéric a écrit : > I had a look at your patches. I don't see the '.fw_version' param anymore > in the 'ngene_info' structure... Is it normal? I also noticed some differences in the PLL presets: In your patch: .entries = { { 30500, 17, 0xb

[GIT PULL FOR v3.8] V4L subdev fix

2012-11-14 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 2c4e11b7c15af70580625657a154ea7ea70b8c76: [media] siano: fix RC compilation (2012-11-07 11:09:08 +0100) are available in the git repository at: git://linuxtv.org/pinchartl/media.git v4l2/core Laurent Pinchart (1): v4l: Don't warn during lin

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

2012-11-14 Thread Sylwester Nawrocki
Hi Sakari, On 11/13/2012 03:24 PM, Sakari Ailus wrote: > Hi all, > > Comments would be appreciated, either positive or negative. The omap3isp > driver does the same check itself currently, but I think this is more > generic than that. > > Thanks. > > On Fri, Oct 26, 2012 at 10:46:17PM +0300, Sa

Re: Support for Terratec Cinergy 2400i DT in kernel 3.x

2012-11-14 Thread Frédéric
Le mardi 13 novembre 2012, Patrice Chotard a écrit : > Two patches have been already submitted and are available since v3.7-rc1 > > media] ngene: add support for Terratec Cynergy 2400i Dual DVB-T : > 397e972350c42cbaf3228fe2eec23fecf6a69903 > > and > > media] dvb: add support for Thomson DTT75