[PATCH] em28xx-i2c: relax error check in em28xx_i2c_recv_bytes()

2013-03-10 Thread Frank Schäfer
It turned out that some devices return less bytes then requested via i2c when ALL of the following 3 conditions are met: - i2c bus B is used - there was no attempt to write to the specified slave address before - no device present at the specified slave address With the current code, this triggers

[RFC PATCH 1/2] bttv: fix audio mute on device close for the video device node

2013-03-10 Thread Frank Schäfer
Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c | 22 +++--- 1 Datei geändert, 11 Zeilen hinzugefügt(+), 11 Zeilen entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 8610b6a..2c09bc5 100644 --- a/

[RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Frank Schäfer
Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |5 - 1 Datei geändert, 4 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 2c09bc5..74977f7 100644 --- a/drivers/media/pci/bt

Re: [RFC PATCH 1/2] bttv: fix audio mute on device close for the video device node

2013-03-10 Thread Frank Schäfer
Am 10.03.2013 12:40, schrieb Frank Schäfer: > Signed-off-by: Frank Schäfer > --- > drivers/media/pci/bt8xx/bttv-driver.c | 22 +++--- > 1 Datei geändert, 11 Zeilen hinzugefügt(+), 11 Zeilen entfernt(-) > > diff --git a/drivers/media/pci/bt8xx/bttv-driver.c > b/drivers/media/pci

Re: [RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Frank Schäfer
Hans, in one of your previous comments you mentioned that radio devices have to be handled differently, so I'm not sure if this is the right thing to do... Am 10.03.2013 12:40, schrieb Frank Schäfer: > Signed-off-by: Frank Schäfer > --- > drivers/media/pci/bt8xx/bttv-driver.c |5 - > 1 D

Re: [RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Hans Verkuil
On Sun March 10 2013 12:40:35 Frank Schäfer wrote: > Signed-off-by: Frank Schäfer > --- > drivers/media/pci/bt8xx/bttv-driver.c |5 - > 1 Datei geändert, 4 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) > > diff --git a/drivers/media/pci/bt8xx/bttv-driver.c > b/drivers/media/pci/bt8xx/bttv-

Re: [RFC PATCH 1/2] bttv: fix audio mute on device close for the video device node

2013-03-10 Thread Hans Verkuil
On Sun March 10 2013 12:40:34 Frank Schäfer wrote: > Signed-off-by: Frank Schäfer Could you describe exactly what bug is fixed? I tested it a fair amount when I created my bttv patches, so I'd like to know what I missed. Regards, Hans > --- > drivers/media/pci/bt8xx/bttv-driver.c |

[PATCH] Drivers: staging: media: davinci_vpfe: Use resource_size function

2013-03-10 Thread Alexandru Gheorghiu
Use resource_size function on resource object instead of explicit computation. Signed-off-by: Alexandru Gheorghiu --- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c b/

Re: [RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Frank Schäfer
Am 10.03.2013 12:59, schrieb Hans Verkuil: > On Sun March 10 2013 12:40:35 Frank Schäfer wrote: >> Signed-off-by: Frank Schäfer >> --- >> drivers/media/pci/bt8xx/bttv-driver.c |5 - >> 1 Datei geändert, 4 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) >> >> diff --git a/drivers/media/pci/bt8x

Re: [RFC PATCH 1/2] bttv: fix audio mute on device close for the video device node

2013-03-10 Thread Frank Schäfer
Am 10.03.2013 13:00, schrieb Hans Verkuil: > On Sun March 10 2013 12:40:34 Frank Schäfer wrote: >> Signed-off-by: Frank Schäfer > Could you describe exactly what bug is fixed? I tested it a fair amount > when I created my bttv patches, so I'd like to know what I missed. Yeah, sure. The whole thin

Re: [RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Hans Verkuil
On Sun March 10 2013 14:47:48 Frank Schäfer wrote: > Am 10.03.2013 12:59, schrieb Hans Verkuil: > > On Sun March 10 2013 12:40:35 Frank Schäfer wrote: > >> Signed-off-by: Frank Schäfer > >> --- > >> drivers/media/pci/bt8xx/bttv-driver.c |5 - > >> 1 Datei geändert, 4 Zeilen hinzugefügt(+)

Re: [RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Mauro Carvalho Chehab
Em Sun, 10 Mar 2013 14:47:48 +0100 Frank Schäfer escreveu: > Am 10.03.2013 12:59, schrieb Hans Verkuil: > > On Sun March 10 2013 12:40:35 Frank Schäfer wrote: > >> Signed-off-by: Frank Schäfer > >> --- > >> drivers/media/pci/bt8xx/bttv-driver.c |5 - > >> 1 Datei geändert, 4 Zeilen hinz

[PATCH 1/7] hverkuil/go7007: staging: media: go7007: Add Framesizes

2013-03-10 Thread Volokh Konstantin
Signed-off-by: Volokh Konstantin --- drivers/staging/media/go7007/go7007-v4l2.c | 76 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c index 66307ea..4ec9b84 1006

[PATCH 2/7] hverkuil/go7007: staging: media: go7007: Add Frameintervals

2013-03-10 Thread Volokh Konstantin
Signed-off-by: Volokh Konstantin --- drivers/staging/media/go7007/go7007-v4l2.c | 123 1 files changed, 123 insertions(+), 0 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c index 4ec9b84..96538f6 100

[PATCH 3/7] hverkuil/go7007: staging: media: go7007: Restore b_frame control

2013-03-10 Thread Volokh Konstantin
Signed-off-by: Volokh Konstantin --- drivers/staging/media/go7007/go7007-priv.h |1 + drivers/staging/media/go7007/go7007-v4l2.c |7 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-priv.h b/drivers/staging/media/go7007/go7007-pri

[PATCH 4/7] hverkuil/go7007: staging: media: go7007: Add Modet controls

2013-03-10 Thread Volokh Konstantin
Signed-off-by: Volokh Konstantin --- drivers/staging/media/go7007/go7007-v4l2.c | 95 drivers/staging/media/go7007/go7007.h | 18 + 2 files changed, 113 insertions(+), 0 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/stag

[PATCH 5/7] hverkuil/go7007: staging: media: go7007: Functionality for modet controls

2013-03-10 Thread Volokh Konstantin
The idea of modet controls through userspace is: The first of all need select region number (0..3) (it value stores) And then config thresolds (pixel,motion,trigger) for that region. Also it`s available setup regions controls (each of 16x16 rects of the frame, where detection will be approve). In u

[PATCH 6/7] hverkuil/go7007: staging: media: go7007: Cleanup Unused modet code

2013-03-10 Thread Volokh Konstantin
Signed-off-by: Volokh Konstantin --- drivers/staging/media/go7007/go7007-v4l2.c | 94 1 files changed, 0 insertions(+), 94 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c index 7ea0ea1..30ae939 1006

[PATCH 7/7] hverkuil/go7007: staging: media: go7007: Clean trivial

2013-03-10 Thread Volokh Konstantin
Signed-off-by: Volokh Konstantin --- drivers/staging/media/go7007/go7007-priv.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-priv.h b/drivers/staging/media/go7007/go7007-priv.h index 36b271f..9ec5319 100644 --- a/drivers/staging/med

Re: [RFC 00/12] Adding media device driver for Exynos imaging subsystem

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: The following patchset features: 1] Creating a common pipeline framework which can be used by all Exynos series SoCs for developing media device drivers. 2] Modified the existing fimc-mdevice for exynos4 to use the common pipeline framework. 3] Ad

Re: [RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the Exynos5 soc compatibility to the fimc-lite driver. It also adds a version checking to deal with the changes between different fimc-lite hardware versions. Is there really anything different between the Exynos4 and Exynos5 FIMC

Re: [RFC 03/12] media: fimc-lite: Adding support for Exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the following functionalities to existing driver 1] FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards. This patch adds the functionality of using shadow registers by checking the current FIMC-LITE hardware versi

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just wondering, if there aren't any further changes needed to make the driver really working on exynos5250 ? Signed-off-by: Shaik Ameer Basha --- drivers/media/platform/s5p-fim

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds necessary source definations needed for mipi-csis driver and adds devicetree node for exynos5250. Signed-off-by: Shaik Ameer Basha --- arch/arm/boot/dts/exynos5250.dtsi | 18 ++ arch/arm/mach-exynos/clock

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -47,6 +47,8 @@ i2c6 =&i2c_6; i2c7 =&i2c_7; i2c8 =&i2c_8; + csis0 =&csis_0; + csis1 =&csis

cron job: media_tree daily build: WARNINGS

2013-03-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Mar 10 19:00:20 CET 2013 git branch: test git hash: 457ba4ce4f435d0b4dd82a0acc6c796e541a2ea7 gcc versio

Re: [RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Frank Schäfer
Am 10.03.2013 14:56, schrieb Hans Verkuil: > On Sun March 10 2013 14:47:48 Frank Schäfer wrote: >> Am 10.03.2013 12:59, schrieb Hans Verkuil: >>> On Sun March 10 2013 12:40:35 Frank Schäfer wrote: Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |5 - >

[RFC PATCH v2 0/6] bttv: fix muting/unmuting on probing, first open and last close

2013-03-10 Thread Frank Schäfer
This patch series fixes some remaining issues with regards to device muting/unmuting on probing, first open and last close with the bttv driver. The first 2 patches are preparatory patches, patches 3 to 6 the actual fixes. Changes since v1: - splitted patch 1 to 4 separate patches (patches 1-4)

[RFC PATCH v2 1/6] bttv: audio_mux() use a local variable "gpio_mute" instead of modifying the function parameter "mute"

2013-03-10 Thread Frank Schäfer
Function audio_mux() actually deals with two types of mute: gpio mute and subdevice muting. This patch claryfies the meaning of these values, but mainly prepares the code for the next patch. Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |8 1 Datei geändert

[RFC PATCH v2 3/6] bttv: fix mute on last close of the video device node

2013-03-10 Thread Frank Schäfer
Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index a082ab4..945ecd2 100644 --- a/drivers/media/pci/bt8xx/

[RFC PATCH v2 2/6] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-10 Thread Frank Schäfer
There are cases where we want to call audio_mux() without changing the value of the v4l2 mute control, for example - mute mute on last close - mute on device probing Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |8 1 Datei geändert, 4 Zeilen hinzugefügt(+),

[RFC PATCH v2 5/6] bttv: avoid mute on last close when the radio device node is still open

2013-03-10 Thread Frank Schäfer
In contrast to video devices, radio devices should not be muted on the last close of the device node. In cases where a device provides a video and a radio device node, tuner ownership has to be taken into account. The current code doesn't handle tuner ownership yet, so never mute the device if the

[RFC PATCH v2 6/6] bttv: radio: apply mute settings on open

2013-03-10 Thread Frank Schäfer
In contrast to the video device node, radio_open() doesn't select an input (which would also applies the mute setting). Hence the device needs to be muted/unmuted with an explicit call to audio_mux() in this function. Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |2

[RFC PATCH v2 4/6] bttv: do not unmute the device before the first open

2013-03-10 Thread Frank Schäfer
Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |8 +--- 1 Datei geändert, 5 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 945ecd2..6432bfe 100644 --- a/drivers/media/pc

Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch modifies the current fimc_pipeline to exynos_pipeline, I think we could leave it as fimc_pipeline, exynos_pipeline seems too generic to me. which can be used across multiple media device drivers. Signed-off-by: Shaik Ameer Basha ---

Re: [RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds support for media device for EXYNOS5 SoCs. The current media device supports the following ips to connect through the media controller framework. * MIPI-CSIS Support interconnection(subdev interface) between devices * FIMC-LITE

Re: [RFC PATCH 2/2] bttv: fix audio mute on device close for the radio device node

2013-03-10 Thread Hans Verkuil
On Sun March 10 2013 22:49:33 Frank Schäfer wrote: > Am 10.03.2013 14:56, schrieb Hans Verkuil: > > On Sun March 10 2013 14:47:48 Frank Schäfer wrote: > >> Am 10.03.2013 12:59, schrieb Hans Verkuil: > >>> On Sun March 10 2013 12:40:35 Frank Schäfer wrote: > Signed-off-by: Frank Schäfer >

Re: cannot unload cx18_alsa to hibernate Mint13 64 computer

2013-03-10 Thread Andy Walls
Dixon Craig wrote: >Thanks Andy > >Pulse was indeed respawning. >Once I got it killed for certain, I was able to rmmod cx18_alsa and >cx18, >then hibernate and wake up worked without problem. > >On wake up, I tried modprobe cx18_alsa, but it just hung. I exited >by >pressing ctrl-c, and lsmod

Re: [PATCH] Drivers: staging: media: davinci_vpfe: Use resource_size function

2013-03-10 Thread Prabhakar Lad
Hi Alexandru, Thanks for the patch! On Sun, Mar 10, 2013 at 5:44 PM, Alexandru Gheorghiu wrote: > Use resource_size function on resource object instead of explicit > computation. > > Signed-off-by: Alexandru Gheorghiu Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > drivers/stagin

[GIT PULL FOR v3.9] DaVinci media driver fixes

2013-03-10 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for Davinci. The first patch fixes module build for VPBE driver and the second patch fixes the module build for VPIF driver. The following changes since commit f6161aa153581da4a3867a2d1a7caf4be19b6ec9: Linux 3.9-rc2 (2013-03-10 16:54:19 -0700) are a

[GIT PULL FOR v3.10] DaVinci media/tvp514x/ths7353 cleanups and feature enhancement

2013-03-10 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches. A gentle request, can you please pull these patches ASAP as my TI I'd might get shut any movement, so as the mails of patches being queued don’t get bounce. Regards, --Prabhakar Lad The following changes since commit f6161aa153581da4a3867a2d1a7caf4be

Re: [PATCH 1/1] [media] davinci_vpfe: Use module_platform_driver macro

2013-03-10 Thread Sachin Kamat
>> > Queued to my branch > http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/for_v3.10 Thanks Prabhakar. BTW, Manjunath's mail ID (manjunath.ha...@ti.com) bounces. Probably you need to update the correct ID in the MAINTAINERS file? -- With warm regards, Sachin -- To

Re: [PATCH 1/1] [media] davinci_vpfe: Use module_platform_driver macro

2013-03-10 Thread Prabhakar Lad
Hi Sachin, On Mon, Mar 11, 2013 at 11:01 AM, Sachin Kamat wrote: >>> >> Queued to my branch >> http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/for_v3.10 > > Thanks Prabhakar. > > BTW, Manjunath's mail ID (manjunath.ha...@ti.com) bounces. Probably > you need to update

Re: [PATCH 1/1] [media] davinci_vpfe: Use module_platform_driver macro

2013-03-10 Thread Sachin Kamat
On 11 March 2013 11:06, Prabhakar Lad wrote: > Hi Sachin, > > On Mon, Mar 11, 2013 at 11:01 AM, Sachin Kamat > wrote: >>> Queued to my branch >>> http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/for_v3.10 >> >> Thanks Prabhakar. >> >> BTW, Manjunath's mail ID (m

Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the review. Actually I know this is the important patch in this series and I wanted us to have enough time to discuss on this patch. That's why I posted this patch series in hurry. I will remove this patch from the exynos5-mdev series and will send this as a separate patc

Re: [RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:06 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds the Exynos5 soc compatibility to the fimc-lite driver. >> It also adds a version checking to deal with the changes between >> different fimc-lite hardw

Re: [RFC 03/12] media: fimc-lite: Adding support for Exynos5

2013-03-10 Thread Shaik Ameer Basha
Hi Sylweter, On Mon, Mar 11, 2013 at 2:09 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds the following functionalities to existing driver >> >> 1] FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards. >> This patch adds the

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: > > Please don't leave the change log empty. I'll apply this patch. > I'm just wondering, if there aren't any further changes needed > to make the driver really working on e

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:24 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds necessary source definations needed for mipi-csis >> driver and adds devicetree node for exynos5250. >> >> Signed-off-by: Shaik Ameer Basha >> --- >>

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Shaik Ameer Basha
On Mon, Mar 11, 2013 at 2:27 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -47,6 +47,8 @@ >> i2c6 =&i2c_6; >> i2c7 =&i2c_7; >>

Re: [RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the review. I will address all you comments for this patch in the next version. Thanks, Shaik Ameer Basha On Mon, Mar 11, 2013 at 3:58 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds support for media device for EXY