Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

Hi Sylwester, Thanks for the review. Actually I know this is the important patch in this series and I wanted us to have enough time to discuss on this patch. That's why I posted this patch series in hurry. I will remove this patch from the exynos5-mdev series and will send this as a separate

Re: [RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

Hi Sylwester, On Mon, Mar 11, 2013 at 2:06 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the Exynos5 soc compatibility to the fimc-lite driver. It also adds a version checking to deal with the changes between

Re: [RFC 03/12] media: fimc-lite: Adding support for Exynos5

Hi Sylweter, On Mon, Mar 11, 2013 at 2:09 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the following functionalities to existing driver 1] FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards.

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just wondering, if there aren't any further changes needed to make the

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

Hi Sylwester, On Mon, Mar 11, 2013 at 2:24 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds necessary source definations needed for mipi-csis driver and adds devicetree node for exynos5250. Signed-off-by: Shaik Ameer

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

On Mon, Mar 11, 2013 at 2:27 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -47,6 +47,8 @@ i2c6 =i2c_6; i2c7

Re: [RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

Hi Sylwester, Thanks for the review. I will address all you comments for this patch in the next version. Thanks, Shaik Ameer Basha On Mon, Mar 11, 2013 at 3:58 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds support

[PATCH] soc_camera: convert to devm_ioremap_resource()

Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by:

Re: [PATCH] soc_camera: convert to devm_ioremap_resource()

Hi Silviu-Mihai On Mon, 11 Mar 2013, Silviu-Mihai Popescu wrote: Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error

Re: [PATCH] soc_camera: convert to devm_ioremap_resource()

On Mon, Mar 11, 2013 at 9:50 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Is there anything in this patch, that this patch series http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/61337 is missing? Thanks Guennadi Hello Guennadi, I seem to have missed that

Re: [PATCH] soc_camera: convert to devm_ioremap_resource()

On Mon, 11 Mar 2013, Silviu Popescu wrote: On Mon, Mar 11, 2013 at 9:50 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Is there anything in this patch, that this patch series http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/61337 is missing? Thanks

[PATCH] crystalhd gst: Port to GStreamer 1.0 API

--- Tested with totem as well as gst-launch. Any chance this can be applied to http://git.linuxtv.org/jarod/crystalhd.git? Cheers, -- Guido filters/gst/gst-plugin/configure.ac|8 +- filters/gst/gst-plugin/src/gstbcmdec.c | 431

omap3isp: iommu register problem.

Hi, I'm trying to make omap3isp work with our DM3730 based board. When I try to boot the kernel I get the following message: [2.064239] omap3isp omap3isp: Revision 15.0 found [2.070220] omap_iommu_attach: 1 [2.073669] omap_iommu_attach: 2 [2.077056] omap_iommu_attach: 3 [

Re: mt9m111/mt9m131: kernel 3.8 issues.

On Fri, 8 Mar 2013, Guennadi Liakhovetski wrote: On Fri, 8 Mar 2013, Benoît Thébaudeau wrote: Hi Javier, On Friday, March 8, 2013 1:37:38 PM, Javier Martin wrote: Hi Benoît, On 8 March 2013 12:53, Benoît Thébaudeau benoit.thebaud...@advansee.com wrote:

Re: mt9m111/mt9m131: kernel 3.8 issues.

Hi Guennadi, I just tested my mt9m131 camera on a i.MX31 board, if not this your email I don't think I'd be alarmed by the image quality it's producing, maybe I'm just less picky:-) And yes, in general I agree, I think, this level of image quality tuning is difficult to achieve on modern

[REVIEW PATCH 00/42] go7007: complete overhaul

Hi all, This patch series updates the staging go7007 driver to the latest V4L2 frameworks and actually makes it work reliably. Some highlights: - moved the custom i2c drivers to media/i2c. - replaced the s2250-loader by a common loader for all the supported devices. - replaced all

[REVIEW PATCH 03/42] v4l2-ioctl: check if an ioctl is valid.

From: Hans Verkuil hans.verk...@cisco.com Just checking if the op exists isn't correct, you should check if the ioctl is valid (which implies that the op exists as well). One exception is g_std: if current_norm is non-zero, then the g_std op may be absent. This sort of weird behavior is one of

[REVIEW PATCH 04/42] saa7115: add config flag to change the IDQ polarity.

From: Hans Verkuil hans.verk...@cisco.com Needed by the go7007 driver: it assumes a different polarity of the IDQ signal, so we need to be able to tell the saa7115 about this. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/saa7115.c |6 ++

[REVIEW PATCH 02/42] v4l2-core: add code to check for specific ops.

From: Hans Verkuil hans.verk...@cisco.com This patch adds a v4l2_subdev_has_op() macro and a v4l2_device_has_op macro to quickly check if a specific subdev or any subdev supports a particular subdev operation. This makes it easy for drivers to disable certain ioctls if none of the subdevs

[REVIEW PATCH 01/42] v4l2-ctrls: eliminate lockdep false alarms for struct v4l2_ctrl_handler.lock

From: Andy Walls awalls at When calling v4l2_ctrl_add_handler(), lockdep would detect a potential recursive locking problem on a situation that is by design intended and not a recursive lock. This happened because all struct v4l2_ctrl_handler.lock mutexes were created as members of the same lock

[REVIEW PATCH 08/42] tuner: add Sony BTF tuners

From: Hans Verkuil hans.verk...@cisco.com This adds support for three Sony BTF tuners: TUNER_SONY_BTF_PG472Z: PAL+SECAM TUNER_SONY_BTF_PK467Z: NTSC-M-JP TUNER_SONY_BTF_PB463Z: NTSC-M These come from the go7007 staging driver where they were implemented in the wis-sony-tuner i2c driver. Adding

[REVIEW PATCH 05/42] saa7115: improve querystd handling for the saa7115.

From: Hans Verkuil hans.verk...@cisco.com The saa7115 has better PAL/NTSC detection, so it can detect PAL even though the chip is currently set up for NTSC. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/saa7115.c | 56 +-- 1

[REVIEW PATCH 06/42] saa7115: add support for double-rate ASCLK

From: Hans Verkuil hans.verk...@cisco.com Some devices expect a double rate ASCLK. Add a flag to let the driver know through the s_crystal_freq call. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/saa7115.c | 16 +++- include/media/saa7115.h |7

[REVIEW PATCH 13/42] tw2804: add support for the Techwell tw2804.

From: Hans Verkuil hans.verk...@cisco.com This is based on the wis-tw2804.c driver that's part of the go7007 driver. It has been converted to a v4l subdev driver by Volokh Konstantin, and I made additional cleanups. Based on work by: Volokh Konstantin volok...@gmail.com Signed-off-by: Hans

[REVIEW PATCH 09/42] sony-btf-mpx: the MPX driver for the sony BTF PAL/SECAM tuner

From: Hans Verkuil hans.verk...@cisco.com The Sony BTF PG472Z has an internal MPX to deal with mono/stereo/bilingual audio. This is split off from the wis-sony-tuner driver that is part of the go7007 driver as it should be a separate i2c sub-device driver. The wis-sony-tuner is really three i2c

[REVIEW PATCH 23/42] go7007: remember boot firmware.

From: Hans Verkuil hans.verk...@cisco.com Don't load it everytime you stop encoding. Instead remember it. Another reason for not loading it every time is that this could be called from within the release() file operation, which turns out to be deadly. Signed-off-by: Hans Verkuil

[REVIEW PATCH 24/42] go7007: fix unregister/disconnect handling.

From: Hans Verkuil hans.verk...@cisco.com - use the v4l2_device's release() callback - remove the unnecessary ref_count - don't free usb data structures on disconnect, only do that in the final release callback. This is the correct way in order to safely handle disconnect and removal of

[REVIEW PATCH 26/42] s2250: convert to the control framework.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/s2250-board.c | 149 +--- 1 file changed, 46 insertions(+), 103 deletions(-) diff --git a/drivers/staging/media/go7007/s2250-board.c

[REVIEW PATCH 27/42] go7007: add prio and control event support.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-priv.h |2 ++ drivers/staging/media/go7007/go7007-v4l2.c | 23 ++- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git

[REVIEW PATCH 29/42] go7007: tuner/std related fixes.

From: Hans Verkuil hans.verk...@cisco.com - The Adlink is initially detected as a sensor board, so the driver config is set up as if it was a sensor. Later the driver discovers that it really is a video capture card and that means that the driver configuration has to be updated for a

[REVIEW PATCH 30/42] go7007: standardize MPEG handling support.

From: Hans Verkuil hans.verk...@cisco.com The go7007 produces elementary streams, so we shouldn't use the STREAM_TYPE control, since that is for multiplexed streams. Instead use V4L2_PIX_FMT_MPEG1/2/4. Initially set up all the values for MPEG-2 dvd-mode, and select the dvd_mode field if those

[REVIEW PATCH 32/42] go7007: set up the saa7115 audio clock correctly.

From: Hans Verkuil hans.verk...@cisco.com The s_crystal_freq operation has to be called for the saa7115 to set up the audio clock correctly. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-priv.h |1 + drivers/staging/media/go7007/go7007-usb.c |

[REVIEW PATCH 35/42] go7007: embed struct video_device

From: Hans Verkuil hans.verk...@cisco.com Do not allocate it, but just embed in the go7007 struct. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-driver.c |1 - drivers/staging/media/go7007/go7007-priv.h|2 +-

[REVIEW PATCH 36/42] go7007: remove cropping functions

From: Hans Verkuil hans.verk...@cisco.com Remove these dummy cropping functions: cropping was never implemented. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-v4l2.c | 92 1 file changed, 92 deletions(-) diff --git

[REVIEW PATCH 38/42] s2250: add comment describing the hardware.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/s2250-board.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/media/go7007/s2250-board.c b/drivers/staging/media/go7007/s2250-board.c index

[REVIEW PATCH 42/42] MAINTAINERS: add the go7007 driver.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- MAINTAINERS |5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ff2fcc9..5703edd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7550,6 +7550,11 @@ M:

[REVIEW PATCH 41/42] go7007: update the README

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/README | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/go7007/README b/drivers/staging/media/go7007/README

[REVIEW PATCH 37/42] saa7134-go7007: add support for this combination.

From: Pete Eberlein p...@sensoray.com Add support for the Sensoray model 614 board, which is a saa7134 with a go7007 MPEG encoder. Signed-off-by: Pete Eberlein p...@sensoray.com [hans.verk...@cisco.com: updated to make it merge correctly] Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[REVIEW PATCH 40/42] go7007-loader: add support for the other devices and move fw files

From: Hans Verkuil hans.verk...@cisco.com Add support for the other devices that need to load the boot firmware. All firmware files are now placed in a single go7007 directory. Also remove the device_extension_s stuff: this is clearly a left-over from the olden days. Signed-off-by: Hans Verkuil

[REVIEW PATCH 34/42] go7007: convert to core locking and vb2.

From: Hans Verkuil hans.verk...@cisco.com Convert this driver to videobuf2 and core locking. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/Kconfig |2 +- drivers/staging/media/go7007/go7007-driver.c | 156 ---

[REVIEW PATCH 39/42] go7007-loader: renamed from s2250-loader

From: Hans Verkuil hans.verk...@cisco.com All s2250 names are renamed to go7007. This will be the generic go7007 firmware loader for any go7007 device, not just for the s2250/1. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/Kconfig | 24 ++--

[REVIEW PATCH 14/42] tw2804: modify ADC power control

From: Volokh Konstantin volok...@gmail.com Switch off all ADC (max 4) with first init, we control it when starting/stopping streaming. Signed-off-by: Volokh Konstantin volok...@gmail.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/tw2804.c |1 + 1 file changed,

[REVIEW PATCH 21/42] go7007: remove current_norm.

From: Hans Verkuil hans.verk...@cisco.com It's deprecated and replaced by g_std. Since this driver already implements g_std the use of current_norm can just be removed. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-v4l2.c |1 - 1 file changed, 1

[REVIEW PATCH 33/42] go7007: drop struct go7007_file

From: Hans Verkuil hans.verk...@cisco.com Remove struct go7007_file: all fields contained in that struct are moved to the go7007 struct since they are really global values. The lock has just been deleted (what's the point of a per-fh lock??). Signed-off-by: Hans Verkuil hans.verk...@cisco.com

[REVIEW PATCH 31/42] go7007: simplify the PX-TV402U board ID handling.

From: Hans Verkuil hans.verk...@cisco.com There really is no need to split out the board IDs for each tuner. That's what the tuner_type is for, after all. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-priv.h | 15 ++-

[REVIEW PATCH 28/42] go7007: add log_status support.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-v4l2.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/go7007/go7007-v4l2.c

[REVIEW PATCH 25/42] go7007: convert to the control framework and remove obsolete JPEGCOMP support.

From: Hans Verkuil hans.verk...@cisco.com Just add a read-only V4L2_CID_JPEG_ACTIVE_MARKER control to replace the JPEGCOMP support. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-driver.c | 11 +- drivers/staging/media/go7007/go7007-priv.h |3

[REVIEW PATCH 12/42] tw9903: add new tw9903 video decoder.

From: Hans Verkuil hans.verk...@cisco.com This based on the wis-tw9903.c driver that's part of the go7007 driver. It has been converted to a v4l subdev driver by Pete Eberlein, and I made additional cleanups. Based on work by: Pete Eberlein p...@sensoray.com Signed-off-by: Hans Verkuil

[REVIEW PATCH 07/42] go7007: fix i2c_xfer return codes.

From: Hans Verkuil hans.verk...@cisco.com The i2c_xfer functions didn't return the proper error codes and (especially important) on success they returned 0 instead of the number of transferred messages. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[REVIEW PATCH 16/42] go7007: switch to standard tuner/i2c subdevs.

From: Hans Verkuil hans.verk...@cisco.com Instead of using the wis-* drivers we now use the standard 'proper' subdev drivers. The board configuration tables now also list the possible audio inputs, this will be used later to implement audio inputs. Special mention deserves a little change in

[REVIEW PATCH 20/42] go7007: go7007: add device_caps and bus_info support to querycap.

From: Hans Verkuil hans.verk...@cisco.com And don't set the version field, the core does that for you. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-priv.h|1 + drivers/staging/media/go7007/go7007-usb.c |1 +

[REVIEW PATCH 18/42] go7007: add audio input ioctls.

From: Hans Verkuil hans.verk...@cisco.com Since we now know what audio inputs there are, we can also get/set and enumerate them. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-v4l2.c | 51 ++-- 1 file changed, 48

[REVIEW PATCH 11/42] uda1342: add new uda1342 audio codec driver

From: Hans Verkuil hans.verk...@cisco.com This based on the wis-uda1342.c driver that's part of the go7007 driver. It has been converted to a v4l subdev driver by Pete Eberlein, and I made additional cleanups. Based on work by: Pete Eberlein p...@sensoray.com Signed-off-by: Hans Verkuil

[REVIEW PATCH 10/42] ov7640: add new ov7640 driver

From: Hans Verkuil hans.verk...@cisco.com This based on the wis-ov7640.c driver that's part of the go7007 driver. It has been converted to a v4l subdev driver by Pete Eberlein, and I made additional cleanups. Based on work by: Pete Eberlein p...@sensoray.com Signed-off-by: Hans Verkuil

[REVIEW PATCH 15/42] go7007: i2c initialization changes for tw2804

From: Volokh Konstantin volok...@gmail.com Do i2c initialization via struct item as tw2804 has a 0x00 i2c address, so we need to use the I2C_CLIENT_TEN flag for validity. Signed-off-by: Volokh Konstantin volok...@gmail.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

Re: [REVIEW PATCH 01/42] v4l2-ctrls: eliminate lockdep false alarms for struct v4l2_ctrl_handler.lock

On Mon March 11 2013 12:45:39 Hans Verkuil wrote: From: Andy Walls awalls at Oops, somehow I messed up Andy's email. I've corrected it in my git tree. Regards, Hans When calling v4l2_ctrl_add_handler(), lockdep would detect a potential recursive locking problem on a situation that

Re: [PATCH] block i2c tuner reads for Avermedia Twinstar in the af9035 driver

On Lunes, 11 de febrero de 2013 14:48:18 Jose Alberto Reguero escribió: On Domingo, 10 de febrero de 2013 22:11:53 Antti Palosaari escribió: On 02/10/2013 09:43 PM, Jose Alberto Reguero wrote: This patch block the i2c tuner reads for Avermedia Twinstar. If it's needed other pids can be

[REVIEW PATCH 22/42] go7007: fix DMA related errors.

From: Hans Verkuil hans.verk...@cisco.com - Don't pass data allocated on the stack to usb_control_msg. - Use dma_mapping_error after calling dma_map_page(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/go7007-priv.h|1 +

[REVIEW PATCH 19/42] s2250-loader: use usbv2_cypress_load_firmware

From: Hans Verkuil hans.verk...@cisco.com The v2 of this function doesn't do DMA to objects on the stack like its predecessor does. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/Makefile |4 ++-- drivers/staging/media/go7007/s2250-loader.c |7

Re: dvb-apps: Additional channels for Netherlands

On 09-03-13 15:45, Dmitry Katsubo wrote: Dear LinuxTV developers, Hoi Dimitry, When I was playing with scan utility, I paid attention to comments in file /usr/share/dvb/dvb-t/nl-All # The Netherlands, whole country # Created from http://radio-tv-nederland.nl/TV%20zenderlijst%20Nederland.xls

Re: omap3isp: iommu register problem.

I've just found the following thread where te problem is explained: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-February/086364.html The problem is related with the order iommu and omap3isp are probed when both are built-in. If I load omap3isp as a module the problem is gone.

Re: [PATCH] block i2c tuner reads for Avermedia Twinstar in the af9035 driver

On 03/11/2013 01:51 PM, Jose Alberto Reguero wrote: On Lunes, 11 de febrero de 2013 14:48:18 Jose Alberto Reguero escribió: On Domingo, 10 de febrero de 2013 22:11:53 Antti Palosaari escribió: On 02/10/2013 09:43 PM, Jose Alberto Reguero wrote: This patch block the i2c tuner reads for

Re: omap3isp: iommu register problem.

Hi Javier, On Monday 11 March 2013 13:18:12 javier Martin wrote: I've just found the following thread where te problem is explained: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-February/086364.h tml The problem is related with the order iommu and omap3isp are probed when

Re: [PATCH v7] [media] Add a V4L2 OF parser

Hi Sylwester Thanks for continuing this work! You have made a great progress compared to my initial version, and I should really have looked at each your submitted new revision, unfortunately, I haven't managed that. So, sorry for chiming back in so late in the game, but maybe we still manage

Re: omap3isp: iommu register problem.

Hi Laurent, thank you for your answer. On 11 March 2013 16:01, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, On Monday 11 March 2013 13:18:12 javier Martin wrote: I've just found the following thread where te problem is explained:

[PATCH] [media] ts2020: use customise option correctly

The Kconfig entry for TS2020 based tuners defaults to modular if DVB_FE_CUSTOMISE is set. But that Kconfig symbol was replaced with MEDIA_SUBDRV_AUTOSELECT as of v3.7. So use the new symbol. And negate the logic, so we are in line with all the similar entries in this file. Signed-off-by: Paul

[PATCH] m920x: silence compiler warning

drivers/media/usb/dvb-usb/m920x.c: In function ‘m920x_probe’: drivers/media/usb/dvb-usb/m920x.c:91:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] drivers/media/usb/dvb-usb/m920x.c:70:6: note: ‘ret’ was declared here Signed-off-by: Antti Palosaari cr...@iki.fi ---

Re: Custom device names for v4l2 devices

Please suggest. Thanks Vinay Hi Names of V4L2 device nodes keep on varying depending on target, on some targets, the device node assigned to my device is /dev/video21 and on some it is /dev/video15. In order to determine my device, i am opening it, reading the capabilities, enumerating its

[PATCH RFC 00/11] s5p-fimc: Exynos4x12 FIMC-IS support prerequisite

This patch series contains couple fixes to the s5p-fimc driver and changes necessary for the Exynos4x12 FIMC-IS support. Andrzej Hajda (1): s5p-fimc: Added error checks for pipeline stream on callbacks Sylwester Nawrocki (10): s5p-fimc: Add parent clock setup s5p-csis: Add parent clock

[PATCH RFC 01/11] s5p-fimc: Added error checks for pipeline stream on callbacks

From: Andrzej Hajda a.ha...@samsung.com set_stream error for pipelines is logged or reported to user space if possible. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH RFC 03/11] s5p-csis: Add parent clock setup

With this patch the driver will set parent clock as a parent clock of mux clock. When the samsung clocks driver is reworked to use new composite clock type, the mux clock can be removed. parent clock should be set in relevant dtsi file and can be overwritten in a board dts file. This way it is

[PATCH RFC 02/11] s5p-fimc: Add parent clock setup

With this patch the driver will set parent clock as a parent clock of mux clock. When the samsung clocks driver is reworked to use new composite clock type, the mux clock can be removed. parent clock should be set in related dtsi file and can be overwritten in a board dts file. This way it is

[PATCH RFC 04/11] s5p-fimc: Update graph traversal for entities with multiple source pads

We cannot assume that the passed entity the fimc_pipeline_prepare() function is supposed to start the media graph traversal from will always have its sink pad at pad index 0. Find the starting media entity's sink pad by iterating over its all pads and checking the pad flags. This ensures proper

[PATCH RFC 05/11] s5p-fimc: Add support for PIXELASYNCMx clocks

This patch ads handling of clocks for the CAMBLK subsystem which is a glue logic for FIMC-IS or LCD controller and FIMC IP. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 41

[PATCH RFC 06/11] s5p-fimc: Add the FIMC ISP writeback input support

A second sink pad is added to each FIMC.N subdev that will be used to link it to the ISP subdev. Only V4L2_MBUS_FMT_YUV10_1X30 format is supported at the pad FIMC_SD_PAD_SINK_FIFO. TODO: - Implement the FIMC input bus type selection based on state of media link from FIMC-IS-ISP to FIMC.N

[PATCH RFC 07/11] s5p-fimc: Ensure CAMCLK clock can be enabled by FIMC-LITE devices

In configurations where FIMC-LITE is used to capture image signal from an external sensor only we need to ensure one of FIMC devices is in active power state and the fimc gate clock is enabled. Otherwise the CAMCLK clock output signal will be masked off preventing an external sensor's operation.

[PATCH RFC 08/11] s5p-fimc: Ensure proper s_stream() call order in the ISP datapaths

Since the FIMC-IS firmware communicates with an image sensor directly through the ISP I2C bus controllers data streaming cannot be simply enabled from left to right or disabled from right to left along the processing pipeline. Thus a subdev index to call s_stream() on is looked up from a table,

[PATCH RFC 09/11] s5p-fimc: Ensure proper s_power() call order in the ISP datapaths

Since the FIMC-IS firmware communicates with an image sensor directly through the ISP I2C bus controllers the sub-devices power supplies cannot be simply enabled from left to right or disabled from right to left along the processing pipeline. Thus a subdev index to call s_power() on is looked up

[PATCH RFC 10/11] s5p-fimc: Remove dependency on fimc-core.h in fimc-lite driver

Drop fimc-lite.h header inclusion to make the exynos-fimc-lite module independent on other modules. Move struct fimc_fmt declaration to the driver's private headers as it is used in multiple modules. Reported-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Sylwester Nawrocki

[PATCH RFC 11/11] V4L: Add MATRIX option to V4L2_CID_EXPOSURE_METERING control

This patch adds a menu option to the V4L2_CID_EXPOSURE_METERING control for multi-zone metering. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml |9 -

[RFC PATCH 0/8] A V4L2 driver for Exynos4x12 Imaging Subsystem

This patch series is an initial version of a driver for the camera ISP subsystem (FIMC-IS) embedded in Samsung Exynos4x12 SoCs. The FIMC-IS subsystem is build around a ARM Cortex-A5 CPU that controls its dedicated peripherals, like I2C, SPI, UART, PWM, ADC,... and the ISP chain. There are 3

[RFC PATCH 2/8] s5p-fimc: Add FIMC-IS ISP I2C bus driver

This patch adds the ISP I2C bus controller driver files. Creating a standard I2C bus adapter, even if the driver doesn't actually communicates with the hardware and it is instead used by the ISP firmware running on the Cortex-A5, allows to use standard hardware description in the device tree. As

[RFC PATCH 3/8] s5p-fimc: Add FIMC-IS parameter region definitions

This patch adds ISP processing parameters interface files. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-is-param.c | 971 +

[RFC PATCH 4/8] s5p-fimc: Add common FIMC-IS image sensor driver

This subdev driver currently only handles an image sensor's power supplies and reset signal. There is no any I2C communication here as it is handled by the ISP's firmware. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[RFC PATCH 5/8] s5p-fimc: Add ISP video capture driver stubs

This patch adds a video capture node for the FIMC-IS ISP IP block and Makefile/Kconfig to actually enable the driver's compilation. The ISP video capture driver is still a work in progress. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

[RFC PATCH 7/8] s5p-fimc: Add fimc-is subdevs registration

This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki

[RFC PATCH 6/8] fimc-is: Add Exynos4x12 FIMC-IS device tree bindings documentation

Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/exynos4-fimc-is.txt | 41 1 file changed, 41 insertions(+) create mode 100644

[RFC PATCH 8/8] s5p-fimc: Create media links for the FIMC-IS entities

Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 78

Re: [PATCH] block i2c tuner reads for Avermedia Twinstar in the af9035 driver

On Lunes, 11 de marzo de 2013 14:57:37 Antti Palosaari escribió: On 03/11/2013 01:51 PM, Jose Alberto Reguero wrote: On Lunes, 11 de febrero de 2013 14:48:18 Jose Alberto Reguero escribió: On Domingo, 10 de febrero de 2013 22:11:53 Antti Palosaari escribió: On 02/10/2013 09:43 PM, Jose

Re: omap3isp: iommu register problem.

Hi Javier, On Monday 11 March 2013 16:28:58 javier Martin wrote: On 11 March 2013 16:01, Laurent Pinchart wrote: On Monday 11 March 2013 13:18:12 javier Martin wrote: I've just found the following thread where te problem is explained:

[REVIEW PATCH 00/15] au0828: v4l2-compliance cleanups

Hi all, This patch series converts the au0828/au8522 drivers to the latest frameworks, except for vb2 as usual. Tested with a WinTV aero generously donated by Hauppauge some time ago. I also did a lot of fixes in the disconnect handling and setting up the right routing/std information at the

[REVIEW PATCH 01/15] au8522_decoder: convert to the control framework.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/dvb-frontends/au8522_decoder.c | 130 +- drivers/media/dvb-frontends/au8522_priv.h|6 +- 2 files changed, 46 insertions(+), 90 deletions(-) diff --git

[REVIEW PATCH 07/15] au0828: add prio, control event and log_status support

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/au0828/au0828-video.c | 42 --- drivers/media/usb/au0828/au0828.h |4 +++ 2 files changed, 37 insertions(+), 9 deletions(-) diff --git

[REVIEW PATCH 10/15] au8522_decoder: remove obsolete control ops.

From: Hans Verkuil hans.verk...@cisco.com Now that au0828 has been converted to the control framework these compatilibity ops are no longer needed. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/dvb-frontends/au8522_decoder.c |7 --- 1 file changed, 7 deletions(-)

[REVIEW PATCH 02/15] au0828: fix querycap.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/au0828/au0828-video.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-video.c

[REVIEW PATCH 06/15] au0828: convert to the control framework.

From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/au0828/au0828-core.c | 15 ++-- drivers/media/usb/au0828/au0828-video.c | 39 ++- drivers/media/usb/au0828/au0828.h |2 ++ 3 files

[REVIEW PATCH 13/15] au0828: don't change global state information on open().

From: Hans Verkuil hans.verk...@cisco.com Just opening a device shouldn't have any side-effects. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/au0828/au0828-video.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

[REVIEW PATCH 14/15] au0828: fix initial video routing.

From: Hans Verkuil hans.verk...@cisco.com After loading the module the initial video routing is not setup. Explicitly call s_input to get this right. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/au0828/au0828-video.c | 30 ++ 1 file

[REVIEW PATCH 11/15] au0828: fix disconnect sequence.

From: Hans Verkuil hans.verk...@cisco.com The driver crashed when the device was disconnected while an application still had a device node open. Fixed by using the release() callback of struct v4l2_device. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[REVIEW PATCH 15/15] au0828: improve firmware loading locking.

From: Hans Verkuil hans.verk...@cisco.com - open/close/read and poll need to take the core lock as well. - when the tuner goes to sleep we should set std_set_in_tuner_core to 0 since the tuner loses the firmware at that time. - initialize the tuner if std_set_in_tuner_core == 0 whenever: 1)

  1   2   >