On Mon May 27 2013 23:53:15 Ben Hutchings wrote:
On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote:
On Mon May 27 2013 18:24:32 Ben Hutchings wrote:
On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote:
Hi Ben, David,
The go7007 staging driver has been substantially
On Mon May 27 2013 14:04:29 Mauro Carvalho Chehab wrote:
At get_video_info, there's a somewhat complex logic that checks
for error.
That logic can be highly simplified, as usb_control_msg will
only return a negative value, or the buffer length, as it does
the transfers via DMA.
While
Hey,
Op 28-05-13 04:49, Inki Dae schreef:
-Original Message-
From: Maarten Lankhorst [mailto:maarten.lankho...@canonical.com]
Sent: Tuesday, May 28, 2013 12:23 AM
To: Inki Dae
Cc: 'Daniel Vetter'; 'Rob Clark'; 'linux-fbdev'; 'YoungJun Cho'; 'Kyungmin
Park'; 'myungjoo.ham'; 'DRI
Those three independent patches are fixes for s5p-mfc encoder.
The first one is a serious bug fix - some controls were not working properly.
The latter two fixes minor issues.
Regards
Andrzej Hajda
Andrzej Hajda (3):
s5p-mfc: separate encoder parameters for h264 and mpeg4
s5p-mfc: v4l2
This patch fixes a bug which caused overwriting h264 codec
parameters by mpeg4 parameters during V4L2 control setting.
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 2 +-
1 file
Callback .start_streaming is called once for every queue,
so v4l2_ctrl_handler_setup was called twice during stream start.
Moving v4l2_ctrl_handler_setup to context initialization
reduces numbers of calls and seems to be more consistent with API.
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Many debug messages missed end-of-line.
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 2 +-
drivers/media/platform/s5p-mfc/s5p_mfc_debug.h | 4 ++--
From: Hans Verkuil hans.verk...@cisco.com
get_video_info() should never return EFAULT, instead it should return
the low-level usb_control_msg() error. Add a valid field to the hdpvr_video_info
struct so the driver can easily check if a valid format was detected.
Whenever get_video_info is called
From: Hans Verkuil hans.verk...@cisco.com
If no format has been detected, then querystd should return V4L2_STD_UNKNOWN,
not V4L2_STD_ALL.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/hdpvr/hdpvr-video.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Hans Verkuil hans.verk...@cisco.com
Remove an unnecessary 'else' and invert a condition which makes the code
more readable.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/hdpvr/hdpvr-video.c | 54 -
1 file changed, 27
The first patch fixes a bug in querystd: if there is no signal, then
querystd should return V4L2_STD_UNKNOWN. There are more drivers that
return the wrong value here, I have a patch series pending to fix that
and also to improve the spec.
The second does a code cleanup that improves readability,
Hi Andrzej,
On 28 May 2013 12:56, Andrzej Hajda a.ha...@samsung.com wrote:
This patch fixes a bug which caused overwriting h264 codec
parameters by mpeg4 parameters during V4L2 control setting.
Just curious, what was the use case that triggered this issue?
--
With warm regards,
Sachin
--
To
Hi Andrzej,
On 28 May 2013 12:56, Andrzej Hajda a.ha...@samsung.com wrote:
Many debug messages missed end-of-line.
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 2 +-
On 05/28/2013 10:31 AM, Sachin Kamat wrote:
Hi Andrzej,
On 28 May 2013 12:56, Andrzej Hajda a.ha...@samsung.com wrote:
This patch fixes a bug which caused overwriting h264 codec
parameters by mpeg4 parameters during V4L2 control setting.
Just curious, what was the use case that triggered
Hi Sachin,
Thanks for comment.
On 05/28/2013 10:42 AM, Sachin Kamat wrote:
Hi Andrzej,
On 28 May 2013 12:56, Andrzej Hajda a.ha...@samsung.com wrote:
Many debug messages missed end-of-line.
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Signed-off-by: Kyungmin Park
Hi Hans,
Passing on the actual error code was intentional.
My main goal was to give user space ability to
distinguish between the no-lock and usb failure
conditions. HDPVR firmware instability usually
manifests itself as a usb failure, and passing
the error code on gives the application ability,
On Tue, May 28, 2013 at 12:56:57PM +0900, Inki Dae wrote:
-Original Message-
From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev-
ow...@vger.kernel.org] On Behalf Of Rob Clark
Sent: Tuesday, May 28, 2013 12:48 AM
To: Inki Dae
Cc: Maarten Lankhorst; Daniel Vetter;
On Mon, May 27, 2013 at 11:56 PM, Inki Dae inki@samsung.com wrote:
-Original Message-
From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev-
ow...@vger.kernel.org] On Behalf Of Rob Clark
Sent: Tuesday, May 28, 2013 12:48 AM
To: Inki Dae
Cc: Maarten Lankhorst; Daniel
Hi Sheu,
Thank you for this patch. May I also ask you to add me to Cc of next mem2mem
patches, as I am the mem2mem submaintainer?
Best wishes,
--
Kamil Debski
Linux Kernel Developer
Samsung RD Institute Poland
-Original Message-
From: linux-media-ow...@vger.kernel.org
Hi Sergei, Vladimir,
Oops, the comments about the captured image contents are my fault.
However, the unhandled irq after stopping capture is still an issue.
Thanks for letting us know.
The good news is that your driver works fine.
The problem I saw only occurs when your patches were
John, thanks for the patch.
On Thu, May 23, 2013 at 5:41 PM, John Sheu s...@google.com wrote:
Save flags correctly when taking spinlocks in v4l2_m2m_try_schedule.
Signed-off-by: John Sheu s...@google.com
Acked-by: Pawel Osciak pa...@osciak.com
---
drivers/media/v4l2-core/v4l2-mem2mem.c |
Hi Daniel,
Thank you so much. And so very useful.:) Sorry but could be give me more
comments to the below my comments? There are still things making me
confusing.:(
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
Vetter
Sent: Tuesday, May
This will allow me to call functions that have multiple arguments if fastpath
fails.
This is required to support ticket mutexes, because they need to be able to
pass an
extra argument to the fail function.
Originally I duplicated the functions, by adding
__mutex_fastpath_lock_retval_arg.
This
From: Daniel Vetter daniel.vet...@ffwll.ch
Injects EDEADLK conditions at pseudo-random interval, with exponential
backoff up to UINT_MAX (to ensure that every lock operation still
completes in a reasonable time).
This way we can test the wound slowpath even for ww mutex users where
contention is
This stresses the lockdep code in some ways specifically useful to
ww_mutexes. It adds checks for most of the common locking errors.
Changes since v1:
- Add tests to verify reservation_id is untouched.
- Use L() and U() macros where possible.
Changes since v2:
- Use the ww_mutex api directly.
Changes since RFC patch v1:
- Updated to use atomic_long instead of atomic, since the reservation_id was a
long.
- added mutex_reserve_lock_slow and mutex_reserve_lock_intr_slow
- removed mutex_locked_set_reservation_id (or w/e it was called)
Changes since RFC patch v2:
- remove use of
-Original Message-
From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev-
ow...@vger.kernel.org] On Behalf Of Rob Clark
Sent: Tuesday, May 28, 2013 10:49 PM
To: Inki Dae
Cc: Maarten Lankhorst; Daniel Vetter; linux-fbdev; YoungJun Cho; Kyungmin
Park; myungjoo.ham; DRI mailing
Version 4 already?
Small api changes since v3:
- Remove ww_mutex_unlock_single and ww_mutex_lock_single.
- Rename ww_mutex_trylock_single to ww_mutex_trylock.
- Remove separate implementations of ww_mutex_lock_slow*, normal
functions can be used. Inline versions still exist for extra
Hi Hans,
On 05/27/2013 12:56 PM, Hans Verkuil wrote:
I can revert the rename action, but I would rather not do it. I
believe there are good reasons for doing this, especially since the
current situation is effectively broken anyway due to the missing
firmware files.
If you really don't
On Tue, May 28, 2013 at 4:50 PM, Inki Dae inki@samsung.com wrote:
I think I already used reservation stuff any time in that way except
ww-mutex. And I'm not sure that embedded system really needs ww-mutex. If
there is any case,
could you tell me the case? I really need more advice and
Hi All,
(replying to myself, probably a bad sign... ;))
On 05/09/2013 05:36 PM, Sylwester Nawrocki wrote:
Currently the media device link_notify callback is invoked before the
actual change of state of a link when the link is being enabled, and
after the actual change of state when the link
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue May 28 19:00:18 CEST 2013
git branch: test
git hash: 7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e
gcc
Hi,
with Debian kernel 3.2 I had the rare problem that dvb on my Hauppauge
WinTV-HVR1300 was not always initialized properly on boot. After an upgrade
to Debian kernel 3.8 and then for testing reasons to vanilla 3.9.4 I can
reproduce this problem on every boot. This is from my dmesg output for
On Tue, May 28, 2013 at 04:48:45PM +0200, Maarten Lankhorst wrote:
This stresses the lockdep code in some ways specifically useful to
ww_mutexes. It adds checks for most of the common locking errors.
Changes since v1:
- Add tests to verify reservation_id is untouched.
- Use L() and U()
Op 28-05-13 21:18, Daniel Vetter schreef:
On Tue, May 28, 2013 at 04:48:45PM +0200, Maarten Lankhorst wrote:
This stresses the lockdep code in some ways specifically useful to
ww_mutexes. It adds checks for most of the common locking errors.
Changes since v1:
- Add tests to verify
Hi Sergei,
On Sunday 26 May 2013 18:15:19 Sergei Shtylyov wrote:
On 26-05-2013 4:49, Laurent Pinchart wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Use devm_ioremap_resource instead of reques_mem_region()/ioremap().
This ensures more consistent error values and simplifies error
Hi Prabhakar,
Thanks for the patch.
On Sunday 26 May 2013 18:49:46 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
add OF support for the tvp514x driver.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Laurent
-Original Message-
From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of
Daniel Vetter
Sent: Wednesday, May 29, 2013 1:50 AM
To: Inki Dae
Cc: Rob Clark; Maarten Lankhorst; linux-fbdev; YoungJun Cho; Kyungmin
Park;
myungjoo.ham; DRI mailing list;
Hi Prabhakar,
Thanks for the patch.
On Sunday 26 May 2013 17:30:07 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Ideally the freeing of irq's and the global variables needs to be
done in the remove() rather than module_exit(), this patch moves
the freeing up of irq's
Hi Prabhakar,
Thanks for the patch.
On Sunday 26 May 2013 18:38:54 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
add OF support for the mt9p031 sensor driver.
Alongside this patch sorts the header inclusion alphabetically.
Signed-off-by: Lad, Prabhakar
On Sunday 26 May 2013 17:30:08 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch uses module_platform_driver() to simplify the code.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
On Sunday 26 May 2013 17:30:11 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch uses module_platform_driver() to simplify the code.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
On Sunday 26 May 2013 17:30:09 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
use devm_request_irq() instead of request_irq(). This ensures
more consistent error values and simplifies error paths.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by:
On Sunday 26 May 2013 17:30:12 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
use devm_request_irq() instead of request_irq(). This ensures
more consistent error values and simplifies error paths.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by:
Hi Laurent,
On Wed, May 29, 2013 at 9:01 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Prabhakar,
Thanks for the patch.
On Sunday 26 May 2013 18:38:54 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
add OF support for the mt9p031 sensor driver.
Hi Laurent,
Thanks for the review.
On Wed, May 29, 2013 at 8:02 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Prabhakar,
Thanks for the patch.
On Sunday 26 May 2013 17:30:07 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Ideally the freeing of
Hi Laurent,
On Wed, May 29, 2013 at 9:08 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
On Sunday 26 May 2013 17:30:12 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
use devm_request_irq() instead of request_irq(). This ensures
more consistent error
Hi Laurent,
On Wed, May 29, 2013 at 6:52 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Prabhakar,
Thanks for the patch.
On Sunday 26 May 2013 18:49:46 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
add OF support for the tvp514x driver.
In certain cases, dma_alloc_coherent returns NULL. Add check for
NULL pointer.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
49 matches
Mail list logo
