[patch] [media] dw2102: some missing unlocks on error

2013-11-21 Thread Dan Carpenter
We recently introduced some new error paths but the unlocks are missing. Fixes: 0065a79a8698 ('[media] dw2102: Don't use dynamic static allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c index c1a63b2a6baa..f272ed86d467

[patch] [media] cxusb: unlock on error in cxusb_i2c_xfer()

2013-11-21 Thread Dan Carpenter
We recently introduced some new error paths which are missing their unlocks. Fixes: 64f7ef8afbf8 ('[media] cxusb: Don't use dynamic static allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c index 20e345d9fe8f..a1c641e1836

[patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-21 Thread Dan Carpenter
It upsets static checkers when we don't check for allocation failure. I moved the memset() of "tv" earlier so we don't use uninitialized data on error. Fixes: 1d212cf0c2d8 ('[media] cx18: struct i2c_client is too big for stack') Signed-off-by: Dan Carpenter diff --git a/drivers/media/pci/cx18/c

[patch] [media] af9035: unlock on error in af9035_i2c_master_xfer()

2013-11-21 Thread Dan Carpenter
We introduced a couple new error paths which are missing unlocks. Fixes: 7760e148350b ('[media] af9035: Don't use dynamic static allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c index c8fcd78425bd..625ef2489b23

cron job: media_tree daily build: WARNINGS

2013-11-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Nov 22 04:00:33 CET 2013 git branch: test git hash: 80f93c7b0f4599ffbdac8d964ecd1162b8b618b9 gcc versio

Dear Account User

2013-11-21 Thread Upgrade_1
Dear Account User. Due to much junk/spam emails you receive daily, we are currently updating all email accounts spam filter to limit unsolicited emails for security reasons and to upgrade our newly improved E-mail account features to ensure you do not experience service interruption. Reply t

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Nov 2013 19:05:05 +0200 Antti Palosaari escreveu: > Hello > I am adding new property for sampling rate that is ideally the only > obligatory parameter required by SDR. It is value that could be only > positive and bigger the better, lets say unsigned 64 bit is quite ideal. > That va

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Antti Palosaari
On 21.11.2013 22:54, Mauro Carvalho Chehab wrote: Em Thu, 21 Nov 2013 22:22:49 +0200 Antti Palosaari escreveu: On 21.11.2013 21:12, Mauro Carvalho Chehab wrote: Em Thu, 21 Nov 2013 20:33:15 +0200 Antti Palosaari escreveu: On 21.11.2013 20:22, Hans Verkuil wrote: BTW, can the sample rate

Re: [PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-21 Thread Hans Verkuil
Hi Andy, This seems more complex than is necessary. See my comments below... On 11/21/13 02:05, Andy Walls wrote: > (This patch is RFC, because it was compiled and tested against kernel > v3.5) > > videobuf2 file I/O emulation assumed that buffers dequeued from the > driver would return in the o

[RFC PATCH 6/8] vb2: return ENODATA in start_streaming in case of too few buffers.

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/platform/davinci/vpbe_display.c | 2 +- drivers/media/platform/davinci/vpif_capture.c | 2 +- drivers/media/platform/davinci/vpif_display.c | 2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c| 2 +- drivers/media/platfo

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Nov 2013 22:22:49 +0200 Antti Palosaari escreveu: > On 21.11.2013 21:12, Mauro Carvalho Chehab wrote: > > Em Thu, 21 Nov 2013 20:33:15 +0200 > > Antti Palosaari escreveu: > > > >> On 21.11.2013 20:22, Hans Verkuil wrote: > >>> On 11/21/2013 06:49 PM, Mauro Carvalho Chehab wrote: > >>>

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Antti Palosaari
On 21.11.2013 21:12, Mauro Carvalho Chehab wrote: Em Thu, 21 Nov 2013 20:33:15 +0200 Antti Palosaari escreveu: On 21.11.2013 20:22, Hans Verkuil wrote: On 11/21/2013 06:49 PM, Mauro Carvalho Chehab wrote: Em Thu, 21 Nov 2013 19:05:05 +0200 Antti Palosaari escreveu: Hello I am adding new p

[PATCH] mceusb: Add Hauppauge WinTV-HVR-930C HD

2013-11-21 Thread Matthias Schwarzott
Add usb id of Hauppauge WinTV-HVR-930C HD to mceusb RC driver. This device has no IR transmitter (according to eeprom content decoded by tveeprom). Set the rc mapping to Hauppauge, every key of the deliviered remote control works correctly. Signed-off-by: Matthias Schwarzott --- drivers/media

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Nov 2013 20:33:15 +0200 Antti Palosaari escreveu: > On 21.11.2013 20:22, Hans Verkuil wrote: > > On 11/21/2013 06:49 PM, Mauro Carvalho Chehab wrote: > >> Em Thu, 21 Nov 2013 19:05:05 +0200 > >> Antti Palosaari escreveu: > >> > >>> Hello > >>> I am adding new property for sampling rat

Re: [RFC PATCH 4/8] vb2: retry start_streaming in case of insufficient buffers.

2013-11-21 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thursday 21 November 2013 16:22:02 Hans Verkuil wrote: > From: Hans Verkuil > > If start_streaming returns -ENODATA, then it will be retried the next time > a buffer is queued. This means applications no longer need to know how many > buffers need to be queu

Re: [RFC PATCH 1/8] vb2: push the mmap semaphore down to __buf_prepare()

2013-11-21 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thursday 21 November 2013 16:21:59 Hans Verkuil wrote: > From: Hans Verkuil > > Rather than taking the mmap semaphore at a relatively high-level function, > push it down to the place where it is really needed. > > It was placed in vb2_queue_or_prepare_buf()

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Antti Palosaari
On 21.11.2013 19:49, Mauro Carvalho Chehab wrote: Em Thu, 21 Nov 2013 19:05:05 +0200 Antti Palosaari escreveu: Hello I am adding new property for sampling rate that is ideally the only obligatory parameter required by SDR. It is value that could be only positive and bigger the better, lets say

[RFC PATCH 0/8] vb2: various cleanups and improvements

2013-11-21 Thread Hans Verkuil
This patch series does some cleanups in the qbuf/prepare_buf handling (the first two patches). The third patch removes the 'fileio = NULL' hack. That hack no longer works when dealing with asynchronous calls from a kernel thread so it had to be fixed. The next three patches implement retrying star

[RFC PATCH 8/8] vb2: Add videobuf2-dvb support.

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil With the new vb2_thread_start/stop core code it is very easy to implement videobuf2-dvb. This should simplify coverting existing videobuf drivers to vb2. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/Kconfig | 4 + drivers/media/v4l2-core/Makefile

[RFC PATCH 5/8] vb2: don't set index, don't start streaming for write()

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil Two fixes: - there is no need to set the index when calling dqbuf: dqbuf will overwrite it. - __vb2_init_fileio already starts streaming for write(), so there is no need to do it again in __vb2_perform_fileio. It can never have worked anyway: either __vb2_init_fileio suc

[RFC PATCH 7/8] vb2: add thread support

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil In order to implement vb2 DVB or ALSA support you need to be able to start a kernel thread that queues and dequeues buffers, calling a callback function for every captured/displayed buffer. This patch adds support for that. It's based on drivers/media/v4l2-core/videobuf-dvb.c,

[RFC PATCH 1/8] vb2: push the mmap semaphore down to __buf_prepare()

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil Rather than taking the mmap semaphore at a relatively high-level function, push it down to the place where it is really needed. It was placed in vb2_queue_or_prepare_buf() to prevent racing with other vb2 calls, however, I see no way that any race can happen. Moving it down o

[RFC PATCH 4/8] vb2: retry start_streaming in case of insufficient buffers.

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil If start_streaming returns -ENODATA, then it will be retried the next time a buffer is queued. This means applications no longer need to know how many buffers need to be queued before STREAMON can be called. This is particularly useful for output stream I/O. If a DMA engine ne

[RFC PATCH 3/8] vb2: remove the 'fileio = NULL' hack.

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil The read/write implementation in vb2 reuses existing vb2 functions, but it sets q->fileio to NULL before calling them in order to skip the 'q->fileio != NULL' check. This works today due to the synchronous nature of read/write, but it 1) is ugly, and 2) will fail in an asynchr

[RFC PATCH 2/8] vb2: simplify qbuf/prepare_buf by removing callback.

2013-11-21 Thread Hans Verkuil
From: Hans Verkuil The callback used to merge the common code of the qbuf/prepare_buf code can be removed now that the mmap_sem handling is pushed down to __buf_prepare(). This makes the code more readable. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 118

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Nov 2013 19:22:51 +0100 Hans Verkuil escreveu: > On 11/21/2013 06:49 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 21 Nov 2013 19:05:05 +0200 > > Antti Palosaari escreveu: > > > >> Hello > >> I am adding new property for sampling rate that is ideally the only > >> obligatory paramete

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Antti Palosaari
On 21.11.2013 20:22, Hans Verkuil wrote: On 11/21/2013 06:49 PM, Mauro Carvalho Chehab wrote: Em Thu, 21 Nov 2013 19:05:05 +0200 Antti Palosaari escreveu: Hello I am adding new property for sampling rate that is ideally the only obligatory parameter required by SDR. It is value that could be

SDR sampling rate - control or IOCTL?

2013-11-21 Thread Antti Palosaari
Hello I am adding new property for sampling rate that is ideally the only obligatory parameter required by SDR. It is value that could be only positive and bigger the better, lets say unsigned 64 bit is quite ideal. That value sets maximum radio frequency possible to receive (ideal SDR). Vali

Re: [PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-21 Thread Andy Walls
Hans Verkuil wrote: >Hi Andy, > >This seems more complex than is necessary. See my comments below... > >On 11/21/13 02:05, Andy Walls wrote: >> (This patch is RFC, because it was compiled and tested against kernel >> v3.5) >> >> videobuf2 file I/O emulation assumed that buffers dequeued from the

Re: SDR sampling rate - control or IOCTL?

2013-11-21 Thread Hans Verkuil
On 11/21/2013 06:49 PM, Mauro Carvalho Chehab wrote: > Em Thu, 21 Nov 2013 19:05:05 +0200 > Antti Palosaari escreveu: > >> Hello >> I am adding new property for sampling rate that is ideally the only >> obligatory parameter required by SDR. It is value that could be only >> positive and bigger

Re: [PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-21 Thread Andy Walls
On Thu, 2013-11-21 at 08:56 +0100, Hans Verkuil wrote: > Hi Andy, > > As I mentioned in irc I have been working in this same area as well, so > I'll take this patch and merge it in my tree and test it as well. > > I suspect that it might be easiest if I add the patch to my upcoming > patch series