Re: [RFC v5, 1/3] v4l2-controls.h: add addtional Flash fault bits

2014-02-20 Thread Andy Shevchenko
On Fri, 2014-02-21 at 13:48 +0900, Daniel Jeong wrote: > Same with v3 and v4. It seems you wrote changelog between v4 and v5 into commit messages. More over when you prepare patch series you forgot to use --thread for git format-patch command. Thus, I suggest you to write better commit messages a

[GIT PULL FOR v3.14] Kconfig fixes and vb2 regression fixes

2014-02-20 Thread Hans Verkuil
Hi Mauro, The first two patches fix some Kconfig dependencies and the second two patches fix regressions introduced in vb2 in 3.14. They were found by v4l2-compliance and tested very well. Regards, Hans The following changes since commit 37e59f876bc710d67a30b660826a5e83e07101ce: [me

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Hans Verkuil
On 02/21/2014 12:30 AM, Laurent Pinchart wrote: > Hi Hans, > > On Thursday 20 February 2014 21:36:51 Hans Verkuil wrote: >> On 02/20/2014 08:41 PM, Sakari Ailus wrote: >>> Some devices do not produce timestamps that correspond to the end of the >>> frame. The user space should be informed on the m

[RFC v5,3/3] media: i2c: add new dual LED Flash driver, lm3646

2014-02-20 Thread Daniel Jeong
To prevent redundant i2c access, Mode register is caching at initial time. And it will be written with control mode. There are many bit data in mode register so it is hard to set zero all. DT is removed and will be created a seperated patch Signed-off-by: Daniel Jeong --- drivers/media/i2c/Kconf

[RFC v5,2/3] controls.xml : add addtional Flash fault bits

2014-02-20 Thread Daniel Jeong
Added more comment about Input voltage flash monitor and external temp function. Signed-off-by: Daniel Jeong --- Documentation/DocBook/media/v4l/controls.xml | 18 ++ 1 file changed, 18 insertions(+) diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/Do

[RFC v5, 1/3] v4l2-controls.h: add addtional Flash fault bits

2014-02-20 Thread Daniel Jeong
Same with v3 and v4. Signed-off-by: Daniel Jeong --- include/uapi/linux/v4l2-controls.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index 2cbe605..1d662f6 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/

cron job: media_tree daily build: WARNINGS

2014-02-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Feb 21 04:00:29 CET 2014 git branch: test git hash: 37e59f876bc710d67a30b660826a5e83e07101ce gcc versio

[PATCH RESEND] s5p-mfc: Replaced commas with semicolons.

2014-02-20 Thread Joonyoung Shim
There is no any reason to use comma here. Signed-off-by: Joonyoung Shim --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index e2aac59..90f

[PATCH] s5p-mfc: Replaced commas with semicolons.

2014-02-20 Thread Joonyoung Shim
There is any reason to use comma here. Signed-off-by: Joonyoung Shim --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index e2aac59..90f4f6

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Laurent Pinchart
Hi Hans, On Thursday 20 February 2014 21:36:51 Hans Verkuil wrote: > On 02/20/2014 08:41 PM, Sakari Ailus wrote: > > Some devices do not produce timestamps that correspond to the end of the > > frame. The user space should be informed on the matter. This patch > > achieves > > that by adding buffe

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Sylwester Nawrocki
On 02/20/2014 10:10 PM, Sylwester Nawrocki wrote: I would actually be inclined to drop it altogether for this particular timestamp source. But it's up to Laurent. Yup, the "a small amount of time" concept seems a bit vague here. It's not clear how long period it could be and the tolerance would

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Sylwester Nawrocki
Hi Sakari, On 02/20/2014 09:36 PM, Hans Verkuil wrote: On 02/20/2014 08:41 PM, Sakari Ailus wrote: Some devices do not produce timestamps that correspond to the end of the frame. The user space should be informed on the matter. This patch achieves that by adding buffer flags (and a mask) for ti

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Hans Verkuil
On 02/20/2014 08:41 PM, Sakari Ailus wrote: > Some devices do not produce timestamps that correspond to the end of the > frame. The user space should be informed on the matter. This patch achieves > that by adding buffer flags (and a mask) for timestamp sources since more > possible timestamping po

Re: [PATCH v5.1 7/7] v4l: Document timestamp buffer flag behaviour

2014-02-20 Thread Hans Verkuil
On 02/20/2014 08:42 PM, Sakari Ailus wrote: > Timestamp buffer flags are constant at the moment. Document them so that 1) > they're always valid and 2) not changed by the drivers. This leaves room to > extend the functionality later on if needed. > > Signed-off-by: Sakari Ailus Acked-by: Hans Ve

[PATCH v4 05/10] V4L: s5c73m3: Add device tree support

2014-02-20 Thread Sylwester Nawrocki
This patch adds the V4L2 asynchronous subdev registration and device tree support. Common clock API is used to control the sensor master clock from within the subdev. Signed-off-by: Andrzej Hajda Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v3: - move clk_get fro

[PATCH v4 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board

2014-02-20 Thread Sylwester Nawrocki
This patch enables the rear facing camera (s5c73m3) on TRATS2 board by adding the I2C0 bus controller, s5c73m3 sensor, MIPI CSI-2 receiver and the sensor's voltage regulator supply nodes. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4412-trats2.dts | 86 +++

[PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-20 Thread Sylwester Nawrocki
This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells property to 'camera' node - the #clock-cells property is needed when the sensor sub-devices use clock provided by the camera host interface; - addition of an optional cl

[PATCH v4 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs

2014-02-20 Thread Sylwester Nawrocki
This patch adds clock provider so the the SCLK_CAM0/1 output clocks can be accessed by image sensor devices through the clk API. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v3: - use clock-output-names DT property instead of hard coding names of registered clo

[PATCH v4 10/10] ARM: dts: exynos4: Update clk provider part of the camera subsystem

2014-02-20 Thread Sylwester Nawrocki
Remove unused /camera/clock-controller node and required clock properties to the camera node. This is required for a clock provider that will be referenced by image sensor devices. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi |6 ++ 1 file

[PATCH v4 01/10] Documentation: dt: Add DT binding documentation for S5K6A3 image sensor

2014-02-20 Thread Sylwester Nawrocki
This patch adds binding documentation for the Samsung S5K6A3(YX) raw image sensor. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park Acked-by: Mark Rutland --- Changes since v3: -none. Changes since v2: - rephrased 'clocks' and 'clock-names' properties' description; --- .../devicetr

[PATCH v4 08/10] exynos4-is: Add support for asynchronous subdevices registration

2014-02-20 Thread Sylwester Nawrocki
Add support for registering external sensor subdevs using v4l2-async API. The async API is used only for sensor subdevs and only for DT platforms. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 233 ++--- driver

[PATCH v4 04/10] V4L: Add driver for s5k6a3 image sensor

2014-02-20 Thread Sylwester Nawrocki
This patch adds subdev driver for Samsung S5K6A3 raw image sensor. As it is intended at the moment to be used only with the Exynos FIMC-IS (camera ISP) subsystem it is pretty minimal subdev driver. It doesn't do any I2C communication since the sensor is controlled by the ISP and its own firmware. T

[PATCH v4 02/10] Documentation: dt: Add DT binding documentation for S5C73M3 camera

2014-02-20 Thread Sylwester Nawrocki
This adds DT binding documentation for Samsung S5C73M3 camera sensor with an embedded ISP. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v3: - DT binding documentation separated into this patch; Changes since v2: - rephrased 'clocks' and 'clock-names' properties'

[PATCH v4 06/10] exynos4-is: Use external s5k6a3 sensor driver

2014-02-20 Thread Sylwester Nawrocki
This patch removes the common fimc-is-sensor driver for image sensors that are normally controlled by the FIMC-IS firmware. The FIMC-IS driver now contains only a table of properties specific to each sensor. The sensor properties required for the ISP's firmware are parsed from device tree and retri

[PATCH v4 00/10] Add device tree support for Exynos4 SoC camera subsystem

2014-02-20 Thread Sylwester Nawrocki
This series adds devicetree support for the front and rear camera of the Exynos4412 SoC Trats2 board. It converts related drivers to use the v4l2-async API. The SoC output clocks are provided to external image image sensors through the common clock API. I'd appreciate a DT binding maintainer revie

[PATCH v5.1 7/7] v4l: Document timestamp buffer flag behaviour

2014-02-20 Thread Sakari Ailus
Timestamp buffer flags are constant at the moment. Document them so that 1) they're always valid and 2) not changed by the drivers. This leaves room to extend the functionality later on if needed. Signed-off-by: Sakari Ailus --- since v5: - Clarify timestamp source flag behaviour. Documentation

[PATCH v4 00/10] Add device tree support for Exynos4 SoC camera subsystem

2014-02-20 Thread Sylwester Nawrocki
This series adds devicetree support for the front and rear camera of the Exynos4412 SoC Trats2 board. It converts related drivers to use the v4l2-async API. The SoC output clocks are provided to external image image sensors through the common clock API. I'd appreciate a DT binding maintainer revie

[PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Sakari Ailus
Some devices do not produce timestamps that correspond to the end of the frame. The user space should be informed on the matter. This patch achieves that by adding buffer flags (and a mask) for timestamp sources since more possible timestamping points are expected than just two. A three-bit mask i

PWC webcam and setpwc tool no longer working with 3.12.11 kernel

2014-02-20 Thread Chris Rankin
Hi, I have an old Logitech webcam, with USB IDs 046d:08b3. When I try to use this camera now, I see this error in the dmesg log: [ 2883.852464] pwc: isoc_init() submit_urb 0 failed with error -28 This error is apparently ENOSPC, which made me suspect that I was trying to use a mode that wou

Re: [PATCH] V4L: s5k6a3: Add DT binding documentation

2014-02-20 Thread Sylwester Nawrocki
On 19/02/14 18:47, Mark Rutland wrote: > On Tue, Feb 18, 2014 at 03:43:11PM +, Sylwester Nawrocki wrote: >> > On 22/12/13 22:27, Sylwester Nawrocki wrote: >>> > > This patch adds DT binding documentation for the Samsung S5K6A3(YX) >>> > > raw image sensor. >>> > > >>> > > Signed-off-by: Sylwes

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-20 Thread Laurent Pinchart
Hi Michael, On Thursday 20 February 2014 14:17:09 Michael Opdenacker wrote: > On 02/20/2014 12:36 PM, Laurent Pinchart wrote: > > Hi Michael, > > > > What's the status of this patch ? Do expect Prabhakar to pick it up, or do > > you plan to push all your IRQF_DISABLED removal patches in one go ?

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-20 Thread Michael Opdenacker
Hi Laurent, On 02/20/2014 12:36 PM, Laurent Pinchart wrote: > Hi Michael, > > What's the status of this patch ? Do expect Prabhakar to pick it up, or do > you > plan to push all your IRQF_DISABLED removal patches in one go ? It's true a good number of my patches haven't been picked up yet, even

Re: [patch] [media] stv090x: remove indent levels

2014-02-20 Thread Manu Abraham
On Thu, Feb 20, 2014 at 2:55 PM, Dan Carpenter wrote: > Guys, what Manu is saying is purest nonsense. The "lock" variable is a > stack variable, it's not a "demodulator Read-modify-Write register". > The implications of changing "if (!lock)" to "if (lock)" are simple and > obvious. Sorry, you mi

Re: [patch] [media] stv090x: remove indent levels

2014-02-20 Thread Dan Carpenter
On Thu, Feb 20, 2014 at 11:24:21AM +0100, Hans Verkuil wrote: > Hi Dan, > > This can be improved even more: > Sure. Thanks. I will send v2 tomorrow. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.ker

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-20 Thread Laurent Pinchart
Hi Michael, What's the status of this patch ? Do expect Prabhakar to pick it up, or do you plan to push all your IRQF_DISABLED removal patches in one go ? On Monday 09 December 2013 11:16:22 Michael Opdenacker wrote: > This patch proposes to remove the use of the IRQF_DISABLED flag > > It's a N

Re: [patch] [media] stv0900: remove an unneeded check

2014-02-20 Thread Hans Verkuil
On 02/06/14 10:24, Dan Carpenter wrote: > No need to check "lock" twice here. > > Signed-off-by: Dan Carpenter Acked-by: Hans Verkuil Regards, Hans > > diff --git a/drivers/media/dvb-frontends/stv0900_sw.c > b/drivers/media/dvb-frontends/stv0900_sw.c > index 0a40edfad739..4ce1d260b

Re: [patch] [media] stv090x: remove indent levels

2014-02-20 Thread Hans Verkuil
Hi Dan, This can be improved even more: On 02/06/14 10:28, Dan Carpenter wrote: > 1) We can flip the "if (!lock)" check to "if (lock) return lock;" and >then remove a big chunk of indenting. > 2) There is a redundant "if (!lock)" which we can remove since we >already know that lock is zer

Re: tvtime and Pinnacle PCTV 72e

2014-02-20 Thread Caterpillar
Ops I made some mistaked in pasting the URLs, heredown the fixed versions lspci http://pastebin.com/Q2bdZiSq ls /dev/ http://pastebin.com/vGYaD1mY lsusb http://pastebin.com/gFSKZcME lsmod http://pastebin.com/QpYUai90 tree /dev/dvb http://pastebin.com/Sf0vewWc dmesg|grep DiB http://pastebin.com/a7

tvtime and Pinnacle PCTV 72e

2014-02-20 Thread Caterpillar
Hi. I am writing to you because I am helping a Fedora user that has problems using tvtime with its Pinnacle Systems, Inc. PCTV 72e [DiBcom DiB7000PC] Before he asked for my help, the user said he managed to work the card with its webcam, but not with the DBV-T Pinnacle card (USB). He says also to h

Re: [patch] [media] stv090x: remove indent levels

2014-02-20 Thread Dan Carpenter
Guys, what Manu is saying is purest nonsense. The "lock" variable is a stack variable, it's not a "demodulator Read-modify-Write register". The implications of changing "if (!lock)" to "if (lock)" are simple and obvious. He's not reviewing patches, he's just NAKing them. It's not helpful. regar