Hi there,
I'm trying this video capture stick from Conceptronic, the Home Video
Creator, but I'm not getting it to work with Linux. I'm using kernel
version 3.13.5 and I'm on Arch Linux. More information and specs here:
http://www.conceptronic.net/product.php?id=322linkid=294.
This is the output
Hi Devin,
Em Fri, 28 Feb 2014 19:13:16 -0500
Devin Heitmueller dheitmuel...@kernellabs.com escreveu:
Seems kind of strange that I wasn't on the CC for this, since I was the
original author of all that code (in fact, DJH are my initials).
Mauro, did you strip off my authorship when you
Hi all,
This is the 6th and hopefully the final version of the set.
What has changed since v5.2:
- Got a patch from Hans to fix timestamp issues in vb2 (1st one). That's
unchanged.
- Renamed the vb2_queue.timestamp_type field as timestamp_flags (patch 4).
- Add a note that on mem-to-mem
For COPY timestamps, buffer timestamp source flags will traverse the queue
untouched.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
drivers/media/v4l2-core/videobuf2-core.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
When sending a buffer to a video output device some of the fields need
to be copied so they arrive in the driver. These are the KEY/P/BFRAME
flags and the TIMECODE flag, and, if that flag is set, the timecode field
itself.
There are a number of functions
The timestamp_type field used to contain only the timestamp type. Soon it
will be used for timestamp source flags as well. Rename the field
accordingly.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
drivers/media/parport/bw-qcam.c |2 +-
Timestamp buffer flags are constant at the moment. Document them so that 1)
they're always valid and 2) not changed by the drivers. This leaves room to
extend the functionality later on if needed.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
Documentation/DocBook/media/v4l/io.xml | 14
The timestamp and timecode fields were copied from destination to source,
not the other way around as they should. Fix it.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
Acked-by: Kamil Debski k.deb...@samsung.com
---
drivers/media/platform/exynos-gsc/gsc-m2m.c |4 ++--
Document that monotonic timestamps are taken after the corresponding frame
has been received, not when the reception has begun. This corresponds to the
reality of current drivers: the timestamp is naturally taken when the
hardware triggers an interrupt to tell the driver to handle the received
The UVC device provided timestamps are taken from the clock once the
exposure of the frame has begun, not when the reception of the frame would
have been finished as almost anywhere else. Show this to the user space by
using V4L2_BUF_FLAG_TSTAMP_SRC_SOE buffer flag.
Signed-off-by: Sakari Ailus
Some devices do not produce timestamps that correspond to the end of the
frame. The user space should be informed on the matter. This patch achieves
that by adding buffer flags (and a mask) for timestamp sources since more
possible timestamping points are expected than just two.
A three-bit mask
The buffer flags field is 32 bits but the defined only used 16. This is
fine, but as more than 16 bits will be used in the very near future, define
them as 32-bit numbers for consistency.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
Acked-by: Hans Verkuil hans.verk...@cisco.com
---
Copy the flags containing the timestamp source from source buffer flags to
the destination buffer flags on memory-to-memory devices. This is analogous
to copying the timestamp field from source to destination.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
Acked-by: Kamil Debski
Hi Sakari,
Don't worry, it's a very minor change:
On 03/01/2014 02:17 PM, Sakari Ailus wrote:
Some devices do not produce timestamps that correspond to the end of the
frame. The user space should be informed on the matter. This patch achieves
that by adding buffer flags (and a mask) for
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
On 03/01/2014 02:17 PM, Sakari Ailus wrote:
Timestamp buffer flags are constant at the moment. Document them so that 1)
they're always valid and 2) not changed by the drivers. This leaves room to
extend the functionality
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
On 03/01/2014 02:17 PM, Sakari Ailus wrote:
The timestamp_type field used to contain only the timestamp type. Soon it
will be used for timestamp source flags as well. Rename the field
accordingly.
Signed-off-by: Sakari
Em Fri, 21 Feb 2014 17:50:16 -0700
Shuah Khan shuah...@samsung.com escreveu:
Implement em28xx_ops: suspend/resume hooks. em28xx usb driver will
invoke em28xx_ops: suspend and resume hooks for all its extensions
from its suspend() and resume() interfaces.
Signed-off-by: Shuah Khan
ARRAY_SIZE(buf) (8 elements) was intended instead of sizeof(buf) (16
bytes). But this is just a sanity check and the callers always pass
valid values so this doesn't cause a problem.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/pci/ttpci/av7110_hw.c
Static checkers complain about the inconsistent NULL check here.
There is an unchecked dereference of intput-fe in the call to
tuner_attach_tda18271() and there is a second unchecked dereference a
couple lines later when we do:
input-fe2-tuner_priv = input-fe-tuner_priv;
But actually
Hi Sakari,
I believe this needs some more work. See comments below:
On 03/01/2014 02:17 PM, Sakari Ailus wrote:
For COPY timestamps, buffer timestamp source flags will traverse the queue
untouched.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
Mask out other bits when comparing timestamp types.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
This change was missing from the set. The check needs to be changed as there
will be also timestamp source flags, not just timestamp type flags in the
field.
Copy timestamp type will mean the timestamp is be copied from the source to
the destination buffer on mem-to-mem devices.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c |9 +
1 file changed, 9 insertions(+)
diff --git a/yavta.c b/yavta.c
index 5171024..50bc6c2 100644
The option is --output, or -o.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/yavta.c b/yavta.c
index 8e43ce5..e010252 100644
--- a/yavta.c
+++ b/yavta.c
@@ -1240,6 +1240,7 @@ static void usage(const
This is necessary since video_open() may not be always called soon
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/yavta.c b/yavta.c
index e010252..870682e 100644
--- a/yavta.c
+++ b/yavta.c
@@ -182,11
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c | 63 +++
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/yavta.c b/yavta.c
index 870682e..a9b192a 100644
--- a/yavta.c
+++ b/yavta.c
@@ -62,6 +62,7 @@ struct
Hi,
This patchset enables using yavta for mem-to-mem devices, including
mem2mem_testdev (or soon vim2m). The timestamp will be set for output
buffers when the timestamp type is copy. An option is added to set the
timestamp source flags (eof/soe).
To use yavta for mem2mem devices, just open the
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
include/linux/v4l2-controls.h | 105 -
include/linux/videodev2.h | 250 +++--
2 files changed, 214 insertions(+), 141 deletions(-)
diff --git a/include/linux/v4l2-controls.h
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/yavta.c b/yavta.c
index 0e1c921..8e43ce5 100644
--- a/yavta.c
+++ b/yavta.c
@@ -476,7 +476,7 @@ static int video_alloc_buffers(struct device *dev,
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/yavta.c b/yavta.c
index a9b192a..71c1477 100644
--- a/yavta.c
+++ b/yavta.c
@@ -73,6 +73,7 @@ struct device
unsigned int height;
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/yavta.c b/yavta.c
index 224405d..5171024 100644
--- a/yavta.c
+++ b/yavta.c
@@ -454,6 +454,9 @@ static void get_ts_flags(uint32_t flags, const char
**ts_type, const char **ts_s
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
yavta.c | 52 ++--
1 file changed, 30 insertions(+), 22 deletions(-)
diff --git a/yavta.c b/yavta.c
index 71c1477..224405d 100644
--- a/yavta.c
+++ b/yavta.c
@@ -445,6 +445,30 @@ static int
Hi Hans,
Hans Verkuil wrote:
Hi Sakari,
Don't worry, it's a very minor change:
I won't; I'm always happy to get comments. ;-) Thank you again.
On 03/01/2014 02:17 PM, Sakari Ailus wrote:
Some devices do not produce timestamps that correspond to the end of the
frame. The user space should
Hi Hans,
Thanks for the comments.
Hans Verkuil wrote:
On 03/01/2014 02:17 PM, Sakari Ailus wrote:
For COPY timestamps, buffer timestamp source flags will traverse the queue
untouched.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
drivers/media/v4l2-core/videobuf2-core.c | 26
For COPY timestamps, buffer timestamp source flags will traverse the queue
untouched.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
changes since v6:
- Clean up changes to __fill_v4l2_buffer().
- Drop timestamp source flags for non-OUTPUT buffers in __fill_vb2_buffer().
- Comments fixed
While playing with make coccicheck I noticed this message:
drivers/media/rc/rc-main.c:1245:3-9: preceding lock on line 1238
It was introduced by commit 587d1b06e07b ([media] rc-core: reuse device
numbers) which returns -ENOMEM after a mutex_lock without first
unlocking it when there are no more
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sun Mar 2 04:00:20 CET 2014
git branch: test
git hash: a06b429df49bb50ec1e671123a45147a1d1a6186
gcc
Hi Philipp,
Thanks for the patch.
On Thu, Feb 27, 2014 at 10:14 PM, Philipp Zabel p.za...@pengutronix.de wrote:
This patch fixes the following warning:
drivers/media/i2c/tvp5150.c: In function '__tvp5150_try_crop':
include/linux/kernel.h:762:17: warning: comparison of distinct pointer types
Hi Philipp,
Thanks for the patch.
On Thu, Feb 27, 2014 at 10:14 PM, Philipp Zabel p.za...@pengutronix.de wrote:
Set permissions on the debug module parameter to make it appear in sysfs.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
On 03/01/2014 05:59 PM, Sakari Ailus wrote:
For COPY timestamps, buffer timestamp source flags will traverse the queue
untouched.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
changes since v6:
- Clean up changes
On 03/01/2014 05:51 PM, Sakari Ailus wrote:
Hi Hans,
Thanks for the comments.
Hans Verkuil wrote:
On 03/01/2014 02:17 PM, Sakari Ailus wrote:
For COPY timestamps, buffer timestamp source flags will traverse the queue
untouched.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
40 matches
Mail list logo