Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

2014-05-09 Thread Jacek Anaszewski
Hi Sakari, On 05/07/2014 09:58 AM, Sakari Ailus wrote: Hi Jacek, On Wed, May 07, 2014 at 09:20:17AM +0200, Jacek Anaszewski wrote: On 05/06/2014 11:10 AM, Sakari Ailus wrote: Hi Jacek, On Tue, May 06, 2014 at 08:44:41AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 05/02/2014 01:06 PM,

[PATCH] Fix _IOC_TYPECHECK sparse error

2014-05-09 Thread Hans Verkuil
Andrew, can you merge this for 3.15 or 3.16 (you decide)? While it fixes a sparse error for the media subsystem, it is not really appropriate to go through our media tree. Thanks, Hans When running sparse over drivers/media/v4l2-core/v4l2-ioctl.c I get these errors:

Re: [PATCH] au0828: Cancel stream-restart operation if frontend is disconnected

2014-05-09 Thread Mauro Carvalho Chehab
Em Fri, 09 May 2014 12:54:11 +0800 Changbing xi...@pop3.w2.samsung.net escreveu: From: Changbing Xiong cb.xi...@samsung.com If the tuner is already disconnected, It is meaningless to go on doing the stream-restart operation, It is better to cancel this operation. Signed-off-by: Changbing

Re: [PATCH 2/5] em28xx: fix i2c_set_adapdata() call in em28xx_i2c_register()

2014-05-09 Thread Hans Verkuil
Hi Frank, I've got a comment about this patch: On 03/22/2014 02:01 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 00/19] em28xx: clean up the main device struct and move sub-module specific data to its own data structs

2014-05-09 Thread Hans Verkuil
Hi Frank, This looks good to me. I do have some comments for future cleanups and I'll reply to the relevant patches for that. However, before I can apply this patch series you need to take a look at my comments for this pre-requisite patch: https://patchwork.linuxtv.org/patch/23179/ That

Re: [PATCH 03/19] em28xx: start moving em28xx-v4l specific data to its own struct

2014-05-09 Thread Hans Verkuil
Some comments for future improvements: On 03/24/2014 08:33 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 4 +- drivers/media/usb/em28xx/em28xx-video.c | 160 +--

Re: [PATCH] au0828: Cancel stream-restart operation if frontend is disconnected

2014-05-09 Thread Mauro Carvalho Chehab
Em Fri, 09 May 2014 05:12:53 -0300 Mauro Carvalho Chehab m.che...@samsung.com escreveu: Em Fri, 09 May 2014 12:54:11 +0800 Changbing xi...@pop3.w2.samsung.net escreveu: From: Changbing Xiong cb.xi...@samsung.com If the tuner is already disconnected, It is meaningless to go on doing the

Re: [PATCH 06/19] em28xx: move video_device structs from struct em28xx to struct v4l2

2014-05-09 Thread Hans Verkuil
On 03/24/2014 08:33 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 120 ++-- drivers/media/usb/em28xx/em28xx.h | 7 +- 2 files changed, 56 insertions(+), 71 deletions(-)

Re: [PATCH] [media] ivtv: avoid GFP_KERNEL in atomic context

2014-05-09 Thread Hans Verkuil
On 04/25/2014 06:14 PM, Alexey Khoroshilov wrote: ivtv_yuv_init() is used in atomic context, so memory allocation should be done keeping that in mind. Call graph for ivtv_yuv_init() is as follows: - ivtv_yuv_next_free() - ivtv_yuv_prep_frame() [ioctl handler] -

Re: [RFC] Fix interrupted recording with Hauppauge HD-PVR

2014-05-09 Thread Hans Verkuil
On 04/08/2014 07:07 PM, Ryley Angus wrote: Hi Kyle. It may be possible that the delay in acceptable grace periods is due to a difference in our input AV sources more so than the Hauppauge units themselves. I'm wondering if it would be useful to control the timeout period via a module

[patch] [media] Staging: dt3155v4l: set error code on failure

2014-05-09 Thread Dan Carpenter
We should be returning -ENOMEM here instead of success. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/staging/media/dt3155v4l/dt3155v4l.c index afbc2e5..178aa5b 100644 --- a/drivers/staging/media/dt3155v4l/dt3155v4l.c

Re: [PATCH 0/3] Smiapp quirk call order and best scaling ratio fixes

2014-05-09 Thread Laurent Pinchart
Hi Sakari, Thank you for the patches. On Wednesday 23 April 2014 22:33:56 Sakari Ailus wrote: Hi, The most important patch is the third one: wrong scaling ratio was selected in many (or most?) cases due to the wrong signedness of the variable. The other two have less effect on the

[GIT PULL FOR v3.16] uvcvideo fixes

2014-05-09 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 393cbd8dc532c1ebed60719da8d379f50d445f28: [media] smiapp: Use %u for printing u32 value (2014-04-23 16:05:06 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/uvcvideo.git uvcvideo-next for you to fetch changes up to

Re: [PATCH 1/3] smiapp: Use better regulator name for the Device tree

2014-05-09 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Sunday 04 May 2014 03:31:55 Sakari Ailus wrote: Rename VANA regulator as vana. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/smiapp/smiapp-core.c |2 +- 1

Re: [PATCH 3/3] smiapp: Return correct return value in smiapp_registered()

2014-05-09 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Sunday 04 May 2014 03:31:57 Sakari Ailus wrote: Prepare for supporting systems using the Device tree. Should the resources not be available at the time of driver probe(), the EPROBE_DEFER error code must be also returned from its probe function.

Re: [PATCH 2/3] smiapp: Check for GPIO validity using gpio_is_valid()

2014-05-09 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Sunday 04 May 2014 03:31:56 Sakari Ailus wrote: Do not use our special value, SMIAPP_NO_XSHUTDOWN. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Wouldn't it make sense to switch to the gpiod API ? That change could then replace this patch. If you

[PATCH] v4l2-ioctl: drop spurious newline in string

2014-05-09 Thread Hans Verkuil
The message logged by v4l_print_cropcap should be a single line without linebreaks, just like all the other v4l_print_ioctl functions. diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index f729bd2..16bffd8 100644 ---

[GIT PULL FOR v3.16] UVC gadget driver fixes

2014-05-09 Thread Laurent Pinchart
Hi Felipe, Could you please pull the following three patches for v3.16 ? They've been reviewed on the linux-media and linux-usb mailing list. The following changes since commit c9eaa447e77efe77b7fa4c953bd62de8297fd6c5: Linux 3.15-rc1 (2014-04-13 14:18:35 -0700) are available in the git

Re: [PATCH 2/3] smiapp: Check for GPIO validity using gpio_is_valid()

2014-05-09 Thread Sakari Ailus
Hi Laurent, On Fri, May 09, 2014 at 02:18:24PM +0200, Laurent Pinchart wrote: On Sunday 04 May 2014 03:31:56 Sakari Ailus wrote: Do not use our special value, SMIAPP_NO_XSHUTDOWN. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Wouldn't it make sense to switch to the gpiod API ? That

Re: Support for Elgato Game Capture HD / MStar MST3367CMK

2014-05-09 Thread Steven Toth
On Thu, May 8, 2014 at 9:48 PM, Tolga Cakir to...@cevel.net wrote: Hello everyone! Hi Tolga! Over the past weeks, I've been busy capturing USB packets between the Elgato Game Capture HD and my PC. It's using the MStar MST3367CMK chip, which seems to have proprietary Linux support available

[GIT PULL FOR v3.16] OMAP4 ISS fixes

2014-05-09 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 393cbd8dc532c1ebed60719da8d379f50d445f28: [media] smiapp: Use %u for printing u32 value (2014-04-23 16:05:06 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git omap4iss/next for you to fetch changes up to

[GIT PULL FOR v3.16] Various fixes

2014-05-09 Thread Hans Verkuil
Hi Mauro, I went through my pending patches queue and managed to go through most of it. There is still one em28xx patch series pending (waiting for feedback from Frank about one patch) and I expect more patches from Prabhakar. Hopefully I can do another batch on Monday. Most patches are fairly

Re: V4L control units

2014-05-09 Thread Hans Verkuil
On 05/08/2014 11:04 AM, Sakari Ailus wrote: Heippa! On Wed, May 07, 2014 at 03:57:11PM +0300, Antti Palosaari wrote: What is preferred way implement controls that could have some known unit or unknown unit? For example for gain controls, I would like to offer gain in unit of dB (decibel)

Re: s_ctrl V4l2 device driver does not work

2014-05-09 Thread Hans Verkuil
On 05/08/2014 11:30 PM, Marcio Campos de Lima wrote: I have also tried these settings #define VIDIOC_AVANCA_ZOOM(0x009a|0x900)+14 #define VIDIOC_RECUA_ZOOM (0x009a|0x900)+14 All controls must have unique IDs, which is clearly not the case for these two ZOOM controls. You say

Re: [PATCH v2] media: stk1160: Avoid stack-allocated buffer for control URBs

2014-05-09 Thread Ezequiel Garcia
On 09 May 12:34 PM, Hans Verkuil wrote: Hi Ezequiel, On 04/17/2014 02:28 PM, Ezequiel Garcia wrote: Currently stk1160_read_reg() uses a stack-allocated char to get the read control value. This is wrong because usb_control_msg() requires a kmalloc-ed buffer. This commit fixes such

Re: [PATCH v3 1/2] [media] v4l: Add source change event

2014-05-09 Thread Laurent Pinchart
Hi Arun, Thank you for the patch. We're slowly getting there :-) On Thursday 08 May 2014 17:19:15 Arun Kumar K wrote: This event indicates that the video device has encountered a source parameter change during runtime. This can typically be a resolution change detected by a video decoder OR a

Re: [PATCH v3 1/2] [media] v4l: Add source change event

2014-05-09 Thread Hans Verkuil
On 05/09/2014 03:09 PM, Laurent Pinchart wrote: Hi Arun, Thank you for the patch. We're slowly getting there :-) On Thursday 08 May 2014 17:19:15 Arun Kumar K wrote: This event indicates that the video device has encountered a source parameter change during runtime. This can typically be

Re: [GIT PULL FOR v3.16] uvcvideo fixes

2014-05-09 Thread William Manley
Hi Laurent Any chance of my patch fixing manual exposure mode for the Logitech C920[1] going in for 3.16? [1]: https://patchwork.linuxtv.org/patch/23047/ Thanks Will -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: V4L control units

2014-05-09 Thread Sakari Ailus
Hi Hans, On Fri, May 09, 2014 at 02:57:13PM +0200, Hans Verkuil wrote: On 05/08/2014 11:04 AM, Sakari Ailus wrote: Heippa! On Wed, May 07, 2014 at 03:57:11PM +0300, Antti Palosaari wrote: What is preferred way implement controls that could have some known unit or unknown unit? For

[GIT PULL for v3.16] smiapp: Scaling configuration fix, rename regulator; fixes

2014-05-09 Thread Sakari Ailus
Hi Mauro, This patchset contains a few miscellaneous fixes but more importantly, a fix for calculating the best scaling and binning ratios. The regulator is also renamed as lower case. The following changes since commit 393cbd8dc532c1ebed60719da8d379f50d445f28: [media] smiapp: Use %u for

Re: V4L control units

2014-05-09 Thread Hans Verkuil
On 05/09/2014 03:46 PM, Sakari Ailus wrote: Hi Hans, On Fri, May 09, 2014 at 02:57:13PM +0200, Hans Verkuil wrote: On 05/08/2014 11:04 AM, Sakari Ailus wrote: Heippa! On Wed, May 07, 2014 at 03:57:11PM +0300, Antti Palosaari wrote: What is preferred way implement controls that could have

Re: s_ctrl V4l2 device driver does not work

2014-05-09 Thread Marcio Campos de Lima
Hi Hans Thanks a lot for your attention. I managed to find the source of the problem in the following code v4l2_ctrl_new_std(priv-ctrls, ov5642_ctrl_ops,V4L2_CID_ZOOM_RELATIVE, -1000, 1000, 1, 500) v4l2_ctrl_new_std(priv-ctrls, ov5642_ctrl_ops,V4L2_CID_FLASH_STROBE, -100, 100, 1, 5); The

Hauppauge 950Q TS capture intermittent lock up

2014-05-09 Thread Trevor Anonymous
Hello all, I have written a simple application to capture RF QAM transport streams with the Hauppauge 950Q, and save to a file. This is essentially the same as dvbstream, but with unnecessary stuff removed (and I have verified this bug using dvbstream as well): - tune using frontend device -

[PATCH] [media] vb2: fix num_buffers calculation if req-count VIDEO_MAX_FRAMES

2014-05-09 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 40024d7..4d4f6ba 100644 ---

[PATCH] [media] vb2: drop queued buffers while q-start_streaming_called is still set

2014-05-09 Thread Philipp Zabel
Otherwise yet another warning will trigger in vb2_buffer_done. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/videobuf2-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c

Re: [PATCH] [media] vb2: fix num_buffers calculation if req-count VIDEO_MAX_FRAMES

2014-05-09 Thread Hans Verkuil
On 05/09/2014 05:32 PM, Philipp Zabel wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de Reviewed-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] [media] vb2: drop queued buffers while q-start_streaming_called is still set

2014-05-09 Thread Hans Verkuil
On 05/09/2014 05:32 PM, Philipp Zabel wrote: Otherwise yet another warning will trigger in vb2_buffer_done. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Duplicate of: https://patchwork.linuxtv.org/patch/23723/ I'm setting your patch to superseded in patchwork. Regards, Hans

Re: [PATCH v2] radio-bcm2048.c: fix wrong overflow check

2014-05-09 Thread Pali Rohár
On Monday 05 May 2014 15:34:29 Jiri Kosina wrote: On Tue, 22 Apr 2014, Dan Carpenter wrote: From: Pali Rohár pali.ro...@gmail.com This patch fixes an off by one check in bcm2048_set_region(). Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Pali Rohár

Re: [PATCH v2] radio-bcm2048.c: fix wrong overflow check

2014-05-09 Thread Hans Verkuil
On 05/09/2014 06:10 PM, Pali Rohár wrote: On Monday 05 May 2014 15:34:29 Jiri Kosina wrote: On Tue, 22 Apr 2014, Dan Carpenter wrote: From: Pali Rohár pali.ro...@gmail.com This patch fixes an off by one check in bcm2048_set_region(). Reported-by: Dan Carpenter dan.carpen...@oracle.com

Re: [RFC] Fix interrupted recording with Hauppauge HD-PVR

2014-05-09 Thread Keith Pyle
On 05/09/14 06:08, Hans Verkuil wrote: On 04/08/2014 07:07 PM, Ryley Angus wrote: Hi Kyle. It may be possible that the delay in acceptable grace periods is due to a difference in our input AV sources more so than the Hauppauge units themselves. I'm wondering if it would be useful to control

Re: [PATCH] Fix _IOC_TYPECHECK sparse error

2014-05-09 Thread Andrew Morton
On Fri, 09 May 2014 09:43:58 +0200 Hans Verkuil hverk...@xs4all.nl wrote: Andrew, can you merge this for 3.15 or 3.16 (you decide)? While it fixes a sparse error for the media subsystem, it is not really appropriate to go through our media tree. Thanks, Hans When running

cron job: media_tree daily build: OK

2014-05-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat May 10 04:00:17 CEST 2014 git branch: test git hash: 393cbd8dc532c1ebed60719da8d379f50d445f28 gcc